November 2010 - xwiki-devs@xwiki.org

[xwiki-devs] [proposal] IRCbot log formatting improvement
by Sorin Burjan 10 Dec '10

10 Dec '10

Hello devs, I have a proposal to make about the IRCbot Application. As you know, the bot logs the channel and saves the content in order to make it viewable from the xwiki designated page. I would like to propose two things : Proposal 1 In order to make archive logs more easily readable and more easy to follow, I would like to change the way the logs are saved. I would like to use a standard format (also used my all major IRC clients like Pidgin, IRC, XChat, irssi, etc). Because date/time will have always the same length, aligning it and putting it at the begginning of the line, makes the text more easy to follow. So, the proposals are : Version 1 (the one we have now) user1 - (20:07): You can comment if you have edit right JohnDoe - (20:07): ok, thx for the answer IreallyLoveXWiki - (20:07): I’m off for today, bye XWikiNormalUser left at 20:07 (Quit: Leaving. EnterpriseUser joined #xwiki at 20:38 EnterpriseUser left at 20:38 (Client Quit sburjan is now known as sburjan1 (~sburjan(a)this.is.areally.long.address.ro Note that the ")" doesn't appear on logs, so this should be fixed any way. Version 2 [11:05] XWikiNormalUser : How can I edit a page? [11:05] IreallyLoveXWiki : You have to be logged in order to do that [11:05] JohnDoe : I love Open Source ! [22:55] EnterpriseUser : joined #xwiki at 20:38 [22:56] EnterpriseUser : left at 20:38 (Client Quit [14:22] sburjan is now known as sburjan1 (~sburjan(a)this.is.areally.long.address.ro) Version 3 [11:05] <XWikiNormalUser> How can I edit a page? [11:05] <IreallyLoveXWiki> You have to be logged in order to do that [11:05] <JohnDoe> I love Open Source ! [22:55] <EnterpriseUser> joined #xwiki at 20:38 [22:56] <EnterpriseUser> left at 20:38 (Client Quit) Version 1 : keep these addresses in log (like we have now) sburjan is now known as sburjan1 (~sburjan(a)this.is.areally.long.address.ro Version 2 : remove then from logging sburjan is now known as sburjan1 I am +1 for 1.3 and +1 for 2.1 Please send your feedback and even your proposals if you have one. WDYT ? Regards, Sorin B. [14:22] sburjan is now known as sburjan1 (~sburjan(a)this.is.areally.long.address.ro) Proposal 2 We also log the user ip/host addresses when user joins. This also makes the line much longer with information that it's not needed IMO. This could be also a privacy concert, because your ip/host address is exposed to anyone who uses xwiki.org . Version 1 : keep these addresses in log (like we have now) sburjan is now known as sburjan1 (~sburjan(a)this.is.areally.long.address.ro Version 2 : remove then from logging sburjan is now known as sburjan1 I am +1 for 1.3 and +1 for 2.1 Please send your feedback and even your proposals if you have one. WDYT ? Regards, Sorin B.

9 14

[xwiki-devs] XWiki farm Powered by XWiki Enterprise 2.6
by Ricardo Rodriguez [eBioTIC.] 30 Nov '10

30 Nov '10

Hi! Just a one line to congratulate the whole XWiki team and community for getting XWiki farm running in the 2.6 XE/XEM featuring colibri skin. It looks great! Thanks for your work! Ricardo -- Ricardo Rodríguez CTO eBioTIC. Life Sciences, Data Modeling and Information Management Systems

1 0

[xwiki-devs] [Discussion] Providing Default Template Providers in default XE
by Vincent Massol 30 Nov '10

30 Nov '10

Hi, I think we should provide default template providers in default XE. This thread is about deciding which ones to have by default. Candidates: ========== 1- Wiki Macro 2- Blog Post 3- Scheduler Job 4- Class (same result as creating a class from the class wizard) 5- Color Theme 6- Panel 7- Skin For some of these we have home pages to create them (For example: Blog, Scheduler, Class, Color Theme, Panel) so we need to decide if it's ok to provide 2 locations from where to create them. In addition some of the candidates above are technical things and they shouldn't be displayed to simple users IMO: Wiki Macro, Scheduler Job, Class, Color Theme, Panel, Skin. Thus I'd also like to discuss having a mechanism for a Template Provider to say to whom it's addressed. Could be done by adding an "Audience" field to the Template Provider class. WDYT? Thanks -Vincent

3 12

[xwiki-devs] [Discussion] Add the $blacklistedSpaces variable to the programming section of the Administation application
by Guillaume Lerouge 30 Nov '10

30 Nov '10

Hi, I've recently had the need to modify the list of blacklisted spaces on one of my wikis. I had to override a .vm file to do that. I was reminded of this issue while reading Vincent's email about default template providers and the need to hide technical items. Hiding some specific spaces is a frequent use case, for instance I often create a "Code" space to hold all my code files and I'd like to hide it from the main dashboard but there's no easy way to do that right now. It would be great if instead I could simply edit a field in the "Programming" section of the administration to define which spaces should be blacklisted. Here's my +1 for that. WDYT? Guillaume

2 1

[xwiki-devs] New administration section for the WYSIWYG editor
by Marius Dumitru Florea 30 Nov '10

30 Nov '10

Hi devs, I'd like to add a new administration section for the WYSIWYG editor. For this I'll create a new page: XWiki.WysiwygEditorConfig (storing the WYSIWYG editor configuration class/object and the XWiki.ConfigurableClass objects) Is this fine with you? I don't think a separate application is needed yet. The WYSIWYG editor configuration will contain there sections/properties: General settings ---------------- Display the WYSIWYG/Source tabs [Yes/No] The editor tab selected initially [WYSIWYG/Source] The list of enabled plugins [submit line separator ...] The top menu items [link image table macro import] The list of tool bar items [bold italic underline ...] Link settings ------------- Limit attachment selection to the edited page [Yes/No] Image settings -------------- Allow insertion of external images [Yes/No] Limit image selection to the edited page [Yes/No] Color settings -------------- The colors available in the color picker [#000000,#444444,#666666,#999999,#CCCCCC ...] The number of colors to display per row in the color picker [8] Font settings ------------- The list of available font names [andale mono, arial, arial black, ...] The list of available font sizes [8pt, 10pt, 12pt, ...] Style settings -------------- The list of predefined styles [] WDYT? Thanks, Marius

10 14

Re: [xwiki-devs] [xwiki-notifications] r33194 - in platform/core/trunk/xwiki-core/src: main/java/com/xpn/xwiki/doc test/java/com/xpn/xwiki/doc
by Vincent Massol 30 Nov '10

30 Nov '10

On Nov 30, 2010, at 4:16 PM, tmortagne (SVN) wrote: > Author: tmortagne > Date: 2010-11-30 16:16:46 +0100 (Tue, 30 Nov 2010) > New Revision: 33194 > > Modified: > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java > platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/doc/XWikiDocumentRenderingTest.java > Log: > XWIKI-4771: Cycles in the method Document.getDisplayTitle are not detected > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java 2010-11-30 15:00:36 UTC (rev 33193) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java 2010-11-30 15:16:46 UTC (rev 33194) > @@ -43,6 +43,7 @@ > import java.util.List; > import java.util.Map; > import java.util.Set; > +import java.util.Stack; > import java.util.TreeMap; > import java.util.Vector; > import java.util.regex.Matcher; > @@ -1203,7 +1204,20 @@ > private String getRenderedContentTitle(Syntax outputSyntax, XWikiContext context) throws XWikiException > { > String title = null; > + This code below requires comment to understand it. It's not obvious to understand it's to prevent cycles. Might be also good to put it in a separate method to make it even more clear. I also think the pop should be in a finally block. Thanks -Vincent > + Stack<DocumentReference> stackTrace = > + (Stack<DocumentReference>) context.get("internal.getRenderedContentTitleStackTrace"); > > + if (stackTrace == null) { > + stackTrace = new Stack<DocumentReference>(); > + context.put("internal.getRenderedContentTitleStackTrace", stackTrace); > + } else if (stackTrace.contains(getDocumentReference())) { > + // TODO: generate an error message instead ? > + return null; > + } > + > + stackTrace.push(getDocumentReference()); > + > if (is10Syntax()) { > title = getRenderedContentTitle10(context); > } else { > @@ -1235,6 +1249,8 @@ > } > } > > + stackTrace.pop(); > + > return title; > } > > > Modified: platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/doc/XWikiDocumentRenderingTest.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/doc/XWikiDocumentRenderingTest.java 2010-11-30 15:00:36 UTC (rev 33193) > +++ platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/doc/XWikiDocumentRenderingTest.java 2010-11-30 15:16:46 UTC (rev 33194) > @@ -250,7 +250,18 @@ > > assertEquals("Page", this.document.getRenderedTitle(Syntax.XHTML_1_0, getContext())); > } > + > + /** > + * Make sure title extracted from content is protected from cycles > + */ > + public void testGetRenderedTitleRecursive() throws XWikiException > + { > + this.document.setSyntax(Syntax.XWIKI_2_0); > + this.document.setContent("= {{groovy}}print doc.getDisplayTitle(){{/groovy}}"); > > + assertEquals("Page", this.document.getRenderedTitle(Syntax.XHTML_1_0, getContext())); > + } > + > public void testExtractTitle() > { > this.document.setSyntaxId("xwiki/2.0"); > > ____________________________________

2 1

Re: [xwiki-devs] [xwiki-notifications] r33193 - in platform: core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web web/trunk/standard/src/main/webapp/resources/js/xwiki/importer
by Thomas Mortagne 30 Nov '10

30 Nov '10

On Tue, Nov 30, 2010 at 16:00, jvdrean <platform-notifications(a)xwiki.org> wrote: > Author: jvdrean > Date: 2010-11-30 16:00:36 +0100 (Tue, 30 Nov 2010) > New Revision: 33193 > > Modified: > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/ImportAction.java > platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/importer/import.js > Log: > XWIKI-5724 : On import document author is not the current user > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/ImportAction.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/ImportAction.java 2010-11-30 14:43:36 UTC (rev 33192) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/ImportAction.java 2010-11-30 15:00:36 UTC (rev 33193) > @@ -133,6 +133,8 @@ > // Set the backup pack option > if (StringUtils.equals(request.getParameter("importAsBackup"), "true")) { > importer.setBackupPack(true); > + } else { > + importer.setBackupPack(false); > } WDYT about: importer.setBackupPack(Boolean.valueOf(request.getParameter("importAsBackup"))); instead ? > // Import files > importer.install(); > > Modified: platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/importer/import.js > =================================================================== > --- platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/importer/import.js 2010-11-30 14:43:36 UTC (rev 33192) > +++ platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/importer/import.js 2010-11-30 15:00:36 UTC (rev 33193) > @@ -298,6 +298,7 @@ > > parameters["historyStrategy"] = $('packageDescription').down("input[type=radio][value='add']").checked ? "add" : > ($('packageDescription').down("input[type=radio][value='replace']").checked ? "replace" : "reset"); > + parameters["importAsBackup"] = $('packageDescription').down("input[type=checkbox][name='importAsBackup']").checked ? "true" : "false"; > parameters["ajax"] = "1"; > > var pages = []; > > _______________________________________________ > notifications mailing list > notifications(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/notifications > -- Thomas Mortagne

1 0

Re: [xwiki-devs] [xwiki-notifications] r33178 - in platform/core/trunk/xwiki-rendering/xwiki-rendering-syntaxes/xwiki-rendering-syntax-xwiki10/src: main/java/org/xwiki/rendering/internal/parser/xwiki10 test/resources/html
by Vincent Massol 30 Nov '10

30 Nov '10

On Nov 30, 2010, at 10:14 AM, tmortagne (SVN) wrote: > Author: tmortagne > Date: 2010-11-30 10:14:58 +0100 (Tue, 30 Nov 2010) > New Revision: 33178 > > Added: > platform/core/trunk/xwiki-rendering/xwiki-rendering-syntaxes/xwiki-rendering-syntax-xwiki10/src/test/resources/html/html19.test > Modified: > platform/core/trunk/xwiki-rendering/xwiki-rendering-syntaxes/xwiki-rendering-syntax-xwiki10/src/main/java/org/xwiki/rendering/internal/parser/xwiki10/HTMLFilter.java > Log: > XWIKI-4468: timeout on xwiki syntax 1.0 to syntax 2.0 conversion > > Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-syntaxes/xwiki-rendering-syntax-xwiki10/src/main/java/org/xwiki/rendering/internal/parser/xwiki10/HTMLFilter.java > =================================================================== > --- platform/core/trunk/xwiki-rendering/xwiki-rendering-syntaxes/xwiki-rendering-syntax-xwiki10/src/main/java/org/xwiki/rendering/internal/parser/xwiki10/HTMLFilter.java 2010-11-30 03:52:53 UTC (rev 33177) > +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-syntaxes/xwiki-rendering-syntax-xwiki10/src/main/java/org/xwiki/rendering/internal/parser/xwiki10/HTMLFilter.java 2010-11-30 09:14:58 UTC (rev 33178) > @@ -429,6 +429,7 @@ > } > } catch (InvalidHtmlException e) { > getLogger().debug("Invalid HTML block at char [" + i + "]", e); > + ++i; > } > } else { > elementContent.append(c); > > Added: platform/core/trunk/xwiki-rendering/xwiki-rendering-syntaxes/xwiki-rendering-syntax-xwiki10/src/test/resources/html/html19.test > =================================================================== > --- platform/core/trunk/xwiki-rendering/xwiki-rendering-syntaxes/xwiki-rendering-syntax-xwiki10/src/test/resources/html/html19.test (rev 0) > +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-syntaxes/xwiki-rendering-syntax-xwiki10/src/test/resources/html/html19.test 2010-11-30 09:14:58 UTC (rev 33178) > @@ -0,0 +1,10 @@ > +.#----------------------------------------------------- > +.input|xwiki/1.0 Would be good to put a comment to explain what this is testing since it's not obvious. Thanks -Vincent > +.#----------------------------------------------------- > +<element> < </element> > +.#----------------------------------------------------- > +.expect|xwiki/2.0 > +.#----------------------------------------------------- > +{{html clean="false" wiki="true"}} > +<element> < </element> > +{{/html}} > \ No newline at end of file

1 0

[xwiki-devs] Add the ability to apply predefined custom styles in the WYSIWYG editor
by Marius Dumitru Florea 30 Nov '10

30 Nov '10

Hi devs, I'd like to introduce a new feature in the WYSIWYG editor in XE 2.7: the ability to apply predefined custom styles to a text selection. Using this instead of the other text formatting features (e.g. font name, font size, text color etc.) can help improve the consistency between wiki pages. Wiki administrators will be able to define a list of custom styles (CSS class names) which will be listed in a select box on the WYSIWYG tool bar. These styles should have meaningful names, e.g. "important", "comment", "todo" etc.. Considering that this feature is independent and will be disabled by default (i.e. we don't provide predefined styles in the standard XE distribution) I think it's save to introduce it in 2.7. Let me know if you are against it. Thanks, Marius

6 9

Re: [xwiki-devs] [xwiki-notifications] r33164 - platform/web/trunk/xwiki-gwt-wysiwyg-client/src/main/resources/org/xwiki/gwt/wysiwyg/public/stylesheets
by Sergiu Dumitriu 29 Nov '10

29 Nov '10

On 11/28/2010 07:54 PM, Marius Dumitru Florea wrote: > Hi Sergiu, > > I've fixed this issue locally by making the selector more specific: > > #body.main (instead of body.main) > > and > > * html #body.main (instead of * html body.main) > > I think this is better because all the rules in RichTextArea.css are > suppose to be overwrites and putting !important everywhere is an > overhead. I hope you agree. Isn't RichTextArea.css supposed to be independent of XWiki? #body is XWiki specific, so it won't always work outside XWiki. Actually, the independence is already sacrificed by the use of the color theme. I looked around when determining what's the best thing to do, and I saw that !important was already used in the same ruleset for setting the background and text color. Anyway, I'm not that familiar with the WYSIWYG, so I'll leave the decision to you, feel free to change it if you consider it's better. > On 11/28/2010 03:58 AM, sdumitriu (SVN) wrote: >> Author: sdumitriu >> Date: 2010-11-28 02:58:54 +0100 (Sun, 28 Nov 2010) >> New Revision: 33164 >> >> Modified: >> platform/web/trunk/xwiki-gwt-wysiwyg-client/src/main/resources/org/xwiki/gwt/wysiwyg/public/stylesheets/RichTextArea.css >> Log: >> XWIKI-5736: Horizontal scrollbar always visible in the WYSIWYG editor on small screens >> Fixed. >> >> Modified: platform/web/trunk/xwiki-gwt-wysiwyg-client/src/main/resources/org/xwiki/gwt/wysiwyg/public/stylesheets/RichTextArea.css >> =================================================================== >> --- platform/web/trunk/xwiki-gwt-wysiwyg-client/src/main/resources/org/xwiki/gwt/wysiwyg/public/stylesheets/RichTextArea.css 2010-11-28 01:47:54 UTC (rev 33163) >> +++ platform/web/trunk/xwiki-gwt-wysiwyg-client/src/main/resources/org/xwiki/gwt/wysiwyg/public/stylesheets/RichTextArea.css 2010-11-28 01:58:54 UTC (rev 33164) >> @@ -32,8 +32,8 @@ >> float: left; >> height: auto; >> margin: 0; >> - min-height: 100%; >> - min-width: 100%; >> + min-height: 100% !important; >> + min-width: 100% !important; >> overflow: visible; >> padding: 0; >> position: static; -- Sergiu Dumitriu http://purl.org/net/sergiu/

2 1