Hi devs,
In order to integrate XWiki in a portal (
http://dev.xwiki.org/xwiki/bin/view/Drafts/PortletIntegration ) we need
to change a bit the front end to:
* ensure XWiki's HTML element IDs are unique within the portal page
* ensure XWiki's stylesheets doesn't affect other portlets and the
portal page itself
* ensure XWiki content is not affected by stylesheets of other portlets
or the portal page itself
We could do the following:
(1) "Mark" IDs and class names whenever they are used in JavaScript
code, both in-line and stand-alone, using two identify functions:
id(String) and className(String). This is required because identifying
automatically IDs and class names in JavaScript code is not always possible.
(2) Automatically rewrite IDs and class names in CSS and HTML (except
in-line JavaScript) and "marked" IDs and class names in both in-line and
stand-alone JavaScript code before the response for each of the
resources (page included) reaches the client. This can be easily done in
the XWiki portlet bridge (
http://svn.xwiki.org/svnroot/xwiki/contrib/sandbox/xwiki-portlet/ ).
Final IDs and class names will include the portlet identifier and the
XWiki namespace (e.g. a simple 'x' prefix).
(3) Split XWiki's stylesheets (e.g. colibri.css) in two:
(a) general rules, including skin reset
(b) XWiki specific rules (i.e. with selectors including class names or IDs)
and import only (b) in portlet mode.
WDYT?
Thanks,
Marius
Hi,
Thomas, JV and I discussed about replacing download pages on xwiki.org with links to our maven repo (for stuff on code.xwiki.org only).
The rationale: Speed up the dev process and make it a failsafe process.
Advantages:
* No need to upload artifacts (which means smaller wiki and faster release process)
* Full history available
* No risk of being not synced with the maven repo (which is the official artifact repository)
* Low-tech solution
http://code.xwiki.org/xwiki/bin/view/Applications/AnnotationsApplication
When you click on download you go to:
http://maven.xwiki.org/releases/org/xwiki/platform/applications/xwiki-appli…
Thomas has already implemented it during the last release. It should have been discussed before but Thomas was in a hurry for the release.
Let us know if you don't agree.
Thanks
-Vincent
Hi all,
I did a small refactoring in the REST module which consisted in
isolating the JAXB model classes in a separate module.
This allows client to use JAXB classes for retrieving XML
representations without dragging in all the core dependencies.
The refactoring consisted in creating an xwiki-rest-model module in
core, moving some files, and update the pom.xml's to make things compile.
Maybe it's risky to commit it now, but if you are ok everything's ready.
I include a diff so that you can check what it looks like.
-Fabio
Hi,
Some time ago I had added the AbstractMockingComponentTestCase class in shared-test. I've refactored it a bit over the week end to make it even easier to use.
The idea is to use a @MockingRequirement annotation in the test case class to get a component instance with all its @Requirement fields injected with mocks.
This makes it easier to test than using the older AbstractComponentTestCase since you don't need to setup component mocks manually.
Here's an example usage:
public class MacroContentTableBlockDataSourceTest extends AbstractMockingComponentTestCase
{
@MockingRequirement
private MacroContentTableBlockDataSource source;
...
Another example:
public class DefaultMacroManagerTest extends AbstractMockingComponentTestCase
{
// Mock all required components except for some for which we want to use the real implementations since they make
// the test easier to write (no need to mock them).
@MockingRequirement(exceptions = { ComponentManager.class, MacroIdFactory.class })
private DefaultMacroManager macroManager;
As you can see in this second example, it's also possible to exclude some @Requirement from being mocked if need be.
I'd like that we agree to use this new test class from now on instead of AbstractComponentTestCase (unless there are cases where it's not usable but please discuss those use cases with me since maybe there are solutions to improve AbstractMockingComponentTestCase).
Here's my +1
Thanks
-Vincent
Festo AG & Co. KG
Lars Hermes
Abteilung IS-PB
BSP Development + User Services
Plieninger Stra?e 50
73760 Ostfildern-Scharnhausen
Deutschland
Telefon +49(711)347-4510
Telefax +49(711)34754-4510
http://www.festo.com
Der Inhalt dieses E-Mails ist ausschliesslich fuer den bezeichneten Adressaten bestimmt. Jede Form der Kenntnisnahme, Veroeffentlichung, Vervielfaeltigung oder Weitergabe des Inhalts dieses E-Mails durch unberechtigte Dritte ist unzulaessig. Wir bitten Sie, sich mit dem Absender des E-Mails in Verbindung zu setzen, falls Sie nicht der Adressat dieses E-Mails sind und das Material von Ihrem Computer zu loeschen.
This e-mail and any attachments are confidential and intended solely for the addressee. The perusal, publication, copying or dissemination of the contents of this e-mail by unauthorised third parties is prohibited. If you are not the intended recipient of this e-mail, please delete it and immediately notify the sender.
Rechtsform: Kommanditgesellschaft
Sitz: Esslingen a.N., Registergericht Stuttgart HRA 211583, Umsatzsteuerident-Nummer: DE 145339206
Pers?nlich haftende Gesellschafterin: Festo Management Aktiengesellschaft
Sitz: Wien/?sterreich, Firmenbuchgericht: Handelsgericht Wien, Firmenbuch Nr. FN 303027 d
Vorstand:
Dipl.-Kfm. Alfred Goll
Dr. Claus Jessen
Dr. Ansgar Kriwet
Dr. Eberhard Veit (Vorsitzender)
Dipl.- Kfm. Michael M?lleken
Aufsichtsratsvorsitzender:
Dr. Wilfried Stoll
Hi Devs,
I have almost completed my work on officepreview module and I would like to
discuss about integrating it into main source tree (and release it with
2.4M1). There are a couple of things to discuss:
1. officepreview module have to depend on xwiki-core for the time being
because with current component approach there is no way of determining the
version of an attachment (officepreview module needs to know attachment
version).
2. Need a couple of tests - I'm working on this.
3. Where to place the officepreview module in main source tree.
My initial idea for (3) was to create a
/platform/core/trunk/xwiki-officepreview submodule. However, since
officepreview module depends on officeimporter module, I'm not sure if we
should create a parent module that would host both of these projects.
Another problem lingering in my mind is that with recent changes
xwiki-officeimporter module encapsulates two sub modules - a module capable
of converting documents from one format to another (this is a generic
converter api kind of thing) and another module which is importing office
documents into xwiki specific formats (XDOMOfficeDocumentBuilder,
PresentationBuilder etc.). I'm not sure if these two modules should be
seperated out, but may be that's a separate discussion.
Please let me know your comments about above points.
Thanks.
- Asiri