xwiki-devs December 2013

xwiki-devs@xwiki.org

33 participants
56 discussions

[xwiki-devs] Questions about fixing getRenderedContent() bug

by Vincent Massol

Hi, Im trying to fix http://jira.xwiki.org/jira/browse/XWIKI-4274 Basically if you do $xwiki.getDocument("someDoc").getRenderedContent() it'll get executed in the context of the current doc which I believe is wrong especially since other signatures of getRenderedContent() execute in the target document's context. I have fixed this locally but found that admin.vm for example is assuming that getRenderedContent() will get executed in the context of the calling doc (i.e. XWiki.Import when doing an import for example). FYI the chain flow is admin.vm -- getRenderedContent() --> XWiki.AdminSheet --> XWiki.AdminImportSheet --> importinline.vm, which requires the current doc to be XWiki.Import (to get/put attachments from/to it). I can fix this easily using a new getRenderedContent signature I've introduced. However I'm wondering if we have other places that incorrectly use getRenderedContent() and assume it won't be rendered in the context of the target document. Is this change too dangerous to make? If not know, we'll need to it quickly (2.1M1?) since it's an important bug IMO. WDYT? Thanks -Vincent

10 years, 1 month

[xwiki-devs] [Contrib] Request repository for Recruitment Application

by Alexandru Chelariu

Hello, I would like to request a repository on xwiki-contrib for the Recruitment Application i am working on. I'd like the repo to be named application-recruitment and also jira component. My github username is chalx. Thank you, Alexandru Chelariu

10 years, 6 months

[xwiki-devs] [ANN] 10 years of the XWiki open source project!

by Vincent Massol

Hi everyone, On the 15th of December (i.e. in a month's time), it will be **10 years** since the first commit on the XWiki open source project. Ludovic did the first commit in CVS on Sourceforge: " 15.12.2003 10:13:33, by ludovic Initial revision " (Can be seen at http://svnsearch.org/svnsearch/repos/XWIKI/search?from=20030101&to=20040101 ) 10 years is starting to be some respectable milestone! I invite everyone to join us in celebrating by adding your own story about your interaction with the XWiki community or the XWiki software at http://dev.xwiki.org/xwiki/bin/view/Drafts/TenYearsOfXWiki <XWiki SAS hat> Since I'm also the CTO of the XWiki SAS company, I'd like to officially invite all the members of this great community to join us in celebrating the 10 days of the XWiki project at the XWiki SAS office in Paris, France on the 12th of December 2013. Here's the invitation: http://www.xwiki.com/lang/en/News/XWiki+10th+Anniversary See you there! </XWiki SAS hat> Well done everyone! -Vincent Massol

10 years, 10 months

[xwiki-devs] [Proposal] Cleaning our POM deps by explicitly listing used dependencies?

by Vincent Massol

Hi devs, Running mvn dependency:dependency-analyze produces interesting results. For example: [INFO] --------------------------------------------------------------------------------------------------------------------------------------------------------------------------- [INFO] Building XWiki Commons - Properties 3.2-SNAPSHOT [INFO] --------------------------------------------------------------------------------------------------------------------------------------------------------------------------- … [INFO] --- maven-dependency-plugin:2.3:analyze (default-cli) @ xwiki-commons-properties --- [WARNING] Used undeclared dependencies found: [WARNING] org.slf4j:slf4j-api:jar:1.6.1:compile [WARNING] javax.inject:javax.inject:jar:1:compile [WARNING] Unused declared dependencies found: [WARNING] org.xwiki.commons:xwiki-commons-component-api:jar:3.2-SNAPSHOT:compile [WARNING] org.xwiki.commons:xwiki-commons-test:jar:3.2-SNAPSHOT:test [WARNING] org.hibernate:hibernate-validator:jar:4.2.0.Final:test [WARNING] org.hamcrest:hamcrest-core:jar:1.1:test [WARNING] org.jmock:jmock:jar:2.5.1:test The question is (for this module but more generally for all others): * Should we add slf4j and javax.inject reps in the pom.xml for this module? (for ex today slf4j and javax.inject are found in the component-api dep) I think we should, wdyt? Note that the "Unused declared dependencies found:" doesn't always generate correct results as is the case here. This is mostly because it's a static byte code check so any dep used at runtime will be considered unused. See http://www.sonatype.com/books/mvnex-book/reference/optimizing-sect-dependen… Thanks -Vincent

10 years, 10 months

[xwiki-devs] [Proposal] Hidden wikis & template wikis

by Guillaume "Louis-Marie" Delhumeau

Hi devs. In the coming 5.3 milestone 2, all wikis are displayed in the Wiki Index, including the templates, which was not the case before. >From the user point of view, maybe these templates should not be listed in the Wiki Index. But on the other hand, if you want to see a template, you will not be able to access through the wiki index. We also have introduced the "hidden" flag for wikis (in the WikiDescriptor, not in the UI yet). If we consider template wikis are "technical" wikis, we may use this flag to hide them. Then, in the Wiki Index, we don't care if a wiki is a template or not, we only care about the "hidden" flag. If the user does not want to see the templates in the list, she can mark them as hidden, exactly as we do for documents. But what about the template list in the wiki creation wizard? Should we list all templates, or only the visible ones? My proposition: - all wikis are visible though the wiki index (template or not). - if we want to hide templates to the users, we use the hidden flag in the wiki descriptor. - in the wiki creation wizard, we display all the templates, even these which are tagged as hidden. WDYT? Thanks, Louis-Marie

11 years

[xwiki-devs] [VOTE] Remove all duplicated information from folders names on git repositories

by Thomas Mortagne

Reviving http://markmail.org/message/hlnqke3igkbec332 for as an official vote. We have waited way too long and I think we really need to find a solution even if none of the committers use Windows since a long time. Every time a Windows dev even think of contributing he is very quickly discouraged... As a reminder the issue is that working on XWiki source code is a pain for MS Windows developers because of the (impossible to understand I agree) limitation on path size. So the idea is to find a new logical rule to drastically shorten our paths and Sergiu proposed the following: remove duplicated information from our paths to maven modules. Here is an example: xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-transformations/xwiki-platform-rendering-transformation-macro (131 chars) would become core/rendering/transformations/macro (36 chars) So WDYT ? Here is my +1 I also find it nicer when navigating using cd and tab in a unix shell anyway. Planning to do it in 5.1 if everyone agree. -- Thomas Mortagne

11 years

[xwiki-devs] [VOTE] Create reference to macros

by Denis Gervalle

Hi devs, While building the new signed script solution with Thomas, we have the need to create a new kind of entity references for macros. This will allow us to keep reference to signed macros. Those references will have entityReference as parent, since macros may be contained in document, but also in object properties. Currently we do not need a syntax for those references, since these will only exists as objects. So, no string serializer is planned. So, we need to agree on creating macroReference that will have at this point a unique identifier (to be discussed later) and a parent that could be either a documentReference or an objectPropertyReference. Here is my +1, -- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO

11 years, 1 month

[xwiki-devs] [Proposal] WebJar integration in XWiki

by Vincent Massol

Hi devs, I'd like to make it easy in XWiki to use javascript frameworks required by extensions. I've found the webjars project (http://webjars.org) which packages javascript frameworks in JAR files available in Maven Central. They work out of the box if you drop them in WEB-INF/lib in a Servlet 3.0 container (like Jetty 7). It works because the 3.0 spec says that any files located in META-INF/resources/<path> will be made available by the servlet container as static resources (accessible as <path>). However the servlet 3.0 specs doesn't support adding those JAR dynamically outside of WEB-INF/lib so it doesn't work with our extension mechanism. Thus I'm proposing the following (which I have tested to work): * Add a new WebJarFilter filter to web.xml * The URL to access, for ex, angular.js packaged in the http://repo2.maven.org/maven2/org/webjars/angularjs/1.1.5-1/angularjs-1.1.5… jar would be: /xwiki/webjar/angularjs/1.1.5/angular.js This allows for example to have a dep on: <dependency> <groupId>org.webjars</groupId> <artifactId>angularjs</artifactId> <version>1.1.5-1</version> <scope>runtime</scope> </dependency> Then in a JSX object: require(["/xwiki/webjar/angularjs/1.1.5/angular.js"], function() { … }); WDYT? Thanks -Vincent

11 years, 2 months

[xwiki-devs] Happy New XWiki Year!

by Ricardo.Julio.Rodriguez.Fernandez＠sergas.es

http://ow.ly/sanLQ Thanks for your hard work, for this nice product and even better community! Warm regards, Ricardo -- Ricardo Rodríguez Research Management and Promotion Technician Technical Secretariat Health Research Institute of Santiago de Compostela (IDIS) http://www.idisantiago.es Nota: A información contida nesta mensaxe e os seus posibles documentos adxuntos é privada e confidencial e está dirixida únicamente ó seu destinatario/a. Se vostede non é o/a destinatario/a orixinal desta mensaxe, por favor elimínea. A distribución ou copia desta mensaxe non está autorizada. Nota: La información contenida en este mensaje y sus posibles documentos adjuntos es privada y confidencial y está dirigida únicamente a su destinatario/a. Si usted no es el/la destinatario/a original de este mensaje, por favor elimínelo. La distribución o copia de este mensaje no está autorizada. See more languages: http://www.sergas.es/aviso_confidencialidad.htm

11 years, 3 months

[xwiki-devs] DW is broken in 5.4M1-SNAPSHOT

by vincent＠massol.net

Hi guys, I’ve rebuilt XE from sources and I’ve found that the DW is broken. I removed the data/ dir to get the DW from a HSQLDB/zip distribution and I’ve found 2 issues: 1) Tons of the following warnings: 2013-12-20 22:22:54,293 [http://localhost:8080/xwiki/bin/distribution/XWiki/Distribution] WARN o.x.v.i.DefaultVelocityEngine - Cannot retrieve method getcause from object of class java.lang.reflect.UndeclaredThrowableException due to security restrictions. 2013-12-20 22:22:54,294 [http://localhost:8080/xwiki/bin/distribution/XWiki/Distribution] WARN o.x.v.i.DefaultVelocityEngine - Cannot retrieve method getCause from object of class java.lang.reflect.UndeclaredThrowableException due to security restrictions. 2 2) The Admin user is not imported anymore. Any idea? Thanks -Vincent

11 years, 3 months

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

xwiki-devs December 2013