August 2019 - xwiki-devs@xwiki.org

[xwiki-devs] [VOTE] Use discourse for the "dev" mailing list
by Guillaume Delhumeau 18 Sep '19

18 Sep '19

Hi devs, I think we are now satisfied with our experimentation with the "users" mailing list on discourse. I propose you to move the "dev" ML too. My main point is that it allows advanced formatting (which is good when you have complex proposals), meanwhile the formatting is lost with our archiving tool like markmail (it's plain text). Here is my +1. Thanks, -- Guillaume Delhumeau (guillaume.delhumeau(a)xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project

3 5

[xwiki-devs] [Proposal] Cleaning of flickering tests
by Simon Urli 06 Sep '19

06 Sep '19

Hi everyone, I was checking our list of flickering tests in JIRA (https://jira.xwiki.org/issues/?jql=labels%20%3D%20flickering%20AND%20status…) and I noticed that we had somehow old flickering test issue concerning test that I've never seen failing. So I propose we close some of them as inactive: the ones that we don't remember having seen for a while. The ideal would be to have a mechanism to update the issue when the CI fails on a flicker, but it takes time to do properly and it's not a priority. On the contrary I propose to trust our memory: if we're wrong because we have closed a flicker that is still happening, it will allow us to remind that we have this flicker to fix and we can easily reopen the issue. As Thomas mentioned on the chat, we should also update the release plan to include the inactive flickers in the list of issue to check. So for now I propose to close the following list of issues as inactive: * XWIKI-14399: AddRemoveTagsTest#addAndDeleteTagFromTagPage is flickering (https://jira.xwiki.org/browse/XWIKI-14399) * XWIKI-14396: AnnotationsTest#addAndDeleteAnnotations is flickering (https://jira.xwiki.org/browse/XWIKI-14396) * XWIKI-14394: SectionTest.testSectionEditInWikiEditorWhenSyntax2x (xwiki-enterprise-test-ui) is flaky (https://jira.xwiki.org/browse/XWIKI-14394) * XWIKI-14386: appwithinminutes.AppsLiveTableTest.testEditApplication is possibly flaky (https://jira.xwiki.org/browse/XWIKI-14386) * XWIKI-14835: DeletePageTest#deletePageIsImpossibleWhenNoDeleteRights is flickering (https://jira.xwiki.org/browse/XWIKI-14835) * XWIKI-14860: LoginTest#testDataIsPreservedAfterLogin is flickering (https://jira.xwiki.org/browse/XWIKI-14860) And I propose in general to close the flickers we don't remember having seen after a cycle as inactive. WDYT? Simon -- Simon Urli Software Engineer at XWiki SAS simon.urli(a)xwiki.com More about us at http://www.xwiki.com

3 20

[xwiki-devs] Map Application - GSoC 19
by Fawad Ali 04 Sep '19

04 Sep '19

Hi everyone, Hope all of you are doing great. About Me I am Fawad Ali, selected as a student for Google Summer of Code. Currently enrolled in the 6th semester at University of Engineering and Technology, Taxila. I am a resident of Pakistan currently living in the city of Rawalpindi. It is a great honor to have been selected and have a chance to work with XWiki. :) *Profiles* GitHub - https://github.com/9inpachi LinkedIn - https://www.linkedin.com/in/fawadaliq/ Riot - @ginpachi:matrix.org I will be presenting my project "Map Application" to all of you. Following are the relevant details. Map Application *Mentors: *Stéphane Laurière, Ecaterina Moraru *Technologies:* JavaScript, Velocity, Java, Leaflet, other if required Overview This project is about the development of interactive maps in XWiki. Creation of an application within XWiki that will allow users to generate interactive maps which support collaboration and are easy to create so that locations can be shared, and areas can be associated with structured data. This application will open several possibilities that can be utilized within XWiki and broaden the overall scope by allowing map rich wikis where locations and areas can be presented in a way that will increase the understandability of data. It will also allow for the sharing of custom map related data which would be very helpful since users and admins will be able to present locations in an information rich map environment which will be interactive. Features > *Markers and popups* - Place markers anywhere on the map and associate popups with them. > *Path between two points* - A path will be generated by the application linking two points of interest. > *Location search* - Search any location on the map. > *Filtered list maps* - Allow the user to search for a specific kind of place (e.g. restaurants) and get a list of locations to choose from. Through the content available and binded to a location, the user will be able to learn some aspects of the location. > *Custom shapes* - Custom shapes can be used to highlight a specific area for representation. The content associated with these shapes can give useful information about the area. > *Indoor maps* - Such maps will be able to describe the internal structure or fair plan of a building or structure. They can be used to guide users in a big building and locate point of interests. > *Maps on mobile* - Special design arrangements will be made for easily viewing of maps and availing all the features of the application on mobile devices. > *Custom map backgrounds* - Custom backgrounds will make the environment of interactive maps much suitable for a specific purpose If you have any features in mind that will make the Map Application better please feel free to reply to this mail. This is all for the summary of the project, if you want to have a more deeper insight, please check out the full proposal. *Project Proposal: * https://drive.google.com/open?id=14qXC7Oy2bPUASfVtSTIsNG1sPcfm5Ikr Thanks for reading through the mail. I will be looking forward to your guidance through this summer and your contributions to the project. If you have any questions or suggestions, please feel free to reply to this mail. Au revoir. :) Best, Fawad Ali

6 112

[xwiki-devs] [XWiki Day] BFD#222
by Simon Urli 30 Aug '19

30 Aug '19

Hello devs, This Thursday is BFD#222: http://dev.xwiki.org/xwiki/bin/view/Community/XWikiDays#HBugfixingday Our current status is: * -19 bugs over 120 days (4 months), i.e. we need to close 19 bugs to have created bugs == closed bugs * -85 bugs over 365 days (1 year) * -147 bugs over 500 days (between 1 and 2 years) * -374 bugs over 1600 days (4.3 years) See https://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=10352 Here's the BFD#222 dashboard to follow the progress during the day: https://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=14439 Good luck at fixing bugs, Simon -- Simon Urli Software Engineer at XWiki SAS simon.urli(a)xwiki.com More about us at http://www.xwiki.com

1 1

[xwiki-devs] [ANN] XWiki 11.7 released
by Marius Dumitru Florea 27 Aug '19

27 Aug '19

The XWiki development team is proud to announce the availability of XWiki 11.7. This release brings a new date picker and various merge improvements. Developers will also be able to reuse the standard color picker and the merge API give more details about the conflicts. You can download it here: https://www.xwiki.org/xwiki/bin/view/Main/Download Make sure to review the release notes: https://www.xwiki.org/xwiki/bin/view/ReleaseNotes/Data/XWiki/11.7 Thanks for your support -The XWiki dev team

1 0

[xwiki-devs] [XWiki Day] BFD#221
by Oana-Lavinia Florean 23 Aug '19

23 Aug '19

Hello devs, This Thursday is BFD#221: http://dev.xwiki.org/xwiki/bin/view/Community/XWikiDays#HBugfixingday Our current status is: * -8 bugs over 120 days (4 months), i.e. we need to close 8 bugs to have created bugs == closed bugs * -77 bugs over 365 days (1 year) * -132 bugs over 500 days (between 1 and 2 years) * -360 bugs over 1600 days (4.3 years) See https://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=10352 Here's the BFD#221 dashboard to follow the progress during the day: https://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=14438 Good luck at fixing bugs, Lavinia

1 1

Re: [xwiki-devs] Map Application - GSoC 19
by Fawad Ali 23 Aug '19

23 Aug '19

Hi all, I wanted to ask if it was possible to have a custom class sheet and the editing options of a normal page available at the same time? As it stands, for the PointSheet, we will have to skip the WYSIWYG editor for editing the page. However, one thing could be that instead of taking the page's content for the Point's popup, we could introduce a new class property popupContent and have the popup content inside that. This way, we can use WYSIWYG as well. Another approach could be to keep the current Point Editor and use that create points without any sheet. The same questions apply for the Shape Editor as well. What do you think? Best, Fawad On Fri, Aug 2, 2019 at 2:53 PM Fawad Ali <m.fawaadali98(a)gmail.com> wrote: > Stéphane, > > Yes, sure. > In the meantime, I will be working on the PointSheet. > However, I do want to ask if the Shape Editor is necessary at this point > if we are going with GeoJSON. We can refer the user to http://geojson.io > for creating the features. What do you think? > > Best, > Fawad > > > On Fri, Aug 2, 2019 at 12:04 PM Stéphane Laurière <slauriere(a)xwiki.com> > wrote: > >> OK Fawad, >> >> Meantime since Caty is off, and since today might actually be a bit early >> for me I'm afraid, I'd propose we have the call on Monday 15:00 UTC on >> Monday if that's ok with you . >> >> Cheers >> >> Stéphane >> >> >> Fawad Ali: >> > Stéphane, Ecaterina, >> > >> > About the call, I think we should have it so that we all converge on >> the things to be done. >> > However, tomorrow (Friday), I have a call with the Pakistan's GSoC >> community at about 5 PM UTC. If the call will be finished in two hours I am >> fine with it or we could reschedule it to 2:30 PM UTC or else Monday. >> > >> > Best, >> >> >> -- >> Stéphane Laurière >> XWiki – https://xwiki.com >> >>

2 19

[xwiki-devs] [Proposal] Remove XWiki.User enable property and introduce email_check property
by Simon Urli 23 Aug '19

23 Aug '19

Hi everyone, I recently (in XWiki 11.6RC1) introduced a new property "enabled" in XWiki.User as part of https://jira.xwiki.org/browse/XWIKI-12654 to distinguish between inactive users (who have not confirm their registration with the token sent by email), and disabled users (who are deactivated by an admin, or by a security mechanism). Now as Marius noticed those two properties are quite redundant, especially when you want to know which users are really active. So it introduces unnecessary complexity and we might even need to change existing extension to check enabled users (cf the last comments on XWIKI-12564). So before doing those changes, I propose to fix immediately the issue by removing that newly introduced property and by introducing a new property only for assessing that users' email are checked. Then we will only have to check "active" property to check if a user is active or not, and we could rely on it to set them enabled or disabled in the admin. The email_check property would be used only for the check email mechanism, so it will avoid any confusion in the semantic. WDYT? Simon -- Simon Urli Software Engineer at XWiki SAS simon.urli(a)xwiki.com More about us at http://www.xwiki.com

5 6

[xwiki-devs] Application pages layout best practices
by Stéphane Laurière 22 Aug '19

22 Aug '19

Hi everyone, I'm following up on a thread started in 2015 about the best practices regarding app pages organization: - https://xwiki.markmail.org/message/657vcm6ylkz4yytc - https://dev.xwiki.org/xwiki/bin/view/Community/ApplicationDevelopmentBestPr… In this thread, the idea of introducing a dedicated common root area for all application technical pages was suggested by Denis: https://xwiki.markmail.org/message/kk5l3dwjmpfelkzp I'm wondering why this idea was not pushed further (it's not strictly incompatible with the current best practices, but most of the recent applications have their top level area, except a few like Notifications or ChartJS). Comparing with how other platforms do is inspirational (Microsoft Windows "Program Files" was mentioned in the thread). On Debian, the Maven package is installed in /usr/share/maven/ while files used and produced by Maven can be located anywhere. Along the same line, I would see as a user and developer experience improvement if we had the following structure: 1) Code: XWiki |- MyApp |- MyAppClass |- MyAppSheet |- ... 2) Data: the pages created by MyApp could then typically be located by default in a MyApp space at the root of the wiki, the user could however choose which default space to use, or leave it empty (then the space from where the user fires the create action could be used, for instance, or any scriptable rule). Another issue I see with the current practice (raised by Clément A. orally) is that some application names may conflict with names the user would like to use for content that is not strictly related to the app. Not necessarily a big deal with one thousand of applications, but might become one with more, wouldn't it? I understand that the layout proposed above would raise technical issues (XWiki space permissions for instance, mentionned in the 2015 thread, and others), however what's your view on it from a design perspective? (sorry if I overlooked strong arguments already expressed against it) Cheers Stéphane

2 4

[xwiki-devs] [ANN] XWiki 11.7 RC1 released
by Thomas Mortagne 20 Aug '19

20 Aug '19

The XWiki development team is proud to announce the availability of XWiki 11.7 RC1. This release brings a new date picker and various merge improvements. Developers will also be able to reuse the standard color picker and the merge API give more details about the conflicts. You can download it here: https://www.xwiki.org/xwiki/bin/view/Main/Download Make sure to review the release notes: https://www.xwiki.org/xwiki/bin/view/ReleaseNotes/Data/XWiki/11.7RC1 Thanks for your support -The XWiki dev team

1 0

[xwiki-devs] [contrib] any interest in another authenticator that deals with failed logins
by Clemens Klein-Robbenhaar 19 Aug '19

19 Aug '19

Hi devs. I noticed that the recent 11.6.x series have introduced a way to deal with attempts to guess a users password by introducing a strategy to handle repeated login failures. I should have payed attention before this was published because I have been implementing something similar because of several user requests. Anyway, my alternative solution has been finished in parallel, and I wonder if there is any interest of hosting this as a contrib project. The implementation differs in the following details: - it does not use the new AuthenticationFailureEvents and the introduced component API, instead it implements its own XWikiAuthService - this means it works for 10.x, too (which my users are mostly running) - otoh it does not work with e.g. the LDAPAuthenticator - it also allows to block IPs (not that I care much about, but some people want this) - it unblocks the user after a given time frame without having an Admin to intervene I guess I can migrate at least most of it into the new AuthenticationFailureStrategy to have a showcase for a different implementation, but for now it is a separate and already slightly outdated implementation. I think I will upload the results to e.x.o anyway (with a big note that this is superseded since XWiki 11.6), but is there any interest of hosting this as an xwiki-contrib project, maybe with the name 'authenticator-blocking', package 'org.xwiki.contrib.blockingauth' and maybe even a Jira project like 'BLOCKINGAUTH' ? Best, Clemens

5 4

[xwiki-devs] [XWiki Day] BFD#220
by Oana-Lavinia Florean 09 Aug '19

09 Aug '19

Hello devs, This Thursday is BFD#220: http://dev.xwiki.org/xwiki/bin/view/Community/XWikiDays#HBugfixingday Our current status is: * -26 bugs over 120 days (4 months), i.e. we need to close 26 bugs to have created bugs == closed bugs * -98 bugs over 365 days (1 year) * -153 bugs over 500 days (between 1 and 2 years) * -376 bugs over 1600 days (4.3 years) See https://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=10352 Here's the BFD#220 dashboard to follow the progress during the day: https://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=14434 Good luck at fixing bugs, Lavinia

1 1

[xwiki-devs] Use the new Mail Sender API for the Share Page By Mail feature
by Gabriel Raileanu 09 Aug '19

09 Aug '19

Hello everyone! Currently, I'm working on moving to the new Mail Sender API for share page by mail, which is related in XWiki-11786 <https://jira.xwiki.org/browse/XWIKI-11786>. After having some discussions with Vincent, we decided to include the possibility of sending the email to groups, related in XWiki-12112 <https://jira.xwiki.org/browse/XWIKI-12112>. Even if everything looks good for now, a problem just appeared when trying to access the recipient name (it's used in the email body, for addressing the recipient (*Hello ${recipientName}*). It seems like the new API it's not providing other information than the email address, which was confirmed by XWiki-12207 <https://jira.xwiki.org/browse/XWIKI-12207>. For now, I worked here <https://github.com/arcilli/xwiki-platform/tree/XWIKI-12112> with some code from Vincent's commits <https://github.com/xwiki/xwiki-platform/tree/feature-sharepage-group>. Also, after a few discussions with Marius, we concluded that for having the name of the recipient in the message, the code needs some refactoring, which can take a considerable amount of time. Another solution is to exclude the *recipientName *from the body of the message and keep only *Hello *(which would be a regression). This will be a shorter solution, but with the benefit of having the possibility to send emails to groups. What's your opinion on this? Thanks a lot! Have a nice day! -- <http://www.xwiki.com/> *Gabriel Răileanu* *Software Developer Engineer Intern* gabriel.raileanu(a)xwiki.com

2 1

[xwiki-devs] [ANN] XWiki 11.6.1 released
by Simon Urli 08 Aug '19

08 Aug '19

The XWiki development team is proud to announce the availability of XWiki 11.6.1. This is a bugfix release that covers important issues that we have discovered since XWiki 11.6 has been released. It has been released mainly to fix a bug related with the usage of nested wikimacro, which might make some applications unusable. It also fix some other bugs related to the newly introduced async macro. You can download it here: https://www.xwiki.org/xwiki/bin/view/Main/Download Make sure to review the release notes: https://www.xwiki.org/xwiki/bin/view/ReleaseNotes/Data/XWiki/11.6.1 Thanks for your support -The XWiki dev team

1 0

[xwiki-devs] [Proposal] Best practice: tests must not output anything outside of the target directory
by Vincent Massol 08 Aug '19

08 Aug '19

Hi devs, I was pretty sure that this was discussed before but I can’t find it so I’m posting it again since I noticed that we continue to have tests (and even add new ones) that use the OS tmp directory to output test data. Tests must not generate anything outside of the target/ directory as this will cause several problems: * not clean generated test data after the test * create a state that can make other tests fail * generate errors in jenkins since jenkins monitors created files and doesn't allow to remove files outside of the worskspace WDYT? If ok I’ll add it to https://dev.xwiki.org/xwiki/bin/view/Community/Testing/JavaUnitTesting/#HBe… Thanks -Vincent PS: Ideally we should have a automatic verification in the build but it doesn’t seem easy to implement, so right now, I’m only proposing it as a best practice.

4 4

[xwiki-devs] [XWiki Day] BFD#219
by Oana-Lavinia Florean 02 Aug '19

02 Aug '19

Hello devs, This Thursday is BFD#219: http://dev.xwiki.org/xwiki/bin/view/Community/XWikiDays#HBugfixingday Our current status is: * -28 bugs over 120 days (4 months), i.e. we need to close 28 bugs to have created bugs == closed bugs * -94 bugs over 365 days (1 year) * -153 bugs over 500 days (between 1 and 2 years) * -376 bugs over 1600 days (4.3 years) See https://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=10352 Here's the BFD#219 dashboard to follow the progress during the day: https://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=14433 Good luck at fixing bugs, Lavinia

1 1

[xwiki-devs] [Proposal] Use a standard 3-way merge implementation
by Simon Urli 01 Aug '19

01 Aug '19

Hello everyone, I'm currently working on the commons-diff-api to add new capabilities in case of conflict. Yesterday while I was working on it, I added new tests to check my changes and discovered that our current implementation of the 3-way merge was not following a "standard" implementation, and so some expectations I could have was not followed. Actually Thomas did a huge job by implementing by himself the 3-way merge based on the diff of previous-current and previous-next, but AFAIU this implementation does not take into account the diff current-next which can also bring information. So for example if you try to do a merge, with the following lines: origin="Once upon a time","a wolf","started to walk","in the forest" next="Once upon a time","a wolf","dressed in black","in the forest" current="Once upon a time","a wolf","started to walk","dressed in black","in the forest" the current result will be: "Once upon a time", "a wolf", "dressed in black", "dressed in black", "in the forest" instead of treating it like a conflict which can be view as a more "standard" answer. Here by standard, I mean the result that a tool like "diff3" or git merge would do. I dig a bit on internet yesterday and apparently diff3 is really considered as the standard implementation of a 3-way merge. I performed the check with those lines both using git and diff3 and in both cases, they see the "started to walk" as a conflictual line: Once upon a time a wolf <<<<<<< HEAD started to walk ======= >>>>>>> 20b7776... My change dressed in black in the forest I assume we could debug the implementation Thomas done to ensure this usecase is taken into account, as far as I can see it's not easy, but I guess it's possible. Another solution, which I personally prefer, would be to rely on an existing implementation of a diff3 merge, or Git merge: I found yesterday that jgit have their own Java implementation of the merge (https://github.com/eclipse/jgit/blob/master/org.eclipse.jgit/src/org/eclips…) and AFAICS the license doesn't prevent us to reuse it (it's a derived BSD license). I don't think we cannot completely reuse it as it is, but it's at least a good inspiration to do our own implementation based on a standard. A better solution would certainly to use a dedicated maintained library but I did not manage to find it. Now we could also assume that the current behaviour of the merge is what we want and we keep up with it. So what do you think, should we change our implem or keep it like that? Simon -- Simon Urli Software Engineer at XWiki SAS simon.urli(a)xwiki.com More about us at http://www.xwiki.com

1 0