- xwiki-devs@xwiki.org - lists.xwiki.org

by Vincent Massol

Hi, Why not have panels on the right too (for the home page at least) and have 3 panels on the right: - Create an Account - Add a language - Supported Languages This would free up space for the main view so that more of the latest translations can be seen without scrolling. I also think it would make the page more balanced. WDYT? Thanks -Vincent

15 years, 7 months

2
2
0 0

[xwiki-devs] hbm.xml files don't appear to be in the war files

by Peter McLarty

Hi All I am trying to install the war file and get it working with Oracle I have followed the instructions resolved a number of issues I still have a problem at present and it appears that the war file for configuring with its own database and container does not contain any of teh hbm.xml files I have tried the stable and latest and scanning them I cannot locate them in teh war file Could someone confirm this for me and what is the best approach in the sort term should I just download from the svm repository? Thanks Cheers Peter

15 years, 7 months

2
1
0 0

[xwiki-devs] GWT RichTextArea questions

by Norbert Sándor

Hello, I'm experimenting with the RichTextArea (RTA) in a separate application, not in XWiki. I checked out the xwiki-gwt-dom and xwiki-gwt-user, and RTA seems to work well. (Until now I've created only a small demo application, with an RTA and some buttons to execute various commands.) My questions are: 1. Pressing ENTER creates a BR element by default, is it possible to create a P instead? (The behaviour of the ENTER key inside a P can be set by executing the insertbronreturn command, but the default document always contains a BR, and if I set the initial content to <p></p>, I cannot navigate the cursor inside the P...) 2. Is there a way to listen to selection events? (I want to enable/disable some buttons based on the current selection.) 3. Are there any extensions to the default RTA in the other parts of XWiki? (I mean for example commands and controls for editing TABLEs visually, toolbars that are enabled/disabled based on the content of the RTA, etc. - I haven't looked at all the source code yet, it's huge :) That's for a starter :) Thanks for your help in advance! Best regards: -- Norbert Sándor http://jvminside.blogspot.com/

15 years, 7 months

3
8
0 0

[xwiki-devs] [Proposal] Evaluate javascript syntax highlighting as alternative to Jython/Pygments

by Caleb James DeLisle

Lately I have been playing with a few different javascript syntax highlighting libraries. One which I think shows some promise is google-code-prettify, used for highlighting on google code (Apache license.) Advantages of javascript highlighting: + We could remove Pygments and Jython, Jython weighs in at 8.3MB making it the largest jar in the lib folder, Pygments adds another 364K. + I understand Jython/Pygments has been responsible for recent out of permgen memory errors. + Shifts work from server to client. + Adding a js syntax highlighting library to the svn repository allows us to patch it to support xwiki syntax (switch lexers when macros are detected.) + Relatively easy compared to other performance boosters. Disadvantages: - Some users do not use Javascript. - Highlighting may be slow on old computers when lots of code is displayed. - Removing Jythion from the default build will add a step to upgrading for wiki operators who are using the {{python}} macro. - Adds another js file to download which hurts page load speed until a js bundling plan is in place. If there is significant interest, I could put up a comparison page on the incubator. Caleb

15 years, 7 months

4
3
0 0

[xwiki-devs] Visual improvements for the home page of l10n.xwiki.org

by Vincent Massol

Hi UI experts, Would be up for the challenge of making the home page of http://l10n.xwiki.org even nicer than what it currently is? :) Thomas has just added best contributors. We're only missing some touch of CSS/HTML magic and the page would be great thus inviting even more people to participate. Any idea? Thanks -Vincent

15 years, 7 months

6
16
0 0

Re: [xwiki-devs] [xwiki-notifications] r26548 - platform/skins/trunk/colibri/src/main/resources/colibri

by Sergiu Dumitriu

On 01/29/2010 04:41 PM, vmassol (SVN) wrote: > Author: vmassol > Date: 2010-01-29 16:41:25 +0100 (Fri, 29 Jan 2010) > New Revision: 26548 > > Modified: > platform/skins/trunk/colibri/src/main/resources/colibri/menuview.vm > Log: > XSCOLIBRI-188: Don't show the create page from office document menu entry if the office importer application isn't installed > > Modified: platform/skins/trunk/colibri/src/main/resources/colibri/menuview.vm > =================================================================== > --- platform/skins/trunk/colibri/src/main/resources/colibri/menuview.vm 2010-01-29 15:12:03 UTC (rev 26547) > +++ platform/skins/trunk/colibri/src/main/resources/colibri/menuview.vm 2010-01-29 15:41:25 UTC (rev 26548) This will fail if the document exists, but the user does not have access to it. $officeImporterMainDocument is null, so $officeImporterMainDocument.isNew() is undefined, so !undefined is true. > + #set($officeImporterMainDocument = $xwiki.getDocument('XWiki.OfficeImporter')) > + #if (!$officeImporterMainDocument.isNew()) Try: #if("$!{officeImporterMainDocument.isNew()}" == 'false') -- Sergiu Dumitriu http://purl.org/net/sergiu/

15 years, 7 months

1
0
0 0

[xwiki-devs] Configuration for velocity applications

by Caleb James DeLisle

Hello all, I have been working on a registration application which is written entirely in velocity and I want to specify some configurations for it such as should captchas be required or should LiveValidation be enabled. This is just an example and I'm sure there are and will be more velocity applications which need to be configured. The problem is that ConfigurationSource is unavailable to velocity applications and a few possible solutions include: Put the configuration in the XWiki.XWikiPreferences object and get it using XWiki.Param This is nice because preferences for applications which are in the database should also be in the database IMO. However it negates the ConfigurationSource, making configuration less portable and it also introduces the need for programming rights to save the document. Add a configuration class to get the parameters from ConfigurationSource and pass them to the velocity application. Vincent has -1'd the idea of having a generic configuration getter like XWiki.Param and writing a java class for each application defeats the purpose of writing code as an XAR application. Another idea is to put the configuration inside the (registration) application and load the registration document in the relevant section of the administration application. The best way to do this would be to define a class and the administration app includes any document containing an object of that class. This way any application which needed configuration could be configured from one place and it wouldn't require a reference for each one. I'd like to hear any other ideas anyone has, Caleb

15 years, 7 months

1
0
0 0

[xwiki-devs] [ANN] XWiki Enterprise 2.2 Milestone 2 Released

by Thomas Mortagne

The XWiki development team is pleased to announce the release of XWiki Enterprise 2.2 Milestone 2. Go grab it at http://www.xwiki.org/xwiki/bin/view/Main/Download Changes from 2.2 Milestone 1: * New improved registration page * New UI for edit mode * Support for color theme in HTML export * Improved speed and responsiveness of the WYSIWYG editor * Comments UI improvements * Upgraded to GWT 2.0.0 * Lots of bugs fixes For more information see the Release notes at: http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXWikiEnterprise22M1 Thanks -The XWiki dev team

15 years, 7 months

4
5
0 0

Re: [xwiki-devs] [xwiki-notifications] r26514 - platform/core/trunk/xwiki-cache/xwiki-cache-jbosscache/src/main/java/org/xwiki/cache/jbosscache/internal

by Sergiu Dumitriu

On 01/28/2010 12:59 PM, tmortagne (SVN) wrote: > Author: tmortagne > Date: 2010-01-28 12:59:59 +0100 (Thu, 28 Jan 2010) > New Revision: 26514 > > Modified: > platform/core/trunk/xwiki-cache/xwiki-cache-jbosscache/src/main/java/org/xwiki/cache/jbosscache/internal/JBossCacheCache.java > Log: > XWIKI-4800: Fix warnings appearing in the logs when importing a XAR > > Modified: platform/core/trunk/xwiki-cache/xwiki-cache-jbosscache/src/main/java/org/xwiki/cache/jbosscache/internal/JBossCacheCache.java > =================================================================== > --- platform/core/trunk/xwiki-cache/xwiki-cache-jbosscache/src/main/java/org/xwiki/cache/jbosscache/internal/JBossCacheCache.java 2010-01-28 11:18:19 UTC (rev 26513) > +++ platform/core/trunk/xwiki-cache/xwiki-cache-jbosscache/src/main/java/org/xwiki/cache/jbosscache/internal/JBossCacheCache.java 2010-01-28 11:59:59 UTC (rev 26514) > @@ -195,8 +195,12 @@ You used LOG.warn in nodeEvicted and LOG.info in nodeRemoved. Shouldn't they use the same log level? > public void nodeEvicted(NodeEvictedEvent event) > { > if (!event.getFqn().isChildOf(ROOT_FQN)) { > - if (LOG.isInfoEnabled()) { > - LOG.info(MessageFormat.format("The node {0} should not has been evicted", event.getFqn())); > + if (!event.getFqn().equals(ROOT_FQN)) { > + LOG.warn(MessageFormat.format( > + "The [{0}] node has been evicted but it should not even have been part of the cache", > + event.getFqn())); > + } else { > + LOG.debug("The entire cache has been evicted"); > } > > return; > @@ -216,8 +220,12 @@ > public void nodeRemoved(NodeRemovedEvent event) > { > if (!event.getFqn().isChildOf(ROOT_FQN)) { > - if (LOG.isInfoEnabled()) { > - LOG.info(MessageFormat.format("The node {0} should not has been removed", event.getFqn())); > + if (!event.getFqn().equals(ROOT_FQN)) { > + LOG.info(MessageFormat.format( > + "The [{0}] node has been removed but it should not even have been part of the cache", > + event.getFqn())); > + } else { > + LOG.debug("The entire cache has been removed"); > } > > return; -- Sergiu Dumitriu http://purl.org/net/sergiu/

15 years, 7 months

2
1
0 0

Re: [xwiki-devs] [VOTE] Edit UI improvements and panelless edit

by Raluca Stavro

On Mon, Jan 25, 2010 at 10:37 PM, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote: > Hi devs, > > We've been working on improving the editors (content, class, object), > and now I have some pretty important UI changes to commit, but not > everybody seems to agree with them, so I bring up a vote. > > The whole improvements can be seen on > http://incubator.myxwiki.org/xwiki/bin/Improvements/ImprovedEdit > > Here are the individual voted points: > > 0 Remove all panels in edit mode +1 > > 1a Parent and title above the content in wiki/wysiwyg mode > > 1b The same style in edit mode as in view mode for the parent/title fields > > 1c AJAX Suggest for the parent field +1 for all > > 2a New label for the content textarea ("Content") > > 2b List of included documents after the Content label > > 3a Syntax switcher in the top right corner of the content > > 3b Syntax help in the top right corner of the content > > 3c Syntax help and switcher only in the wiki editor +1 for all > > 4 Better label for the version comment > big +1 > 5a Right float the Minor edit field > > 5b Put the Minor edit label after the checkbox > +1 for both > 6 Move autosave in line with the submit buttons > +1, but aligned on the right side > 7 Introduce new AJAX-powered Add Object > i) above the objects > ii) bellow the objects +1 for i) > > 8 Introduce new AJAX-powered Add Object from this class > i) at the top of the list of existing objects > ii) at the end of the list +1 for i) > > 9 Move the class switcher in the top right corner > > 9b Remove the class switcher > +1 (I never needed it - and I do work with class editors quite often) > 10 Introduce new AJAX-powered Add Property > i) at the top of the list of properties > ii) at the end of the list > +1 for i) Note: I voted for 7 i), 8 i) and 10 i) to keep consistency. Nice job! Raluca. > > I vote +1 for all of the above, except 9b (-0), and with options 7i), > 8ii), and 10ii) > > -- > Sergiu Dumitriu > http://purl.org/net/sergiu/ > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs >

15 years, 7 months

1
0
0 0

[xwiki-devs] [UX] Delete space menu action

by Vincent Massol

Hi, WDYT about a delete space action in the space action menu? Seems like it' a basic need from the questions we get about how to do this. We would display all docs in the space on the delete page and ask extra confirmation. Thanks -Vincent

15 years, 8 months

7
8
0 0

Re: [xwiki-devs] [xwiki-notifications] r26429 - enterprise/trunk/distribution-test/selenium-tests/src/test/it/com/xpn/xwiki/it/selenium

by Vincent Massol

On Jan 27, 2010, at 11:38 AM, cjdelisle (SVN) wrote: > Author: cjdelisle > Date: 2010-01-27 11:38:03 +0100 (Wed, 27 Jan 2010) > New Revision: 26429 > > Modified: > enterprise/trunk/distribution-test/selenium-tests/src/test/it/com/xpn/xwiki/it/selenium/WatchListTest.java > Log: > XAWATCHLIST-97: Selenium test failing after upgrade from old XWiki.WatchListManager - Removed all references to XWiki.WatchListManager. > > Modified: enterprise/trunk/distribution-test/selenium-tests/src/test/it/com/xpn/xwiki/it/selenium/WatchListTest.java > =================================================================== > --- enterprise/trunk/distribution-test/selenium-tests/src/test/it/com/xpn/xwiki/it/selenium/WatchListTest.java 2010-01-27 09:18:49 UTC (rev 26428) > +++ enterprise/trunk/distribution-test/selenium-tests/src/test/it/com/xpn/xwiki/it/selenium/WatchListTest.java 2010-01-27 10:38:03 UTC (rev 26429) > @@ -56,13 +56,6 @@ > { > // Stop GreenMail test server > this.greenMail.stop(); > - > - // Restore XWiki.WatchListManager from the trash since it's been deleted by the tests below. > - open("XWiki", "WatchListManager"); > - if (isElementPresent("link=Restore")) { > - clickLinkWithLocator("link=Restore"); > - assertTextPresent("Watchlist for Administrator"); > - } > } > > public void testWatchThisPageAndWholeSpace() throws Exception > @@ -93,9 +86,6 @@ > open("XWiki", "WatchListMessage", "edit", "editor=object"); > assertTextPresent("Mail 0:"); > > - // Test if the watchlist manager document exists > - assertTrue("Page XWiki.WatchListManager doesn't exist", isExistingPage("XWiki", "WatchListManager")); > - > // Watch Test.TestWatchThisPage > createPage("Test", "TestWatchThisPage", "TestWatchThisPage selenium"); > clickLinkWithText("Watch", false); > @@ -109,9 +99,15 @@ > assertTextPresent("TestWatchThisPage"); > assertTextPresent("TestWatchWholeSpace"); > > + // Click on the inline edit button > + clickLinkWithLocator("xpath=//a[@id='tmEditInline']"); > + > + // Click the watchlist button because it forgets that we are at the watchlist, no new page loads so we don't wait. > + clickLinkWithLocator("xpath=//li[@id='watchlistTab']/a", false); > + > // Ensure the frequency set is every hour so that Hourly job we've modified is used > - getSelenium().select("XWiki.WatchListClass_0_interval", "label=Scheduler.WatchListDailyNotifier"); > - clickLinkWithXPath("//input[@value='Save']", true); > + getSelenium().select("XWiki.WatchListClass_0_interval", "value=Scheduler.WatchListDailyNotifier"); > + clickEditSaveAndView(); > > // Trigger the notification > open("Scheduler", "WebHome"); > @@ -130,10 +126,5 @@ > clickLinkWithXPath("//div[@id='xobject_XWiki.XWikiPreferences_0_title']", false); > setFieldValue("XWiki.XWikiPreferences_0_smtp_port", "25"); > clickEditSaveAndView(); > - > - // XWIKI-2125 > - // Verify that the Watchlist menu entry is not present if XWiki.WatchListManager does not exists > - deletePage("XWiki", "WatchListManager"); > - assertTextNotPresent("Manage your watchlist"); Not very urgent right now but we may want to not have a watchlist tab in the user profile if the watchlist sheet page doesn't exist. In the future I think this will be an Interface Extension in the user profile so that apps can contribute new tabs and the watchlist will be a separate app. Thanks -Vincent

15 years, 8 months

1
0
0 0

Re: [xwiki-devs] [xwiki-notifications] r26408 - in platform/core/trunk/xwiki-core/src/main: java/com/xpn/xwiki/user/impl/LDAP java/com/xpn/xwiki/user/impl/xwiki resources

by Sergiu Dumitriu

On 01/26/2010 03:20 PM, vmassol (SVN) wrote: > Author: vmassol > Date: 2010-01-26 15:20:55 +0100 (Tue, 26 Jan 2010) > New Revision: 26408 > > Modified: > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/LDAP/XWikiLDAPAuthServiceImpl.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/xwiki/AbstractXWikiAuthService.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiAuthServiceImpl.java > platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties > Log: > XWIKI-2261: Don't give password hints Actually I would leave the nousername/nopassword messages, since this is a known fact that doesn't give any hints about the existence of the user. > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/LDAP/XWikiLDAPAuthServiceImpl.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/LDAP/XWikiLDAPAuthServiceImpl.java 2010-01-26 14:14:24 UTC (rev 26407) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/LDAP/XWikiLDAPAuthServiceImpl.java 2010-01-26 14:20:55 UTC (rev 26408) > @@ -115,7 +115,7 @@ > > // Check for empty usernames > if (login.equals("")) { > - context.put("message", "nousername"); > + context.put("message", "invalidcredentials"); > > if (LOG.isDebugEnabled()) { > LOG.debug("LDAP authentication failed: login empty"); > @@ -126,7 +126,7 @@ > > // Check for empty passwords > if ((password == null) || (password.trim().equals(""))) { > - context.put("message", "nopassword"); > + context.put("message", "invalidcredentials"); > > if (LOG.isDebugEnabled()) { > LOG.debug("LDAP authentication failed: password null or empty"); > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiAuthServiceImpl.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiAuthServiceImpl.java 2010-01-26 14:14:24 UTC (rev 26407) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiAuthServiceImpl.java 2010-01-26 14:20:55 UTC (rev 26408) > @@ -423,13 +423,13 @@ > > // Check for empty usernames > if (cannonicalUsername.equals("")) { > - context.put("message", "nousername"); > + context.put("message", "invalidcredentials"); > return null; > } > > // Check for empty passwords > if ((password == null) || (password.trim().equals(""))) { > - context.put("message", "nopassword"); > + context.put("message", "invalidcredentials"); > return null; > } > -- Sergiu Dumitriu http://purl.org/net/sergiu/

15 years, 8 months

2
1
0 0

Re: [xwiki-devs] [xwiki-notifications] r26271 - in platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki: . objects objects/classes store

by Caleb James DeLisle

When users are added to the XWikiAllGroup, the class which is created is called Main.WebHome instead of XWiki.XWikiGroupClass testwiki=> select baseobject0_.XWO_CLASSNAME, stringprop1_.XWS_VALUE as col_0_0_ from xwikiobjects baseobject0_, xwikistrings stringprop1_ inner join xwikiproperties stringprop1_1_ on stringprop1_.XWS_ID=stringprop1_1_.XWP_ID and stringprop1_.XWS_NAME=stringprop1_1_.XWP_NAME where baseobject0_.XWO_NAME='XWiki.XWikiAllGroup' and baseobject0_.XWO_ID=stringprop1_.XWS_ID and (trim(both from stringprop1_.XWS_VALUE)<>'' or (trim(both from stringprop1_.XWS_VALUE) is not null) and ('' is null)); xwo_classname | col_0_0_ -------------------+----------------- XWiki.XWikiGroups | XWiki.Admin Main.WebHome | XWiki.JohnSmith Main.WebHome | XWiki.meme (3 rows) That is why the createAndDeleteUser test is failing http://hudson.xwiki.org/job/xwiki-product-enterprise-tests/com.xpn.xwiki.pr… Caleb vmassol (SVN) wrote: > Author: vmassol > Date: 2010-01-21 09:25:54 +0100 (Thu, 21 Jan 2010) > New Revision: 26271 > > Modified: > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/objects/BaseObject.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/objects/classes/BaseClass.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateStore.java > Log: > XWIKI-4753: Refactor old model to use the new Entity Reference classes > > * More deprecation removal + added @deprecated annotations for BaseClass/BaseObject's get/SetName() to find places where they shouldn't be used > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java 2010-01-21 08:20:26 UTC (rev 26270) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java 2010-01-21 08:25:54 UTC (rev 26271) > @@ -3796,10 +3796,10 @@ > XWikiDocument groupDoc = getDocument(groupName, context); > > BaseObject memberObject = (BaseObject) groupClass.newObject(context); > - memberObject.setClassName(groupClass.getName()); > - memberObject.setName(groupDoc.getFullName()); > + memberObject.setXClassReference(groupClass.getXClassReference()); > + memberObject.setDocumentReference(groupDoc.getDocumentReference()); > memberObject.setStringValue("member", userName); > - groupDoc.addObject(groupClass.getName(), memberObject); > + groupDoc.addXObject(groupClass.getDocumentReference(), memberObject); > if (groupDoc.isNew()) { > saveDocument(groupDoc, context.getMessageTool().get("core.comment.addedUserToGroup"), context); > } else { > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/objects/BaseObject.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/objects/BaseObject.java 2010-01-21 08:20:26 UTC (rev 26270) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/objects/BaseObject.java 2010-01-21 08:25:54 UTC (rev 26271) > @@ -42,6 +42,26 @@ > private String guid = UUID.randomUUID().toString(); > > /** > + * Note: This method is overridden to add the deprecation warning so that code using is can see it's deprecated. > + * @deprecated since 2.2M2 use {@link #getDocumentReference()} > + */ > + @Deprecated > + @Override public String getName() > + { > + return super.getName(); > + } > + > + /** > + * Note: This method is overridden to add the deprecation warning so that code using is can see it's deprecated. > + * @deprecated since 2.2M2 use {@link #setDocumentReference(org.xwiki.model.reference.DocumentReference)} > + */ > + @Deprecated > + @Override public void setName(String name) > + { > + super.setName(name); > + } > + > + /** > * {@inheritDoc} > * > * @see com.xpn.xwiki.objects.BaseCollection#hashCode() > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/objects/classes/BaseClass.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/objects/classes/BaseClass.java 2010-01-21 08:20:26 UTC (rev 26270) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/objects/classes/BaseClass.java 2010-01-21 08:25:54 UTC (rev 26271) > @@ -76,6 +76,26 @@ > private String nameField; > > /** > + * Note: This method is overridden to add the deprecation warning so that code using is can see it's deprecated. > + * @deprecated since 2.2M2 use {@link #getDocumentReference()} > + */ > + @Deprecated > + @Override public String getName() > + { > + return super.getName(); > + } > + > + /** > + * Note: This method is overridden to add the deprecation warning so that code using is can see it's deprecated. > + * @deprecated since 2.2M2 use {@link #setDocumentReference(org.xwiki.model.reference.DocumentReference)} > + */ > + @Deprecated > + @Override public void setName(String name) > + { > + super.setName(name); > + } > + > + /** > * {@inheritDoc} > * <p> > * This insures natural ordering between properties. > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateStore.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateStore.java 2010-01-21 08:20:26 UTC (rev 26270) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateStore.java 2010-01-21 08:25:54 UTC (rev 26271) > @@ -491,8 +491,8 @@ > } > > // Verify if the document already exists > - Query query = > - session.createQuery("select xwikidoc.id from XWikiDocument as xwikidoc where xwikidoc.id = :id"); > + Query query = session.createQuery( > + "select xwikidoc.id from XWikiDocument as xwikidoc where xwikidoc.id = :id"); > query.setLong("id", doc.getId()); > if (query.uniqueResult() == null) { > session.save(doc); > @@ -503,16 +503,16 @@ > } > > // Remove objects planned for removal > - if (doc.getObjectsToRemove().size() > 0) { > - for (BaseObject removedObject : doc.getObjectsToRemove()) { > + if (doc.getXObjectsToRemove().size() > 0) { > + for (BaseObject removedObject : doc.getXObjectsToRemove()) { > deleteXWikiObject(removedObject, context, false); > } > - doc.setObjectsToRemove(new ArrayList<BaseObject>()); > + doc.setXObjectsToRemove(new ArrayList<BaseObject>()); > } > > // We should only save the class if we are using the class table mode > if (bclass != null) { > - bclass.setName(doc.getFullName()); > + bclass.setDocumentReference(doc.getDocumentReference()); > if ((bclass.getFieldList().size() > 0) && (useClassesTable(true, context))) { > saveXWikiClass(bclass, context, false); > } > @@ -525,18 +525,14 @@ > // migrate values of list properties > if (prop instanceof StaticListClass || prop instanceof DBListClass) { > ListClass lc = (ListClass) prop; > - String[] classes = > - {DBStringListProperty.class.getName(), StringListProperty.class.getName(), > - StringProperty.class.getName()}; // @see > - // ListClass#newProperty() > + String[] classes = { DBStringListProperty.class.getName(), StringListProperty.class.getName(), > + StringProperty.class.getName()}; // @see ListClass#newProperty() > for (int i = 0; i < classes.length; i++) { > String oldclass = classes[i]; > if (!oldclass.equals(lc.newProperty().getClass().getName())) { > - Query q = > - session.createQuery( > - "select p from " + oldclass + " as p, BaseObject as o" + " where o.className=?" > - + " and p.id=o.id and p.name=?").setString(0, bclass.getName()).setString( > - 1, lc.getName()); > + Query q = session.createQuery("select p from " + oldclass + " as p, BaseObject as o" > + + " where o.className=? and p.id=o.id and p.name=?").setString(0, > + bclass.getName()).setString(1, lc.getName()); > for (Iterator it = q.list().iterator(); it.hasNext();) { > BaseProperty lp = (BaseProperty) it.next(); > BaseProperty lp1 = lc.newProperty(); > @@ -609,7 +605,7 @@ > for (List<BaseObject> objects : doc.getXObjects().values()) { > for (BaseObject obj : objects) { > if (obj != null) { > - obj.setName(doc.getFullName()); > + obj.setDocumentReference(doc.getDocumentReference()); > /* If the object doesn't have a GUID, create it before saving */ > if (StringUtils.isEmpty(obj.getGuid())) { > obj.setGuid(UUID.randomUUID().toString()); > > _______________________________________________ > notifications mailing list > notifications(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/notifications >

15 years, 8 months

1
0
0 0

[xwiki-devs] [VOTE] Upgrade to GWT 2.0 before 2.2M2 release

by Marius Dumitru Florea

Hi devs, I'd like to upgrade platform/web to GWT 2.0 before the 2.2M2 release. Even if the WYSIWYG users won't notice any difference (maybe a small decrease in loading time and a small increase in responsiveness dues to compiler optimizations) this upgrade will help ease the development. You can find the detailed release notes at http://code.google.com/webtoolkit/doc/latest/ReleaseNotes.html . I'm most interested in: * ability to run the unit tests on the build server (a 32-bit JVM isn't needed anymore, finally, since the tests are run by default with HtmlUnit) * ability to run and debug the Java code directly in the browser (new development mode using a FF plugin) * ability to split the code and load it on demand In order to upgrade I need http://google-web-toolkit-incubator.googlecode.com/files/gwt-incubator-2009… in our maven repo: mvn install:install-file -Dfile=gwt-incubator-20091216-r1739.jar -DgroupId=com.google.gwt -DartifactId=gwt-incubator -Dversion=20091216-r1739 -Dpackaging=jar Who can help me with that? All unit and integration tests pass locally so here's my +1. Thanks, Marius

15 years, 8 months

7
12
0 0

Re: [xwiki-devs] [xwiki-notifications] r26407 - in platform: core/trunk/xwiki-core/src/main/resources web/trunk/standard/src/main/webapp/templates

by Sergiu Dumitriu

On 01/26/2010 03:14 PM, jvelociter (SVN) wrote: > Author: jvelociter > Date: 2010-01-26 15:14:24 +0100 (Tue, 26 Jan 2010) > New Revision: 26407 > > Modified: > platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties > platform/web/trunk/standard/src/main/webapp/templates/imported.vm > Log: > XWIKI-4796 When importing XE XAR from an empty database, the import result is not properly displayed > Modified: platform/web/trunk/standard/src/main/webapp/templates/imported.vm > =================================================================== > +#else > + ## If the current user does not have admin and this template is being displayed > + ## it means security settings have been changed with the import (probably a defaut XE XAR import) > + ## We display a warning and invite the user to log in to further administrate the wiki What if the user was logged in, but now has fewer rights? Minor: you don't need the "" around the message, since it's a single string result which can be passed to the macro. > + #warning("$msg.get('core.importer.securitySettingsChanged', [$xwiki.getURL('XWiki.XWikiLogin', 'login')])") > +#end > \ No newline at end of file -- Sergiu Dumitriu http://purl.org/net/sergiu/

15 years, 8 months

1
0
0 0

[xwiki-devs] [VOTE] Captcha on or off by default

by Caleb James DeLisle

I have the captcha turned on and a setting in xwiki.properties will turn it off. Should this be reversed? A. On by default B. Off by default My +1 is for A because I like showing off my captchas to everyone. Caleb

15 years, 8 months

7
8
0 0

[xwiki-devs] Help! mvn install wysiwyg module error

by Leon Wang

Hi Dear XWiki Devs, When I try to compile the same Wysiwyg module from Eclipse or from Windows command line, I get different errors. One is org.apache.maven.plugins:maven-compiler-plugin:2.0.2:testCompile error, one is checkstyle error. Could you please give some clue what is wrong? >From Eclispe I will get this error: "[INFO] [compiler:testCompile] [INFO] Compiling 37 source files to C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\target\test-classes [INFO] [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] ------------------------------------------------------------------------ [INFO] XWiki Platform - Web - Parent POM ..................... SUCCESS [0.922s] [INFO] XWiki Platform - Web - GWT API ........................ SUCCESS [11.515s] [INFO] XWiki Platform - Web - GWT - DOM API .................. SUCCESS [3.766s] [INFO] XWiki Platform - Web - GWT - User ..................... SUCCESS [3.437s] [INFO] XWiki Platform - Web - WYSIWYG ........................ FAILED [13.563s] [INFO] XWiki Platform - Web - Standard ....................... NOT BUILT [INFO] ------------------------------------------------------------------------ [ERROR] Mojo: org.apache.maven.plugins:maven-compiler-plugin:2.0.2:testCompile FAILED for project: com.xpn.xwiki.platform:xwiki-web-wysiwyg:war:2.1.1 Reason: C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\RichTextAreaTestCase.java:[22,39] cannot find symbol symbol : class AbstractRichTextAreaTestCase location: package org.xwiki.gwt.user.client.ui.rta C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\RichTextAreaTestCase.java:[29,42] cannot find symbol symbol: class AbstractRichTextAreaTestCase public class RichTextAreaTestCase extends AbstractRichTextAreaTestCase C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\syntax\internal\DefaultValidationRuleTest.java:[24,52] cannot find symbol symbol : class MockCommandManager location: package org.xwiki.gwt.user.client.ui.rta.cmd.internal C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[47,13] cannot find symbol symbol : method gwtSetUp() location: class com.xpn.xwiki.wysiwyg.client.RichTextAreaTestCase C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[64,16] cannot find symbol symbol: variable rta rta.setHTML("<ul><li>one</li><li>two</li></ul>"); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[66,30] cannot find symbol symbol: variable rta Range range = rta.getDocument().createRange(); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[67,31] cannot find symbol symbol: method getBody() range.setStart(getBody().getFirstChild().getChildNodes().getItem(1).getFirstChild(), 0); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[69,16] cannot find symbol symbol: method select(org.xwiki.gwt.dom.client.Range) select(range); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[141,16] cannot find symbol symbol: variable rta rta.setHTML(rtaInnerHTML); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[143,30] cannot find symbol symbol: variable rta Range range = rta.getDocument().createRange(); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[144,31] cannot find symbol symbol: method getBody() range.setStart(getBody().getChildNodes().getItem(0).getChildNodes().getItem(0), 0); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[145,29] cannot find symbol symbol: method getBody() range.setEnd(getBody().getChildNodes().getItem(0).getChildNodes().getItem(0), 4); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[146,16] cannot find symbol symbol: method select(org.xwiki.gwt.dom.client.Range) select(range); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[149,49] cannot find symbol symbol: variable rta assertFalse(executable.isEnabled(rta)); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[151,47] cannot find symbol symbol: variable rta assertFalse(executable.execute(rta, null)); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[223,73] cannot find symbol symbol: variable rta assertEquals(rtaInnerHTML, removeNonBreakingSpaces(clean(rta.getHTML()))); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[205,8] cannot find symbol symbol : method deferTest(<anonymous com.google.gwt.user.client.Command>) location: class com.xpn.xwiki.wysiwyg.client.plugin.indent.exec.IndentExecutableTest C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[265,30] cannot find symbol symbol: variable rta Range range = rta.getDocument().createRange(); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[266,31] cannot find symbol symbol: method getBody() range.setStart(getBody().getFirstChild().getChildNodes().getItem(1).getFirstChild(), 0); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[267,29] cannot find symbol symbol: method getBody() range.setEnd(getBody().getFirstChild().getChildNodes().getItem(1).getChildNodes().getItem(1) C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[270,16] cannot find symbol symbol: method select(org.xwiki.gwt.dom.client.Range) select(range); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[272,48] cannot find symbol symbol: variable rta assertTrue(executable.isEnabled(rta)); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[273,46] cannot find symbol symbol: variable rta assertTrue(executable.execute(rta, null)); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[275,50] cannot find symbol symbol: variable rta removeNonBreakingSpaces(clean(rta.getHTML()))); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[259,8] cannot find symbol symbol : method deferTest(<anonymous com.google.gwt.user.client.Command>) location: class com.xpn.xwiki.wysiwyg.client.plugin.indent.exec.IndentExecutableTest C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[291,16] cannot find symbol symbol: variable rta rta.setHTML("<ul><li>one<ul><li>one plus one</li></ul></li><li>two</li></ul>"); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[293,30] cannot find symbol symbol: variable rta Range range = rta.getDocument().createRange(); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[294,31] cannot find symbol symbol: method getBody() range.setStart(getBody().getFirstChild().getChildNodes().getItem(1).getFirstChild(), 0); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[296,16] cannot find symbol symbol: method select(org.xwiki.gwt.dom.client.Range) select(range); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[298,48] cannot find symbol symbol: variable rta assertTrue(executable.isEnabled(rta)); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[299,46] cannot find symbol symbol: variable rta assertTrue(executable.execute(rta, null)); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[301,50] cannot find symbol symbol: variable rta removeNonBreakingSpaces(clean(rta.getHTML()))); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[287,8] cannot find symbol symbol : method deferTest(<anonymous com.google.gwt.user.client.Command>) location: class com.xpn.xwiki.wysiwyg.client.plugin.indent.exec.IndentExecutableTest C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[316,16] cannot find symbol symbol: variable rta rta.setHTML("<ol><li>one</li><li>two</li><li>three</li><li>four</li></ol>"); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[318,30] cannot find symbol symbol: variable rta Range range = rta.getDocument().createRange(); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[352,46] cannot find symbol symbol: variable rta assertTrue(executable.execute(rta, null)); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[355,79] cannot find symbol symbol: variable rta + "</li><li>four</li></ol>", removeNonBreakingSpaces(clean(rta.getHTML()))); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[339,8] cannot find symbol symbol : method deferTest(<anonymous com.google.gwt.user.client.Command>) location: class com.xpn.xwiki.wysiwyg.client.plugin.indent.exec.IndentExecutableTest C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[372,16] cannot find symbol symbol: variable rta rta.setHTML("<ol><li>one<ul><li>under</li></ul></li><li>two</li><li>three</li>" + "<li>four</li></ol>"); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[374,30] cannot find symbol symbol: variable rta Range range = rta.getDocument().createRange(); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[376,31] cannot find symbol symbol: method getBody() range.setStart(getBody().getFirstChild().getFirstChild().getChildNodes().getItem(1).getFirstChild() C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[378,29] cannot find symbol symbol: method getBody() range.setEnd(getBody().getFirstChild().getChildNodes().getItem(1).getFirstChild(), 3); " _____________________________________________________________________________________________________________________ While I use mvn install to compile for the same code from Windows command line I get this error: _____________________________________________________________________________________________________________________ ig.java:30:8: Unused import - org.xwiki.gwt.dom.client.JavaScriptObject. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\LinkConf ig.java:32:8: Unused import - com.google.gwt.core.client.JsArrayString. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\LinkConf ig.java:132:5: Static variable definition in wrong order. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\LinkConf ig.java:137: warning: Comment matches to-do format 'FIXME'. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\LinkConf ig.java:138: warning: Comment matches to-do format 'TODO'. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\LinkConf ig.java:142:5: Missing a Javadoc comment. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\LinkConf ig.java:144:7: Line contains a tab character. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\LinkConf ig.java:145:5: Line contains a tab character. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:22: Missing a Javadoc comment. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:22:76: '{' is not preceded with whitespace. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:22:76: '{' should be on a new line. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:23:1: Line contains a tab character. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:24:1: Line contains a tab character. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:48:96: The String "Alternative" appears 2 times in the file. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:49:93: The String "Argument" appears 2 times in the file. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:50:98: The String "Assumption" appears 2 times in the file. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:51:92: The String "Claim" appears 2 times in the file. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:52:93: The String "Decision" appears 2 times in the file. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:53:96: The String "Requirement" appears 2 times in the file. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:64: warning: Comment matches to-do format 'TODO'. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:107:15: 'if' is not followed by whitespace. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:107:33: '==' is not preceded with whitespace. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:107:33: Literal Strings should be compared using equals(), not '==' . C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:107:35: '==' is not followed by whitespace. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:109:13: Line contains a tab character. Audit done. [INFO] There are 71 checkstyle errors. [WARNING] Unable to locate Source XRef to link to - DISABLED [INFO] [checkstyle:check {execution: default}] [INFO] ------------------------------------------------------------------------ [ERROR] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] You have 71 Checkstyle violations. [INFO] ------------------------------------------------------------------------ [INFO] For more information, run Maven with the -e switch [INFO] ------------------------------------------------------------------------ [INFO] Total time: 3 minutes 59 seconds [INFO] Finished at: Mon Jan 25 16:14:16 EST 2010 [INFO] Final Memory: 55M/63M [INFO] ------------------------------------------------------------------------ C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web> Thank you for your help! Leon -- http://freeleons.spaces.live.com/ Life might lead me where I least expected.However,I have faith I'm exactly where I am meant to be.

15 years, 8 months

2
1
0 0

[xwiki-devs] LiveValidation is outsmarting the selenium tests. Also selenium can't solve captcha.

by Caleb James DeLisle

Two problems: 1. The selenium tests try to submit bad information but are stopped by LiveValidation causing a test failure. Responsible for: http://hudson.xwiki.org/job/xwiki-product-enterprise-tests/com.xpn.xwiki.pr… http://hudson.xwiki.org/job/xwiki-product-enterprise-tests/com.xpn.xwiki.pr… http://hudson.xwiki.org/job/xwiki-product-enterprise-tests/com.xpn.xwiki.pr… Perhaps we can set up the test to bypass javascript, maybe it's a good idea to test LiveValidation too? 2. Also selenium seems unable to solve the captcha. It wasn't a problem because empty captchas were accepted as long as there was no 'mandatory' constraint on the captcha field, fixed that. Expecting this to start being a problem again: http://hudson.xwiki.org/job/xwiki-product-enterprise-tests/com.xpn.xwiki.pr… Log in as Admin, set captcha to false, log out and then register? Turn off captcha by default? I'd like to hear your thoughts, Caleb

15 years, 8 months

2
1
0 0

Re: [xwiki-devs] [xwiki-notifications] r26388 - platform/xwiki-applications/trunk/administration/src/main/resources/XWiki

by Sergiu Dumitriu

On 01/26/2010 02:14 AM, cjdelisle (SVN) wrote: > Author: cjdelisle > Date: 2010-01-26 02:14:45 +0100 (Tue, 26 Jan 2010) > New Revision: 26388 > > Modified: > platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/Registration.xml > Log: > XAADMINISTRATION-77: Improve registration interface: Fixed embarassing bug which made empty captchas be accepted if there was no 'mandatory' constraint on captcha. > > Modified: platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/Registration.xml > =================================================================== > --- platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/Registration.xml 2010-01-26 00:25:32 UTC (rev 26387) > +++ platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/Registration.xml 2010-01-26 01:14:45 UTC (rev 26388) You reintroduced the old title: > -<title>Registration</title> > +<title>Verified Registration Application</title> > <template></template> > <defaultTemplate></defaultTemplate> > <validationScript></validationScript> > @@ -377,7 +377,7 @@ > #set($cv = $captchaservice.getCaptchaVerifier('image')) > #if(!$cv.isAnswerCorrect($cv.getUserId($request), $answer)) > failed > - #end > + #end > #end > ## > ## Pass the name of the template to $xwiki.createUser so any contained information will be passed in. > @@ -398,7 +398,7 @@ > #else > #set($docName = $doc.getName()) > #end > - #if($xcontext.hasAccessLevel("edit", $docName)) > + #if($xcontext.hasAccessLevel("edit", $doc.getFullName())) > #set($field = > {'name' : 'configure', > 'prompt' : "<a href='$xwiki.getURL($docName, 'edit')?editor=wiki'>You can configure this application by clicking here.</a>", > @@ -451,54 +451,53 @@ > #set($fieldName = $field.get('name')) > #set($validate = $field.get('validate')) > #set($error = '') > - #if($request.get($fieldName)&& $request.get($fieldName) != '') > - #set($value = $request.get($fieldName)) > - ## > - ## Regex validation > - #if($validate.get('regex')) > - #set($regex = $validate.get('regex')) > - #if($regex.get('pattern')&& $regex.get('failureMessage')) > - #if(!$xcontext.getUtil().match($regex.get('pattern'), $value)) > - #set($error = $regex.get('failureMessage')) > - #end > - #elseif($regex.get('pattern')) > - ERROR: In field: ${fieldName}: regex validation must include failureMessage. > - #end > + #set($value = $request.get($fieldName)) > + ## > + ## Check if content is mandatory (!$value || $value == '') can be rewritten as ("$!{value}" == '') > + #if($validate.get('mandatory')&& (!$value || $value == '')) > + #set($mandatory = $validate.get('mandatory')) > + #if($mandatory.get('failureMessage')) > + #set($error = $mandatory.get('failureMessage')) > + #else > + ERROR: In field: ${fieldName}: mandatory validation requires a failureMessage > #end > - ## > - ## If regex validation passed, check "mustMatch" validation > - #if($error == ''&& $validate.get('mustMatch')) > - #set($mustMatch = $validate.get('mustMatch')) > - #if($mustMatch.get('name')&& $mustMatch.get('failureMessage')) > - #if($request.get($fieldName) != $request.get($mustMatch.get('name'))) > - #set($error = $mustMatch.get('failureMessage')) > - #end > - #else > - ERROR: In field: ${fieldName}: mustMatch validation required both name > - (of field which this field must match) and failureMessage. > + #end > + ## > + ## mustMatch validation > + #if($error == ''&& $validate.get('mustMatch')) > + #set($mustMatch = $validate.get('mustMatch')) > + #if($mustMatch.get('name')&& $mustMatch.get('failureMessage')) > + #if($request.get($fieldName) != $request.get($mustMatch.get('name'))) > + #set($error = $mustMatch.get('failureMessage')) > #end > + #else > + ERROR: In field: ${fieldName}: mustMatch validation required both name > + (of field which this field must match) and failureMessage. > #end > - ## > - ## If regex and mustMatch validation passed, try programmatic validation > - #if($error == ''&& $validate.get('programmaticValidation')) > - #set($pv = $validate.get('programmaticValidation')) > - #if($pv.get('code')&& $pv.get('failureMessage')) > - #set($pvReturn = "#evaluate($pv.get('code'))") > - #if($pvReturn.indexOf('failed') != -1) > - #set($error = $pv.get('failureMessage')) > - #end > - #else > - ERROR: In field: ${fieldName}: programmaticValidation requires code and failureMessage > + #end > + ## > + ## Regex validation > + #if($error == ''&& $validate.get('regex')) > + #set($regex = $validate.get('regex')) > + #if($regex.get('pattern')&& $regex.get('failureMessage')) > + #if(!$xcontext.getUtil().match($regex.get('pattern'), $value)) > + #set($error = $regex.get('failureMessage')) > #end > + #elseif($regex.get('pattern')) > + ERROR: In field: ${fieldName}: regex validation must include failureMessage. > #end > + #end > ## > - ## If no content, check if content is mandatory > - #elseif($validate.get('mandatory')) > - #set($mandatory = $validate.get('mandatory')) > - #if($mandatory.get('failureMessage')) > - #set($error = $mandatory.get('failureMessage')) > + ## If regex and mustMatch validation passed, try programmatic validation > + #if($error == ''&& $validate.get('programmaticValidation')) > + #set($pv = $validate.get('programmaticValidation')) > + #if($pv.get('code')&& $pv.get('failureMessage')) > + #set($pvReturn = "#evaluate($pv.get('code'))") > + #if($pvReturn.indexOf('failed') != -1) > + #set($error = $pv.get('failureMessage')) > + #end > #else > - ERROR: In field: ${fieldName}: mandatory validation requires a failureMessage > + ERROR: In field: ${fieldName}: programmaticValidation requires code and failureMessage > #end > #end > #if($error != '') > -- Sergiu Dumitriu http://purl.org/net/sergiu/

15 years, 8 months

1
0
0 0

Re: [xwiki-devs] [xwiki-notifications] r26377 - in platform/core/trunk/xwiki-core/src: main/java/com/xpn/xwiki/store test/java/com/xpn/xwiki/store test/java/com/xpn/xwiki/test

by Sergiu Dumitriu

On 01/25/2010 09:08 PM, vmassol (SVN) wrote: > Author: vmassol > Date: 2010-01-25 21:08:08 +0100 (Mon, 25 Jan 2010) > New Revision: 26377 > > Added: > platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/test/AbstractBridgedComponentTestCase.java > Modified: > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateBaseStore.java > platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/store/XWikiHibernateStoreTest.java > Log: > XWIKI-2758: PostgreSQL exceptions unusable Forgot to give credit. > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateBaseStore.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateBaseStore.java 2010-01-25 18:38:18 UTC (rev 26376) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateBaseStore.java 2010-01-25 20:08:08 UTC (rev 26377) You should cleanup this commented code: > +/* > + if (t.getCause() instanceof BatchUpdateException > +&& ((BatchUpdateException) t.getCause()).getNextException() != null) { > + final BatchUpdateException bue = (BatchUpdateException) t.getCause(); > + return bue.getNextException().getMessage(); > + } > + > + return t.getMessage(); > + */ > + return sb.toString(); > + } Are you sure this was supposed to be part of this commit? > Added: platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/test/AbstractBridgedComponentTestCase.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/test/AbstractBridgedComponentTestCase.java (rev 0) > +++ platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/test/AbstractBridgedComponentTestCase.java 2010-01-25 20:08:08 UTC (rev 26377) -- Sergiu Dumitriu http://purl.org/net/sergiu/

15 years, 8 months

2
1
0 0

[xwiki-devs] [new model][VOTE] Should we support entities that don't have a unique name?

by Anca Luca

Hi devs, Short story: In the new model, does it make sense to support entities that don't have an unique name to be identified in their 'context'? (so-called 'free name', as in free thought). WDYT? Long story: For example, in the current model, an object is an example of entity that does _not_ have a free name: in a document (its context), an object is identified by two values: the name of the class of the object and the 'object number'. An object cannot be differentiated by a single name among all the objects of a document. As opposed to this, a document does have a free name to identify it in the list of documents in a space, namely the page name. The same, an attachment's name is unique among the attachments of a page, etc. Note that the discussion is about a human-readable and accessible name for an entity, for example, using a GUID or other 'identifier' is not an option, since they are not manipulable by humans (for example to create a reference to such an entity). Also note that, even if supporting it is the best solution (which covers all cases anyway), we want to make sure it's necessary, since it would involve some refactoring. Thanks, Anca P.S. I haven't made my mind yet.

15 years, 8 months

4
9
0 0

[xwiki-devs] [VOTE] Release XE 2.2M2 Wednesday 27

by Vincent Massol

Hi, We were supposed to release XE 2.2M2 this Monday but Sergiu would like to include the Color Theme improvement and we can also use these additional 1.5 days to test more. If we agree please all make sure that you don't introduce anything that can potentially break the stability and ensure that all is ready for Wednesday end of morning so that we can start the release beginning of afternoon. Here's my +1 Thanks -Vincent

15 years, 8 months

3
2
0 0

[xwiki-devs] [ANN] XOffice 1.1 M1 Released!

by Florin Ciubotaru

The XWiki development team is pleased to announce the release of XWiki Office 1.1 Milestone 1. Go grab it at: http://www.xwiki.org/xwiki/bin/view/Main/Download#HXWikiOffice Summary of changes: - support for on page style extensions - more powerful text formatting - fixed encoding issues Updating: - active instances of 1.1 snapshots are automatically updated - the 1.1 new features updates will be pushed when version 1.1 final will be available - the 1.0 bugfixes will be pushed during the 1.1 development cycle. View detailed release notes at: http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXOffice11M1 For more information about XOffice visit: http://xoffice.xwiki.org/xwiki/bin/view/Main/WebHome Thanks, -The XWiki dev team

15 years, 8 months

1
0
0 0

[xwiki-devs] hibernate.cfg.xml

by Vivian Richard

Hello Devs, I am getting this strange xml formet error in the hibernate.cfg.xml file. I am attaching my xml and as you can see all I did was uncommented the mysql part of the file. I tried validate the xml format at this site: http://validator.w3.org/#validate_by_input and got these error messages- Line 51, Column 36: document type does not allow element "property" here Line 52, Column 36: document type does not allow element "property" here Line 53, Column 36: document type does not allow element "property" here Line 54, Column 36: document type does not allow element "property" here Line 55, Column 36: document type does not allow element "property" here Line 56, Column 36: document type does not allow element "property" here Line 57, Column 36: document type does not allow element "property" here Line 58, Column 36: document type does not allow element "property" here Can some one please point out what is wrong with it? By the way this xml file came with xwiki-enterprise-manager-web-2.1.1.war file Regards ///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////// <?xml version='1.0' encoding='utf-8'?> <!DOCTYPE hibernate-configuration PUBLIC "-//Hibernate/Hibernate Configuration DTD//EN" "http://hibernate.sourceforge.net/hibernate-configuration-3.0.dtd"> <hibernate-configuration> <session-factory>   <property name="show_sql">false</property> <property name="use_outer_join">true</property> <property name="dbcp.defaultAutoCommit">false</property> <property name="dbcp.maxActive">50</property> <property name="dbcp.maxIdle">5</property> <property name="dbcp.maxWait">30000</property> <property name="dbcp.whenExhaustedAction">1</property> <property name="dbcp.ps.whenExhaustedAction">1</property> <property name="dbcp.ps.maxActive">20</property> <property name="dbcp.ps.maxWait">120000</property> <property name="dbcp.ps.maxIdle">20</property>  <property name="jdbc.use_scrollable_resultset">false</property>  <property name="connection.url">jdbc:hsqldb:file:database/xwiki_db;shutdown=true</property> <property name="connection.username">sa</property> <property name="connection.password"></property> <property name="connection.driver_class">org.hsqldb.jdbcDriver</property> <property name="dialect">org.hibernate.dialect.HSQLDialect</property> <property name="connection.provider_class">com.xpn.xwiki.store.DBCPConnectionProvider</property> <property name="connection.pool_size">2</property> <property name="statement_cache.size">2</property> <mapping resource="xwiki.hbm.xml"/> <mapping resource="feeds.hbm.xml"/> <mapping resource="activitystream.hbm.xml"/>  <property name="connection.url">jdbc:mysql://localhost/xwiki?useServerPrepStmts=false&useUnicode=true&characterEncoding=UTF-8&sessionVariables=sql_mode=''</property> <property name="connection.username">xwiki</property> <property name="connection.password">xwiki</property> <property name="connection.driver_class">com.mysql.jdbc.Driver</property> <property name="dialect">org.hibernate.dialect.MySQLDialect</property> <property name="connection.provider_class">com.xpn.xwiki.store.DBCPConnectionProvider</property> <property name="connection.pool_size">2</property> <property name="statement_cache.size">2</property> <mapping resource="xwiki.hbm.xml"/> <mapping resource="feeds.hbm.xml"/> <mapping resource="activitystream.hbm.xml"/>     </session-factory> </hibernate-configuration> ///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

15 years, 8 months

3
2
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

xwiki-devs