- xwiki-devs@xwiki.org - lists.xwiki.org

by Markus Lanthaler

Hi, after evaluating possible frameworks I would propose to use OpenSSO [1] for my GSOC SSO project. It has full SAML 2.0 support, but lacks a bit regarding OpenID which isn't supported by default. There is an extension which allows OpenSSO to act as a OpenID 1.1 OP, but doesn't have RP support. OpenSSO has a very active and large community (which maybe is the strongest argument to use it). There are several requests for better OpenID support so I think that's a hot topic for them and maybe it's possible to find some other developers with whom I can add full OpenID 2.0 support. So now I'll start implementing RP support (authentication). As far as I understand the code I have to implement a XWikiAuthService analogous to the XWikiLDAPAuthServiceImpl, right? I also have some more questions :-) Let's start with OpenID (I'll start with that): 1.) I need to modify the login screen because I just need a field where the user can enter his OpenID URL, no password field. Then the user is redirect to his OpenID provider. How should/can I implement that? 2.) OpenIDs have to be bound to local user accounts (1:n relations, allow more OpenIDs per account) - how should this happen? In the admin GUI? Who should be allowed to do it? 3.) What about user registration? Should it be possible for users to create accounts without password and just OpenID? Please consider that XWiki should also be able to act as a provider, i.e. act as an OpenID server. Cheers, Markus -- [1] http://opensso.dev.java.net

17 years, 3 months

5
7
0 0

[xwiki-devs] [VOTE] Overhaul of the administration, layout

by Jean-Vincent Drean

Hi XWikiers, Evelina has finished the ground work on the new administration and it's now time to vote for its layout. http://dev.xwiki.org/xwiki/bin/view/Design/ImproveWikiAdministration Proposals : Admin in view mode, with a left menu : http://dev.xwiki.org/xwiki/bin/view/Design/ImproveWikiAdministrationLayout1 Admin in view mode, without a left menu : http://dev.xwiki.org/xwiki/bin/view/Design/ImproveWikiAdministrationLayout2 Admin in edit mode, with a navigation panel : http://dev.xwiki.org/xwiki/bin/view/Design/ImproveWikiAdministrationLayout3 Admin in edit mode, without a navigation panel : http://dev.xwiki.org/xwiki/bin/view/Design/ImproveWikiAdministrationLayout4 Other question, how do we display the space selector : http://dev.xwiki.org/xwiki/bin/view/Design/ImproveWikiAdministrationSpaceSe… -- Jean-Vincent Drean

17 years, 3 months

7
13
0 0

[xwiki-devs] [GSOC] Today is GSOC project starting day

by Vincent Massol

Hi GSOCers, The bonding period is over and today starts your GSOC project period. Note that this doesn't mean you should drop whatever JIRA issue you had assigned to yourself. Please continue to work on it and *finish* it. It's important. However it means that from today onwards you can start working on your project. The most important thing to do is send an email on the xwiki dev list explaining: * what architecture you're envisioning to use for your project. If you have doubts/questions please mention them. * A general planning breaking down the high level tasks you have to do and giving deadlines for each. That'll help you reach your objectives and in that manner we (the mentors and the community in general) can also help you by reviewing milestone objectives and helping you achieve them * what are your next steps and when you're planning to have them done * Any questions you have Please use the mailing list over IRC and especially over direct skype/ chat. Again it's really important that you work with the community. The success of your SOC depends on that as much as finishing your project. Thanks, good luck and have fun! -Vincent on behalf of the XWiki mentors

17 years, 3 months

4
9
0 0

Re: [xwiki-devs] [GSOC] Can't commit to sandbox

by Fabio Mancinelli

On 17 juin 08, at 14:15, malaka ekanayake wrote: > Hi fabio > > I tried with both ways but getting the same error.Anyway I'll try > it again.In my previous mail I have attached my sample plugin.Can > you look at that one till I fix this issur and commit to the > sandbox.svn root will be fine.I'll commit to that path. Hi Malaka, I've looked at your code and you did a good job! It works pretty well though there are some things that must be improved (like the ones you were mentioning) Before I commit the code, could you please, do a bit of reformatting? Here at http://svn.xwiki.org/svnroot/xwiki/xwiki-platform/xwiki-tools/trunk/xwiki-v… you can find the .xml for the Eclipse formatter. This style is the style used by XWiki. I saw that that in your code there are some classes that probably are useless (is the TagRule used?) Could you please remove all the unused code inorder to avoid confusion? I also noticed that you incorporated verbatim some code from the tutorial (the tutorial's author name is in your code) Be careful when incorporating third party code. You must always check for licenses and compatibility and authorization!!! Ideally you should write all the code by yourself, even if when you use a framework you end up with writing more or less the same code. Could you check that the tutorial's code can be reused without restrictions? Please, keep the conversations on the XWiki devs list so that everybody can follow it. Send me a zip with the modifications and I'll commit it to the sandbox. After that, it's important to address Vincent's parser integration and spend some time on trying to figure out if and how it can be integrated in your work. I guess that Vincent's parser should be used as the partitioner, with it's output definining document's partition. But this has to be well investigated because it might be not so simple. Let me know. Cheers, Fabio

17 years, 3 months

1
0
0 0

[xwiki-devs] [GSOC]Sample plugine

by malaka ekanayake

Hi fabio During the weekend I have written a sample plugine for xwiki highlighting some of xwiki syntax .Hear are the list of syntaxes which supports it. Titles ,Bulleted Lists,Text Styles,Info Macro<http://code.xwiki.org/xwiki/bin/view/Macros/InfoMacro> There are some improvements needed to be done . I am having some trouble with identifying composite syntax like bold & Italic. I think I will need your help on that. At the same time is there any reference to learn the jface API because at the moment only I have is the article you gave to me. I think I need to understand it more deeply .So any reference related to JFace Text API will be nice since :D. I will commit my work to the sandbox today. I didn't have time to look in to the Vincent's parser yet. I 'll start it by today.Meantime is there any news from Venkatesh cheers --Malaka Ekanayake CSE UOM

17 years, 3 months

2
1
0 0

Re: [xwiki-devs] [xwiki-notifications] r10325 - xwiki-platform/web/trunk/standard/src/main/webapp/WEB-INF

by Vincent Massol

On Jun 14, 2008, at 3:10 AM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2008-06-14 03:10:55 +0200 (Sat, 14 Jun 2008) > New Revision: 10325 > > Modified: > xwiki-platform/web/trunk/standard/src/main/webapp/WEB-INF/web.xml > Log: > XWIKI-2117: encoding problems with AJAX adminstration utility > Fixed by not ignoring the specified character encoding sent by the > client. > > > Modified: xwiki-platform/web/trunk/standard/src/main/webapp/WEB-INF/ > web.xml > =================================================================== > --- xwiki-platform/web/trunk/standard/src/main/webapp/WEB-INF/ > web.xml 2008-06-14 00:31:23 UTC (rev 10324) > +++ xwiki-platform/web/trunk/standard/src/main/webapp/WEB-INF/ > web.xml 2008-06-14 01:10:55 UTC (rev 10325) > @@ -16,6 +16,10 @@ > <param-name>encoding</param-name> > <param-value>ISO-8859-1</param-value> > </init-param> > + <init-param> > + <param-name>ignore</param-name> > + <param-value>false</param-value> > + </init-param> Some comments on this init-param would be good I think, especially since the "ignore" name is pretty cryptic. Thanks -Vincent

17 years, 3 months

1
0
0 0

[xwiki-devs] Mail Auth - done; 3 questions

by Lilianne E. Blaze

Hello, I just completed the modifications I mentioned in "Mail Problems" earlier. Seems to work just fine. XWiki.sendMessage redirecting to MailSenderPlugin, mail authorization ( = works with any smtp server, local or not), and means to provide additional Java Mail properties in Admin Prefs. I just need to test it a bit more and make patches and demo package. Should be ready in about 12-18 hours tops. Three things though: 1) I still have no idea what about the subject - it just defaults to "XWiki Message" in this version. 2) It needed mailsender plugin moved from plugins module to core module to avoid circulars and other nasties. 3) It still needs some sensible defaults and/or documenation for validation / confirmation content. Greetings, Lilianne E. Blaze

17 years, 3 months

4
21
0 0

[xwiki-devs] ShortURLs?

by Lilianne E. Blaze

Hello, Is http://platform.xwiki.org/xwiki/bin/view/Main/ShortURLs final or a work in progress? Greetings, Lilianne E. Blaze

17 years, 3 months

4
8
0 0

Re: [xwiki-devs] [xwiki-notifications] r10268 - xwiki-products/xwiki-enterprise/trunk/distribution-test/selenium-tests/src/test/it/com/xpn/xwiki/it/selenium

by Vincent Massol

On Jun 12, 2008, at 1:50 AM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2008-06-12 01:50:00 +0200 (Thu, 12 Jun 2008) > New Revision: 10268 > > Modified: > xwiki-products/xwiki-enterprise/trunk/distribution-test/selenium- > tests/src/test/it/com/xpn/xwiki/it/selenium/WikiEditorTest.java > Log: > XWIKI-1007: Removing all content in page has no effect & the content > of a wiki page is not allowed to be completely empty > Added integration test > > > Modified: xwiki-products/xwiki-enterprise/trunk/distribution-test/ > selenium-tests/src/test/it/com/xpn/xwiki/it/selenium/ > WikiEditorTest.java > =================================================================== > --- xwiki-products/xwiki-enterprise/trunk/distribution-test/selenium- > tests/src/test/it/com/xpn/xwiki/it/selenium/WikiEditorTest.java > 2008-06-11 23:49:28 UTC (rev 10267) > +++ xwiki-products/xwiki-enterprise/trunk/distribution-test/selenium- > tests/src/test/it/com/xpn/xwiki/it/selenium/WikiEditorTest.java > 2008-06-11 23:50:00 UTC (rev 10268) > @@ -158,4 +158,20 @@ > getFieldValue("content")); > // TODO: We need to find out how to make a text selection in > Selenium > } > + > + public void testEmptyContent() I'd suggest: testEmptyDocumentContentIsAllowed > > + { > + open("/xwiki/bin/edit/Test/EmptyWikiContent?editor=wiki"); > + setFieldValue("content", "this is some content"); > + clickEditSaveAndView(); > + assertFalse(getSelenium().isAlertPresent()); Why do we test for not having a dialog box present? There's content so why should that happen? If it's required the test should have some comments to explain it. > > + assertEquals(-1, getSelenium().getLocation().indexOf("/ > edit/")); I don't understand this either since we have clicked on save, we're no longer in edit and the url has view. Why verify this in this test which is about verifying that empty content is allowed. > > + assertTextPresent("this is some content"); Again why test this. The ability to enter content is already tested in other tests AFAIK. > > + open("/xwiki/bin/edit/Test/EmptyWikiContent?editor=wiki"); > + setFieldValue("content", ""); > + clickEditSaveAndView(); > + assertFalse(getSelenium().isAlertPresent()); > + assertEquals(-1, getSelenium().getLocation().indexOf("/ > edit/")); > + assertTextNotPresent("this is some content"); Is there a need to do the 3 tests which seem to be about the same verification? Thanks -Vincent

17 years, 3 months

2
1
0 0

[xwiki-devs] retrieving XWIKI-generated page via javascript without headers

by rssh

Good day, community Yet one question: I want to retrieve xwiki page without header and footes via javascript, to save in dom-node. Now I search a principal way how to do this. I see two possible ways: A -- write special 'zero' skin // unfortunelly, I see that documentation on skins is outdated: in installation of svn version I see that velocity templates are situated outside skin. B -- try to use xwiki XML/RPC interface. (or may be add JSON-ORB as servlet) So, questions: - what approach (from this two) is prefferrable ? - where is documentation on xwiki XML/RPC interface ? Or some example of usage ? Are anybody tried to use XML/RPC interface from javascript. ? - may be still possible to reload (returning to first approach) view.vm template in skin. If yes - how ? P.S. (More detailed explanation what I want on code level: i. e. I want to write in xwiki page something like: <script> function update() { new Ajax.Reaqest('/xwiki.home/bin/view/My.Page', 'post' parameters { A: $('form.A').value, B: $('form.B').value, skin: 'zero' } onSuccess: function(transport) { $('result').innerHTML=transport.response; } ); } </script> <form> <input name='A' id='form.A' > <input name='B' id='form.B' > <button name='DO' onClick="update();" > </form> <div id="result">   </div> -- Ruslan Shevchenko GradSoft. http://www.gradsoft.ua

17 years, 3 months

2
3
0 0

[xwiki-devs] Why /templates not in /WEB-INF?

by Lilianne E. Blaze

Hello, Is there any particular reason why /templates are not in /WEB-INF? I don't like the idea of having part of the source code accessible by everyone. Greetings, Lilianne E. Blaze

17 years, 3 months

5
15
0 0

[xwiki-devs] Automatically migrating/adding wiki documents upon upgrade

by Jerome Velociter

Hello devs, I'm currently trying to find the best approach to automatically upgrade an XWS instance workspaces when upgrading the XWS version. By that, I mean adding new pages to existing workspaces for example. I see at least two possible approaches : * On display of the workspace, we check that the considered pages are present, and if not either we automatically create them, either we offer a big button to "upgrade" the workspace. (the test could be done in a skin template, so that any page would trigger the upgrade) * On plugin init, we search for all workspaces and upgrade the ones in need. And we could have a marker once the upgrade is done, not to execute the query at each init. WDYT ? Are there other approaches I'm missing ? Regards, Jerome.

17 years, 3 months

3
5
0 0

[xwiki-devs] New WYSIWYG editor with or without dialogs?

by Marius Dumitru Florea

Hi devs, While working on the new GWT-based WYSIWYG editor, I find out that the default DialogBox from GWT moves very slow when dragged if it contains many HTML elements (like a table with 10 rows and 20 columns). In the current WYSIWYG editor dialog boxes are used for color picker, custom character, insert image / attachment / macro / table. Before I start porting these dialogs to GWT I'd like to ask you: Do you agree with using dialog boxes for these features? * if so, do you think it's ok to optimize the way they are moved by showing only their border while dragging (win95-like)? * if not, how can we replace them? Thanks, Marius

17 years, 3 months

5
16
0 0

[xwiki-devs] [Rendering] XHTML parser

by Vincent Massol

Just to let you know (and especially Marius) that I've discovered that wikimodel has a XHTML parser already which seems to be doing quite a lot of things. I'll be trying it next week and integrate it into the new rendering module so that the new WYSIWYG module can use it. Thanks -Vincent

17 years, 3 months

1
0
0 0

[xwiki-devs] It's voting time again: Help XWiki ! Vote for it's creator at a French radio contest !

by Ludovic Dubost

Hi XWiki users and developers ! It's voting time again.. You have helped me get through to the semi final a few month ago, and this week is the voting period for the semi-final. What's less fun is that this time we cannot not the current voting result in real time so we have to push as much as we can. You can vote here (in french too but that should not be too difficult ! Make sure you select the second person at the top !): http://www.radiobfm.com/bfm_academie/index.php This can give a nice additional boost to XWiki ! Thanks to all of you for you continuous support of XWiki and participation to the lists. Ludovic -- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

17 years, 3 months

3
6
0 0

Re: [xwiki-devs] [xwiki-notifications] r10278 - xwiki-platform/web/trunk/standard/src/main/webapp/templates

by Vincent Massol

On Jun 12, 2008, at 5:08 PM, Sergiu Dumitriu wrote: > vmassol (SVN) wrote: >> Author: vmassol >> Date: 2008-06-12 10:08:57 +0200 (Thu, 12 Jun 2008) >> New Revision: 10278 >> >> Modified: >> xwiki-platform/web/trunk/standard/src/main/webapp/templates/ >> login.vm >> Log: >> XWIKI-2458: Ensure that the username field has the input focus in >> the login form so that it's easier for users to quickly log in >> Idea submitted by Mihail Agafonovs >> >> >> Modified: xwiki-platform/web/trunk/standard/src/main/webapp/ >> templates/login.vm >> =================================================================== >> --- xwiki-platform/web/trunk/standard/src/main/webapp/templates/ >> login.vm 2008-06-12 03:17:43 UTC (rev 10277) >> +++ xwiki-platform/web/trunk/standard/src/main/webapp/templates/ >> login.vm 2008-06-12 08:08:57 UTC (rev 10278) >> @@ -42,5 +42,11 @@ >> #xwikimessageboxend() >> </form> >> </div> >> +## Ensure that the username field of the login form has the focus >> to make it easy for users to log in quickly >> +<script type="text/javascript"> >> +//<![CDATA[ >> + document.forms.loginForm.j_username.focus(); >> +//]]> >> +</script> >> #template("endpage.vm") >> #end > > I don't like it. This is intrusive Javascript. I'd rather: > - add a class attribute, class="autofocus" > - write a global SkinExtension that focuses the first element with > that class, if it exists > - and execute that method onload, with Event.observe(window, "load", > autofocus) Actually before doing this I checked other vm files and I saw this was a common practice... So common but not good I guess :) I'm not sure why we would use a skin extension for a template. This is not about extending a skin, it's about common templates to all skins. I'd like to understand how the full current template structure is impacted by the new Skin Extension and what's the vision. Also AFAIK SkinExtensions are in wiki pages. I don't think it's a good idea to have pages for template stuff since template stuff work without a database. The solution you highlight also sounds very slow for performances. > What's missing now: global skin extensions don't work yet. We could, > for the moment, pull it in. WDYM by "pull it in"? Thanks -Vincent

17 years, 3 months

1
0
0 0

[xwiki-devs] Bug Fixing Day Results for 11 June 2008

by Vincent Massol

Hi everyone, Yesterday was our first bug fixing day (which we intend to have every wednesday). The following bugs were fixed: http://tinyurl.com/5wcvs8 - Vincent * XWIKI-2454 XWiki products don't stop correctly under Tomcat - Sergiu * XWIKI-1007 Removing all content in page has no effect & the content of a wiki page is not allowed to be completely empty * XWIKI-1434 Case Related Issue With Backlinks * XWIKI-1045 halign and align {image} parameters overlap * XWIKI-2199 Saving a document via the inline editor resets the Tags document's property * XWIKI-1284 Image disappears from WYSIWYG editor in documents with special characters in name - Thomas * XWIKI-2453 Wrong use of cache in LDAP authenticator * XWIKI-2264 LDAP authentication does not support "." in login names - Artem * XWIKI-2375 Group and user access rights problem with a name which includes space characters So that's a total of 9 bugs fixed. Well done everybody and thanks to all who participated. Let's hope that even more of you can participate next wednesday. Thanks -Vincent

17 years, 3 months

1
0
0 0

[xwiki-devs] the return of class/object management

by Pascal Voitot

Hello guys, do you remember my work on classes and objects? I fear the answer is "no" :) Anyway, I have been working on some other critical projects so I haven't been able to work on that for some time. But, now I have restarted my study for my current needs. The idea was to provide a simple way to manage classes, to delete/restore class properties and to synchronize objects with these classes. As I was not really happy about the result of my previous work based on class versioning (I found it too much intrusive in XWiki code and complicated), I totally changed my approach into something much lighter. The idea is really simple: I propose to add the feature of enabling/disabling class properties. * If you disable a property, it is only "hidden" without being deleted so you can modify the structure of the class without losing anything. * Then the disabled properties are also "hidden" for the objects instantiating this class and the valued fields are also not lost. * If you add a new property to the class, all objects will inherit a new field with the default value. * If you enable a disabled property, all the objects owning the field re-find it and the objects not having the field now have it with the default value. * you could also delete a disabled field from an object for some optimization issues. I also propose to add the "remove property" feature which would be quite protected but which is useful: you simply delete the property from the class. * All objects having the "removed" field are no more synchronized with the class. * the removed field still exist in the object but is no more available to classical display functions which use "class properties" to find object fields. * the removed field can be deleted from the object to resynchronize the object to the class * if a new property with the same type and name is re-added to the class, the object re-finds its existing field. The way to do it is quite simple: just add a "enabled" field to the PropertyClass and manage it in the code. I have modified a bit XWiki-Core and some velocity scripts but it seems really light without any really new logic Are you interested in this? best regards Pascal

17 years, 3 months

3
3
0 0

Re: [xwiki-devs] [GSOC]syntax highlighting probleam

by Vincent Massol

Hi Venkatesh, On Jun 12, 2008, at 10:40 AM, Venkatesh Nandakumar wrote: [snip] > 1. Syntax Highlighting, to a large extent, though there have been > problems, as pointed out by Malaka, *bold~~combined~~bold* doesn't > give > the required effect, and secondly, the complex use of '*' in the wiki > syntax makes it a bit difficult to differentiate between actual *bold* > usage versus listing uses, maybe we would have to create own custom > regex-based rules for it later. For other tags, its been simple and > straightforward. Do you really need to parse it yourself? We have a parser in charge of doing this so you don't have to care at all about these problems. That's unless the system you use for syntax highlighting uses regexs (in which case I think it should be changed). Thanks -Vincent > > 2. Content Proposal, type <the first character of syntax> and drop- > down > of possible syntaxes, when selected, moves cursor to correct > position of > entry of text. Key-combination also brings down the menu. Also valid > for > applying styles to selected text. > 3. As a minor addition, context information. ( though very partially) > 4. Indentation strategies (very partial implementation till now) > 5. minor - Hyperlink detection and linking within {quote} and a > hyperlinks > > > I've also divided the document into partitions,(as of now, > pre,code,table,<dl> and default) for possibility of different content > proposal/content assist/syntax highlighting. > > I have not integrated any of the code with the xeclipse plugin's code. > What I have created as of now, is just another eclipse-plug-in. > > > Venkatesh > > > >

17 years, 3 months

2
2
0 0

[xwiki-devs] Code commit

by Fabio Mancinelli

Hi everybody. I have some code to commit for XWIKI-2432 and XWIKI-2428... There has been a previous vote for my committership but no official announcement of the results (unless I missed it). So I am just asking for the official ok before committing the code in trunk. Cheers, Fabio

17 years, 3 months

2
1
0 0

[xwiki-devs] [VOTE] Fabio Mancinelli as core committer

by Vincent Massol

Hi, I'd like to propose Fabio as a core committer. Fabio has been mostly participating in the rewrite of the XMLRPC support and I think it's important that he has access to maintain and improve it. Fabio's patches are very good too. In addition I believe Fabio is professional enough to not commit things he's not sure about if he's modifying other parts of the core and ask for core review instead. Last, if this make Fabio contributes to other parts in the core, then that's great for the project! Here's my +1 Thanks -Vincent

17 years, 3 months

7
7
0 0

[xwiki-devs] [GSOC]syntax highlighting probleam

by malaka ekanayake

Hi fabio Regarding the xwiki syntax I have some questions. Up to now its straightforward to implement the highlighting for syntaxes like *bold*. *bold* can be easily identified by a "MultiLineRule" as a single partition. But it is possible for someone to write a *bold~~bold &italics~~bold*.Right ?. So this can go on and on.How should I tackle this problem. I think *bold~~bold &italics~~bold* should generate 3 partitions because partitions are non overlapping. *bold ~~bold &italics~~ bold* Is this right ?. Should I look into this problem later and implement the sample plugin for simple syntaxes like *bild*,~~italics~~ or not ? . cheers -- Malaka Ekanayake

17 years, 3 months

3
3
0 0

Re: [xwiki-devs] [xwiki-notifications] r10277 - in xwiki-platform/web/trunk/standard/src/main/webapp: templates wiki_editor/plugins

by Vincent Massol

On Jun 12, 2008, at 5:17 AM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2008-06-12 05:17:43 +0200 (Thu, 12 Jun 2008) > New Revision: 10277 > > Modified: > xwiki-platform/web/trunk/standard/src/main/webapp/templates/ > editwysiwyg.vm > xwiki-platform/web/trunk/standard/src/main/webapp/wiki_editor/ > plugins/attachments.js > Log: > XWIKI-1284: Image disappears from WYSIWYG editor in documents with > special characters in name > Fixed. > [snip] > > Modified: xwiki-platform/web/trunk/standard/src/main/webapp/ > wiki_editor/plugins/attachments.js > =================================================================== > --- xwiki-platform/web/trunk/standard/src/main/webapp/wiki_editor/ > plugins/attachments.js 2008-06-12 01:39:44 UTC (rev 10276) > +++ xwiki-platform/web/trunk/standard/src/main/webapp/wiki_editor/ > plugins/attachments.js 2008-06-12 03:17:43 UTC (rev 10277) > @@ -44,7 +44,7 @@ > var contextPathImage = > tinyMCE.getParam("wiki_images_path").toString(); > href = contextPathImage.substring(0, > contextPathImage.indexOf("/",2)) + > "/bin/" + href.substring(href.indexOf("/",3) + 1); > - href = unescape(href); > +// href = unescape(href); Shouldn't this be removed? > > var imgname_reg = new RegExp(this.getImagePath() + "(.*)", > "i"); > var r = imgname_reg.exec(href); > if(r) { > @@ -82,7 +82,7 @@ > if (halign != "") { > str += "<div class=\"img" + halign + "\">" > } > - str += "<img id=\"" + result[1] + "\" class=\"" + > this.IMAGE_CLASS_NAME + "\" src=\"" + this.getImagePath() + > result[1] + "\" "; > + str += "<img id=\"" + result[1] + "\" class=\"" + > this.IMAGE_CLASS_NAME + "\" src=\"" + escape(this.getImagePath() + > result[1]) + "\" "; > if( result[5] && (width = this.trimString(result[5])) != "") { > str += "width=\"" + width + "\" "; > } Thanks -Vincent

17 years, 3 months

1
0
0 0

Re: [xwiki-devs] [xwiki-notifications] r10272 - in xwiki-platform/core/trunk/xwiki-core/src/main: java/com/xpn/xwiki/store/hibernate resources

by Vincent Massol

On Jun 12, 2008, at 2:47 AM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2008-06-12 02:47:34 +0200 (Thu, 12 Jun 2008) > New Revision: 10272 > > Added: > xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > store/hibernate/DocumentWebPropertyAccessor.java > Modified: > xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > xwiki.derby.hbm.xml > xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > xwiki.hbm.xml > xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > xwiki.oracle.hbm.xml > Log: > XWIKI-2456: Deprecate the doc.web mapping and add doc.space in the > Hibernate mapping file > Done. > > > Added: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/ > xwiki/store/hibernate/DocumentWebPropertyAccessor.java > =================================================================== > --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > store/hibernate/ > DocumentWebPropertyAccessor.java (rev 0) > +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > store/hibernate/DocumentWebPropertyAccessor.java 2008-06-12 00:47:34 > UTC (rev 10272) > @@ -0,0 +1,69 @@ > +/* > + * See the NOTICE file distributed with this work for additional > + * information regarding copyright ownership. > + * > + * This is free software; you can redistribute it and/or modify it > + * under the terms of the GNU Lesser General Public License as > + * published by the Free Software Foundation; either version 2.1 of > + * the License, or (at your option) any later version. > + * > + * This software is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this software; if not, write to the Free > + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA > + * 02110-1301 USA, or see the FSF site: http://www.fsf.org. > + */ > +package com.xpn.xwiki.store.hibernate; > + > +import org.apache.commons.logging.Log; > +import org.apache.commons.logging.LogFactory; > +import org.hibernate.PropertyNotFoundException; > +import org.hibernate.property.BasicPropertyAccessor; > +import org.hibernate.property.Getter; > +import org.hibernate.property.PropertyAccessor; > +import org.hibernate.property.Setter; > + > +import com.xpn.xwiki.web.XWikiAction; > + > +/** > + * Hibernate property accessor that allows using the deprecated > <code>doc.web</code> in HQL queries, while using the > + * new <code>space</code> getter and setter for the actual object > access. > + * > + * @version $Id$ > + */ > +public class DocumentWebPropertyAccessor extends > BasicPropertyAccessor implements PropertyAccessor > +{ > + /** Logging helper object. */ > + private static final Log LOG = > LogFactory.getLog(XWikiAction.class); > + > + /** > + * {@inheritDoc} > + * > + * @see PropertyAccessor#getGetter(Class, String) > + */ > + @SuppressWarnings("unchecked") > + @Override > + public Getter getGetter(Class theClass, String propertyName) > throws PropertyNotFoundException > + { > + LOG.warn("Deprecated usage of doc.web property in HQL > query"); shouldn't we say: "Deprecated usage of doc.web property in HQL query, use doc.space instead." ? same below. Thanks -Vincent > > + return super.getGetter(theClass, "space"); > + } > + > + /** > + * {@inheritDoc} > + * > + * @see PropertyAccessor#getSetter(Class, String) > + */ > + @SuppressWarnings("unchecked") > + @Override > + public Setter getSetter(Class theClass, String propertyName) > throws PropertyNotFoundException > + { > + LOG.warn("Deprecated usage of doc.web property in HQL > query"); > + return super.getSetter(theClass, "space"); > + } > + > +} > > > Property changes on: xwiki-platform/core/trunk/xwiki-core/src/main/ > java/com/xpn/xwiki/store/hibernate/DocumentWebPropertyAccessor.java > ___________________________________________________________________ > Name: svn:keywords > + Id > > Modified: xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > xwiki.derby.hbm.xml > =================================================================== > --- xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > xwiki.derby.hbm.xml 2008-06-12 00:45:31 UTC (rev 10271) > +++ xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > xwiki.derby.hbm.xml 2008-06-12 00:47:34 UTC (rev 10272) > @@ -66,10 +66,15 @@ > <column name="XWD_CREATOR" length="255" not-null="true" /> > </property> > > - <property name="web" type="string"> > +  > + <property name="web" type="string" update="false" > insert="false" > access="com.xpn.xwiki.store.hibernate.DocumentWebPropertyAccessor"> > <column name="XWD_WEB" length="255" not-null="true"/> > </property> > > + <property name="space" type="string"> > + <column name="XWD_WEB" length="255" not-null="true"/> > + </property> > + > <property name="content" type="string"> > <column name="XWD_CONTENT" sql-type="CLOB" > length="200000" not-null="true"/> > </property> > > Modified: xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > xwiki.hbm.xml > =================================================================== > --- xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > xwiki.hbm.xml 2008-06-12 00:45:31 UTC (rev 10271) > +++ xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > xwiki.hbm.xml 2008-06-12 00:47:34 UTC (rev 10272) > @@ -58,10 +58,15 @@ > <column name="XWD_CREATOR" length="255" not-null="true" /> > </property> > > - <property name="web" type="string"> > +  > + <property name="web" type="string" update="false" > insert="false" > access="com.xpn.xwiki.store.hibernate.DocumentWebPropertyAccessor"> > <column name="XWD_WEB" length="255" not-null="true"/> > </property> > > + <property name="space" type="string"> > + <column name="XWD_WEB" length="255" not-null="true"/> > + </property> > + > <property name="content" type="string"> > <column name="XWD_CONTENT" length="200000" not- > null="true"/> > </property> > > Modified: xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > xwiki.oracle.hbm.xml > =================================================================== > --- xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > xwiki.oracle.hbm.xml 2008-06-12 00:45:31 UTC (rev 10271) > +++ xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > xwiki.oracle.hbm.xml 2008-06-12 00:47:34 UTC (rev 10272) > @@ -60,10 +60,15 @@ > <column name="XWD_CREATOR" length="255"/> > </property> > > - <property name="web" type="string"> > +  > + <property name="web" type="string" update="false" > insert="false" > access="com.xpn.xwiki.store.hibernate.DocumentWebPropertyAccessor"> > <column name="XWD_WEB" length="255" not-null="true"/> > </property> > > + <property name="space" type="string"> > + <column name="XWD_WEB" length="255" not-null="true"/> > + </property> > + > <property name="content" type="string"> > <column name="XWD_CONTENT" length="200000" not- > null="true" sql-type="clob"/> > </property> > > _______________________________________________ > notifications mailing list > notifications(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/notifications

17 years, 3 months

1
0
0 0

Re: [xwiki-devs] [xwiki-notifications] r10270 - xwiki-products/xwiki-enterprise/trunk/distribution-test/selenium-tests/src/test/it/com/xpn/xwiki/it/selenium

by Vincent Massol

On Jun 12, 2008, at 1:53 AM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2008-06-12 01:53:06 +0200 (Thu, 12 Jun 2008) > New Revision: 10270 > > Modified: > xwiki-products/xwiki-enterprise/trunk/distribution-test/selenium- > tests/src/test/it/com/xpn/xwiki/it/selenium/WikiEditorTest.java > Log: > [misc] Added a comment > > > Modified: xwiki-products/xwiki-enterprise/trunk/distribution-test/ > selenium-tests/src/test/it/com/xpn/xwiki/it/selenium/ > WikiEditorTest.java > =================================================================== > --- xwiki-products/xwiki-enterprise/trunk/distribution-test/selenium- > tests/src/test/it/com/xpn/xwiki/it/selenium/WikiEditorTest.java > 2008-06-11 23:51:17 UTC (rev 10269) > +++ xwiki-products/xwiki-enterprise/trunk/distribution-test/selenium- > tests/src/test/it/com/xpn/xwiki/it/selenium/WikiEditorTest.java > 2008-06-11 23:53:06 UTC (rev 10270) > @@ -159,6 +159,9 @@ > // TODO: We need to find out how to make a text selection in > Selenium > } > > + /** > + * See XWIKI-1007 > + */ Personally I don't like referring to JIRA issues like this because: 1) the reader has to navigate to the issue to understand what it is 2) there's the risk that in the future we'll use a tool other than jira So I'd prefer you simply say: "Verify that a document's content can be empty" or if you prefer " Verify that a document's content can be empty (see XWIKI-2007).". My preference for the former. BTW naming the test: testEmptyDocumentContentIsAllowed would be even better :) Thanks -Vincent > public void testEmptyContent() > { > open("/xwiki/bin/edit/Test/EmptyWikiContent?editor=wiki"); > > _______________________________________________ > notifications mailing list > notifications(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/notifications

17 years, 3 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

xwiki-devs