- xwiki-devs@xwiki.org - lists.xwiki.org

[xwiki-devs] [Proposal] Introduce new Execution Context module

by Vincent Massol

Hi, I've been thinking a lot about the Container component I introduced and while writing unit tests for some of the new rendering classes I realized there was something not right: it's not normal that the HTML exporter or the rendering module depend on the Container object, and especially on the Request. Thus I'd like to introduce the notion of Execution Context (EC in short). The idea is that the xwiki entry points depend on the environment (Servlet, Portlet, etc) but those entry points create an Execution Context which is then used by the core components, independently of the environment. For example the VelocityContext is now put in the EC and not in the Request object. The Container objects still exist and can be used where required but it's expected that they should not be used since that makes the code dependent on the environment. This solves issue I had with code that don't have a request. I have it done on my machine. WDYT? Ok to commit? Thanks -Vincent PS: BTW this makes it very similar to the current XWikiContext (which is good) with the exception that the Container objects are not located inside the EC but as separate threadsafe variables.

17 years, 3 months

3
5
0 0

[xwiki-devs] Openoffice sdk client need openoffice runtime to run

by Wang Ning

Hi, I want to develop a component to handle office documents in xwiki. As we discussion before, I want to use openoffice api. I set a openoffice develop environment in my pc running ubuntu 8.04, and learn how to use openoffice api. Yes, The oo sdk is powerful to address office documents, MS doc, MS excel... But there's a problem. AFAIK, openoffice api need a openoffice local runtime or a remote server running openoffice. The whole openoffice runtime is 356M, more or less, so we shouldn't contain it in xwiki release. Hense, I think if we want the office importer run in a computer, the computer should have installed openoffice or configurate a remote openoffice server. WDYT? I need some suggestion. Thanks. -- Sincerely, Wang Ning

17 years, 3 months

5
7
0 0

[xwiki-devs] Problem in Snippets space on code.xwiki.org

by shivshan

Hi Clicking on any snippet gives a blank page with the error "Topic XWiki.SnippetClassSheet does not exist". Regards, Shiva -- View this message in context: http://www.nabble.com/Problem-in-Snippets-space-on-code.xwiki.org-tp1762259… Sent from the XWiki- Dev mailing list archive at Nabble.com.

17 years, 3 months

1
0
0 0

[xwiki-devs] XWS 1.1 status and new dates

by Jerome Velociter

Hello devs, XWS 1.1 M2 was originally planned for May 26th. Unfortunately, I have been taken by other projects and could not stick to that date. I give you here a status on what needs to be achieved and new dates proposal. For me, the consequent tasks left to be done for us to be feature closed for M2 are the following: * XWS-7 (Manage groups of administrators & power users). It has been started by Florin. For me it's 80% complete today. Florin will continue to work on it. * XWS-79 (Invitation management). About 50% complete. * XWS-23 Support public registration As for dates, here is my proposal : * 1.1 M2 next Monday (June 9th) * 1.1 RC1 on June 19th * 1.1 RC2 or 1.1 final on June 30th. wdyt ? Regards, Jerome.

17 years, 3 months

3
2
0 0

[xwiki-devs] XWiki-2006 again (configurable database schema name)

by rssh

Good day community. I want to ask again about XWIKI-2006 issue. http://jira.xwiki.org/jira/browse/XWIKI-2006 Now I find the way to change initialization of hibernate (instead calling of setDatabase in the beginning of each session) for non-virtual mode. [attached as configurated_db_schema_07.patch] Can I ask committers to review one ? (See previous discussion in this mail list http://markmail.org/message/6mtyxwff4ccmn3lk) We have 2 votes for previous patch. We need three [as I remember rules of this game] -- yet one vote, please ;) -- Ruslan Shevchenko GradSoft. http://www.gradsoft.ua

17 years, 3 months

1
0
0 0

Re: [xwiki-devs] [xwiki-notifications] r10078 - xwiki-products/xwiki-enterprise/branches/xwiki-enterprise-1.4/distribution-test/selenium-tests/src/test/it/com/xpn/xwiki/it/selenium

by Vincent Massol

Hi Ludovic, You should gather those 3 methods into one: * functional tests are slow to run and this will slow down the overall tests (the setup is long) * the naming of the test methods is not explanatory Thanks -Vincent On Jun 2, 2008, at 3:39 PM, ludovic (SVN) wrote: > Author: ludovic > Date: 2008-06-02 15:39:10 +0200 (Mon, 02 Jun 2008) > New Revision: 10078 > > Modified: > xwiki-products/xwiki-enterprise/branches/xwiki-enterprise-1.4/ > distribution-test/selenium-tests/src/test/it/com/xpn/xwiki/it/ > selenium/WysiwygEditorFromWikiTest.java > Log: > XWIKI-2343 Wysiwyg editor breaks accents in links > > Modified: xwiki-products/xwiki-enterprise/branches/xwiki- > enterprise-1.4/distribution-test/selenium-tests/src/test/it/com/xpn/ > xwiki/it/selenium/WysiwygEditorFromWikiTest.java > =================================================================== > --- xwiki-products/xwiki-enterprise/branches/xwiki-enterprise-1.4/ > distribution-test/selenium-tests/src/test/it/com/xpn/xwiki/it/ > selenium/WysiwygEditorFromWikiTest.java 2008-06-01 21:50:23 UTC (rev > 10077) > +++ xwiki-products/xwiki-enterprise/branches/xwiki-enterprise-1.4/ > distribution-test/selenium-tests/src/test/it/com/xpn/xwiki/it/ > selenium/WysiwygEditorFromWikiTest.java 2008-06-02 13:39:10 UTC (rev > 10078) > @@ -100,4 +100,29 @@ > clickLinkWithText("Wiki"); > assertEquals("## comment", getFieldValue("content")); > } > + > + public void testAccentsInLinks() throws Exception > + { > + setFieldValue("content", "[\u00E9t\u00E9]"); > + clickLinkWithText("WYSIWYG"); > + clickLinkWithText("Wiki"); > + assertEquals("[\u00E9t\u00E9]", getFieldValue("content")); > + } > + > + public void testAccentsInLinks2() throws Exception > + { > + setFieldValue("content", "[test>\u00E9t\u00E9]"); > + clickLinkWithText("WYSIWYG"); > + clickLinkWithText("Wiki"); > + assertEquals("[test>\u00E9t\u00E9]", > getFieldValue("content")); > + } > + > + public void testAccentsInLinks3() throws Exception > + { > + setFieldValue("content", "[\u00E9t\u00E9>test]"); > + clickLinkWithText("WYSIWYG"); > + clickLinkWithText("Wiki"); > + assertEquals("[\u00E9t\u00E9>test]", > getFieldValue("content")); > + } > + > }

17 years, 3 months

1
0
0 0

[xwiki-devs] [proposal] Componentize XWiki Stores

by Artem Melentyev

Hi devs. I would like to propose: 1. Make all xwiki stores as components. So they will be constructed via our ComponentManager. 2. Deprecate all store public constructors. Because they are useless for components. 3. Add SessionFactory component to all hibernate stores. this will fix XWIKI-2332: Share one session factory among all hibernate stores. move all hibernate configuration to SessionFactory component. one SessionFactory is shared by all stores by default (configured in components.xml). here is tentative interface SessionFactory { Session openSession() Configuration getConfiguration() /** rebuild session factory with new configuration. needed for inject hibernate custom mappings. */ void updateConfiguration(Configuration cfg) } 4. Add QueryManager component to main store (XWikiStoreInterface) WDYT? -- Artem Melentyev

17 years, 3 months

1
0
0 0

[xwiki-devs] [VOTE] Release XEM 1.3M1

by Thomas Mortagne

Hi, As XE 1.5M1 is now released, I would like to released XEM 1.3M1 based on it after XEM 1.2 final release. The pure XEM modification part is the same as XEM 1.2 final but with all new XE 1.5 branch features. See http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXEM13M1 Here is my +1 -- Thomas Mortagne

17 years, 3 months

3
2
0 0

[xwiki-devs] XWiki Enterprise 1.4.1 to be released ASAP

by Jean-Vincent Drean

Hi XWikiers, XWiki Enterprise 1.4 has introduced a regression for group management in farm mode. We strongly suggest to use XWiki Enterprise 1.3.2 if you are upgrading a wiki farm before the 1.4.1 release. XWiki Enterprise 1.4.1 is planned on june 2nd and will be performed by Thomas Mortagne, it will include the following fixes : * XWIKI-2413 : Global groups are not taken into account in a virtual wiki Anything missing in the list ? Thanks, -- Jean-Vincent Drean

17 years, 3 months

6
9
0 0

[xwiki-devs] [ANN] XWiki Enterprise 1.5 Milestone 1 Released

by Jean-Vincent Drean

The XWiki development team is pleased to announce the release of XWiki Enterprise 1.5 Milestone 1. Go grab it at http://www.xwiki.org/xwiki/bin/view/Main/Download First milestone of the XWiki Enterprise 1.5 version. Main changes: * LDAP support improvements ** Add possibility to map one LDAP group with more that one XWiki group ** Add the ability to configure LDAP groups classes and members fields names ** LDAP authenticator re-save user page even there is no modification ** "userPassword" LDAP field should be configurable ** Makes the SSL provider implementation used to support LDAP communication over SSL configurable ** LDAP authentication print error message with empty "group_mapping" property * Better PDF export support * Have "from" (second to last version) and "to" (last version) fields checked by default in the the document history * Ability to change just one (or several) object properties * Automatic logging of deprecated method calls in Velocity * Better language negotiation * Don't display the login link on the login page Note that the general goals of XE 1.5 are : * More bug fixes * Better performance * More automated tests * Overhaul of the Administration For more information see the Release notes at: http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXWikiEnterprise15M1 Thanks, The XWiki dev team

17 years, 3 months

1
0
0 0

[xwiki-devs] best way to override xwiki.cfg properties in my source?

by Paul Libbrecht

Hello list, as indicated on: http://www.nabble.com/my-attempt-at-building-a-development-curriki-to175692… I am using a simple maven install to build curriki which is very nice. Within the process both xwiki.cfg and hibernate.cfg.xml are built and I could override these with changes in the pom.xml. Do I have a chance to override these somewhere else? thanks in advance paul

17 years, 3 months

2
1
0 0

[xwiki-devs] Google AJAX Libraries API

by Fabio Mancinelli

Hi all, Maybe this can be interesting... http://code.google.com/apis/ajaxlibs/ Cheers, Fabio

17 years, 3 months

5
4
0 0

[xwiki-devs] Watch Menu in XE 1.4

by Glenn Everitt

I wasn't seeing the watch menu in XE 1.4. In menuview.vm an additional test was added: && $wiki.exists("XWiki.WatchListManager") I don't seem to have the page and so the menu doesn't appear. Does something have to be separately installed? If I remove the test above the Watch Menu is displayed as expected. I am not using virtual Wiki's. Is the test necessary? Glenn Everitt -- View this message in context: http://www.nabble.com/Watch-Menu-in-XE-1.4-tp17581949p17581949.html Sent from the XWiki- Dev mailing list archive at Nabble.com.

17 years, 3 months

2
1
0 0

[xwiki-devs] WatchList working

by Kamna Jain

Hello Jean, Devs, I got the Watchlist notifications to work. Thanks a lot for guidance. I did not do anything new today. But, I guess I was expecting it to fire at any simple changes I made to the page..like just adding a simple line and commenting it out... Do you think it should have fired even for those changes...9it did not..or maybe it just takes one day to start ..) today, I added some logic using velocity on that page and then it fired..and has been doing so since then. So I changed the chron to hourly again from every minute( 0 * * * * to 0 0 * * *) Also, I tried using the RSS feeds that are provided but my RSS reader complains that the link is not valid (it does not have a .rss or .xml extension to it) Is there a way I can set my preferences to get the updated RSS feed links. I see in the Watchlist object, only email settings are included. Nothing for the RSS. Can anyone advice on how to use that. The emails I am receiving have a Comment section! How can we program the system so that a comment is automatically added to the email based on the page that was modified? Thanks and looking forward to your responses Kamna

17 years, 3 months

2
1
0 0

[xwiki-devs] [VOTE] XE 1.5 roadmap and dates

by Vincent Massol

Here's a date proposal for XE 1.5: 1.5 M1 - 30 May 2008 1.5 M2 - 20 June 2008 1.5 RC1 - 4 Juillet 2008 1.5 RC2 / Final - 11 Juillet 2008 Roadmap: * More bug fixes * Better performance o Run XE with a profiler and find bottlenecks o Reduce number of database calls o Improved page loading * More automated tests o More selenium tests * Overhaul of the Administration Optional (good to have): New rendering mechanism. Here's my +1 Thanks -Vincent

17 years, 3 months

6
8
0 0

[xwiki-devs] Exception when excuting checkstyle with maven

by Julien Lancelot

I'm trying to generate checkstyle report with maven (mvn checkstyle:checkstyle) and it fails... I'm executing it at the root folder of xwiki source. I use maven 2.0.8, and tried without success with version 2.0.9, and 2.1-SNAPSHOT. Here the trace (see trace.txt attached for full trace) : [ERROR] FATAL ERROR [INFO] ------------------------------------------------------------------------ [INFO] An invalid artifact was detected. This artifact might be in your project's POM, or it might have been included transitively during the resolution process. Here is the information we do have for this artifact: o GroupID: com.xpn.xwiki.platform.tools o ArtifactID: xwiki-verification-resources o Version: <<< MISSING >>> o Type: jar [INFO] ------------------------------------------------------------------------ [INFO] Trace org.apache.maven.artifact.InvalidArtifactRTException: For artifact {com.xpn.xwiki.platform.tools:xwiki-verification-resources:null:jar}: The version cannot be empty. at org.apache.maven.artifact.DefaultArtifact.validateIdentity(DefaultArtifact.java:147) at org.apache.maven.artifact.DefaultArtifact.<init>(DefaultArtifact.java:122) at org.apache.maven.artifact.factory.DefaultArtifactFactory.createArtifact(DefaultArtifactFactory.java:158) at org.apache.maven.artifact.factory.DefaultArtifactFactory.createDependencyArtifact(DefaultArtifactFactory.java:70) at org.apache.maven.project.artifact.MavenMetadataSource.createArtifacts(MavenMetadataSource.java:334) at org.apache.maven.plugin.DefaultPluginManager.addPlugin(DefaultPluginManager.java:343) at org.apache.maven.plugin.DefaultPluginManager.verifyVersionedPlugin(DefaultPluginManager.java:208) at org.apache.maven.plugin.DefaultPluginManager.verifyPlugin(DefaultPluginManager.java:172) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.verifyPlugin(DefaultLifecycleExecutor.java:1257) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.getMojoDescriptor(DefaultLifecycleExecutor.java:1522) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.segmentTaskListByAggregationNeeds(DefaultLifecycleExecutor.java:386) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:138) at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:333) at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:126) at org.apache.maven.cli.MavenCli.main(MavenCli.java:282) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315) at org.codehaus.classworlds.Launcher.launch(Launcher.java:255) at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430) at org.codehaus.classworlds.Launcher.main(Launcher.java:375) -- Julien Lancelot Hortis, Consulting & Innovation team Sonar , Open Source Quality Dashboard for Java projects Try Sonar at http://sonar.hortis.ch

17 years, 3 months

1
2
0 0

Re: [xwiki-devs] [xwiki-notifications] r9982 - xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki

by Vincent Massol

On May 29, 2008, at 11:41 PM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2008-05-29 23:41:59 +0200 (Thu, 29 May 2008) > New Revision: 9982 > > Modified: > xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > XWiki.java > Log: > XWIKI-2415: Sending notifications fails when restoring documents > from the recycle bin > Fixed. > > > Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/ > xwiki/XWiki.java > =================================================================== > --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > XWiki.java 2008-05-29 21:10:01 UTC (rev 9981) > +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > XWiki.java 2008-05-29 21:41:59 UTC (rev 9982) > @@ -1113,6 +1113,12 @@ > // We need to save the original document since > saveXWikiDoc() will reset it and we > // need that original document for the notification below. > XWikiDocument originalDocument = > doc.getOriginalDocument(); > + // Always use an originalDocument, to provide a > consistent behavior. The cases where > + // originalDocument is null are rare (specifically when > the XWikiDocument object is > + // manually constructed, and not obtained using the API). > + if (originalDocument == null) { > + originalDocument = new > XWikiDocument(doc.getSpace(), doc.getName()); > + } > > // Notify listeners about the document change > if (originalDocument == null || > originalDocument.isNew()) { hmmm... this doesn't look correct. You're forcing the originalDocument to be not null but then next says: if originalDocument is null... Thanks -Vincent

17 years, 3 months

2
2
0 0

Re: [xwiki-devs] Admin XAR package

by Ludovic Dubost

I'll work on making a working version. Sorry about that. Ludovic Evelina Slatineanu wrote: > Hi, > > Why does the AdminApplication xar has 0 bytes when I download it? :P > > Thx, > Evelina > > -----Original Message----- > From: devs-bounces(a)xwiki.org [mailto:devs-bounces@xwiki.org] On Behalf Of > Ludovic Dubost > Sent: Wednesday, May 28, 2008 6:11 PM > To: devs(a)xwiki.org; XWiki Users > Subject: [xwiki-devs] Admin XAR package > > > I've published an admin XAR package which helps monitoring an XWiki > instance. It includes a Requests Status, Memory Status as well as a > selective Import/Export. > > http://code.xwiki.org/xwiki/bin/view/Applications/AdminApplication > > Ludovic > > -- > Ludovic Dubost > Blog: http://blog.ludovic.org/ > XWiki: http://www.xwiki.com > Skype: ldubost GTalk: ldubost > > > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs > > -- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost

17 years, 3 months

1
0
0 0

[xwiki-devs] Admin XAR package

by Ludovic Dubost

I've published an admin XAR package which helps monitoring an XWiki instance. It includes a Requests Status, Memory Status as well as a selective Import/Export. http://code.xwiki.org/xwiki/bin/view/Applications/AdminApplication Ludovic -- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost

17 years, 3 months

3
2
0 0

[xwiki-devs] About the top menu item in Presentation tag in Space Prefs in Administration

by Saraswatee Kashyap

Hi, What should be done to get the top menu items in a single line? We are using menuitem to create the menu items which we get in multiple lines. Can you provide us the way in which the menu should be created in a single line. Thanks, Sara

17 years, 3 months

1
0
0 0

Re: [xwiki-devs] [xwiki-notifications] r9953 - xwiki-platform/xwiki-plugins/tags/xwiki-plugin-spacemanager-1.0

by Vincent Massol

Hi Ludovic, Some questions for you: * Why are you re-releasing the SM 1.0 version? (was this an error?). Did you rollback (I didn't see a rollback message)? Has your change overriden the existing 1.0 tag? * Why are you creating a 1.0 branch? Why your change cannot go in 1.1 instead? * Did you create a jira version for 1.0.1? Thanks -Vincent On May 27, 2008, at 9:16 PM, ludovic (SVN) wrote: > Author: ludovic > Date: 2008-05-27 21:16:09 +0200 (Tue, 27 May 2008) > New Revision: 9953 > > Modified: > xwiki-platform/xwiki-plugins/tags/xwiki-plugin-spacemanager-1.0/ > pom.xml > Log: > [maven-release-plugin] prepare release xwiki-plugin-spacemanager-1.0 > > Modified: xwiki-platform/xwiki-plugins/tags/xwiki-plugin- > spacemanager-1.0/pom.xml > =================================================================== > --- xwiki-platform/xwiki-plugins/tags/xwiki-plugin-spacemanager-1.0/ > pom.xml 2008-05-27 19:16:06 UTC (rev 9952) > +++ xwiki-platform/xwiki-plugins/tags/xwiki-plugin-spacemanager-1.0/ > pom.xml 2008-05-27 19:16:09 UTC (rev 9953) > @@ -62,8 +62,8 @@ > </dependencies> > > <scm> > - <connection>scm:svn:http://svn.xwiki.org/svnroot/xwiki/xwiki-platform/xwiki-plugins/bra… > </connection> > - <developerConnection>scm:svn:https://svn.xwiki.org/svnroot/xwiki/xwiki-platform/xwiki-plugins/br… > </developerConnection> > - <url>http://svn.xwiki.org/svnroot/xwiki/xwiki-platform/xwiki-plugins/branches/xw… > </url> > + <connection>scm:svn:http://svn.xwiki.org/svnroot/xwiki/xwiki-platform/xwiki-plugins/tag… > </connection> > + <developerConnection>scm:svn:https://svn.xwiki.org/svnroot/xwiki/xwiki-platform/xwiki-plugins/ta… > </developerConnection> > + <url>http://svn.xwiki.org/svnroot/xwiki/xwiki-platform/xwiki-plugins/tags/xwiki-… > </url> > </scm> > </project>

17 years, 3 months

3
3
0 0

Re: [xwiki-devs] [xwiki-notifications] r9964 - xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/xwiki

by Vincent Massol

Maybe this code could be put in some releaseLocks() method(s) for now? Thanks -Vincent On May 29, 2008, at 1:24 AM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2008-05-29 01:24:11 +0200 (Thu, 29 May 2008) > New Revision: 9964 > > Modified: > xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > user/impl/xwiki/XWikiAuthServiceImpl.java > Log: > XWIKI-2191: When user logout, his pages locks should be removed > Fixed. > - When a local user logs out, his locks are removed. > - When a global user logs out, his locks in the current and main > wiki are removed. > > Patch submitted by Asiri Rathnayake, applied with a few changes > > > Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/ > xwiki/user/impl/xwiki/XWikiAuthServiceImpl.java > =================================================================== > --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > user/impl/xwiki/XWikiAuthServiceImpl.java 2008-05-28 20:18:19 UTC > (rev 9963) > +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > user/impl/xwiki/XWikiAuthServiceImpl.java 2008-05-28 23:24:11 UTC > (rev 9964) > @@ -31,6 +31,8 @@ > import org.apache.commons.lang.StringUtils; > import org.apache.commons.logging.Log; > import org.apache.commons.logging.LogFactory; > +import org.hibernate.Query; > +import org.hibernate.Session; > import org.securityfilter.config.SecurityConfig; > import org.securityfilter.filter.SecurityRequestWrapper; > import org.securityfilter.realm.SimplePrincipal; > @@ -200,8 +202,66 @@ > wrappedRequest.setUserPrincipal(null); > > try { > + if (auth.processLogin(wrappedRequest, response, > context)) { > + return null; > + } > > - // Process login out (this only works with FORMS > + // TODO : This code need to be moved elsewhere > (appropriately). > + Principal user = wrappedRequest.getUserPrincipal(); > + if (context.getAction().equals("logout") && user != > null) { > + // Release all active locks on current wiki. > + try { > + > xwiki.getHibernateStore().beginTransaction(context); > + Session session = > xwiki.getHibernateStore().getSession(context); > + String sql = "delete from XWikiLock as lock > where lock.userName=:userName"; > + Query query = session.createQuery(sql); > + query.setString("userName", user.getName()); > + query.executeUpdate(); > + } catch (Exception e) { > + throw new > XWikiException(XWikiException.MODULE_XWIKI_STORE, > + > XWikiException.ERROR_XWIKI_STORE_HIBERNATE_DELETING_LOCK, > + "Error while deleting active locks held by > logging out user."); > + } finally { > + try { > + > xwiki.getHibernateStore().endTransaction(context, true); > + } catch (Exception e) { > + > + } > + } > + // If we're in a non-main wiki & the user is global, > + // switch to the global wiki and delete locks held > there. > + if (xwiki.isVirtualMode() > + && ! > context.getMainXWiki().equals(context.getDatabase()) > + && > user.getName().startsWith(context.getMainXWiki() + ":")) { > + String cdb = context.getDatabase(); > + // switch to main wiki. > + context.setDatabase(context.getMainXWiki()); > + try { > + > xwiki.getHibernateStore().beginTransaction(context); > + Session session = > xwiki.getHibernateStore().getSession(context); > + String sql = > + "delete from XWikiLock as lock where > lock.userName=:userName"; > + Query query = session.createQuery(sql); > + String localName = > user.getName().substring(user.getName().indexOf(":") + 1); > + query.setString("userName", localName); > + query.executeUpdate(); > + } catch (Exception e) { > + throw new > XWikiException(XWikiException.MODULE_XWIKI_STORE, > + > XWikiException.ERROR_XWIKI_STORE_HIBERNATE_DELETING_LOCK, > + "Error while deleting active locks held > by logging out user."); > + } finally { > + try { > + > xwiki.getHibernateStore().endTransaction(context, true); > + } catch (Exception e) { > + > + } > + // switch back to original wiki. > + context.setDatabase(cdb); > + } > + } > + } > + > + // Process logout (this only works with Forms) > if (auth.processLogout(wrappedRequest, response, > xwiki.getUrlPatternMatcher())) { > if (log.isInfoEnabled()) { > log.info("User " + context.getUser() + " has > been logged-out"); > @@ -210,11 +270,6 @@ > return null; > } > > - if (auth.processLogin(wrappedRequest, response, > context)) { > - return null; > - } > - > - Principal user = wrappedRequest.getUserPrincipal(); > if (log.isInfoEnabled()) { > if (user != null) { > log.info("User " + user.getName() + " is > authentified");

17 years, 3 months

1
0
0 0

[xwiki-devs] [Proposal] QueryManager in store

by Artem Melentyev

Hi, devs. I would like to propose new QueryManager which will deprecate our store.search(* methods This proposal is based on Vincent ideas at http://markmail.org/message/mjgg52coupsmfomg and QueryManager from JCR v2 QueryManager is designed for low-level querying in Java code. (QueryPlugin for high-level and velocity) The main idea is support of multiple languages and easy to add new languages. This is needed for JCRStore. Here is interfaces: public interface QueryManager { Query createQuery(String statement, String language); Query getNamedQuery(String qname); String[] getLanguages(); boolean hasLanguage(String language); } public interface Query { enum Language { HQL, XPATH, JCRSQL } <T> List<T> execute(); Query bindValue(String var, Object val); Query setLimit(int limit); Query setOffset(int offset); } Here is abstract usecase: QueryManager qm = xwiki.getStore().getQueryManager(); Query q = qm.getNamedQuery("SomeNameOfQuery"); if (q==null && qm.hasLanguage(Query.Language.HQL.name())) { q = qm.createQuery("from XWikiDocument where author=:var", Language.HQL.name()); } else if (q==null && qm.hasLanguage(Language.XPATH.name())) { q = qm.createQuery("/*/*[@author=:var]", Language.XPATH.name()); } else throw new RuntimeException(); List<XWikiDocument> res = q.setLimit(10).setOffset(10) .bindValue("var", "Some.Author").execute(); notes: I'm not sure we need getNamedQuery right now. But it can be useful for move some complicated queries to store level (to some QueryHolders) or overriding queries. Queries are detached from store session. So session isn't opened until Query#execute(). WDYT? -- Artem Melentyev

17 years, 3 months

2
6
0 0

Re: [xwiki-devs] [xwiki-notifications] r9958 - xwiki-platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/gwt/api/client/app

by Vincent Massol

Hi Anca, A possible improvement below. On May 28, 2008, at 12:47 PM, lucaa (SVN) wrote: > Author: lucaa > Date: 2008-05-28 12:47:56 +0200 (Wed, 28 May 2008) > New Revision: 9958 > > Modified: > xwiki-platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/gwt/api/ > client/app/XWikiGWTDefaultApp.java > Log: > XWIKI-2408: Default XWikiService URL not created correctly in hosted > mode in XWikiGWTDefaultApp > > * added a test for the ending character of the module base URL > returned by GWT > > > Modified: xwiki-platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/ > gwt/api/client/app/XWikiGWTDefaultApp.java > =================================================================== > --- xwiki-platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/gwt/api/ > client/app/XWikiGWTDefaultApp.java 2008-05-28 10:40:44 UTC (rev 9957) > +++ xwiki-platform/web/trunk/gwt/src/main/java/com/xpn/xwiki/gwt/api/ > client/app/XWikiGWTDefaultApp.java 2008-05-28 10:47:56 UTC (rev 9958) > @@ -181,10 +181,15 @@ > if (serviceInstance == null) { > serviceInstance = (XWikiServiceAsync) > GWT.create(XWikiService.class); > String defaultXWikiService; > - if (GWT.isScript()) > + if (GWT.isScript()) { > defaultXWikiService = > XWikiGWTAppConstants.XWIKI_DEFAULT_BASE_URL + > XWikiGWTAppConstants.XWIKI_DEFAULT_SERVICE; > - else > - defaultXWikiService = GWT.getModuleBaseURL() + > XWikiGWTAppConstants.XWIKI_DEFAULT_SERVICE; > + } else { > + String moduleBaseURL = GWT.getModuleBaseURL(); > + if (moduleBaseURL.endsWith("/")) { > + moduleBaseURL = moduleBaseURL.substring(0, > moduleBaseURL.length() - 1); > + } // Here, explain why we need to remove the last "/" if it's there and why it's not deterministic String moduleBaseURL = StringUtils.chomp(GWT.getModuleBaseURL(), "/"); > > + defaultXWikiService = moduleBaseURL + > XWikiGWTAppConstants.XWIKI_DEFAULT_SERVICE; > + } > ((ServiceDefTarget) > serviceInstance).setServiceEntryPoint(getParam("xwikiservice" , > defaultXWikiService)); > } > return serviceInstance; Thanks -Vincent

17 years, 3 months

2
4
0 0

Re: [xwiki-devs] [xwiki-notifications] r9956 - xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki

by Vincent Massol

Thomas, does this mean it's now set in 2 places? If so I think that's not correct. Thanks -Vincent On May 27, 2008, at 10:58 PM, tmortagne (SVN) wrote: > Author: tmortagne > Date: 2008-05-27 22:58:40 +0200 (Tue, 27 May 2008) > New Revision: 9956 > > Modified: > xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > XWiki.java > Log: > XWIKI-2367: Makes ComponentManager getable without the XWikiContext > * Reset ComponentManager in XWiki.initXWiki as shared-test can't > call Utils.setComponentManager > > Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/ > xwiki/XWiki.java > =================================================================== > --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > XWiki.java 2008-05-27 19:37:05 UTC (rev 9955) > +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > XWiki.java 2008-05-27 20:58:40 UTC (rev 9956) > @@ -737,6 +737,11 @@ > public void initXWiki(XWikiConfig config, XWikiContext context, > XWikiEngineContext engine_context, boolean noupdate) throws > XWikiException > { > + // Statically store the component manager in {@link Utils} > to be able to access it without > + // the context. > + Utils.setComponentManager((ComponentManager) context > + .get(ComponentManager.class.getName())); > + > setEngineContext(engine_context); > context.setWiki(this);

17 years, 3 months

2
6
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

xwiki-devs