- xwiki-devs@xwiki.org - lists.xwiki.org

[VOTE] Release POM v3 and XWiki Tools v1.2

by Vincent Massol

Hi, I'd like to release those 2 projects in preparation for the release of the other modules. Changes for XWiki Tools v1.2: ** Bug * [XTOOLS-4] - Shutdown the database only for the HSQLDB database ** Improvement * [XTOOLS-6] - Move the Jetty container files to a module so that they can be reused by the different products without duplication ** Task * [XTOOLS-5] - Move the License files to the XWiki Configuration Resources JAR Here's my +1 Thanks -Vincent

18 years, 1 month

5
4
0 0

Re: [xwiki-users] Interface XMLRPC

by Catalin Hritcu

Hi, As Sergiu pointed out I am currently working to improve the implementation of the XML-RPC API. The discussion is going on xwiki-dev: http://www.nabble.com/Proposal%3A-XML-RPC-API---True-Interoperability-with-… http://www.nabble.com/Why-do-we-throw-exceptions-in-the-ConfluenceRpcInterf… This JIRA issue is also relevant: http://jira.xwiki.org/jira/browse/XWIKI-1560 There are many changes which I will commit after the M4 release, and any additional help on testing them would be appreciated (especially if you can provide us automated tests). On 8/13/07, diaga(a)nomade.fr <diaga(a)nomade.fr> wrote: > Hi, > I am still testing the XMLRPC interface. This the first result I have noticed: > > 1.There are some messages that are not implemented: > -public Map getUser(String token, String username); > -public void addGroup(String token, String group); > -public Object[] getUserGroups(String token, String username); > -public void addUserToGroup(String token, String username, String groupname); > True, they are not yet implemented. But there are many others as well: http://jira.xwiki.org/jira/browse/XWIKI-1559 > 2.To make the update or the creation of a page work normally, I have to get the content of a page and to modify his element to have the result I want. This is linked with the fact that we have to use a Map Object to define a page or Map is an interface. So the other solution I haven't tested is to implement the interface Map instead of getting a page and modifying it. I don't follow you here. Can you please explain better what bothers you here. Or maybe just give the code you had to write now, and how you would like it to be. > 3.For "public Object[] getComments(String token, String pageId);" I have some problem to make it work normally. I would advise you to wait a couple more days and try the new implementation of this method from the SVN repository. > 4.Another result is that I have to flush the cash very often in order to make the Update and creation of a page work. If I don't do that I have to restart my server to see the changes. When all work correct with a login/logout, we see the changes. There were some complaints before that the modifications through xmlrpc don't work well with the caches: http://www.nabble.com/Trouble-with-refresh-after-update-from-xmlrpc-tf39287… http://www.nabble.com/XML-RPC-oddities-tf3607425.html http://www.nabble.com/On-Which-Features-Should-I-Focus-When-Testing--tf3890… Since xmlrpc does not use any sort of caching I always thought that the problem should be somewhere else :) ... But well, maybe we should do something to use those caches. Any suggestions what to do? > 5.When I try to get the content of a document created by a Class, I get the content of the Template linked to the Class. I don't know if this is normal or not. I don't know either. What else would you expect ? Regards, Catalin

18 years, 1 month

2
1
0 0

Feature Freeze: 1.1 M4

by Vincent Massol

Hi, I'd like us to stop committing stuff now and focus on testing and committing fixes for regressions and errors in what we have committed (no more patch applications for stuff in 1.1M3). We need to stabilize now and release 1.1M4 but we can't done that with a minimum of testing. WDYT? Is that ok for everyone? What would be nice is that each of us takes some issues from the 1.1 release notes, test that the implementation works and report it in JIRA as such. Preferably pick issues that you haven't done yourself as it'll be more effective. WDYT? Thanks -Vincent

18 years, 1 month

2
2
0 0

Updated 1.1M4 release date

by Vincent Massol

Hi, We need to start releasing 1.1M4. Here's a tentative release date: * Code freeze tonight (Monday, 23:59PM) * I start doing the release tomorrow morning. Will take me 1 full day I think, meaning 1.1M4 can be released Tuesday night. * I create the 1.1 branch on tuesday too. Bug fixes for RC1 and RC2 go there. * Work on 1.2 trunk can start on Wednesday (I'm not sure how to release from a branch with maven yet as otherwise I could have branched right now - I need to check this out). WDYT? Thanks -Vincent

18 years, 1 month

1
0
0 0

Wiki 1.1M4 release: what's left?

by Vincent Massol

Hi, We need to release 1.1M4. However there are a few things to finish before being able to release it. Here's my list: 1) Do some testing on the new features introduced recently: - nested style macros - history table and related modifications - full screen - wysiwyg new features If everyone could help here that'd be great. 2) Fix code macro as my changed has been rolled back is it was causing problems with other macros coming after. 3) Finish fixing TC so that we can have a full clean build 4) Assess scheduler plugin state and verify it works fine. It's missing some feature (like restart jobs when the server restarts) but that's ok if they are documented and jira issues created for fixing this later on 5) Finish testing the installer 6) Restore xwiki.org clean to remove vandalism + write release notes for 1.1M4 Anything more? Thanks -Vincent

18 years, 1 month

3
5
0 0

Re: [xwiki-commits] r4208 - in xwiki-products/xwiki-enterprise/trunk: . wiki/src/main/resources/Main wiki/src/main/resources/XWiki

by Vincent Massol

Hi JV, On Aug 12, 2007, at 9:13 PM, Jean-Vincent Drean wrote: [snip] > +#if($query != "") > + #set($lucene = $xwiki.getPlugin("lucene")) > + #if($lucene) [snip] > + #else > + Error: Lucene plugin not found. I think it would be nice to tell the user that the Lucene plugin is not enabled in xwiki's configuration and add a link to the old search here. Also what happens if the lucene plugin isn't found? It seems to me the rest of the code below will get executed, no? > + #end > +#end > + > +#set($doRebuild = $request.getParameter("rebuild")) > +#if($doRebuild=="yes") > + #set($lucene = $xwiki.getPlugin("lucene")) > + #if($lucene) > + #set($documentCount = $lucene.rebuildIndex($xwiki,$context)) > + #if(${documentCount}>=0) > + #info("Started index rebuild with $documentCount documents.\\ > + Will take some time depending on > the number of pages/attachments.") > + #else > + #error("Error: Index rebuild failed.") > + #end > + #end > +#else > + #if($xwiki.hasAdminRights()) > + #info ("[Rebuild the lucene index>${doc.web}.${doc.name}? > rebuild=yes]") > + #end > +#end > + > +#warning("This is the new lucene search engine.\\ > + You can still use the XWiki [default search > engine>WebSearch?text=$query]..")</content> There's an extra dot ("."). Shouldn't this be an "info" rather than a warning? Or it could stay a warning but in that case it might be better to tell the user that this is an experimental feature, WDYT? Thanks -Vincent

18 years, 1 month

1
0
0 0

Re: [xwiki-commits] r4208 - in xwiki-products/xwiki-enterprise/trunk: . wiki/src/main/resources/Main wiki/src/main/resources/XWiki

by Vincent Massol

JV, We need the new search page to behave the same as the old one in term of "features". I haven't checked your code yet (will do in a few moments). Here's is what it should have: - a combo box to select the space to search in - exclusion of some spaces if the user is not admin - ability to pass a space in parameter - escaping of some special characters <, >, etc - etc In addition is the Lucene search searching in all places that the old hibernate search was searching in? From what I recall the old search was looking in: - document contents - document names - document object properties (string and textarea properties) (I know the new lucene search searches in attachments too which is a great new feature!) Thanks -Vincent On Aug 12, 2007, at 9:13 PM, Jean-Vincent Drean wrote: > Author: jvdrean > Date: 2007-08-12 21:13:05 +0200 (Sun, 12 Aug 2007) > New Revision: 4208 > > Added: > xwiki-products/xwiki-enterprise/trunk/wiki/src/main/resources/ > Main/LuceneSearch > Modified: > xwiki-products/xwiki-enterprise/trunk/ > xwiki-products/xwiki-enterprise/trunk/wiki/src/main/resources/ > XWiki/Results > Log: > XE-48 : Replace current hibernate search with the lucene plugin + > nice search page > > > Property changes on: xwiki-products/xwiki-enterprise/trunk > ___________________________________________________________________ > Name: svn:ignore > - *.iml > .project > .classpath > target > *.log > > + *.iml > .project > .classpath > target > *.log > idea > > > Added: xwiki-products/xwiki-enterprise/trunk/wiki/src/main/ > resources/Main/LuceneSearch > =================================================================== > --- xwiki-products/xwiki-enterprise/trunk/wiki/src/main/resources/ > Main/LuceneSearch 2007-08-12 19:12:39 UTC (rev 4207) > +++ xwiki-products/xwiki-enterprise/trunk/wiki/src/main/resources/ > Main/LuceneSearch 2007-08-12 19:13:05 UTC (rev 4208) > @@ -0,0 +1,174 @@ > +<?xml version="1.0" encoding="ISO-8859-1"?> > + > +<xwikidoc> > +<web>Main</web> > +<name>LuceneSearch</name> > +<language></language> > +<defaultLanguage>en</defaultLanguage> > +<translation>0</translation> > +<parent></parent> > +<creator>XWiki.Admin</creator> > +<author>XWiki.Admin</author> > +<customClass></customClass> > +<contentAuthor>XWiki.Admin</contentAuthor> > +<creationDate>1186588178000</creationDate> > +<date>1186942604000</date> > +<contentUpdateDate>1186942604000</contentUpdateDate> > +<version>1.2</version> > +<title></title> > +<template></template> > +<defaultTemplate></defaultTemplate> > +<validationScript></validationScript> > +<comment></comment> > +<minorEdit>false</minorEdit> > +<attachment> > +<filename>next.png</filename> > +<filesize>395</filesize> > +<author>XWiki.Admin</author> > +<date>1186927318000</date> > +<version>1.1</version> > +<comment></comment> > +<content>iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAABGdBTUEAAK/I > NwWK6QAAABl0RVh0U29mdHdhcmUAQWRvYmUgSW1hZ2VSZWFkeXHJZTwAAAEdSURBVDjLY/ > j//z8DJZiB6gY0rH7xpW7li3YKDHj1v2bli38lix61k2VA5fJn/9eeeP+/fcOL/wlT7/ > aRbEDegkf/Vxx/93/xobf/S5c8/u/ecm0eSQYkTX/4f+HBN/8nbX/xf+bul/ > 8Tp9/9r1N0dgnRBgT33QZqfPW/YdXj/42rH//v2vjkv3fHtf9SScceEWWAc8u1/ > xO2Pv9fsvjB//IlD4CGPPrvXH/5v2Tksc1EGWBaful/+/on/4sW3gfGxsP/9lUX/ > ksEH1gj6rqdhSgDlPPO/q9b8fB/5bIH/23LL/wXD9i7kqRAlEo6+b908f3/NiXn/ > 4t57V1EcjRKRB75b1145r+o684FZCUkMb8D/ > 0Uct88euMxEKgYA7Ojrv4CgE7EAAAAASUVORK5CYII=</content> > +</attachment> > +<attachment> > +<filename>previous.png</filename> > +<filesize>389</filesize> > +<author>XWiki.Admin</author> > +<date>1186927329000</date> > +<version>1.1</version> > +<comment></comment> > +<content>iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAABGdBTUEAAK/I > NwWK6QAAABl0RVh0U29mdHdhcmUAQWRvYmUgSW1hZ2VSZWFkeXHJZTwAAAEXSURBVDjLY/ > j//z8DJZiBLgZkz37Ynjrz4ReyDEideb89afrDf5ET7v4n2YCEqXf7qpY9/T9r76v/ > Xu03STMgasLteaVLHv+fufvl/6k7X/y3qrlCvAHBvTeXFC54ANbctv7p/95Nz/ > 5rFZ0nzoCAzpuPsuc++D91x4v/jasf/y9aeP9/89rH/6VTTxJngGPDtc3xU+/ > 879789H/5kgf/02fd+V+17OF/yZhjxBmgVXCaRT3v7BqP1mv/a1Y+/J824/b/woX3/ > osHHSAtECVjjqy0Lb/wP2/+3f+Zs+/8F3XfS3o0inntXWSeffJ/0tRb/ > 0Ucdv4nKyEJW25ZYBh/5L+w5fb/ZCdlQYMNs4WMt/wfuMyEDwMA0Irn/ > pDRT58AAAAASUVORK5CYII=</content> > +</attachment> > +<object> > +<class> > +<name>XWiki.TagClass</name> > +<customClass></customClass> > +<customMapping></customMapping> > +<defaultViewSheet></defaultViewSheet> > +<defaultEditSheet></defaultEditSheet> > +<defaultWeb></defaultWeb> > +<nameField></nameField> > +<validationScript></validationScript> > +<tags> > +<cache>0</cache> > +<displayType>input</displayType> > +<multiSelect>1</multiSelect> > +<name>tags</name> > +<number>1</number> > +<prettyName>Tags</prettyName> > +<relationalStorage>1</relationalStorage> > +<separator> </separator> > +<separators> ,|</separators> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<values></values> > +<classType>com.xpn.xwiki.objects.classes.StaticListClass</classType> > +</tags> > +</class> > +<name>Main.LuceneSearch</name> > +<number>0</number> > +<className>XWiki.TagClass</className> > +<property> > +<tags/> > +</property> > +</object> > +<content>## =================== > +## Lucene search > +## =================== > +## Inputs : $request.text > +## Outputs : $list, $isScored > +## =================== > + > +1 Search > + > +#set($query = $request.getParameter("text")) > +#if(!$query) > + #set($query = "") > +#end > +#set($itemsPerPage = "30") > + > +{pre} > +<form action="$doc.name" method="post"> > +<input type="text" name="text" value="$query" /> > +<input type="submit" value="Search"/> > +</form> > +{/pre} > + > +#if($query != "") > + #set($lucene = $xwiki.getPlugin("lucene")) > + #if($lucene) > + ## --------------- > + ## Lucene search > + ## --------------- > + #set($wikinames = "xwiki") > + #set($languages = "default,en,de") > + #set($firstIndex = $request.getParameter("firstIndex")) > + #if(!$firstIndex) > + #set($firstIndex = "1") > + #end > + #set($searchresults = $lucene.getSearchResults($query, > $wikinames, $languages, $xwiki)) > + #set($results = $searchresults.getResults($firstIndex, > $itemsPerPage)) > + #if($searchresults.getHitcount()>0) > + ## ----------------- > + ## Results numbers > + ## ----------------- > + #set($lastIndex=$searchresults.getEndIndex($firstIndex, > $itemsPerPage)) > + #if($searchresults.getHitcount()==1) > + One result: > + #else > + Results $firstIndex - $lastIndex of ${searchresults.getHitcount > ()}: > + #end > + ## --------------- > + ## Previous page > + ## --------------- > + #if($searchresults.hasPrevious($firstIndex)) > + #set($linkfirstIndex = $searchresults.getPreviousIndex > ($firstIndex,$itemsPerPage)) > + #set($link = "${doc.name}?text=${query}&firstIndex=$ > {linkfirstIndex}") > + {pre} > + <a href="$link"><img src="${doc.getAttachmentURL > ("previous.png")}" alt="previous" />previous page</a> > + {/pre} > + #end > + ## ------------- > + ## Next page > + ## ------------- > + #if($searchresults.hasNext($firstIndex,$itemsPerPage)) > + #set($linkfirstIndex = $searchresults.getNextIndex($firstIndex, > $itemsPerPage)) > + #set($link = "${doc.name}?text=${query}&firstIndex=$ > {linkfirstIndex}") > + {pre} > + <a href="$link"><img src="${doc.getAttachmentURL > ("next.png")}" alt="next" />next page</a> > + {/pre} > + #end > + > + ## ----------------- > + ## Display results > + ## ----------------- > + #set ($list = $results) > + #set ($isScored = true) > + #includeInContext("XWiki.Results") > + #end > + #else > + Error: Lucene plugin not found. > + #end > +#end > + > +#set($doRebuild = $request.getParameter("rebuild")) > +#if($doRebuild=="yes") > + #set($lucene = $xwiki.getPlugin("lucene")) > + #if($lucene) > + #set($documentCount = $lucene.rebuildIndex($xwiki,$context)) > + #if(${documentCount}>=0) > + #info("Started index rebuild with $documentCount documents.\\ > + Will take some time depending on > the number of pages/attachments.") > + #else > + #error("Error: Index rebuild failed.") > + #end > + #end > +#else > + #if($xwiki.hasAdminRights()) > + #info ("[Rebuild the lucene index>${doc.web}.${doc.name}? > rebuild=yes]") > + #end > +#end > + > +#warning("This is the new lucene search engine.\\ > + You can still use the XWiki [default search > engine>WebSearch?text=$query]..")</content> > +</xwikidoc> > > Modified: xwiki-products/xwiki-enterprise/trunk/wiki/src/main/ > resources/XWiki/Results > =================================================================== > --- xwiki-products/xwiki-enterprise/trunk/wiki/src/main/resources/ > XWiki/Results 2007-08-12 19:12:39 UTC (rev 4207) > +++ xwiki-products/xwiki-enterprise/trunk/wiki/src/main/resources/ > XWiki/Results 2007-08-12 19:13:05 UTC (rev 4208) > @@ -12,14 +12,15 @@ > <customClass></customClass> > <contentAuthor>XWiki.Admin</contentAuthor> > <creationDate>1158300067000</creationDate> > -<date>1180527554000</date> > -<contentUpdateDate>1180527554000</contentUpdateDate> > -<version>1.4</version> > +<date>1186942158000</date> > +<contentUpdateDate>1186942158000</contentUpdateDate> > +<version>1.5</version> > <title></title> > <template></template> > <defaultTemplate></defaultTemplate> > <validationScript></validationScript> > <comment></comment> > +<minorEdit>false</minorEdit> > <object> > <class> > <name>XWiki.TagClass</name> > @@ -31,18 +32,18 @@ > <nameField></nameField> > <validationScript></validationScript> > <tags> > +<cache>0</cache> > +<displayType>input</displayType> > +<multiSelect>1</multiSelect> > <name>tags</name> > +<number>1</number> > <prettyName>Tags</prettyName> > -<unmodifiable>0</unmodifiable> > <relationalStorage>1</relationalStorage> > -<displayType>input</displayType> > -<multiSelect>1</multiSelect> > -<size>30</size> > <separator> </separator> > -<cache>0</cache> > <separators> ,|</separators> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > <values></values> > -<number>1</number> > <classType>com.xpn.xwiki.objects.classes.StaticListClass</classType> > </tags> > </class> > @@ -67,14 +68,21 @@ > <th style="width:150px" class="selectFilter">Space</ > th> > <th style="width:150px">Date</th> > <th style="width:150px">Last Author</th> > + #if($isScored) > + <th style="width:150px">Score</th> > + #end > #if($xwiki.hasAdminRights()) > <th style="width:210px" class="unsortable > noFilter">Actions</th> > #end > </tr> > #foreach ($item in $list) > - #set($troubi ="non") > + #set($troubi = "non") > #if ($xwiki.hasAccessLevel("view", $context.user, "$ > {context.database}:${item}")) > - #set($bentrydoc = $xwiki.getDocument($item)) > + #if ($item.class == "class java.lang.String") > + #set($bentrydoc = $xwiki.getDocument($item)) > + #elseif ($item.class == "class > com.xpn.xwiki.plugin.lucene.SearchResult") > + #set($bentrydoc = $item) > + #end > #set($cclass = $xwiki.getDocument > ("XWiki.XWikiComments").getxWikiClass()) > #set($comment = $cclass.newObject()) > #if($xwiki.getWebPreferenceAsInt("commentsorder",1)==0) > @@ -84,7 +92,7 @@ > #end > #set($createur = $xwiki.getUserName($bentrydoc.author)) > #set($ptitle = $bentrydoc.getDisplayTitle()) > - <tr><td style="text-align:left"> > + <tr><td style="text-align:left"> > #if($comments.size()>0) > #set($i = 0) > #set($cobj = $comments.get($i)) > @@ -103,13 +111,17 @@ > #else > [$bentrydoc.name>${bentrydoc.web}. > $bentrydoc.name] #if ($ptitle != $bentrydoc.name) <em>- > $ptitle</em>#end > #end > + ## LUCENE : entries are typed > + #elseif ($bentrydoc.type == "attachment") > + <a href="${bentrydoc.url}" > target="_blank"><img src="${xwiki.getSkinFile("disk.png")}" > ALT="download"> ${bentrydoc.filename}</a>\\ > + Attachment of [${bentrydoc.web}.${bentrydoc.name}] > #else > #set($comment = "") > [$bentrydoc.name>${bentrydoc.web}. > $bentrydoc.name.replaceAll("@","%40")] #if ($ptitle != > $bentrydoc.name) <em>- $ptitle</em>#end > #end > </td><td style="text-align:left"> > [$bentrydoc.web>${bentrydoc.web}.WebHome] > - </td><td style="text-align:left"> > + </td><td style="text-align:left"> > $xwiki.formatDate($bentrydoc.date,"yyyy MMM dd") at > $xwiki.formatDate($bentrydoc.date,"HH:mm")</td><td > style="text-align:center"> > #if($troubi =="oui") > #set($createur = $xwiki.getUserName($cobj.author) ) > @@ -120,6 +132,21 @@ > $createur > #end > </td> > + #if ($isScored) > + <td style="text-align:left"> > + #set($resval=$bentrydoc.score*100) > + #set($starurl=$xwiki.getSkinFile("star.png")) > + #set($star = "<img src='$starurl' alt='$resval'>") > + <span class="hidden">$bentrydoc.score</span> > + #if($resval>10) $star #end > + #if($resval>20) $star #end > + #if($resval>40) $star #end > + #if($resval>60) $star #end > + #if($resval>90) $star #end > + #set ($perc = $resval.toString()) > + ${perc.substring(0, $perc.indexOf("."))}% > + </td> > + #end > #if($xwiki.hasAdminRights()) > <td> > <a href="$xwiki.getURL("XWiki.CopyDocument", > "view", "sourcedoc=${bentrydoc.fullName}")">Copy</a> - > <a href="$bentrydoc.getURL("delete")">Delete</a> - > <a href="$bentrydoc.getURL("view", > "xpage=rename&amp;step=1")">Rename</a> - <a > href="$bentrydoc.getURL("edit", "editor=rights")">Rights</a> > > > > -- > You receive this message as a subscriber of the xwiki- > commits(a)objectweb.org mailing list. > To unsubscribe: mailto:xwiki-commits-unsubscribe@objectweb.org > For general help: mailto:sympa@objectweb.org?subject=help > ObjectWeb mailing lists service home page: http://www.objectweb.org/ > wws

18 years, 1 month

1
0
0 0

Re: [xwiki-commits] r4207 - in xwiki-platform/web/trunk/standard/src/main/webapp/skins: albatross dodo finch

by Vincent Massol

Hi JV, What would you think about locating the images in icons/search (we need to rename icons in images later on too)? Here you've put the images at the top level of the skin along with the other 999 files... :) Thanks -Vincent On Aug 12, 2007, at 9:12 PM, Jean-Vincent Drean wrote: > Author: jvdrean > Date: 2007-08-12 21:12:39 +0200 (Sun, 12 Aug 2007) > New Revision: 4207 > > Added: > xwiki-platform/web/trunk/standard/src/main/webapp/skins/ > albatross/disk.png > xwiki-platform/web/trunk/standard/src/main/webapp/skins/ > albatross/star.png > xwiki-platform/web/trunk/standard/src/main/webapp/skins/dodo/ > disk.png > xwiki-platform/web/trunk/standard/src/main/webapp/skins/dodo/ > star.png > xwiki-platform/web/trunk/standard/src/main/webapp/skins/finch/ > disk.png > xwiki-platform/web/trunk/standard/src/main/webapp/skins/finch/ > star.png > Log: > XE-48 : Replace current hibernate search with the lucene plugin + > nice search page > > Added: xwiki-platform/web/trunk/standard/src/main/webapp/skins/ > albatross/disk.png > =================================================================== > (Binary files differ) > > > Property changes on: xwiki-platform/web/trunk/standard/src/main/ > webapp/skins/albatross/disk.png > ___________________________________________________________________ > Name: svn:mime-type > + application/octet-stream > > Added: xwiki-platform/web/trunk/standard/src/main/webapp/skins/ > albatross/star.png > =================================================================== > (Binary files differ) > > > Property changes on: xwiki-platform/web/trunk/standard/src/main/ > webapp/skins/albatross/star.png > ___________________________________________________________________ > Name: svn:mime-type > + application/octet-stream > > Added: xwiki-platform/web/trunk/standard/src/main/webapp/skins/dodo/ > disk.png > =================================================================== > (Binary files differ) > > > Property changes on: xwiki-platform/web/trunk/standard/src/main/ > webapp/skins/dodo/disk.png > ___________________________________________________________________ > Name: svn:mime-type > + application/octet-stream > > Added: xwiki-platform/web/trunk/standard/src/main/webapp/skins/dodo/ > star.png > =================================================================== > (Binary files differ) > > > Property changes on: xwiki-platform/web/trunk/standard/src/main/ > webapp/skins/dodo/star.png > ___________________________________________________________________ > Name: svn:mime-type > + application/octet-stream > > Added: xwiki-platform/web/trunk/standard/src/main/webapp/skins/ > finch/disk.png > =================================================================== > (Binary files differ) > > > Property changes on: xwiki-platform/web/trunk/standard/src/main/ > webapp/skins/finch/disk.png > ___________________________________________________________________ > Name: svn:mime-type > + application/octet-stream > > Added: xwiki-platform/web/trunk/standard/src/main/webapp/skins/ > finch/star.png > =================================================================== > (Binary files differ) > > > Property changes on: xwiki-platform/web/trunk/standard/src/main/ > webapp/skins/finch/star.png > ___________________________________________________________________ > Name: svn:mime-type > + application/octet-stream > > > > -- > You receive this message as a subscriber of the xwiki- > commits(a)objectweb.org mailing list. > To unsubscribe: mailto:xwiki-commits-unsubscribe@objectweb.org > For general help: mailto:sympa@objectweb.org?subject=help > ObjectWeb mailing lists service home page: http://www.objectweb.org/ > wws

18 years, 1 month

1
0
0 0

Re: [xwiki-commits] r4205 - xwiki-platform/core/trunk/src/main/java/com/xpn/xwiki

by Vincent Massol

Thanks JV. Would be nice to improve the javadoc to explain: - what is a work directory and what xwiki is using it for - what is a temporary directory and what xwiki is using it for, and more specifically how it is different from a work dir - the algorithm to find the temporary directory. Thanks -Vincent On Aug 12, 2007, at 9:06 PM, Jean-Vincent Drean wrote: > Author: jvdrean > Date: 2007-08-12 21:06:28 +0200 (Sun, 12 Aug 2007) > New Revision: 4205 > > Modified: > xwiki-platform/core/trunk/src/main/java/com/xpn/xwiki/XWiki.java > Log: > XWIKI-1583 : Standard methods in XWiki to get a work or temp directory > > Modified: xwiki-platform/core/trunk/src/main/java/com/xpn/xwiki/ > XWiki.java > =================================================================== > --- xwiki-platform/core/trunk/src/main/java/com/xpn/xwiki/ > XWiki.java 2007-08-12 18:14:24 UTC (rev 4204) > +++ xwiki-platform/core/trunk/src/main/java/com/xpn/xwiki/ > XWiki.java 2007-08-12 19:06:28 UTC (rev 4205) > @@ -185,6 +185,16 @@ > */ > private static String configPath = null; > > + /* > + * Work directory > + */ > + private static File workDir = null; > + > + /* > + * Temp directory > + */ > + private static File tempDir = null; > + > private static String getConfigPath() throws NamingException > { > if (configPath == null) { > @@ -5438,4 +5448,150 @@ > else > return max; > } > + > + /** > + * Get the XWiki temporary filesystem directory (deleted on exit) > + * > + * @param context > + * @return temporary directory > + * @since 1.1 Milestone 4 > + */ > + public File getTempDirectory(XWikiContext context) > + { > + // if tempDir has already been set, return it > + if (tempDir != null) > + { > + return tempDir; > + } > + > + // xwiki.cfg > + String dirPath = context.getWiki().Param("xwiki.temp.dir"); > + if (dirPath != null) > + { > + try > + { > + tempDir = new File(dirPath.replaceAll("\\s+$", "")); > + if (tempDir.isDirectory() && tempDir.canWrite()) > + { > + tempDir.deleteOnExit(); > + return tempDir; > + } > + } > + catch(Exception e) > + { > + tempDir = null; > + LOG.warn("xwiki.temp.dir set in xwiki.cfg : " + > dirPath + " does not exist or is not writable", e); > + } > + } > + > + Object jsct = context.getEngineContext().getAttribute > ("javax.servlet.context.tempdir"); > + > + // javax.servlet.context.tempdir (File) > + if (jsct!=null && (jsct instanceof File)) > + { > + workDir=(File)jsct; > + if (workDir.isDirectory() && workDir.canWrite()) > + { > + return workDir; > + } > + } > + > + // javax.servlet.context.tempdir (String) > + if (jsct!=null && (jsct instanceof String)) > + { > + workDir=new File((String)jsct); > + > + if (workDir.isDirectory() && workDir.canWrite()) > + { > + return workDir; > + } > + } > + > + // Let's make a tempdir in java.io.tmpdir > + workDir = new File(System.getProperty("java.io.tmpdir"), > "xwikiTemp"); > + > + if (workDir.exists()) > + { > + workDir.deleteOnExit(); > + } > + else > + { > + workDir.mkdir(); > + workDir.deleteOnExit(); > + } > + > + return workDir; > + } > + > + /** > + * Get a new directory in the xwiki work directory > + * > + * @param subdir desired directory name > + * @param context > + * @return work subdirectory > + * @since 1.1 Milestone 4 > + */ > + public File getWorkSubdirectory(String subdir, XWikiContext > context) > + { > + File fdir = new File(this.getWorkDirectory > (context).getAbsolutePath(), subdir); > + if (!fdir.exists()) > + { > + fdir.mkdir(); > + } > + return fdir; > + } > + > + /** > + * Get the XWiki work directory > + * > + * @param context > + * @return work directory > + * @since 1.1 Milestone 4 > + */ > + public File getWorkDirectory(XWikiContext context) > + { > + String dirPath; > + > + // if workDir has already been set, return it > + if (workDir != null) > + { > + return workDir; > + } > + > + // xwiki.cfg > + dirPath = context.getWiki().Param("xwiki.work.dir"); > + if (dirPath != null) > + { > + try > + { > + workDir = new File(dirPath.replaceAll("\\s+$", "")); > + if (workDir.exists()) > + { > + if (workDir.isDirectory() && workDir.canWrite()) > + { > + return workDir; > + } > + } > + else > + { > + workDir.mkdir(); > + return workDir; > + } > + } > + catch(Exception e) > + { > + workDir = null; > + LOG.warn("xwiki.work.dir set in xwiki.cfg : " + > dirPath + " does not exist or is not writable", e); > + } > + } > + > + /* > + * TODO : it would be nice to create a subdirectory xwiki > in APPServer/work or WEBAPP/WEB-INF/work > + */ > + > + // No choices left, retreiving the temp directory > + workDir = this.getTempDirectory(context); > + > + return workDir; > + } > } > > > > -- > You receive this message as a subscriber of the xwiki- > commits(a)objectweb.org mailing list. > To unsubscribe: mailto:xwiki-commits-unsubscribe@objectweb.org > For general help: mailto:sympa@objectweb.org?subject=help > ObjectWeb mailing lists service home page: http://www.objectweb.org/ > wws

18 years, 1 month

1
0
0 0

FW: [xwiki-users] xWiki and eXo 1.1.x

by Kito D. Mann

Can anyone answer this question? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Kito D. Mann - Author, JavaServer Faces in Action <http://www.virtua.com/> http://www.virtua.com - JSF/Java EE consulting, training, and mentoring <http://www.jsfcentral.com/> http://www.JSFCentral.com - JavaServer Faces FAQ, news, and info From: Kito D. Mann [mailto:kmann@virtua.com] Sent: Sunday, August 05, 2007 2:15 AM To: xwiki-users(a)objectweb.org Subject: [xwiki-users] xWiki and eXo 1.1.x Hello, Is there a version of xWiki that works with eXo portal 1.1.x? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Kito D. Mann - Author, JavaServer Faces in Action <http://www.virtua.com/> http://www.virtua.com - JSF/Java EE consulting, training, and mentoring <http://www.jsfcentral.com/> http://www.JSFCentral.com - JavaServer Faces FAQ, news, and info * Sign up for the JSF Central newsletter! http://oi.vresp.com/?fid=ac048d0e17 *

18 years, 1 month

2
1
0 0

Re: [xwiki-commits] r4196 - xwiki-platform/web/trunk/standard/src/main/webapp/skins/albatross

by Vincent Massol

Hi Sergiu, I thought this was done in some previous release. I can see it's on xwiki.org which is using 1.1M3 and I've found this in the release notes of 1.1M2: "When deleting a page, first show the list of pages linking to it and warn about them". Or is this something different? Thanks -Vincent On Aug 12, 2007, at 3:03 AM, Sergiu Dumitriu wrote: > Author: sdumitriu > Date: 2007-08-12 03:03:46 +0200 (Sun, 12 Aug 2007) > New Revision: 4196 > > Modified: > xwiki-platform/web/trunk/standard/src/main/webapp/skins/ > albatross/delete.vm > Log: > XWIKI-1297: When deleting a page, first show the list of pages that > will be orphaned > Done (velocity files) > > > Modified: xwiki-platform/web/trunk/standard/src/main/webapp/skins/ > albatross/delete.vm > =================================================================== > --- xwiki-platform/web/trunk/standard/src/main/webapp/skins/ > albatross/delete.vm 2007-08-11 23:59:11 UTC (rev 4195) > +++ xwiki-platform/web/trunk/standard/src/main/webapp/skins/ > albatross/delete.vm 2007-08-12 01:03:46 UTC (rev 4196) > @@ -8,23 +8,41 @@ > <div id="xwikimessage">$message</div> > #end > #set($links=$doc.getBacklinks()) > +#set($orphans = $xwiki.searchDocuments(" where doc.fullName <> '$ > {doc.fullName}as' and (doc.parent = '${doc.fullName}' or > (doc.parent = '${doc.name}' and doc.web = '${doc.web}'))")) > #if($request.xredirect) > #set($redirectparam = "&xredirect=$request.xredirect") > #end > +#set($quote = '"') > +#set($hasInlinks = false) > +#set($fullmsg = "") > #if($links && $links.size() > 0) > - #set($quote = '"') > - #set ($fullmsg="</p><ul style=${quote}text-align: left;${quote}>") > + #set($tmpmsg = "</p><ul style=${quote}text-align: left;${quote}>") > #foreach($docname in $links) > #set($rdoc = $xwiki.getDocument($docname).getTranslatedDocument > ()) > - #set($fullmsg = "${fullmsg}<li><a href=${quote}${rdoc.getURL > ('view')}${quote}>${rdoc.displayTitle}</a></li>") > + #set($tmpmsg = "${tmpmsg}<li><a href=${quote}${rdoc.getURL > ('view')}${quote}>${rdoc.displayTitle}</a></li>") > #end > - #set($fullmsg = "${fullmsg}</ul><p class=${quote}xwikimessage$ > {quote}>") > - #set($fullmsg=$msg.get("core.delete.backlinksWarning", [$fullmsg])) > - #set($fullmsg="${fullmsg}</p><p class=${quote}xwikimessage$ > {quote}>"+$msg.get("core.delete.confirmWithBacklinks")) > - #xwikimessagebox($msg.get("core.delete") $fullmsg $doc.getURL > ("delete", "confirm=1$!{redirectparam}&$languageparams") > $doc.getURL("view") $msg.get("yes") $msg.get("no")) > + #set($tmpmsg = "${tmpmsg}</ul><p class=${quote}xwikimessage$ > {quote}>") > + #set($tmpmsg = $msg.get("core.delete.backlinksWarning", [$tmpmsg])) > + #set($fullmsg="${fullmsg}${tmpmsg}</p><p class=${quote} > xwikimessage${quote}>") > + #set($hasInlinks = true) > +#end > +#if($orphans && $orphans.size() > 0) > + #set($tmpmsg ="</p><ul style=${quote}text-align: left;${quote}>") > + #foreach($docname in $orphans) > + #set($rdoc = $xwiki.getDocument($docname).getTranslatedDocument > ()) > + #set($tmpmsg = "${tmpmsg}<li><a href=${quote}${rdoc.getURL > ('view')}${quote}>${rdoc.displayTitle}</a></li>") > + #end > + #set($tmpmsg = "${tmpmsg}</ul><p class=${quote}xwikimessage$ > {quote}>") > + #set($tmpmsg = $msg.get("core.delete.orphansWarning", [$tmpmsg])) > + #set($fullmsg="${fullmsg}${tmpmsg}</p><p class=${quote} > xwikimessage${quote}>") > + #set($hasInlinks = true) > +#end > +#if($hasInlinks) > + #set($fullmsg="${fullmsg}${msg.get > ('core.delete.confirmWithInlinks')}") > #else > - #xwikimessagebox($msg.get("core.delete") $msg.get > ("core.delete.confirm") $doc.getURL("delete", "confirm=1$! > {redirectparam}&$languageparams") $doc.getURL("view") $msg.get > ("yes") $msg.get("no")) > + #set($fullmsg = $msg.get("core.delete.confirm")) > #end > +#xwikimessagebox($msg.get("core.delete") $fullmsg $doc.getURL > ("delete", "confirm=1$!{redirectparam}&$languageparams") > $doc.getURL("view") $msg.get("yes") $msg.get("no")) > </div> > <div class="clearfloats"></div> > #template("endpage.vm") > \ No newline at end of file > > > > -- > You receive this message as a subscriber of the xwiki- > commits(a)objectweb.org mailing list. > To unsubscribe: mailto:xwiki-commits-unsubscribe@objectweb.org > For general help: mailto:sympa@objectweb.org?subject=help > ObjectWeb mailing lists service home page: http://www.objectweb.org/ > wws

18 years, 1 month

2
2
0 0

Why do we throw exceptions in the ConfluenceRpcInterface methods?

by Vincent Massol

Hi, If our goal is to implement the Confluence XMLRPC interface (http:// confluence.atlassian.com/display/DOC/Remote+API+Specification) then it seems to me we shouldn't throw XWikiException in any method in our ConfluenceRpcInterface interface. Several methods instead should return a boolean to indicate success or failure. Does anyone know why we're throwing them? Are we ok to remove all exception throwing? Thanks -Vincent

18 years, 1 month

4
19
0 0

What happened to Page titles ? :`(

by Asiri Rathnayake

Hi All, Until recently XMLRPCs returned pages with titles of the form "<space-name>.<page-title>" but after i built xwiki's latest sources today, i figured out that they now have the form "<page-title>" (space name is gone). We need to change XEclipse a bit to accommodate this change (a very very tiny change). Anyway, what caused this change ? am I missing something ? Thanks. - Asiri

18 years, 1 month

2
2
0 0

Proposal: XML-RPC API - True Interoperability with Confluence

by Catalin Hritcu

Hello, We have decided to implement the Confluence Remote API because the interoperability would bring many advantages to XWiki (as Vincent explained here http://tinyurl.com/ypfamt). However at this moment the XWiki implementation of this API is not yet interoperable with Confluence. And this is not only because we are implementing only a very small subset of the API, but more important because nobody ever checked that we are in fact behaving similarly. The goal should be to write clients that are able to run against XWiki or Confluence servers without being able to tell any difference. At this moment this is not the case and there are many reasons for this. One reason is that we are currently relying on dynamic proxies in our client code (http://ws.apache.org/xmlrpc/advanced.html). In this setting the client and the server have to use the same Java interface, namely com.xpn.xwiki.xmlrpc.ConfluenceRpcInterface. And no, there is absolutely no chance to convince the Confluence team to implement this XWiki-specific interface. One way around this is to write client code which does not use dynamic proxies, but that is tedious and error prone (e.g. you can pass as many agruments as you like and you can call methods that don't exist). Remote calls look like this: token = (String)rpc.execute("confluence1.login", new Object[] {token, username, password}); There is however a better option, and that is to use swizzle-confluence, a client proxy for the confluence XML-RPC API (http://docs.codehaus.org/display/SWIZZLE). This would offer all the advantages of calling a typed proxy. Still all calls would eventually look like the one above, so they could go to any server that implements the interface (whether it's XWiki or Confluence). There are many other advantages: swizzle is intuitive, well-documented, well-tested and makes it unnecessary to explicitly pass a token around. Switching to swizzle would mean that all our client code would need to be modified. I already started to convert our tests to swizzle and it seems an easy task. Setup is a lot easier than before. Compare this: XmlRpcClientConfigImpl clientConfig = new XmlRpcClientConfigImpl(); clientConfig.setServerURL(new URL("http://127.0.0.1:8080/xwiki/xmlrpc")); XmlRpcClient rpcClient = new XmlRpcClient(); rpcClient.setConfig(clientConfig); ClientFactory factory = new ClientFactory(rpcClient); xwikiRpc = (ConfluenceRpcInterface)factory.newInstance(ConfluenceRpcInterface.class); to this Confluence rpc = new Confluence("http://127.0.0.1:8080/xwiki/xmlrpc"); And using swizzle for the tests will allow not only to test the xwiki implementation, but to validate that we are testing the right behavior by running the tests against a confluence instance (this can be done once when designing the test, not all the time). Using swizzle is however not enough. Additionally we need to ensure that the observable behavior of XWiki matches that of Confluence. For example we will need to adjust the way we deal with page modifications and histories to the way Confluence does it. And we will need to mirror even strange behavior in Confluence. For example we will need to convert all non-string primitive values (e.g int, Date) into strings in the maps and lists that get exchanged between the client and server. Even if this is strange, this is how Confluence does it and this is how clients (like the ones using swizzle) expect their results. I'm already working on these modifications and if everybody agrees they will make it into the trunk after the M4 release. The easiest way to adapt clients to these changes will be to make them use swizzle. Regards, Catalin

18 years, 1 month

4
4
0 0

Problems with Permissions in XWiki Cache

by georg.mayrhauser＠jku.at

Hi! We have a (maybe very small) problem that keeps us busy for weeks now, and we do not find the solution. We want to create XWiki-documents from another web-application and set also the document-rights depending on the rights the user has in that other web-application. Creating the document works very fine and also the document-rights are set correctly in the database. But with the document-rights we unfortunately have (presumably) problems with the cache. When a user opens the link to a XWiki-document, the document-rights of that document are newly set before the document is openend. So when user "1" opens a new XWiki-document, the user "XWiki.1" (xws_value) is entered in the db-table "xwikistrings" along with the value "users" in the "xws_name"-column (xws_id of the document). And that user can then correctly see the XWiki-document. But when a second user "2" wants to open that same document, he only gets the message "You are not allowed to view this document or perform this action" although he is correctly entered in the "xwikistrings"-table: xws_id = id of document; xws_name = users; xws_value = "XWiki.1,XWiki.2". That second user can see the document not until a $xwiki.flushcache() is performed (which is not easy to automatically realize in that process) or the tomcat is restartet. A com.xpn.xwiki.XWiki.flushCache() in our Java-Code - which would serve us best - does somehow not have the desired effect. If we run XWiki without Cache (xwiki.store.cache) our procedure works also correctly. Hence, it seems like flushing the cache from our java-code does not work for any reason. Here is our code for setting the document-rights: private boolean doUpdateRight(String fullname, String user, String group, String level, boolean allow, boolean global) throws XWikiException { this.xdoc = xwiki.getDocument(fullname, context); this.bobj = new BaseObject(); this.bobj.setName(fullname); if (global) this.bclass = xwiki.getGlobalRightsClass(context); else this.bclass = xwiki.getRightsClass(context); this.bobj = (BaseObject) xdoc.getObject(bclass.getName()); String oldusers = bobj.getStringValue("users"); if(!(oldusers.contains(user))) { bobj.setStringValue("users", oldusers+","+user); XWikiDocument tdoc; tdoc = xdoc; XWikiDocument olddoc = (XWikiDocument) tdoc.clone(); tdoc.setObject(bclass.getClassName(), 0, bobj); xwiki.saveDocument(tdoc, olddoc, context); xwiki.flushCache(); } return true; } When starting Xwiki we get the warning, that oscache.properties and oscache-local.properties are not loade although they are existing in the WEB-INF folder ([http-8080-Processor24] WARN com.xpn.xwiki.cache.impl.OSCacheService - Could not load cache properties oscache.properties: null [http-8080-Processor24] WARN com.xpn.xwiki.cache.impl.OSCacheService - Could not load cache properties oscache-local.properties: null). Could that have an influence on the XWiki-cache problem mentioned above? We are working with XWiki 1.0 We would be very pleased if anybody could help us out. We do have no further ideas what else to try :-( Thanks in advance! Georg

18 years, 1 month

2
1
0 0

Two idea of base core tools : SuperClass and XWikiApplication

by Thomas Mortagne

Hello, First of all sorry for the my english, I hope it's understandable. For the multiwiki plugin (mostly used for XEM product) needs I had started to make some JAVA tools mostly for plugins development that can be useful for others. I will expose you the ideas to let everyone discuss around and see what I can change. First implementation (to illustrate) of theses ideas are in jira. SUPERCLASS: http://jira.xwiki.org/jira/browse/XWIKI-1576 First the "SuperClass" concept: not very original (inspired by "com.xpn.xwiki.plugin.userdirectory.Group" class), it's a Xwiki Class and Xwiki Object management tool. It automate some very common actions and assure that needed Class document exist and is valid. It's composed in two interfaces and their abstract default implementations : ISuperClass (and AbstractSuperClass) and IsuperDocument (and IsuperDocument). SuperClass : manage the Xwiki Class document : - first it assure that when using it the class exists in the database with all needed feelds. Not only the Class but also the ClassSheet and the ClassTemplate documents. - it generate, based on the actual pseudo xwiki product implementation norm, all the "ClassName", "FullClassName", "ClassSpace", "ClassSheetName", etc. SuperDocument : manage document containing one instance object of this XwikiClass : just encapsulate XwikiDocument and Document and simplify creation, saving, deleting, merging. These two java classes had to be extended with the type we want to manage (Group, User, Application, Wiki, etc.). XWIKI APPLICATION: http://jira.xwiki.org/jira/browse/XWIKI-1577 (also a example of "SuperClass" use) To create a new sub wiki in XEM from template I need to determine in the "template" wiki which document have to be copied and which included. For this I think that have a real "Xwiki Application" descriptor can be very useful. My implementation is composed in a mainly document that contains all application configuration: - application name (that can be different from Document name) - other applications dependencies - document that application contains (that is not in other applications dependencies) - in theses documents which have to be included and other field that I had not implemented yet but can be very soon: - plugins dependencies - in theses document which have to be linked (need that XWiki support this concept) For now my "application packager" just give to the actual xwiki xar packager all the documents including applications descriptors documents and make a xar file with all this. I think an other format that a maven plugin can parse like XML application descriptor to generate the package combining all the applications dependencies can be made later. Regards, Thomas

18 years, 1 month

1
0
0 0

1.1 Release dates and Rollbacking "History storage" patch

by Vincent Massol

Hi, We've just committed the patch for XWIKI-1459 yesterday. However we may need to rollback it. Let me explain the situation: 1) It's a big and dangerous patch 2) The Curriki project is currently building on top of XWiki trunk and they're doing some important release soon. 3) They understand that using XWiki trunk is risky and they're going to branch off xwiki trunk real soon (I heard it's planned for next week) 4) They have some test server and it seems the recent commit broke a few things. No investigations done yet. As a consequence, they're asking us if we could rollback that patch and release 1.1M4 without it so that they can branch at 1.1M4. We can then apply the patch after. The problem is that 1.1M4 was supposed to be our last release with new features and 1.1M5/M6 were supposed to be 1.1RC1/RC2 till the final release planned for the 3rd of September. I don't think we'll be able to release a good 1.1 version if we only have one release for hunting down bug fixes. I also think Curriki is right in that committing such a big change one or 2 days before a release is asking for trouble... Thus I'd like to propose the following: A) We rollback the patch and release 1.1M4 without it B) We shift the final 1.1 release by 15 days - New date: 17th of September. We add one release: 1.1M5 and then 1.1RC1 and 1.1RC2 C) We add this patch in 1.1M5. However we don't generally allow any other important change unless there's a good reason. I.e. we consider 1.1M5 almost like a RC except for this patch WDYT? Thanks -Vincent

18 years, 1 month

8
11
0 0

Re: [xwiki-commits] Build XWiki Enterprise::Default #94 failing (5 tests passed)

by Sergiu Dumitriu

Again, can't we do something about the localhost link? On 8/7/07, teamcity(a)xwiki.org <teamcity(a)xwiki.org> wrote: > Build XWiki Enterprise::Default #94 failing (5 tests passed) > Agent: Default agent > Build results: http://localhost:8111/viewLog.html?buildId=497&buildTypeId=bt7 > > -- http://purl.org/net/sergiu

18 years, 1 month

2
1
0 0

Re: [xwiki-dev] XECLIPSE.R.1.0.M1

by Vincent Massol

Hi Tharindu, (I've copied the dev list, please send all dev related information to the list please so that we're all on the same page) See below. On Aug 6, 2007, at 8:34 AM, tharindu jayasuriya wrote: > Hi Vincent, > > Sorry about the late reply. > > I have mistaken the XWiki account information with object web details. > > Tharindu - tharinduj > > Asiri - asiri (newly created) Done. You can now do commits on xwiki-sandbox/xeclipse. > ---------------------------------------------------------------------- > ------------ > > Also, we need some help regarding XEclipse off-line. We are > struggling bit to find a place to start development. And one more > question, do we need to complete the off-line operation mode within > GSoC time period ? we're having trouble with academic work load. I think you need to provide a simple offline feature which is the ability to: - save pages locally (I recall there's an easy eclipse api for this) - ability to choose what to download from the server: a page, a full space or a full wiki - ability to check if the page isn't more recent on the server on save and if so warn the user and let him decide what to do: overwrite the server version or cancel - ability to refresh one's own copy of saved pages with the server's versions Basically this means everything except the hard part which is the synchronization. Let me know if this is possible but I don't think this is too hard to do and it's important for such a tool I think. Now I haven't reviewed what's left you have to do for 1.1M2 but that needs to be finished as a priority. Let me know if you have any schedule issues with this and we'll try to find a solution. I'll work on the m2 build this coming week to help you. Thanks -Vincent > On 8/4/07, Vincent Massol <vincent(a)massol.net> wrote: > Hi Tharindu, > > I've tried adding both of you but your ids don't exist on > forge.objectweb.org... > > I've committed xeclipse into xwiki-sandbox but you don't have > write access yet as I couldn't add you... > > Thanks > -Vincent > > On Aug 3, 2007, at 5:56 PM, tharindu jayasuriya wrote: > >> Hi Vincent, >> >> On 8/3/07, Vincent Massol <vincent(a)massol.net > wrote: >> Hi Tharindu/Asiri, >> >> I have reviewed the patch and it looks good. Only potential issue >> is the package name you've used: org.xwiki.plugins. So far we've >> used com.xpn.xwiki.*. However you're correct that we want to move >> to org.xwiki. That said we need to decide if we want to do the >> move right now for the Eclipse extension. I think it's a good idea >> to do so and the strategy would be that any new extension/plugin >> or any component in the new architecture should be located in the >> org.xwiki package. What do others think? >> >> I'm going to commit it to xwiki-sandbox for now (till we have a >> maven2 build for it, then I'll move it to xwiki-extensions/ >> eclipse) and we have already voted to give you access to it. >> >> Thanks a lot. We were thinking about moving into implementing the >> off-line operations asap, i think we need to take few design >> decisions upfront regarding off-line operations (mainly issues >> regarding synchronization). I'll make a post once we have thought >> about an initial idea so that we can optimize it on the dev list. >> >> I'll just need your ObjectWeb user id to give you write access. >> >> Tharindu - tharindujayasuriya >> >> Asiri - asiri >> >> Thanks. >> >> - Tharindu & Asiri >> >> Thanks >> -Vincent >> >> On Jul 31, 2007, at 2:45 PM, Vincent Massol wrote: >> >>> Hi Tharindu, >>> >>> I'll review this latest patch later today or tomorrow. >>> >>> Thanks >>> -Vincent >>> >>> On Jul 28, 2007, at 7:32 PM, tharindu jayasuriya wrote: >>> >>>> Hi All, >>>> >>>> Attached are the latest sources and binaries of XEclipse m1. >>>> >>>> Issues Fixed, >>>> >>>> 1. All Jigloo dependencies removed. >>>> >>>> 2. Code documentation improved according to instructions from >>>> Vincent. >>>> >>>> 3. Back-End XML RPC's patched to suite XEclipse (Asiri) >>>> >>>> http://jira.xwiki.org/jira/browse/XWIKI-1520 >>>> >>>> http://jira.xwiki.org/jira/browse/XWIKI-1521 >>>> >>>> http://jira.xwiki.org/jira/browse/XWIKI-1524 >>>> >>>> Let's hope this would finalize XEclipse m1 ... :) >>>> >>>> Hoping to hear from you soon... >>>> >>>> Thanks. >>>> >>>> - Tharindu & Asiri >>>> >>>> On 7/16/07, Vincent Massol < vincent(a)massol.net > wrote: >>>> Hi Tharindu, >>>> >>>> I have done a first pass on the code review and I have a few >>>> comments: >>>> >>>> 1) You seem to have use Cloudgarden's Jigloo and unfortunately >>>> the license isn't good enough for us so we cannot use it... >>>> Here's what it says in the generated file: >>>> >>>> /** >>>> * This code was edited or generated using CloudGarden's Jigloo >>>> SWT/Swing GUI Builder, which is free >>>> * for non-commercial use. If Jigloo is being used commercially >>>> (ie, by a corporation, company or >>>> * business for any purpose whatever) then you should purchase a >>>> license for each developer using >>>> * Jigloo. Please visit www.cloudgarden.com for details. Use of >>>> Jigloo implies acceptance of these >>>> * licensing terms. A COMMERCIAL LICENSE HAS NOT BEEN PURCHASED >>>> FOR THIS MACHINE, SO JIGLOO OR THIS >>>> * CODE CANNOT BE USED LEGALLY FOR ANY CORPORATE OR COMMERCIAL >>>> PURPOSE. >>>> */ >>>> >>>> We cannot use Jigloo because we want commercial companies using >>>> XWiki under the LGPL license. Thus we cannot commit this code. >>>> >>>> Could you find some alternative? The UI doesn't seem too complex >>>> so I should be easy to do it by hand I think. >>>> >>>> 2) Thanks for your javadoc. It's nice and helps a lot. However >>>> it can be improved, especially for Classes. This is the most >>>> important Javadoc and should answer the question "what is the >>>> class for?". >>>> >>>> Also please see: >>>> http://www.xwiki.org/xwiki/bin/view/Community/ >>>> CodeStyle#HDonotuse27public27ininterfaces >>>> http://www.xwiki.org/xwiki/bin/view/Community/ >>>> CodeStyle#HDonotduplicatemethodcommentswithparameterscomments >>>> >>>> Parameters and return value shouldn't start with "-" in javadoc. >>>> See the Sun's Javadoc coding conventions. >>>> >>>> 3) Please add copyright to all classes and don't use the @author >>>> tag. Instead we'll add Asiri and yourself to the Hall of Fame + >>>> in the SVN commits. >>>> >>>> The rest sounds good. We need to add maven build of course. I'll >>>> start looking into that after we fix the points above. >>>> >>>> Also, I haven't coded plugins in Eclipse for a very very long >>>> time so I have no idea if what you've done is the right way of >>>> doing it so I'll assume it is :-) >>>> >>>> Thanks again and keep up the good work! >>>> -Vincent >>>> >>>> On Jul 15, 2007, at 10:04 AM, tharindu jayasuriya wrote: >>>> >>>>> Hi all, >>>>> >>>>> This is about r.1.0.m1 version of xeclipse (XWiki-Eclipse-Plugin). >>>>> >>>>> We have completed following tasks in this release, >>>>> >>>>> 1. Cleaned up source code ( need to be confirmed by Vincent ) >>>>> >>>>> 2. Implemented adding/deleting pages. >>>>> >>>>> - Adding pages does not seem to work correctly due to some >>>>> errors in XML-RPC implementation of XWiki, need to look into this. >>>>> - Removing pages does not work at all because the >>>>> corresponding XML-RPC is not implemented in XWiki. >>>>> >>>>> 3. Implemented adding/deleting spaces. >>>>> >>>>> - Adding spaces work fine. >>>>> - Deleting spaces does not work (RPC not implemented in XWiki) >>>>> >>>>> As it's obvious by now, we need to peek into XWiki internals to >>>>> get these issues fixed. But since we have a scheduled release >>>>> today (and these issues showed up all of a sudden), we thought >>>>> of finishing the work from the plugin's end and uploading the >>>>> relevant work. Anyway, those issues need to be fixed asap. >>>>> >>>>> We have tested the work on a stand alone (HSQLDB) Xwiki >>>>> installation, it would be really nice if someone can test the >>>>> plugin on a real server and confirm the results :) >>>>> >>>>> Vincent, I couldn't find an appropriate place to upload the >>>>> files in XWIKI JIRA, so i thought of attaching relevant files >>>>> into this email. I'm really sorry for any inconveniences. >>>>> >>>>> Hope to hear from you very soon. >>>>> >>>>> Thanks a lot! >>>>> >>>>> - Tharindu & Asiri >>>>> >> > >

18 years, 1 month

3
4
0 0

XEclipse Offline

by Asiri Rathnayake

Hi all, I have a few doubts that might arise when we're implementing off-line operation of XEclipse. 1. Currently, when the user saves a page after editing, no checks are made to ensure that if the same page has been modified by someone else at the same time. But avoiding this is a problem since that would require us to retrieve the page again (to check locks) every-time user tries to save a page. 2. Also, when a page is retrieved for the first time if there are any locks are present, we must convey that information to the user (in the extreme case, we can disallow any attempts to modify a page with any locks in it). 3. How permissions should be conveyed to users ? And how to handle them ? (currently, this is ignored) We can use different icons for all of these situations (for permissions , dirty pages etc.), but that would require a lot of icons (and we're running out of appropriate icons too). Any thoughts ? Thanks. - Asiri

18 years, 1 month

3
3
0 0

[XWiki V2] Componentizing XWiki with Plexus

by Vincent Massol

Hi, I've committed in the Sandbox a first shot at componentizing XWiki. The idea is to have concrete examples so that: 1) you can all see how it's meant to work 2) to validate we can use Plexus without having a single import on plexus in our components For 2), I can say it's been successful so far. I've grouped all Plexus stuff in the xwiki-plexus module and that's the only place where there are plexus imports. If we want to use another component system we should be able to do the same (provided that other component system is transparent too). Some more information: * Components are described in components.xml files (check them out) * I haven't committed the plexus.xml file that goes in xwiki-platform- web/standard/src/main/webapp/WEB-INF. See attached. There's plenty more to say but it'd be great if you could check this out and ask questions here and we'll go from there. I'm really happy with the result. I think it makes writing components a breeze and I really like the separation of concerns. Let's get all your questions answered and then we can decide how we want to integrate this in a XWiki release. Thanks -Vincent

18 years, 1 month

1
0
0 0

Re: [xwiki-commits] r4086 - xwiki-platform/xwiki-tools/trunk/xwiki-jetty-resources/src/main/resources

by Vincent Massol

Hi Sergiu, I think you also need to change the xwiki_start_debug.sh file. Thanks -Vincent On Aug 3, 2007, at 3:39 PM, Sergiu Dumitriu wrote: > Author: sdumitriu > Date: 2007-08-03 15:39:30 +0200 (Fri, 03 Aug 2007) > New Revision: 4086 > > Modified: > xwiki-platform/xwiki-tools/trunk/xwiki-jetty-resources/src/main/ > resources/start_xwiki.sh > Log: > XWIKI-1557: Starting XWiki messes the locale of the shell > Fixed > > > > Modified: xwiki-platform/xwiki-tools/trunk/xwiki-jetty-resources/ > src/main/resources/start_xwiki.sh > =================================================================== > --- xwiki-platform/xwiki-tools/trunk/xwiki-jetty-resources/src/main/ > resources/start_xwiki.sh 2007-08-03 00:43:54 UTC (rev 4085) > +++ xwiki-platform/xwiki-tools/trunk/xwiki-jetty-resources/src/main/ > resources/start_xwiki.sh 2007-08-03 13:39:30 UTC (rev 4086) > @@ -1,6 +1,5 @@ > #!/bin/sh > > -export LANG=fr_FR.ISO8859-1 > JETTY_HOME=. > JAVA_OPTS=-Xmx300m > > @@ -15,4 +14,4 @@ > echo Logs are in the logs/ directory > > mkdir -p logs 2>/dev/null > -nohup java $JAVA_OPTS -Dfile.encoding=iso-8859-1 -Djetty.port= > $JETTY_PORT -Djetty.home=$JETTY_HOME -jar $JETTY_HOME/start.jar > > logs/xwiki_output.log 2> logs/xwiki_errors.log & > +LANG=fr_FR.ISO8859-1 nohup java $JAVA_OPTS - > Dfile.encoding=iso-8859-1 -Djetty.port=$JETTY_PORT -Djetty.home= > $JETTY_HOME -jar $JETTY_HOME/start.jar > logs/xwiki_output.log 2> > logs/xwiki_errors.log & > > > > -- > You receive this message as a subscriber of the xwiki- > commits(a)objectweb.org mailing list. > To unsubscribe: mailto:xwiki-commits-unsubscribe@objectweb.org > For general help: mailto:sympa@objectweb.org?subject=help > ObjectWeb mailing lists service home page: http://www.objectweb.org/ > wws

18 years, 1 month

1
0
0 0

Patches for XML RPCs related to Xeclipse

by Asiri Rathnayake

Hi Vincent, I have completed patches on XML RPCs needed to continue work on Xeclipse. http://jira.xwiki.org/jira/browse/XWIKI-1520 http://jira.xwiki.org/jira/browse/XWIKI-1521 http://jira.xwiki.org/jira/browse/XWIKI-1524 Can you please verify these and apply them as you see fit ? Thanks a lot. - Asiri

18 years, 1 month

2
2
0 0

XECLIPSE.R.1.0.M1

by tharindu jayasuriya

Hi all, This is about r.1.0.m1 version of xeclipse (XWiki-Eclipse-Plugin). We have completed following tasks in this release, 1. Cleaned up source code ( need to be confirmed by Vincent ) 2. Implemented adding/deleting pages. - Adding pages does not seem to work correctly due to some errors in XML-RPC implementation of XWiki, need to look into this. - Removing pages does not work at all because the corresponding XML-RPC is not implemented in XWiki. 3. Implemented adding/deleting spaces. - Adding spaces work fine. - Deleting spaces does not work (RPC not implemented in XWiki) As it's obvious by now, we need to peek into XWiki internals to get these issues fixed. But since we have a scheduled release today (and these issues showed up all of a sudden), we thought of finishing the work from the plugin's end and uploading the relevant work. Anyway, those issues need to be fixed asap. We have tested the work on a stand alone (HSQLDB) Xwiki installation, it would be really nice if someone can test the plugin on a real server and confirm the results :) Vincent, I couldn't find an appropriate place to upload the files in XWIKI JIRA, so i thought of attaching relevant files into this email. I'm really sorry for any inconveniences. Hope to hear from you very soon. Thanks a lot! - Tharindu & Asiri

18 years, 1 month

3
11
0 0

Boolean fields in XWikiDocument & BaseCollection

by Thomas Mortagne

Hi XWikiers, In BaseClass there is possibility to add Boolean type field with "addBooleanField". In XwikiDocument (and then in BaseCollection), we use "getIntValue" and "setIntValue" to retrieve or set the value with 0=false and 1=true. It's very simple but I think a "get/setBooleanValue" that do the conversion would be much more readable and avoid developper to search how boolean values are really stored. Regards, Thomas Mortagne

18 years, 1 month

3
3
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

xwiki-devs