- xwiki-devs@xwiki.org - lists.xwiki.org

by Vincent Massol

Hi, The current header copyright says: "Copyright 2006-2007, XpertNet SARL, and individual contributors as indicated by the contributors.txt." 2 issues: - The sentence is not english - We don't have such a file I propose that we change it in favor of: "Copyright 2006-2007, XpertNet SARL, and individual contributors." Main Reason: - We don't specify where the contributors are listed which means we can decide to change that location. For example a list of contributors is on http://www.xwiki.org/xwiki/bin/view/Community/ HallOfFame#HContributors but it's far from being accurate. Tomorrow we may use another strategy or another location and we'd rather not change all headers. So better not specify where we define them. Another location is SVN. Here's my +1 to that. I also propose that we continue listing contributors on that HallOfFame page. Unfortunately I've been the only one adding names there. I need help. Thanks -Vincent

18 years, 1 month

7
6
0 0

Re: [xwiki-commits] r4049 - in xwiki-platform/xwiki-applications/trunk/panels: . src/main/resources/Panels

by Vincent Massol

Hi Catalin, That's cool. I think I had a jira issue in XE for fixing all orphaned links for 1.1M4. If you do more fixes of this kind maybe you could use that jira issue # in the commit (you may want to create other issues if your changes are not in the XE JIRA though. Thanks -Vincent On Jul 28, 2007, at 3:59 PM, Catalin Hritcu wrote: > Author: hritcu > Date: 2007-07-28 15:59:52 +0200 (Sat, 28 Jul 2007) > New Revision: 4049 > > Removed: > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/New Panel > Modified: > xwiki-platform/xwiki-applications/trunk/panels/ > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/AddClassProperty > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/AddObject > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/Backlinks > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/BlogCategories > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/ClassEditorWelcome > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/ClassSwitcher > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/CreatePanel > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/DocumentInformation > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/EditTranslations > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/GlobalRightsEditorWelcome > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/HomePageUpdate > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/IncludedDocuments > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/Members > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/MyRecentModifications > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/Navigation > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/NewPage > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/ObjectEditorWelcome > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/OrphanedPages > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/PanelClass > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/PanelLayoutUpdate > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/PanelSheet > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/PanelTemplate > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/PanelWizard > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/QuickLinks > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/Recently Created > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/Recently Modified > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/RecentlyVisited > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/RightsEditorWelcome > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/RightsHelp > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/RightsTips > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/Search > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/Shortcuts > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/SpaceDocs > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/Spaces > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/SyntaxHelp > xwiki-platform/xwiki-applications/trunk/panels/src/main/ > resources/Panels/Tags > Log: > Added svn:ignore for Eclipse project files > > XAPANELS-33: If it says Valid XHTML, then it MUST be valid XHTML. > All documents fixed > > Setting the parent for all panels.

18 years, 1 month

1
0
0 0

[Proposal] Solution for filtering out pages in the XE wiki

by Vincent Massol

Hi, We need a global solution for including/excluding pages in the XE wiki. The needs comes from the fact that we shouldn't show internal pages to casual xwiki users and we shouldn't show pages that they don't have the rights to view. At least the following places need to use this feature: * Navigation panel * All docs Treeview * All docs Index * WebSearch * WebSearchRss * WebRss * Orphaned pages + Panel I propose the following implementation: 1) Add a new API $xwiki.filterDocuments(List docNamesList, String persmissionToCheck). It would be used like this: for each ($item in $xwiki.filterDocuments($xwiki.searchDocuments ($sql), "view")) ... In the XE wiki: 2) Add a XWiki.PageFiltersClass class with 1 property: Includes. This property will contain pages to exclude, using HQL like format (one entry per line) 3) Add a XWiki.PageFiltersClassSheet to explain what this is about, explain how to add/remove entries, etc 4) Add a XWiki.PageFilters document that contains a XWiki.PageFiltersClass object and which has velocity code in its wiki content to compute the HQL clause corresponding to the exclusions specified in its object. 5) Modify the documents listed above to use XWiki.PageFilters as follows: #includeInContext("XWiki.PageFilters") #if (!$pageFiltersSqlClause) #set ($pageFiltersSqlClause = "") #end #set ($sql = ".... and $pageFiltersSqlClause ...") #set ($list = $xwiki.filterDocuments($xwiki.searchDocuments($sql , $nb , 0), "view")) ... WDYT? Thanks -Vincent

18 years, 1 month

2
1
0 0

using XAR pages to modify user details

by Radu Danciu

Could anybody point me towards some documentation about how to write/use xar files? Thanks, Radu

18 years, 1 month

3
2
0 0

[Proposal] Document history storage

by Sergiu Dumitriu

Hi, Sometime ago, there was a discussion regarding how should the document history be stored in a better way. Right now, the complete history is stored as one field in the xwikidoc table. From my PoV, this has some major disadvantages: - loading an older version requires parsing all the history -> memory inefficiency - as the documents grow older, loading a document will take a lot of time -> time inefficiency - queries on archives cannot return just one version, but they match the whole document (somewhere in the history, there was a version containing "search term") The blocking issue with storing old version in a different table was, at that time, the fact that a document archive should contain all information needed for completely restoring the document, like content, metadata, objects. I don't think that is actually an issue. We are archiving document versions, but we're joining all versions in one large string. Why don't we archive the complete version, but one version per row? So, the archive table should look like: - document name - version number - language (for translations) - content - archived metadata (one field, or the same fields as in xwikidoc) - archived objects (one field) - attachment names and versions It is not like storing the version as a normal document is, with separate objects and properties, but at least it provides a better storage and retrieval mechanism, and it separates a bit the parts of a wikidocument - content, metadata, objects. WDYT? -- http://purl.org/net/sergiu

18 years, 1 month

4
10
0 0

Re: [xwiki-commits] Build XWiki Enterprise::Default #8 failing

by Sergiu Dumitriu

Why are there links to localhost? teamcity(a)xwiki.org wrote: > Build XWiki Enterprise::Default #8 failing > Agent: Default agent > Build results: http://localhost:8111/viewLog.html?buildId=30&buildTypeId=bt7 > > Changes included (1 change) > ==================================================== > Change 4048 by sdumitriu (2 files): > XE-30: If it says Valid XHTML, then it MUST be valid XHTML. > Fixed some documents. > > > see more information about changed files: http://localhost:8111/viewLog.html?tab=buildChangesDiv&buildId=30&buildType… > > > ============================================================================ > Configure email notifications: http://localhost:8111/profile.html?init=1#notifications > > >

18 years, 1 month

1
0
0 0

TeamCity is back

by Vincent Massol

ok, after fighting for 2 days, TeamCity is back working fine. http://teamcity.xwiki.org We had a disk full problem dues to the large size of our maven repos so I cleaned them all and then discovered the build on TC wasn't working anymore. This was due to several errors in the build which were hidden by the fact that the local repo on the TC machine had the artifacts there. To be more precise, in order to do a release with maven we cannot have any SNAPSHOT deps in our POM so we had to "release" some external dependencies we're using in SNAPSHOT version. One of these was the maven selenium plugin and I've discovered that faking a release of an external maven plugin isn't as simple as it appears... But I now know how to do that. Thanks -Vincent

18 years, 1 month

1
0
0 0

About Copyright Statements...

by tharindu jayasuriya

Hi Vincent, We are going to add copyright statements to Xeclipse source, I think we can get them from xwiki sources, please let us know if you have any concerns... Btw, is it Xeclipse or XEclipse ? :) Thanks. - Tharindu & Asiri

18 years, 1 month

3
2
0 0

Re: Build XWiki Platform Web::Maven2 #217 failed

by Vincent Massol

All those errors were caused by some disk space issue that has been fixed now. -Vincent On Jul 24, 2007, at 2:18 PM, teamcity(a)xwiki.org wrote: > Build XWiki Platform Web::Maven2 #217 failed > Agent: Default agent > Build results: http://teamcity.xwiki.org/viewLog.html? > buildId=1395&buildTypeId=bt7 > > Changes included (1 change) > ==================================================== > Change 4019 by vmassol (1 file): > XWIKI-1519: The version shouldn't come from xwiki.cfg file > > see more information about changed files: http://teamcity.xwiki.org/ > viewLog.html?tab=buildChangesDiv&buildId=1395&buildTypeId=bt7 > > > ====================================================================== > ====== > Configure email notifications: http://teamcity.xwiki.org/ > profile.html?init=1#notifications

18 years, 1 month

2
2
0 0

Change of SVN externals for trunks-users

by Vincent Massol

Hi, I'm about to modify the SVN externals definition for trunks-users so that they point to our own XWiki readonly SVN repo instead of pointing to the OW repo as there are issues with it. If you have checked out trunks-users, then do a svn update once I've made the change. Hopefully that'll just work. If not, you might need to do a new checkout. Sorry for that Thanks -Vincent

18 years, 1 month

3
5
0 0

[VOTE] Include Foxwiki project in our main source tree and vote Rick Kenney as committer for it

by Vincent Massol

Hi, Rick Kenney has fixed the Foxwiki plugin available in our sandbox (it was initially created by Robin Fernandes - Site is here: http:// soal.xwiki.com/xwiki/bin/view/Code/FoXWiki). Rick has tried to contact Robin without success so far. We need to find out under what license it is. But assuming the license is correct and Robin agrees, I'd like us to vote on including it as part of our releases. This means we are agreeing to maintaining it. Rick has agreed to maintain it, so if we agree I'll vote to get him write access to it so that he can be the maintainer for it. If we agree on this, I propose the following: 1) Rick creates a JIRA issue in the XWiki Platform project for now, component "Other" and attach his working version to it 2) I create the extension area for foxwiki in our SVN and apply your patch there. I had already proposed such an area which we also need for the Eclipse integration. 3) I also create the maven build for it so that it can be built as part of our CI 4) I create a JIRA project for it and move your issue to it 5) I do a release of it (version 1.0) with maven in our remote maven repo 6) I create an extension page for it on xwiki.org (in the Code Zone, Extension section) and link to the download location on our remote maven repo 7) I create a blog post on xwiki.org to announce the new project and the availability of the 1.0 version 8) From there on, people create JIRA issues for it in its jira project and Rick acts on them. I can act as the release manager whenever a new version is ready Here's my +1 for both including Foxwiki and voting Rick as committer for *that* project only. Thanks -Vincent

18 years, 1 month

3
3
0 0

[VOTE] Postpone XWiki 1.1M4 by one week?

by Vincent Massol

Hi developers, I'm on semi-holiday next week and I'll have only limited internet connectivity so it's going to be difficult to upload the 500MB that are required when performing a release. I can see 3 options: 1) Someone else does the release 2) I do the release on this coming Friday (the 27th) 3) We postpone by one week the release (6th of August) As 1.1M4 is our last release before the RCs start, I think the best is to postpone it by one week so that we have more time to add new features into it. However I'd like the 1.1M5 (to be renamed 1.1RC1) to remain slated for the 20th of August. So here's my +1 for postponing by 1 week the 1.1M4 release (unless someone else want to do the release but I doubt it :)). Thanks -Vincent

18 years, 1 month

5
6
0 0

What is password of Xwiki repository through SVN?

by Sarfraz ASHFAQ

Hello all I am currently working as Engineer in INRIA and we are working on XWIKI.When i want to get XWiki source using Console of my linux , i provided following coomand svn co svn://svn.forge.objectweb.org/svnroot/xwiki/trunks-devs But if require a password from me.Can you tell me please what is password for it? Waiting for Answer Sarfraz Inria , France

18 years, 1 month

5
8
0 0

Re: [xwiki-commits] r4015 - in xwiki-platform: core/trunk/src/main/java/com/xpn/xwiki/render/macro web/trunk/standard/src/main/webapp/tiny_mce/themes/wikieditor web/trunk/standard/src/main/webapp/tiny_mce/themes/wikieditor/images web/trunk/standard/src/main/webapp/wiki_editor web/trunk/standard/src/main/webapp/wiki_editor/plugins web/trunk/standard/src/main/webapp/wiki_editor/themes

by Vincent Massol

Hi Nam, You've modified the style macro to add a new align parameter. For this you need: 1) A separate JIRA issue! 2) To update the documentation on http://www.xwiki.org/xwiki/bin/view/ Code/StyleMacro Can you please implement both? Thanks -Vincent On Jul 24, 2007, at 1:25 PM, Phung Hai Nam wrote: > Author: namphunghai > Date: 2007-07-24 13:25:45 +0200 (Tue, 24 Jul 2007) > New Revision: 4015 > > Added: > xwiki-platform/web/trunk/standard/src/main/webapp/tiny_mce/ > themes/wikieditor/images/justifycenter.gif > xwiki-platform/web/trunk/standard/src/main/webapp/tiny_mce/ > themes/wikieditor/images/justifyfull.gif > xwiki-platform/web/trunk/standard/src/main/webapp/tiny_mce/ > themes/wikieditor/images/justifyleft.gif > xwiki-platform/web/trunk/standard/src/main/webapp/tiny_mce/ > themes/wikieditor/images/justifyright.gif > Modified: > xwiki-platform/core/trunk/src/main/java/com/xpn/xwiki/render/ > macro/StyleMacro.java > xwiki-platform/web/trunk/standard/src/main/webapp/tiny_mce/ > themes/wikieditor/editor_template.js > xwiki-platform/web/trunk/standard/src/main/webapp/wiki_editor/ > plugins/core.js > xwiki-platform/web/trunk/standard/src/main/webapp/wiki_editor/ > themes/default.js > xwiki-platform/web/trunk/standard/src/main/webapp/wiki_editor/ > wiki_editor.js > Log: > Fixed XWIKI 370 : to be able to justify text left center right full > > Modified: xwiki-platform/core/trunk/src/main/java/com/xpn/xwiki/ > render/macro/StyleMacro.java > =================================================================== > --- xwiki-platform/core/trunk/src/main/java/com/xpn/xwiki/render/ > macro/StyleMacro.java 2007-07-24 07:42:22 UTC (rev 4014) > +++ xwiki-platform/core/trunk/src/main/java/com/xpn/xwiki/render/ > macro/StyleMacro.java 2007-07-24 11:25:45 UTC (rev 4015) > @@ -50,6 +50,7 @@ > String type = params.get("type"); > String id = params.get("id"); > String classes = params.get("class"); > + String align = params.get("align"); > String name = params.get("name"); > String size = params.get("font-size"); > String font = params.get("font-family"); > @@ -117,6 +118,9 @@ > if ((!"none".equals(name)) && (name != null) && (!"".equals > (name.trim()))) { > str.append("name=\"" + name.trim() + "\" "); > } > + if ((!"none".equals(align)) && (align != null) && > (!"".equals(align.trim()))) { > + str.append("align=\"" + align.trim() + "\" "); > + } > > str.append("style=\""); > > > Modified: xwiki-platform/web/trunk/standard/src/main/webapp/ > tiny_mce/themes/wikieditor/editor_template.js > =================================================================== > --- xwiki-platform/web/trunk/standard/src/main/webapp/tiny_mce/ > themes/wikieditor/editor_template.js 2007-07-24 07:42:22 UTC (rev > 4014) > +++ xwiki-platform/web/trunk/standard/src/main/webapp/tiny_mce/ > themes/wikieditor/editor_template.js 2007-07-24 11:25:45 UTC (rev > 4015) > @@ -258,8 +258,59 @@ > template['height'] = 250; > > tinyMCE.openWindow(template, {editor_id : editor_id, inline : > "yes"}); > - return true; > + return true; > > + case "JustifyLeft": > + var focusElm = > tinyMCE.selectedInstance.getFocusElement(); > + if (focusElm && (focusElm.nodeName == "P")) { > + tinyMCE.execInstanceCommand(editor_id, > "FormatBlock", false, "<div>"); > + var selectedElm = > tinyMCE.selectedInstance.selection.getFocusElement(); > + selectedElm.setAttribute('align', 'left'); > + } else { > + return wikiEditor.execCommand(editor_id, > element, "justifyLeft", user_interface, value); > + } > + tinyMCE.triggerNodeChange(); > + return true; > + > + case "JustifyCenter": > + > + var focusElm = > tinyMCE.selectedInstance.getFocusElement(); > + if (focusElm && (focusElm.nodeName == "P")) { > + tinyMCE.execInstanceCommand(editor_id, > "FormatBlock", false, "<div>"); > + var selectedElm = > tinyMCE.selectedInstance.selection.getFocusElement(); > + selectedElm.setAttribute('align', 'center'); > + } else { > + return wikiEditor.execCommand(editor_id, > element, "justifyCenter", user_interface, value); > + } > + tinyMCE.triggerNodeChange(); > + return true; > + > + case "JustifyRight": > + > + var focusElm = > tinyMCE.selectedInstance.getFocusElement(); > + if (focusElm && (focusElm.nodeName == "P")) { > + tinyMCE.execInstanceCommand(editor_id, > "FormatBlock", false, "<div>"); > + var selectedElm = > tinyMCE.selectedInstance.selection.getFocusElement(); > + selectedElm.setAttribute('align', 'right'); > + } else { > + return wikiEditor.execCommand(editor_id, > element, "justifyRight", user_interface, value); > + } > + tinyMCE.triggerNodeChange(); > + return true; > + > + case "JustifyFull": > + > + var focusElm = > tinyMCE.selectedInstance.getFocusElement(); > + if (focusElm && (focusElm.nodeName == "P")) { > + tinyMCE.execInstanceCommand(editor_id, > "FormatBlock", false, "<div>"); > + var selectedElm = > tinyMCE.selectedInstance.selection.getFocusElement(); > + selectedElm.setAttribute('align', 'justify'); > + } else { > + return wikiEditor.execCommand(editor_id, > element, "justifyFull", user_interface, value); > + } > + tinyMCE.triggerNodeChange(); > + return true; > + > default : > return wikiEditor.execCommand(editor_id, element, > command, user_interface, value); > } > > Added: xwiki-platform/web/trunk/standard/src/main/webapp/tiny_mce/ > themes/wikieditor/images/justifycenter.gif > =================================================================== > (Binary files differ) > > > Property changes on: xwiki-platform/web/trunk/standard/src/main/ > webapp/tiny_mce/themes/wikieditor/images/justifycenter.gif > ___________________________________________________________________ > Name: svn:mime-type > + application/octet-stream > > Added: xwiki-platform/web/trunk/standard/src/main/webapp/tiny_mce/ > themes/wikieditor/images/justifyfull.gif > =================================================================== > (Binary files differ) > > > Property changes on: xwiki-platform/web/trunk/standard/src/main/ > webapp/tiny_mce/themes/wikieditor/images/justifyfull.gif > ___________________________________________________________________ > Name: svn:mime-type > + application/octet-stream > > Added: xwiki-platform/web/trunk/standard/src/main/webapp/tiny_mce/ > themes/wikieditor/images/justifyleft.gif > =================================================================== > (Binary files differ) > > > Property changes on: xwiki-platform/web/trunk/standard/src/main/ > webapp/tiny_mce/themes/wikieditor/images/justifyleft.gif > ___________________________________________________________________ > Name: svn:mime-type > + application/octet-stream > > Added: xwiki-platform/web/trunk/standard/src/main/webapp/tiny_mce/ > themes/wikieditor/images/justifyright.gif > =================================================================== > (Binary files differ) > > > Property changes on: xwiki-platform/web/trunk/standard/src/main/ > webapp/tiny_mce/themes/wikieditor/images/justifyright.gif > ___________________________________________________________________ > Name: svn:mime-type > + application/octet-stream > > Modified: xwiki-platform/web/trunk/standard/src/main/webapp/ > wiki_editor/plugins/core.js > =================================================================== > --- xwiki-platform/web/trunk/standard/src/main/webapp/wiki_editor/ > plugins/core.js 2007-07-24 07:42:22 UTC (rev 4014) > +++ xwiki-platform/web/trunk/standard/src/main/webapp/wiki_editor/ > plugins/core.js 2007-07-24 11:25:45 UTC (rev 4015) > @@ -80,6 +80,7 @@ > this.addToolbarHandler('handleHorizontalRuleButtons'); > this.addToolbarHandler('handleSupAndSubButons'); > this.addToolbarHandler('handleTableButtons'); > + this.addToolbarHandler('handleAlignButtons'); > > // Add Comands and Fix Commands(workarounds) > this.addCommand('Title', 'titleCommand'); > @@ -392,6 +393,47 @@ > tinyMCE.switchClass(editor_id + '_table', 'mceButtonNormal', > false); > } > > +WikiEditor.prototype.handleAlignButtons = function(editor_id, > node, undo_index, undo_levels, visual_aid, any_selection) { > + tinyMCE.switchClass(editor_id + '_justifyleft', > 'mceButtonNormal'); > + tinyMCE.switchClass(editor_id + '_justifyright', > 'mceButtonNormal'); > + tinyMCE.switchClass(editor_id + '_justifycenter', > 'mceButtonNormal'); > + tinyMCE.switchClass(editor_id + '_justifyfull', > 'mceButtonNormal'); > + > + var alignNode = node; > + var breakOut = false; > + do { > + if (!alignNode.getAttribute || !alignNode.getAttribute > ('align')) > + continue; > + > + switch (alignNode.getAttribute('align').toLowerCase()) { > + case "left": > + tinyMCE.switchClass(editor_id + '_justifyleft', > 'mceButtonSelected'); > + breakOut = true; > + break; > + > + case "right": > + tinyMCE.switchClass(editor_id + '_justifyright', > 'mceButtonSelected'); > + breakOut = true; > + break; > + > + case "middle": > + case "center": > + tinyMCE.switchClass(editor_id + '_justifycenter', > 'mceButtonSelected'); > + breakOut = true; > + break; > + > + case "justify": > + tinyMCE.switchClass(editor_id + '_justifyfull', > 'mceButtonSelected'); > + breakOut = true; > + break; > + } > + } while (!breakOut && (alignNode = alignNode.parentNode) != > null); > + > + var div = tinyMCE.getParentElement(node, "div"); > + if (div && div.style.textAlign == "center") > + tinyMCE.switchClass(editor_id + '_justifycenter', > 'mceButtonSelected'); > +} > + > WikiEditor.prototype.handleTitlesList = function(editor_id, node, > undo_index, undo_levels, visual_aid, any_selection) { > var list = document.getElementById(editor_id + "_titleSelect"); > if(list) { > @@ -578,6 +620,29 @@ > return str; > } > > +WikiEditor.prototype.getJustifyToolbar = function() { > + return this.getJustifyControls('justifyleft') + > this.getJustifyControls('justifycenter') + this.getJustifyControls > ('justifyright') + this.getJustifyControls('justifyfull'); > +} > + > +WikiEditor.prototype.getJustifyControls = function(button_name) { > + var str = ""; > + switch (button_name) { > + case 'justifyleft': > + str = this.createButtonHTML('justifyleft', > 'justifyleft.gif', 'lang_justifyleft_desc', 'JustifyLeft'); > + break; > + case 'justifycenter': > + str = this.createButtonHTML('justifycenter', > 'justifycenter.gif', 'lang_justifycenter_desc', 'JustifyCenter'); > + break; > + case 'justifyright' : > + str = this.createButtonHTML('justifyright', > 'justifyright.gif', 'lang_justifyright_desc', 'JustifyRight'); > + break; > + case 'justifyfull' : > + str = this.createButtonHTML('justifyfull', > 'justifyfull.gif', 'lang_justifyfull_desc', 'JustifyFull'); > + break; > + } > + return str; > +} > + > WikiEditor.prototype.getSupAndSubToolbar = function() { > return this.getSupAndSubControls('sup') + > this.getSupAndSubControls('sub'); > } > @@ -705,6 +770,7 @@ > '<option value="3">{$lang_wiki_title_3}</option>' + > '<option value="4">{$lang_wiki_title_4}</option>' + > '<option value="5">{$lang_wiki_title_5}</option>' + > + '<option value="6">{$lang_wiki_title_6}</option>' + > '</select>'; > } > > @@ -1130,7 +1196,7 @@ > WikiEditor.prototype.convertStyleExternal = function(regexp, > result, content) { > var str = ""; > var atts = result[1].split("|"); > - var tag = "font", style = "", myclass = "", id = "", name = > "", doc = ""; > + var tag = "font", style = "", myclass = "", id = "", name = > "", doc = "", align = ""; > var hasIcon = false; > for (var i=0; i < atts.length; i++) { > var att = this.trimString(atts[i].substring(0, atts > [i].indexOf("="))); > @@ -1147,6 +1213,9 @@ > else if (att == "type") { > tag = value; > } > + else if (att == "align") { > + align = value; > + } > else if (att == "icon") { > style += "background-image: url(" + value + ");"; > hasIcon = true; > @@ -1166,6 +1235,9 @@ > if (name != "") { > str += " name=\"" + name + "\""; > } > + if (align != "") { > + str += " align=\"" + align + "\""; > + } > if (style != "") { > str += " style=\"" + style + "\""; > } > @@ -1193,6 +1265,9 @@ > if (attributes["id"]) { > str += "|id=" + attributes["id"] ; > } > + if (attributes["align"]) { > + str += "|align=" + attributes["align"] ; > + } > if (attributes["class"] && attributes["class"] != > "stylemacro") { > str += "|class=" + attributes["class"] ; > } > > Modified: xwiki-platform/web/trunk/standard/src/main/webapp/ > wiki_editor/themes/default.js > =================================================================== > --- xwiki-platform/web/trunk/standard/src/main/webapp/wiki_editor/ > themes/default.js 2007-07-24 07:42:22 UTC (rev 4014) > +++ xwiki-platform/web/trunk/standard/src/main/webapp/wiki_editor/ > themes/default.js 2007-07-24 11:25:45 UTC (rev 4015) > @@ -21,6 +21,9 @@ > case "texttoolbar": > str += this.getTextToolbar(); > break; > + case "justifytoolbar": > + str += this.TOOLBAR_SPACER + this.getJustifyToolbar > (); > + break; > case "listtoolbar": > str += this.TOOLBAR_SPACER + this.getListToolbar(); > break; > > Modified: xwiki-platform/web/trunk/standard/src/main/webapp/ > wiki_editor/wiki_editor.js > =================================================================== > --- xwiki-platform/web/trunk/standard/src/main/webapp/wiki_editor/ > wiki_editor.js 2007-07-24 07:42:22 UTC (rev 4014) > +++ xwiki-platform/web/trunk/standard/src/main/webapp/wiki_editor/ > wiki_editor.js 2007-07-24 11:25:45 UTC (rev 4015) > @@ -76,7 +76,7 @@ > params["use_linkeditor_tabs"] = "wiki_tab, web_tab, > attachments_tab, email_tab, file_tab"; > } > if((params["wiki_editor_toolbar"] == null) || (params > ["wiki_editor_toolbar"].toString() == "")) { > - params["wiki_editor_toolbar"] = "texttoolbar, listtoolbar, > indenttoolbar, undotoolbar, titletoolbar, styletoolbar, " > + params["wiki_editor_toolbar"] = "texttoolbar, > justifytoolbar, listtoolbar, indenttoolbar, undotoolbar, > titletoolbar, styletoolbar, " > + "horizontaltoolbar, > symboltoolbar, attachmenttoolbar, macrostoolbar, tabletoolbar, " > + "tablerowtoolbar, > tablecoltoolbar, linktoolbar"; > } > > > > -- > You receive this message as a subscriber of the xwiki- > commits(a)objectweb.org mailing list. > To unsubscribe: mailto:xwiki-commits-unsubscribe@objectweb.org > For general help: mailto:sympa@objectweb.org?subject=help > ObjectWeb mailing lists service home page: http://www.objectweb.org/ > wws

18 years, 1 month

1
0
0 0

removeSpace RPC & Xeclipse

by Asiri Rathnayake

Hi All, We were silent for few days due to mid-semester work load (still have some unfinished business). Anyway, I have added the removeSpace RPC to xwiki back-end. But now i'm having few doubts about it. The remove space RPC works by retrieving all the page names under the given space and deleting them individually. But following complications may happen when using this RPC, 1. If the user does not have enough privileges to delete some of the pages within that space, an exception will be thrown half-way down. Now the RPC invoker does not know which pages were removed and which were not. (Thus, he is out of sync with the wiki) 2. If instead we chose to remove page by page from the client - Xeclipse (say), we don't have this problem , and we could even display a progress bar. (to indicate that pages are being deleted). Since the XML RPC API requires the removeSpace() RPC, we must indeed add it. But wouldn't it be better if we do not use this RPC within Xeclipse (due to reasons mentioned above) ? Or, is there a better way to implement removeSpace() RPC ? (like checking privileges before doing anything ?) ) (+ How ? ) Thanks a lot. Best Regards, - Asiri

18 years, 1 month

3
13
0 0

Re: [xwiki-commits] r4023 - xwiki-products/xwiki-enterprise/trunk/distribution-test/src/test/it/com/xpn/xwiki/it

by Vincent Massol

Hi Catalin, On Jul 25, 2007, at 12:25 PM, Catalin Hritcu wrote: > Author: hritcu > Date: 2007-07-25 12:25:45 +0200 (Wed, 25 Jul 2007) > New Revision: 4023 > > Modified: > xwiki-products/xwiki-enterprise/trunk/distribution-test/src/test/ > it/com/xpn/xwiki/it/DeletePageTest.java > Log: > Test for the presence of bug XWIKI-1388 (the test currently fails) > > Modified: xwiki-products/xwiki-enterprise/trunk/distribution-test/ > src/test/it/com/xpn/xwiki/it/DeletePageTest.java > =================================================================== > --- xwiki-products/xwiki-enterprise/trunk/distribution-test/src/ > test/it/com/xpn/xwiki/it/DeletePageTest.java 2007-07-25 08:45:50 > UTC (rev 4022) > +++ xwiki-products/xwiki-enterprise/trunk/distribution-test/src/ > test/it/com/xpn/xwiki/it/DeletePageTest.java 2007-07-25 10:25:45 > UTC (rev 4023) > @@ -109,6 +109,18 @@ > } > } > > + /* > + * This tests for regression of XWIKI-1388 > + */ This should be a javadoc I think. > + public void testUserStaysLoggedInWhileDeleting() > + { > + logInAndCreatePageToBeDeleted("DeleteTest"); > + clickDeletePage(); > + > + assertTrue("The interface should not show the user as > logged out while deleting", > + isAuthenticated()); > + } > + I don't think we should commit test that make the build fail. We should commit them at the same time as we commit the fix IMO. When you don't have the implementation ready, then I suggest putting them in the JIRA issue related to the problem. That's what I did in the past. WDYT? Thanks -Vincent

18 years, 1 month

2
1
0 0

Problem with some files names on Windows

by Thomas Mortagne

Hi, I checkouted "trunks-users" on Windows XP with TortoiseSVN and see that some files mark has modified or non versioned. I checked with Repo-browser (tools provided by TortoiseSVN) and see that theses problems appear with files containing a blank at the end. Theses names are not supported by Windows that automatically delete all ending blanks. It can be corrected with mentioned Repo-browser or on system that support blank ending files names. -- Thomas Mortagne

18 years, 1 month

4
4
0 0

Future roadmap

by Sergiu Dumitriu

Hi all, The 1.1 deadline is approaching fast, and we still have a lot of issues marked as bugs, and 2.0 is contouring very slowly. Thus, I think we will need to decide whether we will have other 1.x releases or start working on 2.0 Here are some factors I see: - 2.0 will be mostly a rewrite from scratch, so all the existing bugs will probably be fixed in 2.0 - Since there will be many differences between 2.0 and 1.x, we should have a 1.x version without major known bugs, for those that don't want to upgrade to 2.0 - We have a limited manpower, so working on both branches will be hard - We will (probably) hire some new developers in the near future, so we could split the people in two branches, if we must - 2.0 will offer many new features that people are already asking for, so we shouldn't delay it much longer. I think we should make XWiki 1.2, but not more. Sergiu -- http://purl.org/net/sergiu

18 years, 1 month

2
2
0 0

[Proposal] New notification implementation

by Vincent Massol

For those interested I've sent a patch for implementing a new notification mechanism. It's available here: http://jira.xwiki.org/jira/browse/XWIKI-1522 I'd love to get feedback on this. Here's what I say in there: " At the place where you want to register for an event: getObservationManager().addListener(new DocumentSaveEvent ("DocumentToWatch"), listener); At the place where you want to receive for an event: public class MyListener implements EventListener { public void onEvent(Event event, Object source, Object data) { ... } } At the place where you want to fire notifications to event listeners: getObservationManager().notify(new DocumentSaveEvent("SomeDocument"), "some source", "some data"); It's easily extensible and you can create all sorts of events as it's fully generic. " Have a look at the implementation. You'll see I have even introduced the notion of EventFilter so that we can have regex when registering interest for an event. Thanks -Vincent

18 years, 1 month

4
4
0 0

[VOTE] Removing 2 XWiki.saveDocument() APIs

by Vincent Massol

Hi, I'd like to to commit the fix for http://jira.xwiki.org/jira/browse/ XWIKI-1517 This involves removing 2 of the 4 APIs. Indeed, 2 APIs take an olddoc parameter of a XWikiDocument type. The only reason for this is because the notification mechanism requires two documents so that it can check if the new one has differences over the old one and send notifications accordingly. However this need should be an implementation need and should not surface in the API. Hence XWIKI-1517. BTW this change allows fixing http://jira.xwiki.org/jira/ browse/XWIKI-1518 and some other potential bugs too. Note: I'm not changing the *.api.XWiki object (only the one in *.xwiki.XWiki). This change will a small impact on people building XWiki applications on top of the XWiki platform but not on end users. I feel this is still ok because: * We need to improve our API if we want to progress in improving XWiki * The alternative is to create a XWiki 2.0 version but we won't have enough manpower to 1) continue supporting the 1.x line and 2) to build XWiki 2.0 from scratch. I think our only reasonable option is to build on XWiki 1.x and start refactoring the internal APIs slowly, a bit in each version. * I'll document this in the release notes * It's easy to fix for anyone hit by this * End users are not touched * It fixes current existing bugs * It makes the API easier to use. Right now in 99% of the code I had to change the olddoc was simply a clone of the current doc thus making the call useless So here's my +1 Thanks -Vincent

18 years, 1 month

2
4
0 0

Logging..

by Erin Schnabel

xwiki.org says that XWiki uses log4j, but the code uses a mix of both commons logging interfaces, and those particular to log4j.. Should we be picking one? It seems that the commons logging interfaces would be preferred (as it knows how to interact with log4j), but I'm not sure. ? -- Waste of a good apple. --Samwise Gamgee

18 years, 1 month

2
2
0 0

hi

by Guo Ray

18 years, 1 month

1
0
0 0

maven build problem

by Jackson Wang

Hi, I change mysql connect url setting in xwiki-2.pom (local repository) from <xwiki.db.connection.url>"jdbc:mysql://localhost/xwiki?useServerPrepStmts=false"</xwiki.db.connection.url> to <xwiki.db.connection.url>"jdbc:mysql://localhost/xwiki ?useUnicode=true&useServerPrepStmts=false"</xwiki.db.connection.url> then build 'xwiki-web-standard' by 'mvn install -Pxe,mysql ', get eror: [INFO] Scanning for projects... [INFO] ------------------------------------------------------------------------ [ERROR] BUILD ERROR [INFO] ------------------------------------------------------------------------ [INFO] Error building POM (may not be this project's POM). Project ID: unknown:xwiki-web-standard POM Location: E:\dev\xwiki\svnroot\xwiki-users\xwiki-platform-web\standard\pom.xml Reason: Cannot read project model from interpolating filter of serialized version. I have build successfully before this modification. Does pom file can not use the expression '&' ?

18 years, 1 month

2
2
0 0

Email shortage of 16/17th July 2007 - Please resend

by Vincent Massol

Hi everyone, ObjectWeb (our infrastructure) is not answering as to whether we will recover the mails lost on the 16th and 17th. I have asked OW Admins at least 3 times for the past 6 days and they said they're working on it (but they haven't told us whether it'll be possible or not to recover them). Thus we cannot wait any longer as there were important mails sent during that period. I'm going to resend my emails and I advise everyone to do the same. We're really sorry about this. I'm following this up on OW's side. Please note that the emails sent this week end have also not made it to the list yet. Let's hope they're not lost too. Thanks and again please accept our apologies for all these emails issues we're suffering from the past 3 months. We're working on finding a solution real soon so that it doesn't happen again in the future. -Vincent Massol XWiki Release Manager

18 years, 1 month

1
0
0 0

We still haven't received emails sent between the 16th and the 18th...

by Vincent Massol

Just a note to tell you that I have (again) asked the ObjectWeb admin to give us a status about the missing emails and that I have not yet received any answer... :( This is a real *pain*. I'm fully committed that these email issues don't happen again in the future. I'll let you know more about the solution... Thanks -Vincent

18 years, 2 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

xwiki-devs