- xwiki-devs@xwiki.org - lists.xwiki.org

Re: [xwiki-devs] [xwiki-notifications] r26407 - in platform: core/trunk/xwiki-core/src/main/resources web/trunk/standard/src/main/webapp/templates
by Sergiu Dumitriu 26 Jan '10

26 Jan '10

On 01/26/2010 03:14 PM, jvelociter (SVN) wrote: > Author: jvelociter > Date: 2010-01-26 15:14:24 +0100 (Tue, 26 Jan 2010) > New Revision: 26407 > > Modified: > platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties > platform/web/trunk/standard/src/main/webapp/templates/imported.vm > Log: > XWIKI-4796 When importing XE XAR from an empty database, the import result is not properly displayed > Modified: platform/web/trunk/standard/src/main/webapp/templates/imported.vm > =================================================================== > +#else > + ## If the current user does not have admin and this template is being displayed > + ## it means security settings have been changed with the import (probably a defaut XE XAR import) > + ## We display a warning and invite the user to log in to further administrate the wiki What if the user was logged in, but now has fewer rights? Minor: you don't need the "" around the message, since it's a single string result which can be passed to the macro. > + #warning("$msg.get('core.importer.securitySettingsChanged', [$xwiki.getURL('XWiki.XWikiLogin', 'login')])") > +#end > \ No newline at end of file -- Sergiu Dumitriu http://purl.org/net/sergiu/

1 0

[xwiki-devs] [VOTE] Captcha on or off by default
by Caleb James DeLisle 26 Jan '10

26 Jan '10

I have the captcha turned on and a setting in xwiki.properties will turn it off. Should this be reversed? A. On by default B. Off by default My +1 is for A because I like showing off my captchas to everyone. Caleb

7 8

[xwiki-devs] Help! mvn install wysiwyg module error
by Leon Wang 26 Jan '10

26 Jan '10

Hi Dear XWiki Devs, When I try to compile the same Wysiwyg module from Eclipse or from Windows command line, I get different errors. One is org.apache.maven.plugins:maven-compiler-plugin:2.0.2:testCompile error, one is checkstyle error. Could you please give some clue what is wrong? >From Eclispe I will get this error: "[INFO] [compiler:testCompile] [INFO] Compiling 37 source files to C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\target\test-classes [INFO] [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] ------------------------------------------------------------------------ [INFO] XWiki Platform - Web - Parent POM ..................... SUCCESS [0.922s] [INFO] XWiki Platform - Web - GWT API ........................ SUCCESS [11.515s] [INFO] XWiki Platform - Web - GWT - DOM API .................. SUCCESS [3.766s] [INFO] XWiki Platform - Web - GWT - User ..................... SUCCESS [3.437s] [INFO] XWiki Platform - Web - WYSIWYG ........................ FAILED [13.563s] [INFO] XWiki Platform - Web - Standard ....................... NOT BUILT [INFO] ------------------------------------------------------------------------ [ERROR] Mojo: org.apache.maven.plugins:maven-compiler-plugin:2.0.2:testCompile FAILED for project: com.xpn.xwiki.platform:xwiki-web-wysiwyg:war:2.1.1 Reason: C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\RichTextAreaTestCase.java:[22,39] cannot find symbol symbol : class AbstractRichTextAreaTestCase location: package org.xwiki.gwt.user.client.ui.rta C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\RichTextAreaTestCase.java:[29,42] cannot find symbol symbol: class AbstractRichTextAreaTestCase public class RichTextAreaTestCase extends AbstractRichTextAreaTestCase C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\syntax\internal\DefaultValidationRuleTest.java:[24,52] cannot find symbol symbol : class MockCommandManager location: package org.xwiki.gwt.user.client.ui.rta.cmd.internal C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[47,13] cannot find symbol symbol : method gwtSetUp() location: class com.xpn.xwiki.wysiwyg.client.RichTextAreaTestCase C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[64,16] cannot find symbol symbol: variable rta rta.setHTML("<ul><li>one</li><li>two</li></ul>"); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[66,30] cannot find symbol symbol: variable rta Range range = rta.getDocument().createRange(); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[67,31] cannot find symbol symbol: method getBody() range.setStart(getBody().getFirstChild().getChildNodes().getItem(1).getFirstChild(), 0); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[69,16] cannot find symbol symbol: method select(org.xwiki.gwt.dom.client.Range) select(range); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[141,16] cannot find symbol symbol: variable rta rta.setHTML(rtaInnerHTML); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[143,30] cannot find symbol symbol: variable rta Range range = rta.getDocument().createRange(); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[144,31] cannot find symbol symbol: method getBody() range.setStart(getBody().getChildNodes().getItem(0).getChildNodes().getItem(0), 0); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[145,29] cannot find symbol symbol: method getBody() range.setEnd(getBody().getChildNodes().getItem(0).getChildNodes().getItem(0), 4); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[146,16] cannot find symbol symbol: method select(org.xwiki.gwt.dom.client.Range) select(range); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[149,49] cannot find symbol symbol: variable rta assertFalse(executable.isEnabled(rta)); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[151,47] cannot find symbol symbol: variable rta assertFalse(executable.execute(rta, null)); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[223,73] cannot find symbol symbol: variable rta assertEquals(rtaInnerHTML, removeNonBreakingSpaces(clean(rta.getHTML()))); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[205,8] cannot find symbol symbol : method deferTest(<anonymous com.google.gwt.user.client.Command>) location: class com.xpn.xwiki.wysiwyg.client.plugin.indent.exec.IndentExecutableTest C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[265,30] cannot find symbol symbol: variable rta Range range = rta.getDocument().createRange(); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[266,31] cannot find symbol symbol: method getBody() range.setStart(getBody().getFirstChild().getChildNodes().getItem(1).getFirstChild(), 0); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[267,29] cannot find symbol symbol: method getBody() range.setEnd(getBody().getFirstChild().getChildNodes().getItem(1).getChildNodes().getItem(1) C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[270,16] cannot find symbol symbol: method select(org.xwiki.gwt.dom.client.Range) select(range); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[272,48] cannot find symbol symbol: variable rta assertTrue(executable.isEnabled(rta)); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[273,46] cannot find symbol symbol: variable rta assertTrue(executable.execute(rta, null)); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[275,50] cannot find symbol symbol: variable rta removeNonBreakingSpaces(clean(rta.getHTML()))); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[259,8] cannot find symbol symbol : method deferTest(<anonymous com.google.gwt.user.client.Command>) location: class com.xpn.xwiki.wysiwyg.client.plugin.indent.exec.IndentExecutableTest C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[291,16] cannot find symbol symbol: variable rta rta.setHTML("<ul><li>one<ul><li>one plus one</li></ul></li><li>two</li></ul>"); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[293,30] cannot find symbol symbol: variable rta Range range = rta.getDocument().createRange(); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[294,31] cannot find symbol symbol: method getBody() range.setStart(getBody().getFirstChild().getChildNodes().getItem(1).getFirstChild(), 0); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[296,16] cannot find symbol symbol: method select(org.xwiki.gwt.dom.client.Range) select(range); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[298,48] cannot find symbol symbol: variable rta assertTrue(executable.isEnabled(rta)); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[299,46] cannot find symbol symbol: variable rta assertTrue(executable.execute(rta, null)); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[301,50] cannot find symbol symbol: variable rta removeNonBreakingSpaces(clean(rta.getHTML()))); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[287,8] cannot find symbol symbol : method deferTest(<anonymous com.google.gwt.user.client.Command>) location: class com.xpn.xwiki.wysiwyg.client.plugin.indent.exec.IndentExecutableTest C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[316,16] cannot find symbol symbol: variable rta rta.setHTML("<ol><li>one</li><li>two</li><li>three</li><li>four</li></ol>"); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[318,30] cannot find symbol symbol: variable rta Range range = rta.getDocument().createRange(); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[352,46] cannot find symbol symbol: variable rta assertTrue(executable.execute(rta, null)); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[355,79] cannot find symbol symbol: variable rta + "</li><li>four</li></ol>", removeNonBreakingSpaces(clean(rta.getHTML()))); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[339,8] cannot find symbol symbol : method deferTest(<anonymous com.google.gwt.user.client.Command>) location: class com.xpn.xwiki.wysiwyg.client.plugin.indent.exec.IndentExecutableTest C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[372,16] cannot find symbol symbol: variable rta rta.setHTML("<ol><li>one<ul><li>under</li></ul></li><li>two</li><li>three</li>" + "<li>four</li></ol>"); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[374,30] cannot find symbol symbol: variable rta Range range = rta.getDocument().createRange(); C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[376,31] cannot find symbol symbol: method getBody() range.setStart(getBody().getFirstChild().getFirstChild().getChildNodes().getItem(1).getFirstChild() C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki-web\wysiwyg\src\test\java\com\xpn\xwiki\wysiwyg\client\plugin\indent\exec\IndentExecutableTest.java:[378,29] cannot find symbol symbol: method getBody() range.setEnd(getBody().getFirstChild().getChildNodes().getItem(1).getFirstChild(), 3); " _____________________________________________________________________________________________________________________ While I use mvn install to compile for the same code from Windows command line I get this error: _____________________________________________________________________________________________________________________ ig.java:30:8: Unused import - org.xwiki.gwt.dom.client.JavaScriptObject. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\LinkConf ig.java:32:8: Unused import - com.google.gwt.core.client.JsArrayString. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\LinkConf ig.java:132:5: Static variable definition in wrong order. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\LinkConf ig.java:137: warning: Comment matches to-do format 'FIXME'. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\LinkConf ig.java:138: warning: Comment matches to-do format 'TODO'. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\LinkConf ig.java:142:5: Missing a Javadoc comment. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\LinkConf ig.java:144:7: Line contains a tab character. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\LinkConf ig.java:145:5: Line contains a tab character. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:22: Missing a Javadoc comment. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:22:76: '{' is not preceded with whitespace. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:22:76: '{' should be on a new line. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:23:1: Line contains a tab character. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:24:1: Line contains a tab character. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:48:96: The String "Alternative" appears 2 times in the file. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:49:93: The String "Argument" appears 2 times in the file. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:50:98: The String "Assumption" appears 2 times in the file. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:51:92: The String "Claim" appears 2 times in the file. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:52:93: The String "Decision" appears 2 times in the file. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:53:96: The String "Requirement" appears 2 times in the file. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:64: warning: Comment matches to-do format 'TODO'. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:107:15: 'if' is not followed by whitespace. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:107:33: '==' is not preceded with whitespace. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:107:33: Literal Strings should be compared using equals(), not '==' . C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:107:35: '==' is not followed by whitespace. C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web\wysiwyg\src\main\java\com\xpn\xwiki\wysiwyg\client\plugin\rationale\Rational ePlugin.java:109:13: Line contains a tab character. Audit done. [INFO] There are 71 checkstyle errors. [WARNING] Unable to locate Source XRef to link to - DISABLED [INFO] [checkstyle:check {execution: default}] [INFO] ------------------------------------------------------------------------ [ERROR] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] You have 71 Checkstyle violations. [INFO] ------------------------------------------------------------------------ [INFO] For more information, run Maven with the -e switch [INFO] ------------------------------------------------------------------------ [INFO] Total time: 3 minutes 59 seconds [INFO] Finished at: Mon Jan 25 16:14:16 EST 2010 [INFO] Final Memory: 55M/63M [INFO] ------------------------------------------------------------------------ C:\Documents and Settings\Leon\workspace_xwiki_eclipse-jee-ganymede\2.1.1\xwiki- web> Thank you for your help! Leon -- http://freeleons.spaces.live.com/ Life might lead me where I least expected.However,I have faith I'm exactly where I am meant to be.

2 1

[xwiki-devs] LiveValidation is outsmarting the selenium tests. Also selenium can't solve captcha.
by Caleb James DeLisle 26 Jan '10

26 Jan '10

Two problems: 1. The selenium tests try to submit bad information but are stopped by LiveValidation causing a test failure. Responsible for: http://hudson.xwiki.org/job/xwiki-product-enterprise-tests/com.xpn.xwiki.pr… http://hudson.xwiki.org/job/xwiki-product-enterprise-tests/com.xpn.xwiki.pr… http://hudson.xwiki.org/job/xwiki-product-enterprise-tests/com.xpn.xwiki.pr… Perhaps we can set up the test to bypass javascript, maybe it's a good idea to test LiveValidation too? 2. Also selenium seems unable to solve the captcha. It wasn't a problem because empty captchas were accepted as long as there was no 'mandatory' constraint on the captcha field, fixed that. Expecting this to start being a problem again: http://hudson.xwiki.org/job/xwiki-product-enterprise-tests/com.xpn.xwiki.pr… Log in as Admin, set captcha to false, log out and then register? Turn off captcha by default? I'd like to hear your thoughts, Caleb

2 1

Re: [xwiki-devs] [xwiki-notifications] r26388 - platform/xwiki-applications/trunk/administration/src/main/resources/XWiki
by Sergiu Dumitriu 26 Jan '10

26 Jan '10

On 01/26/2010 02:14 AM, cjdelisle (SVN) wrote: > Author: cjdelisle > Date: 2010-01-26 02:14:45 +0100 (Tue, 26 Jan 2010) > New Revision: 26388 > > Modified: > platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/Registration.xml > Log: > XAADMINISTRATION-77: Improve registration interface: Fixed embarassing bug which made empty captchas be accepted if there was no 'mandatory' constraint on captcha. > > Modified: platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/Registration.xml > =================================================================== > --- platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/Registration.xml 2010-01-26 00:25:32 UTC (rev 26387) > +++ platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/Registration.xml 2010-01-26 01:14:45 UTC (rev 26388) You reintroduced the old title: > -<title>Registration</title> > +<title>Verified Registration Application</title> > <template></template> > <defaultTemplate></defaultTemplate> > <validationScript></validationScript> > @@ -377,7 +377,7 @@ > #set($cv = $captchaservice.getCaptchaVerifier('image')) > #if(!$cv.isAnswerCorrect($cv.getUserId($request), $answer)) > failed > - #end > + #end > #end > ## > ## Pass the name of the template to $xwiki.createUser so any contained information will be passed in. > @@ -398,7 +398,7 @@ > #else > #set($docName = $doc.getName()) > #end > - #if($xcontext.hasAccessLevel("edit", $docName)) > + #if($xcontext.hasAccessLevel("edit", $doc.getFullName())) > #set($field = > {'name' : 'configure', > 'prompt' : "<a href='$xwiki.getURL($docName, 'edit')?editor=wiki'>You can configure this application by clicking here.</a>", > @@ -451,54 +451,53 @@ > #set($fieldName = $field.get('name')) > #set($validate = $field.get('validate')) > #set($error = '') > - #if($request.get($fieldName)&& $request.get($fieldName) != '') > - #set($value = $request.get($fieldName)) > - ## > - ## Regex validation > - #if($validate.get('regex')) > - #set($regex = $validate.get('regex')) > - #if($regex.get('pattern')&& $regex.get('failureMessage')) > - #if(!$xcontext.getUtil().match($regex.get('pattern'), $value)) > - #set($error = $regex.get('failureMessage')) > - #end > - #elseif($regex.get('pattern')) > - ERROR: In field: ${fieldName}: regex validation must include failureMessage. > - #end > + #set($value = $request.get($fieldName)) > + ## > + ## Check if content is mandatory (!$value || $value == '') can be rewritten as ("$!{value}" == '') > + #if($validate.get('mandatory')&& (!$value || $value == '')) > + #set($mandatory = $validate.get('mandatory')) > + #if($mandatory.get('failureMessage')) > + #set($error = $mandatory.get('failureMessage')) > + #else > + ERROR: In field: ${fieldName}: mandatory validation requires a failureMessage > #end > - ## > - ## If regex validation passed, check "mustMatch" validation > - #if($error == ''&& $validate.get('mustMatch')) > - #set($mustMatch = $validate.get('mustMatch')) > - #if($mustMatch.get('name')&& $mustMatch.get('failureMessage')) > - #if($request.get($fieldName) != $request.get($mustMatch.get('name'))) > - #set($error = $mustMatch.get('failureMessage')) > - #end > - #else > - ERROR: In field: ${fieldName}: mustMatch validation required both name > - (of field which this field must match) and failureMessage. > + #end > + ## > + ## mustMatch validation > + #if($error == ''&& $validate.get('mustMatch')) > + #set($mustMatch = $validate.get('mustMatch')) > + #if($mustMatch.get('name')&& $mustMatch.get('failureMessage')) > + #if($request.get($fieldName) != $request.get($mustMatch.get('name'))) > + #set($error = $mustMatch.get('failureMessage')) > #end > + #else > + ERROR: In field: ${fieldName}: mustMatch validation required both name > + (of field which this field must match) and failureMessage. > #end > - ## > - ## If regex and mustMatch validation passed, try programmatic validation > - #if($error == ''&& $validate.get('programmaticValidation')) > - #set($pv = $validate.get('programmaticValidation')) > - #if($pv.get('code')&& $pv.get('failureMessage')) > - #set($pvReturn = "#evaluate($pv.get('code'))") > - #if($pvReturn.indexOf('failed') != -1) > - #set($error = $pv.get('failureMessage')) > - #end > - #else > - ERROR: In field: ${fieldName}: programmaticValidation requires code and failureMessage > + #end > + ## > + ## Regex validation > + #if($error == ''&& $validate.get('regex')) > + #set($regex = $validate.get('regex')) > + #if($regex.get('pattern')&& $regex.get('failureMessage')) > + #if(!$xcontext.getUtil().match($regex.get('pattern'), $value)) > + #set($error = $regex.get('failureMessage')) > #end > + #elseif($regex.get('pattern')) > + ERROR: In field: ${fieldName}: regex validation must include failureMessage. > #end > + #end > ## > - ## If no content, check if content is mandatory > - #elseif($validate.get('mandatory')) > - #set($mandatory = $validate.get('mandatory')) > - #if($mandatory.get('failureMessage')) > - #set($error = $mandatory.get('failureMessage')) > + ## If regex and mustMatch validation passed, try programmatic validation > + #if($error == ''&& $validate.get('programmaticValidation')) > + #set($pv = $validate.get('programmaticValidation')) > + #if($pv.get('code')&& $pv.get('failureMessage')) > + #set($pvReturn = "#evaluate($pv.get('code'))") > + #if($pvReturn.indexOf('failed') != -1) > + #set($error = $pv.get('failureMessage')) > + #end > #else > - ERROR: In field: ${fieldName}: mandatory validation requires a failureMessage > + ERROR: In field: ${fieldName}: programmaticValidation requires code and failureMessage > #end > #end > #if($error != '') > -- Sergiu Dumitriu http://purl.org/net/sergiu/

1 0

Re: [xwiki-devs] [xwiki-notifications] r26377 - in platform/core/trunk/xwiki-core/src: main/java/com/xpn/xwiki/store test/java/com/xpn/xwiki/store test/java/com/xpn/xwiki/test
by Sergiu Dumitriu 25 Jan '10

25 Jan '10

On 01/25/2010 09:08 PM, vmassol (SVN) wrote: > Author: vmassol > Date: 2010-01-25 21:08:08 +0100 (Mon, 25 Jan 2010) > New Revision: 26377 > > Added: > platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/test/AbstractBridgedComponentTestCase.java > Modified: > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateBaseStore.java > platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/store/XWikiHibernateStoreTest.java > Log: > XWIKI-2758: PostgreSQL exceptions unusable Forgot to give credit. > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateBaseStore.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateBaseStore.java 2010-01-25 18:38:18 UTC (rev 26376) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateBaseStore.java 2010-01-25 20:08:08 UTC (rev 26377) You should cleanup this commented code: > +/* > + if (t.getCause() instanceof BatchUpdateException > +&& ((BatchUpdateException) t.getCause()).getNextException() != null) { > + final BatchUpdateException bue = (BatchUpdateException) t.getCause(); > + return bue.getNextException().getMessage(); > + } > + > + return t.getMessage(); > + */ > + return sb.toString(); > + } Are you sure this was supposed to be part of this commit? > Added: platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/test/AbstractBridgedComponentTestCase.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/test/AbstractBridgedComponentTestCase.java (rev 0) > +++ platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/test/AbstractBridgedComponentTestCase.java 2010-01-25 20:08:08 UTC (rev 26377) -- Sergiu Dumitriu http://purl.org/net/sergiu/

2 1

[xwiki-devs] [new model][VOTE] Should we support entities that don't have a unique name?
by Anca Luca 25 Jan '10

25 Jan '10

Hi devs, Short story: In the new model, does it make sense to support entities that don't have an unique name to be identified in their 'context'? (so-called 'free name', as in free thought). WDYT? Long story: For example, in the current model, an object is an example of entity that does _not_ have a free name: in a document (its context), an object is identified by two values: the name of the class of the object and the 'object number'. An object cannot be differentiated by a single name among all the objects of a document. As opposed to this, a document does have a free name to identify it in the list of documents in a space, namely the page name. The same, an attachment's name is unique among the attachments of a page, etc. Note that the discussion is about a human-readable and accessible name for an entity, for example, using a GUID or other 'identifier' is not an option, since they are not manipulable by humans (for example to create a reference to such an entity). Also note that, even if supporting it is the best solution (which covers all cases anyway), we want to make sure it's necessary, since it would involve some refactoring. Thanks, Anca P.S. I haven't made my mind yet.

4 9

[xwiki-devs] [VOTE] Release XE 2.2M2 Wednesday 27
by Vincent Massol 25 Jan '10

25 Jan '10

Hi, We were supposed to release XE 2.2M2 this Monday but Sergiu would like to include the Color Theme improvement and we can also use these additional 1.5 days to test more. If we agree please all make sure that you don't introduce anything that can potentially break the stability and ensure that all is ready for Wednesday end of morning so that we can start the release beginning of afternoon. Here's my +1 Thanks -Vincent

3 2

[xwiki-devs] [ANN] XOffice 1.1 M1 Released!
by Florin Ciubotaru 25 Jan '10

25 Jan '10

The XWiki development team is pleased to announce the release of XWiki Office 1.1 Milestone 1. Go grab it at: http://www.xwiki.org/xwiki/bin/view/Main/Download#HXWikiOffice Summary of changes: - support for on page style extensions - more powerful text formatting - fixed encoding issues Updating: - active instances of 1.1 snapshots are automatically updated - the 1.1 new features updates will be pushed when version 1.1 final will be available - the 1.0 bugfixes will be pushed during the 1.1 development cycle. View detailed release notes at: http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXOffice11M1 For more information about XOffice visit: http://xoffice.xwiki.org/xwiki/bin/view/Main/WebHome Thanks, -The XWiki dev team

1 0

[xwiki-devs] hibernate.cfg.xml
by Vivian Richard 25 Jan '10

25 Jan '10

Hello Devs, I am getting this strange xml formet error in the hibernate.cfg.xml file. I am attaching my xml and as you can see all I did was uncommented the mysql part of the file. I tried validate the xml format at this site: http://validator.w3.org/#validate_by_input and got these error messages- Line 51, Column 36: document type does not allow element "property" here Line 52, Column 36: document type does not allow element "property" here Line 53, Column 36: document type does not allow element "property" here Line 54, Column 36: document type does not allow element "property" here Line 55, Column 36: document type does not allow element "property" here Line 56, Column 36: document type does not allow element "property" here Line 57, Column 36: document type does not allow element "property" here Line 58, Column 36: document type does not allow element "property" here Can some one please point out what is wrong with it? By the way this xml file came with xwiki-enterprise-manager-web-2.1.1.war file Regards ///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////// <?xml version='1.0' encoding='utf-8'?> <!DOCTYPE hibernate-configuration PUBLIC "-//Hibernate/Hibernate Configuration DTD//EN" "http://hibernate.sourceforge.net/hibernate-configuration-3.0.dtd"> <hibernate-configuration> <session-factory>   <property name="show_sql">false</property> <property name="use_outer_join">true</property> <property name="dbcp.defaultAutoCommit">false</property> <property name="dbcp.maxActive">50</property> <property name="dbcp.maxIdle">5</property> <property name="dbcp.maxWait">30000</property> <property name="dbcp.whenExhaustedAction">1</property> <property name="dbcp.ps.whenExhaustedAction">1</property> <property name="dbcp.ps.maxActive">20</property> <property name="dbcp.ps.maxWait">120000</property> <property name="dbcp.ps.maxIdle">20</property>  <property name="jdbc.use_scrollable_resultset">false</property>  <property name="connection.url">jdbc:hsqldb:file:database/xwiki_db;shutdown=true</property> <property name="connection.username">sa</property> <property name="connection.password"></property> <property name="connection.driver_class">org.hsqldb.jdbcDriver</property> <property name="dialect">org.hibernate.dialect.HSQLDialect</property> <property name="connection.provider_class">com.xpn.xwiki.store.DBCPConnectionProvider</property> <property name="connection.pool_size">2</property> <property name="statement_cache.size">2</property> <mapping resource="xwiki.hbm.xml"/> <mapping resource="feeds.hbm.xml"/> <mapping resource="activitystream.hbm.xml"/>  <property name="connection.url">jdbc:mysql://localhost/xwiki?useServerPrepStmts=false&useUnicode=true&characterEncoding=UTF-8&sessionVariables=sql_mode=''</property> <property name="connection.username">xwiki</property> <property name="connection.password">xwiki</property> <property name="connection.driver_class">com.mysql.jdbc.Driver</property> <property name="dialect">org.hibernate.dialect.MySQLDialect</property> <property name="connection.provider_class">com.xpn.xwiki.store.DBCPConnectionProvider</property> <property name="connection.pool_size">2</property> <property name="statement_cache.size">2</property> <mapping resource="xwiki.hbm.xml"/> <mapping resource="feeds.hbm.xml"/> <mapping resource="activitystream.hbm.xml"/>     </session-factory> </hibernate-configuration> ///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

3 2