- xwiki-devs@xwiki.org - lists.xwiki.org

Re: [xwiki-devs] [xwiki-notifications] r25290 - enterprise/branches/xwiki-enterprise-2.0/distribution-test/xmlrpc-tests/src/test/it/com/xpn/xwiki/it/xmlrpc enterprise/branches/xwiki-enterprise-2.0/distribution-test/xmlrpc-tests/src/test/it/org/xwiki/xmlrpc platform/core/branches/xwiki-core-2.0/xwiki-core/src/main/java/com/xpn/xwiki/xmlrpc platform/core/branches/xwiki-core-2.0/xwiki-xmlrpc/xwiki-xmlrpc-client/src/main/java/org/xwiki/xmlrpc platform/core/branches/xwiki-core-2.0/xwiki-xmlrpc/xwiki-xmlrpc-model
by Fabio Mancinelli 27 Nov '09

27 Nov '09

Hi all, I wonder if http://svn.xwiki.org/svnroot/xwiki/platform/core/trunk/xwiki-xmlrpc/xwiki-x… is needed at all after the refactoring Florin did. The rationale for this interface was that before we were creating a Java proxy object in order to wrap each invocation inside a context initialization-cleanup. And since proxies could be created only by using interfaces we needed the API to be expressed as an interface. Now that the context initialization/cleanup is handled through filters there is no more need for the proxy and hence for that interface. Moreover this interface exposes method signature using XMLRPC types (so Maps instead of model objects). So it might also be confusing. I am +1 for removing it so that the code is even more clean. -Fabio On Nov 26, 2009, at 5:17 PM, tmortagne (SVN) wrote: > Author: tmortagne > Date: 2009-11-26 17:17:04 +0100 (Thu, 26 Nov 2009) > New Revision: 25290 > > Added: > enterprise/branches/xwiki-enterprise-2.0/distribution-test/xmlrpc-tests/src/test/it/org/xwiki/xmlrpc/RenderingTest.java > Modified: > enterprise/branches/xwiki-enterprise-2.0/distribution-test/xmlrpc-tests/src/test/it/com/xpn/xwiki/it/xmlrpc/AllTests.java > platform/core/branches/xwiki-core-2.0/xwiki-core/src/main/java/com/xpn/xwiki/xmlrpc/XWikiXmlRpcApiImpl.java > platform/core/branches/xwiki-core-2.0/xwiki-xmlrpc/xwiki-xmlrpc-client/src/main/java/org/xwiki/xmlrpc/XWikiXmlRpcClient.java > platform/core/branches/xwiki-core-2.0/xwiki-xmlrpc/xwiki-xmlrpc-model/src/main/java/org/xwiki/xmlrpc/XWikiXmlRpcApi.java > Log: > XWIKI-4464: Extend the XmlRpc API with new rendering features > * Apply patch from Florin Ciubotaru: > ** New getRenderedContendMethods added to the api(We still need a few votes on devs for these to get commited). Completed the client with the new additions. > ** Added integration tests. > > Modified: enterprise/branches/xwiki-enterprise-2.0/distribution-test/xmlrpc-tests/src/test/it/com/xpn/xwiki/it/xmlrpc/AllTests.java > =================================================================== > --- enterprise/branches/xwiki-enterprise-2.0/distribution-test/xmlrpc-tests/src/test/it/com/xpn/xwiki/it/xmlrpc/AllTests.java 2009-11-26 15:38:04 UTC (rev 25289) > +++ enterprise/branches/xwiki-enterprise-2.0/distribution-test/xmlrpc-tests/src/test/it/com/xpn/xwiki/it/xmlrpc/AllTests.java 2009-11-26 16:17:04 UTC (rev 25290) > @@ -62,6 +62,7 @@ > addTestCase(suite, org.xwiki.xmlrpc.XWikiClassesTest.class); > addTestCase(suite, org.xwiki.xmlrpc.XWikiObjectsTest.class); > addTestCase(suite, org.xwiki.xmlrpc.SearchTest.class); > + addTestCase(suite, org.xwiki.xmlrpc.RenderingTest.class); > > return new XWikiTestSetup(suite); > } > > Copied: enterprise/branches/xwiki-enterprise-2.0/distribution-test/xmlrpc-tests/src/test/it/org/xwiki/xmlrpc/RenderingTest.java (from rev 25288, enterprise/trunk/distribution-test/xmlrpc-tests/src/test/it/org/xwiki/xmlrpc/RenderingTest.java) > =================================================================== > --- enterprise/branches/xwiki-enterprise-2.0/distribution-test/xmlrpc-tests/src/test/it/org/xwiki/xmlrpc/RenderingTest.java (rev 0) > +++ enterprise/branches/xwiki-enterprise-2.0/distribution-test/xmlrpc-tests/src/test/it/org/xwiki/xmlrpc/RenderingTest.java 2009-11-26 16:17:04 UTC (rev 25290) > @@ -0,0 +1,145 @@ > +/* > + * See the NOTICE file distributed with this work for additional > + * information regarding copyright ownership. > + * > + * This is free software; you can redistribute it and/or modify it > + * under the terms of the GNU Lesser General Public License as > + * published by the Free Software Foundation; either version 2.1 of > + * the License, or (at your option) any later version. > + * > + * This software is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this software; if not, write to the Free > + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA > + * 02110-1301 USA, or see the FSF site: http://www.fsf.org. > + * > + */ > +package org.xwiki.xmlrpc; > + > +import java.util.List; > + > +import junit.framework.Assert; > + > +import org.apache.xmlrpc.XmlRpcException; > +import org.xwiki.xmlrpc.model.XWikiPage; > + > +public class RenderingTest extends AbstractXWikiXmlRpcTest > +{ > + public void testGetInputSyntaxes() throws XmlRpcException > + { > + List<String> syntaxes = rpc.getInputSyntaxes(); > + > + TestUtils.banner("TEST: getInputSyntaxes()"); > + System.out.format("%d conversion input syntaxes found:\n", syntaxes.size()); > + for (String syntaxId : syntaxes) { > + System.out.format("%s\n", syntaxId); > + } > + Assert.assertTrue(syntaxes.size() != 0); > + } > + > + public void testGetOutputSyntaxes() throws XmlRpcException > + { > + List<String> syntaxes = rpc.getOutputSyntaxes(); > + > + TestUtils.banner("TEST: getOutputSyntaxes()"); > + System.out.format("%d conversion output syntaxes found:\n", syntaxes.size()); > + for (String syntaxId : syntaxes) { > + System.out.format("%s\n", syntaxId); > + } > + Assert.assertTrue(syntaxes.size() != 0); > + } > + > + public void testConvert() throws XmlRpcException > + { > + String inputXWiki = > + "**BoldText**//ItalicText//" + String.format("%n") + "==h2Text==" + String.format("%n") + "normalText"; > + String inputXhtml = > + "<div><p><strong>boldText</strong><br/><em>ItalicText</em></p>" + String.format("%n") > + + "<h2 id=\"h2Text\"><span>h2Text</span></h2><p>normalText</p></div>"; > + > + TestUtils.banner("TEST: convert()"); > + System.out.format("\nTesting xwiki/2.0 -> xhtml/1.0 conversion\n"); > + System.out.format("Input text:\n%s", inputXWiki); > + > + String outputXhtml = rpc.convert(inputXhtml, "xwiki/2.0", "xhtml/1.0"); > + > + System.out.format("\nOutput text:\n%s", outputXhtml); > + > + Assert.assertNotNull(outputXhtml); > + Assert.assertFalse(outputXhtml.equals("")); > + Assert.assertTrue(outputXhtml.contains("strong")); > + Assert.assertTrue(outputXhtml.contains("normalText")); > + Assert.assertTrue(outputXhtml.contains("ItalicText")); > + > + System.out.format("\nTesting xhtml/1.0 -> xwiki/2.0 conversion\n"); > + System.out.format("Input text:\n%s", inputXhtml); > + > + String outputXWiki = rpc.convert(inputXhtml, "xhtml/1.0", "xwiki/2.0"); > + > + System.out.format("\nOutput text:\n%s\n", outputXWiki); > + > + Assert.assertNotNull(outputXWiki); > + Assert.assertFalse(outputXhtml.equals("")); > + Assert.assertTrue(outputXhtml.contains("normalText")); > + Assert.assertTrue(outputXhtml.contains("ItalicText")); > + } > + > + public void testGetRenderedContent() throws XmlRpcException > + { > + String pageContent = "**Text in Bold**{{velocity}}VelocityCode{{/velocity}}"; > + > + XWikiPage page = new XWikiPage(); > + page.setId(TestConstants.TEST_PAGE); > + page.setContent(pageContent); > + page.setSyntaxId("xwiki/2.0"); > + > + TestUtils.banner("TEST: getRenderedContent()"); > + System.out.format("\nCalling getRenderedContent for page %s\n", page.getId()); > + System.out.format("\nWiki content is:\n%s\n", pageContent); > + > + rpc.storePage(page); > + > + try { > + String renderedContent = rpc.getRenderedContent(page.getId(), "annotatedxhtml/1.0"); > + > + System.out.format("\nObtained rendered content:\n%s\n\n", renderedContent); > + > + Assert.assertTrue(renderedContent.contains("Text in Bold")); > + Assert.assertTrue(renderedContent.contains("startmacro")); > + } finally { > + rpc.removePage(page.getId()); > + } > + } > + > + public void testRenderPageContent() throws XmlRpcException > + { > + String pageContent = "**Text in Bold**{{velocity}}VelocityCode{{/velocity}}"; > + > + XWikiPage page = new XWikiPage(); > + page.setId(TestConstants.TEST_PAGE); > + page.setContent(pageContent); > + page.setSyntaxId("xwiki/2.0"); > + > + TestUtils.banner("TEST: renderPageContent"); > + System.out.format("\nCalling renderPageContent with context as page %s\n", TestConstants.TEST_PAGE); > + System.out.format("\nWiki content is:\n%s\n", pageContent); > + > + rpc.storePage(page); > + > + try { > + String renderedContent = > + rpc.renderPageContent(page.getId(), page.getContent(), page.getSyntaxId(), "annotatedxhtml/1.0"); > + > + System.out.format("\nObtained rendered content:\n%s\n\n", renderedContent); > + > + Assert.assertTrue(renderedContent.contains("Text in Bold")); > + Assert.assertTrue(renderedContent.contains("startmacro")); > + } finally { > + rpc.removePage(page.getId()); > + } > + } > +} > > Modified: platform/core/branches/xwiki-core-2.0/xwiki-core/src/main/java/com/xpn/xwiki/xmlrpc/XWikiXmlRpcApiImpl.java > =================================================================== > --- platform/core/branches/xwiki-core-2.0/xwiki-core/src/main/java/com/xpn/xwiki/xmlrpc/XWikiXmlRpcApiImpl.java 2009-11-26 15:38:04 UTC (rev 25289) > +++ platform/core/branches/xwiki-core-2.0/xwiki-core/src/main/java/com/xpn/xwiki/xmlrpc/XWikiXmlRpcApiImpl.java 2009-11-26 16:17:04 UTC (rev 25290) > @@ -1446,4 +1446,47 @@ > } > return syntaxes; > } > + > + /** > + * Renders a text in the context of a wiki page. > + * > + * @param token The authentication token. > + * @param pageId The id of the page. > + * @param content The context to be rendered. > + * @param sourceSyntaxId The syntax of the content. > + * @param targetSyntaxId The target syntax of the rendered content > + * @return The rendered content. > + * @throws Exception If a invalid token is provided, an unsupported syntax id is given or the rendering fails. > + */ > + public String renderPageContent(String token, String pageId, String content, String sourceSyntaxId, > + String targetSyntaxId) throws Exception > + { > + XWikiXmlRpcUser user = XWikiUtils.checkToken(token, this.xwikiContext); > + LOG.debug(String.format("User %s has called renderPageContent()", user.getName())); > + > + Document doc = XWikiUtils.getDocument(this.xwikiApi, pageId, true); > + > + return doc.getRenderedContent(content, sourceSyntaxId, targetSyntaxId); > + } > + > + /** > + * Gets the rendered content of an existing document. > + * > + * @param token The authentication token. > + * @param pageId The id of the page. > + * @param syntaxId The target syntax of the rendered content > + * @return The rendered content > + * @throws Exception If a invalid token is provided, an unsupported syntax id is given or the rendering fails. > + */ > + public String getRenderedContent(String token, String pageId, String syntaxId) throws Exception > + { > + XWikiXmlRpcUser user = XWikiUtils.checkToken(token, this.xwikiContext); > + LOG.debug(String.format("User %s has called getRenderedContent()", user.getName())); > + > + Document doc = XWikiUtils.getDocument(this.xwikiApi, pageId, true); > + SyntaxFactory syntaxFactory = Utils.getComponent(SyntaxFactory.class); > + Syntax syntax = syntaxFactory.createSyntaxFromIdString(syntaxId); > + > + return doc.getRenderedContent(syntax); > + } > } > > Modified: platform/core/branches/xwiki-core-2.0/xwiki-xmlrpc/xwiki-xmlrpc-client/src/main/java/org/xwiki/xmlrpc/XWikiXmlRpcClient.java > =================================================================== > --- platform/core/branches/xwiki-core-2.0/xwiki-xmlrpc/xwiki-xmlrpc-client/src/main/java/org/xwiki/xmlrpc/XWikiXmlRpcClient.java 2009-11-26 15:38:04 UTC (rev 25289) > +++ platform/core/branches/xwiki-core-2.0/xwiki-xmlrpc/xwiki-xmlrpc-client/src/main/java/org/xwiki/xmlrpc/XWikiXmlRpcClient.java 2009-11-26 16:17:04 UTC (rev 25290) > @@ -932,6 +932,85 @@ > } > > /** > + * Converts a wiki source from a syntax to another syntax. > + * > + * @param source The content to be converted. > + * @param initialSyntaxId The initial syntax of the source. > + * @param targetSyntaxId The final syntax of the returned content. > + * @return The converted source. > + * @throws XmlRpcException An invalid token is provided, the syntaxId is not supported, the source is invalid or the > + * conversion fails. > + */ > + public String convert( String source, String initialSyntaxId, String targetSyntaxId) > + throws XmlRpcException > + { > + return (String) invokeRpc("convert", this.token, source, initialSyntaxId, targetSyntaxId); > + } > + > + /** > + * Gets all syntaxes supported by the rendering parsers as an input for a syntax conversion. > + * > + * @return A list containing all syntaxes supported by rendering parsers. > + * @throws Exception An invalid token is provided or the syntax lookup fails. > + */ > + public List<String> getInputSyntaxes() throws XmlRpcException > + { > + List<String> result = new ArrayList<String>(); > + Object[] objects = (Object[]) invokeRpc("getInputSyntaxes", this.token); > + for(Object object:objects) > + { > + result.add((String)object); > + } > + return result; > + } > + > + /** > + * Gets all syntaxes supported by the rendering as an output for a syntax conversion. > + * > + * @return A list containing all syntaxes supported by renderers. > + * @throws XmlRpcException An invalid token is provided or the syntax lookup fails. > + */ > + public List<String> getOutputSyntaxes() throws XmlRpcException > + { > + List<String> result = new ArrayList<String>(); > + Object[] objects = (Object[]) invokeRpc("getOutputSyntaxes", this.token); > + for(Object object:objects) > + { > + result.add((String)object); > + } > + return result; > + } > + > + /** > + * Renders a text in the context of a wiki page. > + * > + * @param pageId The id of the page. > + * @param content The contenxt to be rendered. > + * @param sourceSyntaxId The syntax of the content. > + * @param targetSyntaxId The target syntax of the rendered content > + * @return The rendered content. > + * @throws XmlRpcException If a invalid token is provided, an unsuported syntax id is given or the rendering fails. > + */ > + public String renderPageContent(String pageId, String content, String sourceSyntaxId, > + String targetSyntaxId) throws XmlRpcException > + { > + return (String) invokeRpc("renderPageContent", this.token, pageId, content, sourceSyntaxId, targetSyntaxId); > + } > + > + /** > + * Gets the rendered content of an existing document. > + * > + * @param pageId The id of the page. > + * @param syntaxId The target syntax of the rendered content > + * @return The renderded content > + * @throws Exception If a invalid token is provided, an unsuported syntax id is given or the rendering fails. > + */ > + public String getRenderedContent(String pageId, String syntaxId) throws XmlRpcException > + { > + return (String) invokeRpc("getRenderedContent", this.token, pageId, syntaxId); > + } > + > + /** > * Utility method for invoking remote RPC methods. > * > * @param methodName > > Modified: platform/core/branches/xwiki-core-2.0/xwiki-xmlrpc/xwiki-xmlrpc-model/src/main/java/org/xwiki/xmlrpc/XWikiXmlRpcApi.java > =================================================================== > --- platform/core/branches/xwiki-core-2.0/xwiki-xmlrpc/xwiki-xmlrpc-model/src/main/java/org/xwiki/xmlrpc/XWikiXmlRpcApi.java 2009-11-26 15:38:04 UTC (rev 25289) > +++ platform/core/branches/xwiki-core-2.0/xwiki-xmlrpc/xwiki-xmlrpc-model/src/main/java/org/xwiki/xmlrpc/XWikiXmlRpcApi.java 2009-11-26 16:17:04 UTC (rev 25290) > @@ -63,6 +63,11 @@ > > public String renderContent(String token, String space, String pageId, String content) throws Exception; > > + public String renderPageContent(String token, String pageId, String content, String sourceSyntaxId, > + String targetSyntaxId) throws Exception; > + > + public String getRenderedContent(String token, String pageId, String syntaxId) throws Exception; > + > public String convert(String token, String source, String initialSyntaxId, String targetSyntaxId) throws Exception; > > public List<String> getInputSyntaxes(String token) throws Exception; > > _______________________________________________ > notifications mailing list > notifications(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/notifications

2 2

[xwiki-devs] [Proposal] Component isolation implementations
by Vincent Massol 27 Nov '09

27 Nov '09

Hi, We have the need to isolate groups of components. For ex a wiki macro created in a subwiki should only be visible in that subwiki by default. Here's an implementation proposal that I'm planning to implement: * There's a Root Component Manager (the current CM) * There are 3 components which implement the ComponentManager role and with 3 hints: "wiki", "user" and "all". There's a CompositeComponentManager class that allows chaining CM and the "all" CM chains the "default" (root CM), "wiki" CM and "user" CM. This works the same as with the configuration module. * Other components can have CMs injected as they want (if not specified then it's the default, etc). For ex: @Requirement("all") private ComponentManager cm * Creation process. As for now the user creates the root CM and then the annotation loader will create the descriptors for the other CMs and register them against the root CM. They'll get instantiated once (singleton) the first time they're looked up. * In order to register a component for, say, a given "enterprise" wiki, we need to add a new property to the ComponentDescriptor: get/ setAdditionalData(Object data). For example: wikiCM.registerComponent(CD mycd) where cd.setAdditionalData("enterprise"). * Last, Guice uses Modules to isolate component definitions so it should be possible and relatively easy to port the implementation to Guice (even though Guice uses static Modules we can make them dynamic). WDYT? Thanks -Vincent

5 17

[xwiki-devs] Fwd: [ANNOUNCE] Apache Lucene Java 3.0.0 released
by Vincent Massol 27 Nov '09

27 Nov '09

fyi -Vincent Begin forwarded message: > From: "Uwe Schindler" <uschindler(a)apache.org> > Date: November 26, 2009 10:53:40 AM CEST > To: <announce(a)apache.org>, <java-user(a)lucene.apache.org>, <java-dev(a)lucene.apache.org > > > Subject: [ANNOUNCE] Apache Lucene Java 3.0.0 released > > Hello Lucene users, > > On behalf of the Lucene dev community (a growing community far > larger than > just the committers) I would like to announce the release of Lucene > Java > 3.0.0: > > The new version is mostly a cleanup release without any new > features. All > deprecations targeted to be removed in version 3.0 were removed. If > you are > upgrading from version 2.9.1 of Lucene, you have to fix all > deprecation > warnings in your code base to be able to recompile against this > version. > > This is the first Lucene release with Java 5 as a minimum > requirement. The > API was cleaned up to make use of Java 5's generics, varargs, enums, > and > autoboxing. New users of Lucene are advised to use this version for > new > developments, because it has a clean, type safe new API. Upgrading > users can > now remove unnecessary casts and add generics to their code, too. If > you > have not upgraded your installation to Java 5, please read the file > JRE_VERSION_MIGRATION.txt (please note that this is not related only > to this > version of Lucene, it will also happen with any previous release > when you > upgrade your Java environment). > > Lucene 3.0.0 has some changes regarding compressed fields: 2.9.0 > already > deprecated compressed fields; support for them was removed now. > Lucene 3.0.0 > is still able to read indexes with compressed fields, but as soon as > merges > occur or the index is optimized, all compressed fields are > decompressed and > converted to Field.Store.YES. Because of this, indexes with compressed > fields can suddenly get larger. > > While we generally try and maintain full backwards compatibility > between > major versions, Lucene 3.0.0 has some minor breaks, mostly related to > deprecation removal, pointed out in the 'Changes in backwards > compatibility > policy' section of CHANGES.txt. Notable are: > > - IndexReader.open(Directory) now opens in read-only mode per > default (this > method was deprecated because of that in 2.9.X). The same occurs to > IndexSearcher. > > - Already started in 2.9, core TokenStreams are now made final to > enforce > the decorator pattern. > > - If you interrupt an IndexWriter merge thread, IndexWriter now > throws an > unchecked ThreadInterruptedException that extends RuntimeException and > clears the interrupt status. > > > See core changes at > http://lucene.apache.org/java/3_0_0/changes/Changes.html > and contrib changes at > http://lucene.apache.org/java/3_0_0/changes/Contrib-Changes.html > > Binary and source distributions are available at > http://www.apache.org/dyn/closer.cgi/lucene/java/ > > Lucene artifacts are also available in the Maven2 repository at > http://repo1.maven.org/maven2/org/apache/lucene/ > > > ----- > Uwe Schindler > uschindler(a)apache.org > Apache Lucene Java Committer > Bremen, Germany > http://lucene.apache.org/java/docs/ > >

2 1

[xwiki-devs] Reduce heap exhaustion during export operation (and partly import for now)
by Denis Gervalle 26 Nov '09

26 Nov '09

Hi, As you knows, Import/Export operation on large XAR file cause problem. We felt on an even worse situation, where a single XWiki document is not properly exported due to heap exhaustion during the built of its XML DOM or due to large attachments. Having a look at the source, I have notice that many optimizations on the way the export is produce could be quite easily introduced. Currently, XWiki stored the exported document several times in memory during the operation, which impact performance negativly and is uselessly heavy on memory usage, even for reasonable documents. Therefore, I have started a large patch to avoid these caveats, here is the strategies I have followed: 1) The current implementation mostly build a DOM in memory for immediately serialized it into a stream. So I have remove the intermediate DOM and provide direct streaming of Element content by: 1.1) extending org.dom4j.XMLWriter to allow direct streaming of Element content into the output stream, as is, or Base64 encoded. Accessorily, my extension also ensure proper pairing of open/close tag. 1.2) writing a minimal DOMXMLWriter which extends my XMLWriter and could be used with the same toXML() code to build a DOMDocument to provide the toXMLDocument() methods to support the older implementation unchanged if ever needed. 1.3) using the above, minimal change to the current XML code was required 1.3.1) replacing element.add(Element) by either writer.writeElement) or writer.writeOpen(Element) 1.3.2) for large content, use my extensions, either writer.write(Element, InputStream) or writer.writeBase64(Element, InputStream) which use the InputStream for the element content 2) The current implementation for binary data such as attachments and export zip file is mostly based on in memory byte[] passing from function to function while these data initially came from a request.getInputStream() or are written to a response.getOutputStream (). So I have change these to passover the stream instead of the data: 2.1) using IOUtils.copy when required 2.2) using org.apache.commons.codec.binary.Base64OutputStream for base64 encoding when required 2.3) using an extension of ZipInputStream to cope with unexpected close() 2.4) avoid buffer duplication in favor of stream filters 3) Since most oftently used large data came from the database through an attachment content, it would be nice to have these attachment streamed from the database when they are too large. However, I feel that it is still too early to convert our binary into a blob, mainly because HSQLDB and MySQL still does not really support blob, just an emulation. These are also used to be cached in the document cache, and this will require improvement to support blob. However I propose to take the occasion to go in the direction of the blob by: 3.1) deprecating setContent(byte[]) and Byte[] getContent() in favor of newly created setContent(InputStream, int), InputStream getContentInputStream() and getSize() 3.2) Begin to use these new function as much as possible as 2) implied 3.3) this also open the ability to store attachment in another repository that support better the streaming aspect (ie: a filesystem) I am currently testing the above changes onto our client project, and I expect to provide a patch really soon. It will require an upgrade of org.apache.commons.codec to version 1.4, to have access to Base64OutputStream. I feel it will be a first step into the right direction, further improvement should be to: - import XML using a SAXParser without building a DOM in memory - manage JRCS Archive better, the way they are built and store raise the same issue then attachment - manage the recycle bin better for the same reason - improve caching to avoid caching very large stuffs WDYT ? Denis Gervalle -- SOFTEC sa http://www.softec.st

4 5

[xwiki-devs] Regarding renaming a page
by durgaprasad karri 26 Nov '09

26 Nov '09

Hello All, I have this use case that when i rename a page it should rename the other pages with same name in the same space. ex., there are 3 pages with names "A" ,"B" and "A has / of B" in a space. when i rename "A" to say "renamedA" we need to change the other pages to" renamedA has / of B" and the same for renaming a page with name "B". I tried to catch the events when i do a rename action on the page , and there are two events fired DocumentSaveEvent and DocumentDeleteEvent and tried to apply my logic in my component to rename the pages with name in the same space but it failed . i checked the implementation of the rename method and there the object name is not changed for the renamed document because of which when i try hql query with doc.name=obj.name it fails. is there any way through which i can solve my use case? Regards Durga

1 0

[xwiki-devs] [VOTE] Add new XWiki APIs for searching attachments (ie without programming rights)
by Vincent Massol 26 Nov '09

26 Nov '09

Hi, I'd like to apply Caleb's patch for http://jira.xwiki.org/jira/browse/XWIKI-4410 . This issue is a prereq to fix "AllDocs's attachment tab requires programming right to work" (http://jira.xwiki.org/jira/browse/XE-521) This means introducing the following new APIs: - public List<Attachment> searchAttachments(String parametrizedSqlClause, int nb, int start, List< ? > parameterValues) throws XWikiException - public List<Attachment> searchAttachments(String whereSql, int nb, int start) throws XWikiException - public List<Attachment> searchAttachments(String whereSql) throws XWikiException - public int countAttachments(String parametrizedSqlClause, List< ? > parameterValues) throws XWikiException - public int countAttachments(String whereSql) throws XWikiException Here's my +1 (even though it keeps making the class larger but I don't have any other idea for now without a huge refactoring) Thanks -Vincent

4 3

[xwiki-devs] [VOTE] API modifications to the Rendering module to handle optional Transformations
by Vincent Massol 26 Nov '09

26 Nov '09

Hi, We have the need to handle optional Transformations (for Annotations and more generally for user-introduced annotations). Here's what Thomas and I are proposing: 1) We remove the TransformationManager component from the Rendering module (public API). This means that calling code must lookup Transformations directly. 2) We modify the Converter interface in the Rendering module in 2 ways: - add a new signature that takes a list of Transformation as parameter - modify the implementation for the signature that take no Transformation params so that no Transformations are executed when it's used (API breakage) 3) We add a XWiki configuration parameter in xwiki.properties to list the transformations that must be executed (it's a list of component hints) when a document is rendered. If this config param is not defined then the default value will contain the Macro Transformation. 4) We introduce a new module called xwiki-presentation which will contain code to handle XWiki Presentation stuff. For example: - template handling - displayers (document displayer, object displayers, etc) - display configuration - more to be defined but related to presentation The idea would be to move stuff that is currently in XWiki/ XWikiDocument related to presentation there (for example XWikiDocument.getRenderedContent could be replaced by DocumentDisplayer.display(DocumentName, Syntax, Writer output) - to be defined later). 5) In order to allow modules to not depend on xwiki-core we introduce PresentationConfiguration in the new xwiki-presentation module defined in 4) with a getViewTransformations() method corresponding to a "presentation.viewTransformations" configuration parameter. 6) We introduce a new TransformationContext class similar to MacroTransformationContext and modify the Transformation API to: void transform(XDOM, TransformationContext) (instead of XDOM dom, Syntax syntax)). TransformationContext would contain 2 type of data: - the syntax - the list of transformations being executed (this is required by some Macros. For ex the HTML macro needs it and other may need it too) 7) We remove the getPriority() method from the Transformation interface 8) We modify calling code: WYSIWYG, XMLRPC, etc to use the new Converter API and to lookup PresentationConfiguration to get access to the list of view transformations to be executed. Here's my +1 Thanks -Vincent PS: A long and complex mail... sorry about that...

6 5

[xwiki-devs] [VOTE] Refactor rendering submodules to sort by syntax instead of by parser/renderer
by Thomas Mortagne 26 Nov '09

26 Nov '09

Hi devs, I would like to reorg a little rendering submodule on svn/maven to have: xwiki-rendering - xwiki-rendering-syntaxes -- xwiki-rendering-syntax-wikimodel -- xwiki-rendering-syntax-xml instead of the current xwiki-rendering - xwiki-rendering-parsers -- xwiki-rendering-parser-wikimodel -- xwiki-rendering-parser-xml - xwiki-rendering-renderers -- xwiki-rendering-renderer-wikimodel -- xwiki-rendering-renderer-xml Because parsers and renderer for a same syntax usually share informations and are synchronized. Here is my +1 -- Thomas Mortagne

7 8

[xwiki-devs] [VOTE] Move XWikiContextInitializationFilter to xwiki-core
by Marius Dumitru Florea 26 Nov '09

26 Nov '09

Hi devs, I'd like to move http://svn.xwiki.org/svnroot/xwiki/platform/web/trunk/wysiwyg/src/main/java… to http://svn.xwiki.org/svnroot/xwiki/platform/core/trunk/xwiki-core/src/main/… Here's my +1. Thanks, Marius

6 7

[xwiki-devs] [VOTE] Add getRenderedContent method to xml-rpc
by Florin Ciubotaru 26 Nov '09

26 Nov '09

Hi devs, I want to add two new methods to the xml-rpc api: - String getRenderedContent(String token, String pageId, String syntaxId); - String getRenderedContent(String token, String pageId, String content, String syntaxId); Currently we are only able to get xhtml/1.0 output by using getPage and accesing page.Content from the methods output. We need this new methods to get the output in different syntaxes(Eg: annotatedxhtml). This is useful to parse the output for macros, images and links like we do in the wysiwyg. I'd like the code to go in the 2.0.4 release. The old method invocation required different method names. Since we don't have the xml-rpc cleanup in 2.0.4 we probably need to have different naming for the methods above. Since starting with 2.1 we use the Apache Xml-Rpc method lookup and invocation, we might be able to use the same name and different signature in the future. I'll need to check this. WDYT? Thanks, Florin Ciubotaru

4 3