- xwiki-devs@xwiki.org - lists.xwiki.org

[xwiki-devs] excel plugin for xwiki
by Vivian Richard 02 Jan '09

02 Jan '09

Hi I am trying to use the excel plugin for xwiki enterprise 1.7. Since I am using java 1.6, I downloaded this plugin http://code.xwiki.org/xwiki/bin/view/Plugins/ExcelPluginDownload?version=1.… and followed these instructions: http://code.xwiki.org/xwiki/bin/view/Plugins/ExcelPlugin But with out any result. By the way I am using my windows XP machine. Can someone please point out why it is not working and how can I make it work? Regards.....

1 0

Re: [xwiki-devs] [xwiki-notifications] r15010 - in sandbox/xwiki-officeimporter: . src/main/java/org/xwiki/officeimporter/html/filter src/test/java/org/xwiki/officeimporter/html/cleaner
by Vincent Massol 02 Jan '09

02 Jan '09

Hi Asiri, If you want to run your tests with different initial conditions you should use a Test Suite instead and pass the cleaner in the constructor of the Test Case class. That said, I don't see why you'd want to run the same tests again. Since the implementation is the same the result will be the same! What you need to test are the extra things you've added to WysiwygDefaultHTMLCleaner. Thanks -Vincent On Jan 2, 2009, at 7:04 AM, asiri (SVN) wrote: > Author: asiri > Date: 2009-01-02 07:04:20 +0100 (Fri, 02 Jan 2009) > New Revision: 15010 > > Added: > sandbox/xwiki-officeimporter/src/test/java/org/xwiki/ > officeimporter/html/cleaner/AbstractHTMLCleanerTestCase.java > sandbox/xwiki-officeimporter/src/test/java/org/xwiki/ > officeimporter/html/cleaner/WysiwygDefaultHTMLCleanerTest.java > Modified: > sandbox/xwiki-officeimporter/pom.xml > sandbox/xwiki-officeimporter/src/main/java/org/xwiki/ > officeimporter/html/filter/TableFilter.java > sandbox/xwiki-officeimporter/src/test/java/org/xwiki/ > officeimporter/html/cleaner/OpenOfficeDefaultHTMLCleanerTest.java > Log: > * Added few more test cases. > > Modified: sandbox/xwiki-officeimporter/pom.xml > =================================================================== > --- sandbox/xwiki-officeimporter/pom.xml 2009-01-02 03:59:29 UTC > (rev 15009) > +++ sandbox/xwiki-officeimporter/pom.xml 2009-01-02 06:04:20 UTC > (rev 15010) > @@ -73,4 +73,17 @@ > <scope>test</scope> > </dependency> > </dependencies> > + <build> > + <plugins> > + <plugin> > + <groupId>org.apache.maven.plugins</groupId> > + <artifactId>maven-surefire-plugin</artifactId> > + <configuration> > + <excludes> > + <exclude>**/Abstract*.java</exclude> > + </excludes> > + </configuration> > + </plugin> > + </plugins> > + </build> > </project> > \ No newline at end of file > > Modified: sandbox/xwiki-officeimporter/src/main/java/org/xwiki/ > officeimporter/html/filter/TableFilter.java > =================================================================== > --- sandbox/xwiki-officeimporter/src/main/java/org/xwiki/ > officeimporter/html/filter/TableFilter.java 2009-01-02 03:59:29 UTC > (rev 15009) > +++ sandbox/xwiki-officeimporter/src/main/java/org/xwiki/ > officeimporter/html/filter/TableFilter.java 2009-01-02 06:04:20 UTC > (rev 15010) > @@ -36,12 +36,12 @@ > public class TableFilter implements HTMLFilter > { > /** > - * Tags that need to be removed from cell items. > + * Tags that need to be removed from cell items while > preserving there children. > */ > private static final String[] filterTags = new String[] {"p"}; > > /** > - * Tags that need to be removed from cell items. > + * Tags that need to be completely removed from cell items. > */ > private static final String[] removeTags = new String[] {"br"}; > > @@ -54,7 +54,7 @@ > for (int i = 0; i < cellItems.getLength(); i++) { > Node cellItem = cellItems.item(i); > cleanNode(cellItem); > - // Workaround empty cells. > + // Workaround empty cells. > if (cellItem.getTextContent().equals("")) { > boolean empty = true; > for (int j = 0; j < > cellItem.getChildNodes().getLength(); j++) { > @@ -81,7 +81,13 @@ > NodeList children = node.getChildNodes(); > boolean removed = false; > if (node.getNodeType() == Node.TEXT_NODE) { > - node.setTextContent(node.getTextContent().trim()); > + String trimmedContent = node.getTextContent().trim(); > + if (trimmedContent.equals("")) { > + parent.removeChild(node); > + removed = true; > + } else { > + node.setTextContent(trimmedContent); > + } > } else if (Arrays.binarySearch(filterTags, > node.getNodeName()) >= 0) { > while (children.getLength() > 0) { > Node child = children.item(0); > @@ -95,7 +101,9 @@ > removed = true; > } else { > for (int i = 0; i < children.getLength(); i++) { > - i = cleanNode(children.item(i)) ? i-- : i; > + if (cleanNode(children.item(i))) { > + --i; > + } > } > } > return removed; > > Added: sandbox/xwiki-officeimporter/src/test/java/org/xwiki/ > officeimporter/html/cleaner/AbstractHTMLCleanerTestCase.java > =================================================================== > --- sandbox/xwiki-officeimporter/src/test/java/org/xwiki/ > officeimporter/html/cleaner/ > AbstractHTMLCleanerTestCase.java (rev 0) > +++ sandbox/xwiki-officeimporter/src/test/java/org/xwiki/ > officeimporter/html/cleaner/AbstractHTMLCleanerTestCase.java > 2009-01-02 06:04:20 UTC (rev 15010) > @@ -0,0 +1,112 @@ > +/* > + * See the NOTICE file distributed with this work for additional > + * information regarding copyright ownership. > + * > + * This is free software; you can redistribute it and/or modify it > + * under the terms of the GNU Lesser General Public License as > + * published by the Free Software Foundation; either version 2.1 of > + * the License, or (at your option) any later version. > + * > + * This software is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this software; if not, write to the Free > + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA > + * 02110-1301 USA, or see the FSF site: http://www.fsf.org. > + */ > +package org.xwiki.officeimporter.html.cleaner; > + > +import java.io.StringReader; > + > +import org.w3c.dom.Document; > +import org.w3c.dom.NodeList; > +import org.xwiki.xml.html.HTMLCleaner; > + > +import com.xpn.xwiki.test.AbstractXWikiComponentTestCase; > + > +/** > + * Abstract test case class for all HTMLCleaner tests. > + * > + * @version $Id$ > + * @since 1.8M1 > + */ > +public class AbstractHTMLCleanerTestCase extends > AbstractXWikiComponentTestCase > +{ > + /** > + * Beginning of the test html document. > + */ > + protected String header = "<html><head><title>Title</title></ > head><body>"; > + > + /** > + * Beginning of the test html document, which has a {@code > <style> tag.} > + */ > + protected String headerWithStyles = > + "<html><head><style type=\"text/css\">h1 {color:red} p > {color:blue} </style><title>Title</title></head><body>"; > + > + /** > + * Ending of the test html document.. > + */ > + protected String footer = "</body></html>"; > + > + /** > + * Test most basic cleaning. > + */ > + public void testBasicCleaning(HTMLCleaner cleaner) > + { > + String html = header + footer; > + Document doc = cleaner.clean(new StringReader(html)); > + assertNotNull(doc.getDoctype()); > + } > + > + /** > + * Test stripping of {@code <style>} and {@code <script>} tags. > + */ > + public void testTagStripping(HTMLCleaner cleaner) > + { > + String html = headerWithStyles + footer; > + Document doc = cleaner.clean(new StringReader(html)); > + NodeList nodes = doc.getElementsByTagName("style"); > + assertEquals(0, nodes.getLength()); > + html = > + header + "<script type=\"text/javascript > \">document.write(\"Hello World!\")</script>" > + + footer; > + doc = cleaner.clean(new StringReader(html)); > + nodes = doc.getElementsByTagName("script"); > + assertEquals(0, nodes.getLength()); > + } > + > + /** > + * Test stripping of redundant tags. > + */ > + public void testRedundancyFiltering(HTMLCleaner cleaner) > + { > + // <span> & <div> tags without attributes should be > stripped off. > + String htmlTemplate = header + "<p>Test%sRedundant > %sFiltering<p>" + footer; > + String[] attributeWiseFilteredTags = new String[] {"span", > "div"}; > + for (String tag : attributeWiseFilteredTags) { > + String startTag = "<" + tag + ">"; > + String endTag = "</" + tag + ">"; > + String html = String.format(htmlTemplate, startTag, > endTag); > + Document doc = cleaner.clean(new StringReader(html)); > + NodeList nodes = doc.getElementsByTagName(tag); > + assertEquals(0, nodes.getLength()); > + } > + // Tags that usually contain textual information like > <strong>, <code>, <em> etc. etc. > + // should be filtered if they do not contain any textual > content. > + htmlTemplate = header + "<p>Test%sRedundant%s%s > %sFiltering<p>" + footer; > + String[] contentWiseFilteredTags = > + new String[] {"em", "strong", "dfn", "code", "samp", > "kbd", "var", "cite", "abbr", > + "acronym", "address", "blockquote", "q", "pre", "h1", > "h2", "h3", "h4", "h5", "h6"}; > + for(String tag: contentWiseFilteredTags) { > + String startTag = "<" + tag + ">"; > + String endTag = "</" + tag + ">"; > + String html = String.format(htmlTemplate, startTag, > endTag, startTag, endTag); > + Document doc = cleaner.clean(new StringReader(html)); > + NodeList nodes = doc.getElementsByTagName(tag); > + assertEquals(1, nodes.getLength()); > + } > + } > +} > > Modified: sandbox/xwiki-officeimporter/src/test/java/org/xwiki/ > officeimporter/html/cleaner/OpenOfficeDefaultHTMLCleanerTest.java > =================================================================== > --- sandbox/xwiki-officeimporter/src/test/java/org/xwiki/ > officeimporter/html/cleaner/OpenOfficeDefaultHTMLCleanerTest.java > 2009-01-02 03:59:29 UTC (rev 15009) > +++ sandbox/xwiki-officeimporter/src/test/java/org/xwiki/ > officeimporter/html/cleaner/OpenOfficeDefaultHTMLCleanerTest.java > 2009-01-02 06:04:20 UTC (rev 15010) > @@ -22,48 +22,135 @@ > import java.io.StringReader; > > import org.w3c.dom.Document; > +import org.w3c.dom.Element; > +import org.w3c.dom.Node; > +import org.w3c.dom.NodeList; > import org.xwiki.xml.html.HTMLCleaner; > > -import com.xpn.xwiki.test.AbstractXWikiComponentTestCase; > - > /** > * Test case for default open office html cleaner. > - * > + * > * @version $Id$ > * @since 1.8M1 > */ > -public class OpenOfficeDefaultHTMLCleanerTest extends > AbstractXWikiComponentTestCase > +public class OpenOfficeDefaultHTMLCleanerTest extends > AbstractHTMLCleanerTestCase > { > /** > - * Beginning of the test html document. > - */ > - private String header = "<html><head><title>Title</title></ > head><body>"; > - > - /** > - * Ending of the test html document.. > - */ > - private String footer = "</body></html>"; > - > - /** > * Open office html cleaner. > */ > private HTMLCleaner cleaner; > - > + > /** > * {@inheritDoc} > */ > protected void setUp() throws Exception > { > super.setUp(); > - cleaner = (HTMLCleaner) > getComponentManager().lookup(HTMLCleaner.ROLE, "openoffice-default"); > + cleaner = > + (HTMLCleaner) > getComponentManager().lookup(HTMLCleaner.ROLE, "openoffice-default"); > } > - > + > /** > * Test most basic cleaning. > */ > - public void testBasicCleaning() { > - String html = header + footer; > + public void testBasicCleaning() > + { > + super.testBasicCleaning(cleaner); > + } > + > + /** > + * Test stripping of {@code <style>} and {@code <script>} tags. > + */ > + public void testTagStripping() > + { > + super.testTagStripping(cleaner); > + } > + > + /** > + * Test stripping of redundant tags. > + */ > + public void testRedundancyFiltering() > + { > + super.testRedundancyFiltering(cleaner); > + } > + > + /** > + * Test filtering of html links. > + */ > + public void testLinkFiltering() > + { > + String html = header + "<a href=\"http://www.xwiki.org > \">xwiki</a>" + footer; > Document doc = cleaner.clean(new StringReader(html)); > - assertNotNull(doc.getDoctype()); > + NodeList nodes = doc.getElementsByTagName("a"); > + assertEquals(1, nodes.getLength()); > + Node link = nodes.item(0); > + Element span = (Element) link.getParentNode(); > + assertEquals("span", span.getNodeName()); > + assertEquals("wikiexternallink", span.getAttribute("class")); > + Node startComment = span.getPreviousSibling(); > + > assertTrue(startComment.getNodeValue().startsWith("startwikilink")); > + Node stopComment = span.getNextSibling(); > + > assertTrue(stopComment.getNodeValue().startsWith("stopwikilink")); > } > + > + /** > + * Test filtering of html lists. > + */ > + public void testListFiltering() > + { > + // Leading spaces inside list items are not allowed. > + String html = header + "<ol><li> Test</li></ol>" + footer; > + Document doc = cleaner.clean(new StringReader(html)); > + NodeList nodes = doc.getElementsByTagName("li"); > + Node listContent = nodes.item(0).getFirstChild(); > + assertEquals(Node.TEXT_NODE, listContent.getNodeType()); > + assertEquals("Test", listContent.getNodeValue()); > + // Paragraphs inside list items are not allowed. > + html = header + "<ol><li><p>Test</p></li></ol>" + footer; > + doc = cleaner.clean(new StringReader(html)); > + listContent = nodes.item(0).getFirstChild(); > + assertEquals(Node.TEXT_NODE, listContent.getNodeType()); > + assertEquals("Test", listContent.getNodeValue()); > + // Leading space plus a starting paragraph. > + html = header + "<ol><li> <p>Test</p></li></ol>" + footer; > + doc = cleaner.clean(new StringReader(html)); > + listContent = nodes.item(0).getFirstChild(); > + assertEquals(Node.TEXT_NODE, listContent.getNodeType()); > + assertEquals("Test", listContent.getNodeValue()); > + } > + > + /** > + * Test filtering of html tables. > + */ > + public void testTableFiltering() > + { > + // Leading or trailing spaces inside cell items are not > allowed. > + String html = header + "<table><tr><td> Test </td></tr></ > table>" + footer; > + Document doc = cleaner.clean(new StringReader(html)); > + NodeList nodes = doc.getElementsByTagName("td"); > + Node cellContent = nodes.item(0).getFirstChild(); > + assertEquals(Node.TEXT_NODE, cellContent.getNodeType()); > + assertEquals("Test", cellContent.getNodeValue()); > + // Paragraphs are not allowed inside cell items. > + html = header + "<table><tr><td> <p>Test</p> </td></tr></ > table>" + footer; > + doc = cleaner.clean(new StringReader(html)); > + nodes = doc.getElementsByTagName("td"); > + cellContent = nodes.item(0).getFirstChild(); > + assertEquals(Node.TEXT_NODE, cellContent.getNodeType()); > + assertEquals("Test", cellContent.getNodeValue()); > + // Line breaks are not allowed inside cell items. > + html = header + "<table><tr><td><br/><p><br/>Test</p> </ > td></tr></table>" + footer; > + doc = cleaner.clean(new StringReader(html)); > + nodes = doc.getElementsByTagName("td"); > + cellContent = nodes.item(0).getFirstChild(); > + assertEquals(Node.TEXT_NODE, cellContent.getNodeType()); > + assertEquals("Test", cellContent.getNodeValue()); > + // Empty cells should be replaced by a '-' (this is > temporary) > + html = header + "<table><tr><td><br/><p><br/></p> </td></ > tr></table>" + footer; > + doc = cleaner.clean(new StringReader(html)); > + nodes = doc.getElementsByTagName("td"); > + cellContent = nodes.item(0).getFirstChild(); > + assertEquals(Node.TEXT_NODE, cellContent.getNodeType()); > + assertEquals("-", cellContent.getNodeValue()); > + } > } > > Added: sandbox/xwiki-officeimporter/src/test/java/org/xwiki/ > officeimporter/html/cleaner/WysiwygDefaultHTMLCleanerTest.java > =================================================================== > --- sandbox/xwiki-officeimporter/src/test/java/org/xwiki/ > officeimporter/html/cleaner/ > WysiwygDefaultHTMLCleanerTest.java (rev 0) > +++ sandbox/xwiki-officeimporter/src/test/java/org/xwiki/ > officeimporter/html/cleaner/WysiwygDefaultHTMLCleanerTest.java > 2009-01-02 06:04:20 UTC (rev 15010) > @@ -0,0 +1,71 @@ > +/* > + * See the NOTICE file distributed with this work for additional > + * information regarding copyright ownership. > + * > + * This is free software; you can redistribute it and/or modify it > + * under the terms of the GNU Lesser General Public License as > + * published by the Free Software Foundation; either version 2.1 of > + * the License, or (at your option) any later version. > + * > + * This software is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this software; if not, write to the Free > + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA > + * 02110-1301 USA, or see the FSF site: http://www.fsf.org. > + */ > +package org.xwiki.officeimporter.html.cleaner; > + > +import org.xwiki.xml.html.HTMLCleaner; > + > +/** > + * Test case for default wysiwyg html cleaner. > + * > + * @version $Id$ > + * @since 1.8M1 > + */ > +public class WysiwygDefaultHTMLCleanerTest extends > AbstractHTMLCleanerTestCase > +{ > + > + /** > + * Wysiwyg html cleaner. > + */ > + private HTMLCleaner cleaner; > + > + /** > + * {@inheritDoc} > + */ > + protected void setUp() throws Exception > + { > + super.setUp(); > + cleaner = > + (HTMLCleaner) > getComponentManager().lookup(HTMLCleaner.ROLE, "wysiwyg-default"); > + } > + > + /** > + * Test most basic cleaning. > + */ > + public void testBasicCleaning() > + { > + super.testBasicCleaning(cleaner); > + } > + > + /** > + * Test stripping of {@code <style>} and {@code <script>} tags. > + */ > + public void testTagStripping() > + { > + super.testTagStripping(cleaner); > + } > + > + /** > + * Test stripping of redundant tags. > + */ > + public void testRedundancyFiltering() > + { > + super.testRedundancyFiltering(cleaner); > + } > +}

2 2

[xwiki-devs] RESTful API alpha
by Fabio Mancinelli 31 Dec '08

31 Dec '08

Dear all, I've committed a first implementation of the RESTful API as described on http://dev.xwiki.org/xwiki/bin/view/Design/RestfulAPI Not all the URIs are working but pages and translations are. You can: * GET / * GET /spaces * GET /spaces/{spaceId}/pages * GET|PUT /spaces/{spaceId}/pages/{pageId} * GET|PUT /spaces/{spaceId}/pages/{pageId}/translations/{translationId} PUT will create/modify the corresponding page. You can use curl to interoperate with the API. Some examples: * curl -u Admin:admin -X PUT -d "Hello world" -H "Content-Type: text/plain" http://localhost:8080/xwiki/rest/spaces/Main/pages/WebHome Will set the content of Main.WebHome to "Hello world" * curl -u Admin:admin -X PUT -d @text.txt -H "Content-Type: text/plain" http://localhost:8080/xwiki/rest/spaces/Main/pages/WebHome Will set the Main.WebHome content to whatever is writen in the text.txt file. * curl -u Admin:admin -X PUT -d @page.xml -H "Content-Type: application/xml" http://localhost:8080/xwiki/rest/spaces/Main/pages/WebHome Will set the Main.WebHome attributes to whatever is written in the page.xml. The xml file must conform to the structure described in the design page. This allows to change the content, the title and to reparent the page. * curl -u Admin:admin -X PUT -d @text.txt -H "Content-Type: text/plain" http://localhost:8080/xwiki/rest/spaces/Not/pages/Existing Will create the Not.Existing page and set its content to whatever is writen in the text.txt file. Currently the implementation is in the sandbox and is available for public review (http://svn.xwiki.org/svnroot/xwiki/sandbox/xwiki-core-rest/) It uses the XStream library (http://xstream.codehaus.org) for XML serialization/deserialization of data types. Very handy. Comments are welcome. -Fabio

3 5

[xwiki-devs] [Idea] Add document XDOM structure content to XML page export
by Vincent Massol 30 Dec '08

30 Dec '08

Hi, I think it might be interesting to export a document's structure (the XDOM) to the XML we generate for pages (?xpage=xml), in addition to the unparsed content and the rendered content. This would make it easy for external tools to process page structures and extract required information. More importantly it's something easy to do now. WDYT? This is low priority but I thought it could be interesting. Technically this means writing a DOMListener (which creates a w3c Document from a XDOM). Thanks -Vincent

4 4

[xwiki-devs] [PROPOSAL] Update DocumentAccessBridge
by Asiri Rathnayake 30 Dec '08

30 Dec '08

Hi Devs, I'm upgrading office-importer code base to new architecture. For this I suggest following methods to be added to the DocumentAccessBridge: 1. createNewDocument(String documentName, String content) //This method will throw an exception if the document already exists. 2. setDocumentContent(String documentName, String newContent) //For updating an existing document. 3. setDocumentSyntaxId(String documentName, String syntaxId) //For presentation documents the syntax would be 1.0 and for others it would be 2.0 4. addAttachmentToDocument(String documentName, String AttachmentName, byte [] attachmentData) //For making attachments 5. isDocumentEditable(String documentName) //This is following isDocumentViewable() mthod. But we could also have a hasRight() mthod instead. I'm +1 for all. But please let me know if any of above methods are redundant / not required / has wrong signature. Thanks. - Asiri

3 3

[xwiki-devs] [VOTE] Support multilines headers
by Thomas Mortagne 30 Dec '08

30 Dec '08

Hi everyone Currently the XWiki 2.0 parser does not support multilines headers, meaning that it consider new line as end of header: = Heading 1 = give "<h1>Heading</h1><p>1 =</p>" I propose to have the same things than paragraphs: need two consecutive new lines (or the =* syntax of course) to be end of header. = Heading 1 = = Heading 2 = would give "<h1>Heading<br/>1</h1><h1>Heading</h1><p>2 =</p>" Here is my +1 Thanks, -- Thomas Mortagne

5 6

Re: [xwiki-devs] [xwiki-notifications] r14946 - platform/web/trunk/standard/src/main/webapp/templates
by Vincent Massol 29 Dec '08

29 Dec '08

On Dec 29, 2008, at 10:49 AM, Ludovic Dubost wrote: > Marius Dumitru Florea wrote: >> ludovic (SVN) wrote: >> >>> Author: ludovic >>> Date: 2008-12-29 10:10:55 +0100 (Mon, 29 Dec 2008) >>> New Revision: 14946 >>> >>> Modified: >>> platform/web/trunk/standard/src/main/webapp/templates/ >>> editwysiwygnew.vm >>> Log: >>> XWIKI-3046 GWT Editor SyncPlugin: correct loading of initial >>> content supporting images. Added a reset sync action >>> >>> Modified: platform/web/trunk/standard/src/main/webapp/templates/ >>> editwysiwygnew.vm >>> =================================================================== >>> --- platform/web/trunk/standard/src/main/webapp/templates/ >>> editwysiwygnew.vm 2008-12-29 09:10:38 UTC (rev 14945) >>> +++ platform/web/trunk/standard/src/main/webapp/templates/ >>> editwysiwygnew.vm 2008-12-29 09:10:55 UTC (rev 14946) >>> @@ -47,11 +47,16 @@ >>> hookId: 'content', >>> #if($request.sync=="1") >>> syncPage: '$doc.fullName', >>> + plugins: 'separator text valign list indent undo format >>> symbol link image table sync', >>> >> >> >>> + inputURL: "${request.contextPath}/ >>> com.xpn.xwiki.wysiwyg.Wysiwyg/empty.html", >>> >> >> > Well I need a read empty content, and the issue is that when > parseTemplate returns empty this is not considered as ok and will > generate an error. So I have to use a real static HTML. What I need is > not the exact relative path but the server part name so that images > display properly. > > This is currently working. This is good enough for now and specific to > the sync method, since this is demo code. We can change it later. Well this definitely needs comments since it's a hack and not an obvious one. Thanks -Vincent > Ludovic > >> Why do you need this empty.html? Did you try setting the wysiwyg >> input >> to an empty string? >> >> #set($ok = $wysiwygInput.put($wysiwygInputKey, "")) ? >> >> Plus, all the links and images will be relative to >> ${request.contextPath}/com.xpn.xwiki.wysiwyg.Wysiwyg and this is >> not good. >> >> >>> + #if($request.reset=="1") >>> + syncReset: 1, >>> + #end >>> #else >>> inputURL: "${tdoc.getExternalURL("view", >>> "xpage=wysiwyginput&key=$wysiwygInputKey")}", >>> + plugins: 'separator text valign list indent undo format >>> symbol link image table', >>> #end >>> syntax: "$doc.syntaxId", >>> - plugins: 'separator text valign list indent undo format >>> symbol link image table', >>> toolbar: 'bold italic underline strikethrough | subscript >>> superscript | unorderedlist orderedlist | outdent indent | undo >>> redo | format | hr symbol | link unlink | image | inserttable >>> deletetable | insertrowbefore insertrowafter deleterow | >>> insertcolbefore insertcolafter deletecol', >>> space: '${doc.space}', >>> page: '${doc.name}',

2 1

Re: [xwiki-devs] [xwiki-notifications] r14946 - platform/web/trunk/standard/src/main/webapp/templates
by Vincent Massol 29 Dec '08

29 Dec '08

On Dec 29, 2008, at 10:17 AM, Anca Paula Luca wrote: > ludovic (SVN) wrote: >> Author: ludovic >> Date: 2008-12-29 10:10:55 +0100 (Mon, 29 Dec 2008) >> New Revision: 14946 >> >> Modified: >> platform/web/trunk/standard/src/main/webapp/templates/ >> editwysiwygnew.vm >> Log: >> XWIKI-3046 GWT Editor SyncPlugin: correct loading of initial >> content supporting images. Added a reset sync action >> >> Modified: platform/web/trunk/standard/src/main/webapp/templates/ >> editwysiwygnew.vm >> =================================================================== >> --- platform/web/trunk/standard/src/main/webapp/templates/ >> editwysiwygnew.vm 2008-12-29 09:10:38 UTC (rev 14945) >> +++ platform/web/trunk/standard/src/main/webapp/templates/ >> editwysiwygnew.vm 2008-12-29 09:10:55 UTC (rev 14946) >> @@ -47,11 +47,16 @@ >> hookId: 'content', >> #if($request.sync=="1") >> syncPage: '$doc.fullName', >> + plugins: 'separator text valign list indent undo format >> symbol link image table sync', > > Ludovic, > is the sync plugin ready to be activated by default? I hope it's not activated by default on the 1.7 branch! (haven't checked) Thanks -Vincent > Happy coding, > Anca Luca > >> + inputURL: "${request.contextPath}/ >> com.xpn.xwiki.wysiwyg.Wysiwyg/empty.html", >> + #if($request.reset=="1") >> + syncReset: 1, >> + #end >> #else >> inputURL: "${tdoc.getExternalURL("view", >> "xpage=wysiwyginput&key=$wysiwygInputKey")}", >> + plugins: 'separator text valign list indent undo format >> symbol link image table', >> #end >> syntax: "$doc.syntaxId", >> - plugins: 'separator text valign list indent undo format >> symbol link image table', >> toolbar: 'bold italic underline strikethrough | subscript >> superscript | unorderedlist orderedlist | outdent indent | undo >> redo | format | hr symbol | link unlink | image | inserttable >> deletetable | insertrowbefore insertrowafter deleterow | >> insertcolbefore insertcolafter deletecol', >> space: '${doc.space}', >> page: '${doc.name}', >>

2 1

[xwiki-devs] General Development Flow + Release Cycles
by Vincent Massol 26 Dec '08

26 Dec '08

Hi everyone, We have discussed this in the past but I wanted to formalize it so I've taken the time to write 2 new sections in our development practices: * General Development Flow: http://dev.xwiki.org/xwiki/bin/view/Community/DevelopmentPractices#HGeneral… * Frequent Releases: http://dev.xwiki.org/xwiki/bin/view/Community/DevelopmentPractices#HFrequen… All devs should be sure to read them and agree with them. If you don't agree that's fine, we can discuss it and revise what's written. The end goal is to make us work all together nicely and smoothly. Thanks and a merry christmas to all -Vincent

1 0

[xwiki-devs] [RFC] RESTful API + Mediatypes
by Fabio Mancinelli 26 Dec '08

26 Dec '08

Dear all, I am starting a new thread because the old one started to be overloaded. I have started to write some media types that could be used as the representations returned by our RESTful API. It's a first attempt but they already contain some ideas and the guiding design principle I would like to follow. You can find them on http://dev.xwiki.org/xwiki/bin/view/Design/RestfulAPI Comments are welcome. -Fabio

1 0