- xwiki-devs@xwiki.org - lists.xwiki.org

[xwiki-devs] [VOTE] Allow multi-line headers
by Marius Dumitru Florea 05 Jan '09

05 Jan '09

Hi devs, A) Should xwiki/2.0 support multi-line headers? I'm +0. Wikimodel, HTML and Open Office support them. B) What should happen when you press Enter inside a header in the new WYSIWYG? B1) Currently, the text is moved on a new line, but still inside the header (multi-line header). I'm +1 since it's already done (We agreed that you have to press Enter twice to generate a new paragraph). B2) Text is moved in a new paragraph, below the header. Shift+Enter would have the effect described in B1). I'm -0. B3) Text is moved in a new header of the same level, below the current one. Shift+Enter would have the effect described in B1). This is what Open Office does (and we agreed not to follow it). I'm -0. Please cast your vote asap. Thanks, Marius.

8 16

[xwiki-devs] [Proposal]Adding ability to display an optional image and a optional title in the Box macro
by Dan Miron 05 Jan '09

05 Jan '09

Hi. Regarding the http://jira.xwiki.org/jira/browse/XWIKI-2967 issue and the http://jira.xwiki.org/jira/browse/XWIKI-2882 one, this is the proposal: Proposal: The title to support wiki syntax and the image to support absolute URLs as well as local stored images. Reason: The goal is to reuse the boxMacro in for implementing RssMacro, Warning and Error macros. The most complex of them being the RssMacro. So, a RSS feed should be rendered as follows: --------------------------------------- optional image (provided as an URL to an image stored outside the wiki, anywhere in the web) title (which can be a static text or a link to a web location containing the full news article) body - which consists of several news articles, each article being structured as follows: ................................................. title (link or static text, the same situation as above) optional body (plain text) ................................................. ----------------------------------------- Basically, the Wiki 2.0 RssMacro should behave like the old Radeox RssMacro. Now, for the RssMacro I was planning to use a "big" box (rendendered using the improved BoxMacro) which would take care of the title and the image of the RSS feed and which would contain nested "small" boxes for each news article. Also, i was planning of offering the same CSS-related features as the old Radeox RssMacro. (see http://code.xwiki.org/xwiki/bin/view/Macros/RssMacro for details) for which adding an optional cssClass parameter to the BoxMacroParameters is required. So I look forward to knowing what you think about this. Tnx. PS: all I posted here was suggested in a skype discussion with Vincent and Thomas: ................................................................................... [15:34:31] Dan Miron: well, the title is not an ordinary text it's an anchor to a web location [15:34:31] Vincent Massol: but on the general principle, do you agree about a single box macro? [15:34:48] Dan Miron: +1 for me [15:34:50] Vincent Massol: I don't understand the use case [15:34:52] … can you give one? [15:35:04] … I've never seen a title be a url [15:35:24] Dan Miron: well, when displaying the contents of a Rss feed [15:35:43] … each title is a link to the site which contains that specific article [15:36:15] Vincent Massol: you want one box per post? [15:36:24] … currentl all posts are in a single box [15:36:34] Thomas Mortagne: dan it's not the title of the box you want ? [15:36:56] … I did not understood that [15:37:23] Vincent Massol: IMO it's one box [15:37:31] Thomas Mortagne: yes [15:37:32] Vincent Massol: and iside the box macro you can put whatever wiki syntax you want [15:37:40] … including links [15:37:39] Thomas Mortagne: the macro is an entire feed [15:37:55] Dan Miron: well, i need a big box for the hole rss content which holds several other "small" boxes for each article [15:38:16] Vincent Massol: oh you want to nest box macros [15:38:19] Thomas Mortagne: theses small bowex are not macros [15:38:27] Vincent Massol: it could be thomas [15:38:36] Thomas Mortagne: well [15:38:57] Dan Miron: i was planing to use for both the big and the small boxes the same messageboxMacro i was going to create [15:38:59] Thomas Mortagne: I don't like very much that a macro generate other macro if it's not really needed [15:39:25] Vincent Massol: but if he wants to have a style for the boxes inside he'll need that I think [15:39:26] Thomas Mortagne: but meybe it make sense here [15:39:43] Vincent Massol: or he'll have to reinvent the box macro [15:40:10] Thomas Mortagne: this means the boxmacro need to support to be in a boxmacro [15:40:26] Vincent Massol: that's supported by the rendering engine [15:40:35] Thomas Mortagne: currently it's not the case as the big and small box will have the same color for example [15:40:44] … it needs some css [15:40:45] Vincent Massol: but the box macro will need to support this [15:40:49] … yes [15:40:55] Thomas Mortagne: but on pure rendering side yes it's supported [15:41:59] … so yes use nested macro boxes is a good idea here Dan ;) [15:42:26] Vincent Massol: now re the links I'm not sure yet [15:42:37] … there are different ways of doing that I guess [15:43:29] … one idea (brainstorming): we could allow inline wiki syntax to be used the title parameter maybe [15:44:14] Dan Miron: yes, it could be a way [15:44:17] Thomas Mortagne: I like that yes [15:46:45] Vincent Massol: hmm I wonder if this is something we'd want for all macros [15:47:09] … not sure [15:47:17] Thomas Mortagne: at wors we can add a isTitleWiki [15:47:19] Vincent Massol: even for this use case I'm stil not fully sure [15:47:51] … it sounds good but I wonder if we'd get side effects [15:48:09] … actually we wan't do that in a generic way for all macros [15:48:20] … since it's not going to generate text [15:48:25] … but Blocks [15:48:32] … so the macro needs to handle that [15:48:50] … s/Wan't/can't/ [15:49:33] … ok I think I'm +1 for making the image and title params allow inline wiki syntax here for this macro [15:49:45] … (it's a good experiment, we'll see how it goes) [15:49:49] … wdyt? [15:49:53] Thomas Mortagne: +1 [15:50:03] Jean-Vincent Drean: +1 [15:50:45] Thomas Mortagne: by the way Dan, Vincent already created http://jira.xwiki.org/jira/browse/XWIKI-2967 (on which you are assigned) [15:51:01] Vincent Massol: since our wiki syntax is clean there's little chance a normal title will not be rendered as the user thinks [15:52:11] Dan Miron: +1 [15:53:03] Vincent Massol: dan: I think you can close http://jira.xwiki.org/jira/browse/XWIKI-3025 as duplicate [15:54:16] Dan Miron: so we drop the idea of creating a new messaboxMacro and we focus on using the existing boxMacro? [15:55:09] Vincent Massol: yep [15:55:32] … and at the same time if you could implement info/message/error macros that would be great [15:55:41] … (there are already jira issues assigned to you for those I believe) [15:56:54] Dan Miron: in this case, could we enhance the boxmacro a little bit? [15:56:58] … for example [15:57:08] … the ability to specify custom css sheets [15:57:18] Vincent Massol: it's already supported [15:57:32] … using the (% %) notation [15:57:36] … isn't it? [15:58:54] … (% class="whatever" %){{box...}} [15:59:09] Thomas Mortagne: boxmacro alreadu support custom for the box it sould be enought [15:59:39] Dan Miron: the only way i knew for specifying a css class is inheriting the AbstractBoxMacro and overriding the getClassProperty() method [15:59:44] Thomas Mortagne: then you can use .rssbox a { } isn't it ? [16:00:42] … (for the link of rss box) [16:00:50] … an same for other content [16:01:13] … (it's maybe not the better way i'm not a css expert) [16:01:36] Vincent Massol: thomas: that's not good enough [16:01:43] … since there can be other a inside other boxes [16:02:01] … but using a FormatBlock can be used to create a new class as I mentioned above [16:02:07] Thomas Mortagne: then bow can define specific class for title and such [16:02:31] … and then you use .rssbox .box_titlea { } [16:02:57] … bow = box macro [16:04:14] Vincent Massol: not sure we support params for block macros [16:04:16] … checking... [16:04:19] … but we should [16:04:40] Thomas Mortagne: we support in Block but maybe XHTMLRender does not [16:04:49] Vincent Massol: wikimodel [16:05:56] Thomas Mortagne: ok I was speaking about parameters blocks in the macro [16:06:17] Vincent Massol: inside the macro is ok since it's inline [16:06:17] Thomas Mortagne: I don't think the Xiki parser support (%%) parameters for macro [16:06:22] Vincent Massol: and we support inline params [16:06:25] … for everything [16:06:47] … note that they'll be applied to a span surrounding the element [16:07:02] Thomas Mortagne: boxmacro content is not inline [16:07:10] … you could have table intable etc. [16:08:24] Vincent Massol: ok I've checked and I don't think it's implemented [16:08:33] … we have it for all other block elements [16:08:41] … but it doesn't seem to be there for macros [16:09:02] Thomas Mortagne: as macro as parameter I guess we did not thing of supporting generic parameters [16:09:29] Vincent Massol: it could be added easily though [16:09:37] Dan Miron: if you mean specifying a css class via block parameters, it's not working, i tried that, but it gets overriden [16:11:06] Vincent Massol: actually it should even maybe fail [16:11:17] … I don't have the time to work on this right now unfortunately [16:11:56] … maybe for now you could have an optional "cssClass" parameter? [16:12:24] … and when thomas or me implement params for block macros we could refactor it [16:13:09] Dan Miron: yes, that's what i was thinking about from the beggining [16:13:37] Vincent Massol: it would be only temporary ...................................................................................

5 8

[xwiki-devs] [VOTE][UI] WYSIWYG Table dialog
by Jean-Vincent Drean 05 Jan '09

05 Jan '09

Hi, I've made a mockup for the table dialog in the WYSIWYG editor : http://incubator.myxwiki.org/xwiki/bin/download/Mockups/WebHome/TableDialog… I don't think there's a lot of room for debate with this one but I'd like to make sure we all agree. I'm sure the label for table header checkbox could be improved, any proposal ? Here's my +1. JV.

5 4

[xwiki-devs] [PROPOSAL] Summary of improvements/bugfixes needed on list syntax
by Thomas Mortagne 05 Jan '09

05 Jan '09

Hi xwikiers, During the process of doing a 1.0 to 2.0 syntax converter I found some bugs on XWiki 2.0 lists syntax/parser. Let's list them: a) The parser repeat list parameters on each sub list. See http://jira.xwiki.org/jira/browse/XWIKI-3067 for details. b) any parameter on a sub list break the list c) IMO we should support mixed list syntax (see http://markmail.org/message/a3bzyzxk4yxcwb7x) like in 1. item 1 ** item 2 (% style="list-style-type: lower-alpha" %) *** subitem 2.1 *** subitem 2.2 ** item 3 1. item 4 d) we should support adding any parameter on list item. We dont have any syntax for that. For all this I propose the following: 1) A sub list inherits from its parent 1.a) Stop repeating parameters in parser 1.b) A sub list can add new parameters 1.c) A sub list can override a parameter 2) Add support for mixed list syntax. This is about "1." and "*", the mixing of different "*" style is already covered by 1) 1.first level item ** second level item ** second level item 1. first level item 2.a) Remove the 1*. syntax support 3) Add support for list item (LI) parameters. 3.a) We will need a syntax for it. For now I propose: if this is not the first item list or if there is two parameter token the second is for the list item. This means you will need to explicitly add a empty parameters token when you want to add parameters on an the item list. (%%) (% param=value %) * first item (% param2=value %) * second item 1) +1 2) +1 because it's easier for user IMO and a lot more simple for parser than having a specific syntax for mixing syntax like with "1*.". Plus I voted for 1) and I don't like particular cases. 2.a) +1 for cleaner parser and syntax 3) +1, we need it since we generally allow custom parameters everywhere Thanks, -- Thomas Mortagne

2 1

Re: [xwiki-devs] [VOTE] Support multilines headers (SUMMARY)
by Thomas Mortagne 05 Jan '09

05 Jan '09

Three +1, two 0 and no -1 It will be part of 1.7.1. See http://jira.xwiki.org/jira/browse/XWIKI-3066 On Mon, Dec 29, 2008 at 3:30 PM, Thomas Mortagne <thomas.mortagne(a)xwiki.com> wrote: > Hi everyone > > Currently the XWiki 2.0 parser does not support multilines headers, > meaning that it consider new line as end of header: > > = Heading > 1 = > > give "<h1>Heading</h1><p>1 =</p>" > > I propose to have the same things than paragraphs: need two > consecutive new lines (or the =* syntax of course) to be end of > header. > > = Heading > 1 = > = Heading > > 2 = > > would give "<h1>Heading<br/>1</h1><h1>Heading</h1><p>2 =</p>" > > Here is my +1 > > Thanks, > -- > Thomas Mortagne > -- Thomas Mortagne

1 0

Re: [xwiki-devs] [xwiki-notifications] r15058 - in sandbox/xwiki-core-rest/src/main/java/org/xwiki/rest: . internal
by Vincent Massol 05 Jan '09

05 Jan '09

On Jan 5, 2009, at 1:00 PM, fmancinelli (SVN) wrote: > Author: fmancinelli > Date: 2009-01-05 13:00:42 +0100 (Mon, 05 Jan 2009) > New Revision: 15058 > > Added: > sandbox/xwiki-core-rest/src/main/java/org/xwiki/rest/internal/ > sandbox/xwiki-core-rest/src/main/java/org/xwiki/rest/internal/ > PageRepresenter_TEXT_PLAIN.java > sandbox/xwiki-core-rest/src/main/java/org/xwiki/rest/internal/ > PageRepresenter_TEXT_XML.java I don't think this follows the Java coding conventions for Java class Names... IMO would be better named: PlainTextPagePresenter XMLTextPagePresenter -Vincent

2 2

[xwiki-devs] [Proposal] WYSIWYG roadmap
by Jean-Vincent Drean 05 Jan '09

05 Jan '09

Hi devs, As stated in a previous thread we need a roadmap for the implementation of the final WYSIWYG specifications. This roadmap is also about making the WYSIWYG use a 3rd party framework and re-usable components. Here's a proposal : - Until december 17 all the persons working on the WYSIWYG continue fixing bugs. (Marius, Anca, JV) - December 23 : -- First version of the "wiki explorer" [1] based on smartGWT, allow to browse wikis, spaces and pages. See if it is a valid option with the link plugin as a real world example (Marius). -- Wysiwyg wizard, allow to chain dialogs and to navigate between them. Use of this wizard in the image plugin with 3 dialogs : current image browser, upload file dialog, upload in progress dialog (Anca). -- Final version of the Table UI (JV). - January 9 : -- WIP on the "wiki explorer". Allow to add spaces, add pages, browse pages attachments (Marius). -- Final version of the Link UI (Anca). -- Verbatim and quote features implemented (JV). - January 16 : -- Final version of the "wiki explorer" : allow to rename pages/spaces, to change pages parent with drag and drop. Replacement of the YUI tree by the GWT one in XE (Marius). -- Final version of the Image UI (Anca). -- Definition list feature implemented (JV). - January 23 -- First version of the Macro plugin (Anca). -- Alignment, color [2], font family [2], font size [2], custom parameters features implemented (Marius). - January 30 -- Import plugin (Marius). -- WIP on the Macro plugin, hopefully a final version (Anca). [1] Components like "wiki explorer", "color picker", "file uploader" must be usable outside of the WYSIWYG. [2] We need to vote for the inclusion of those features. JV.

3 3

[xwiki-devs] [VOTE] Tab key behavior in the new WYSIWYG editor
by Marius Dumitru Florea 05 Jan '09

05 Jan '09

Hi devs, We have to decide upon the proper behavior of the Tab key in the new WYSIWYG editor. Open Office has the following behavior: A) If the caret is inside a table cell then jump to the next one (or previous one with Shift). B) If the caret is at the beginning of a list item then indent that item (or outdent with Shift). By indent I mean make it a subitem of the previous list item. C) Otherwise insert a Tab. The Tab doesn't always have the same width; it depends on the top ruler and on the caret position. Shift+Tab is ignored. I'm +1 for A) and B) Regarding C), it's difficult to have the same behavior. What we can do is: C1) Insert spaces (say 4); we would have to use non-breaking spaces of course. C2) Insert just one (breaking) space to discourage users from using the tab key to layout text. I'm +0 for C1) and +0.5 for C2). I need your vote asap. Thanks, Marius

7 9

Re: [xwiki-devs] [xwiki-notifications] r14987 - sandbox/xwiki-core-rest/src/main/java/org/xwiki/rest
by Sergiu Dumitriu 05 Jan '09

05 Jan '09

fmancinelli (SVN) wrote: > Author: fmancinelli > Date: 2008-12-31 11:06:24 +0100 (Wed, 31 Dec 2008) > New Revision: 14987 > > Modified: > sandbox/xwiki-core-rest/src/main/java/org/xwiki/rest/PageResource.java > sandbox/xwiki-core-rest/src/main/java/org/xwiki/rest/PagesResource.java > sandbox/xwiki-core-rest/src/main/java/org/xwiki/rest/SpacesResource.java > Log: > Added proper error handling and status code setting in response headers. > > Modified: sandbox/xwiki-core-rest/src/main/java/org/xwiki/rest/PageResource.java > =================================================================== > + /* Represent */ > + if (variant.getMediaType().equals(MediaType.TEXT_XML)) { > + return new StringRepresentation(Utils.toXml(DomainObjectFactory.createPage(getRequest(), doc)), > + MediaType.APPLICATION_XML); > + } else if (variant.getMediaType().equals(MediaType.TEXT_PLAIN)) { > + return new StringRepresentation(doc.getContent(), MediaType.TEXT_PLAIN); > + } This if-else looks bad. What will happen when we support more formats? PDF, XAR, HTML, RTF, zip, RDF... -- Sergiu Dumitriu http://purl.org/net/sergiu/

3 3

[xwiki-devs] [VOTE] XWiki 2.0 syntax does not support list starting at second level or more
by Thomas Mortagne 05 Jan '09

05 Jan '09

Hi xwikiers, Currently the syntaxes ** list item and * ** list item are giving exactly the same rendering: <ul><li><ul><li>list item</li></ul></li></ul> This is expected and we have even a unit test for that but I think it's a wrong behavior. The "problem" is not really at rendering level but at wikimodel XWiki parser which send the same events for the two syntaxes: beginList beginListItem beginList beginListItem [...] endListItem endList endListItem endList I propose to change that for ** list item to render beginList beginList beginListItem [...] endListItem endList endList and <ul><ul><li>list item</li></ul></ul> and same concept for any other list level (like *** , **** , etc.). Since XDOM and XHTML support it, here is my +1. See also http://jira.xwiki.org/jira/browse/XWIKI-3057 Thanks, -- Thomas Mortagne

3 9