- xwiki-devs@xwiki.org - lists.xwiki.org

[xwiki-devs] Selecting a tool to manage localization
by Ludovic Dubost 10 Nov '08

10 Nov '08

Hi team, I wrore a report about the different localization strategies we could have for XWiki comparing: - a simple tool Jean-Vincent wrote - an L10N app I started to build - using launchpad.net http://dev.xwiki.org/xwiki/bin/view/Drafts/Selecting+a+tool+for+managing+Lo… Please review and add requirements if you see requirements that have not been listed. I think we need to look at the applications and evaluate them in more details, especially to see of launchpad.net could work for us. Let's discuss. Ludovic -- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost

7 16

[xwiki-devs] Blog terminology
by Sergiu Dumitriu 09 Nov '08

09 Nov '08

What is the best term: 1. blog post 2. blog article 3. blog entry Others? -- Sergiu Dumitriu http://purl.org/net/sergiu/

9 13

[xwiki-devs] Rewriting the comments plug-in into a component
by Florin Ciubotaru 07 Nov '08

07 Nov '08

Hi devs, We currently have a comments plug-in that is written for a custom core. This plug-in enables us to have hierarchical comments and several storage implementations. The issue I encounter when rewriting it to a plexus component is that I cannot make it independent from the core. I need both read and write access to the storage, and I could not find a bridge to it. All I can do is retrieve data, with org.xwiki.bridge.DocumentAccessBridge and org.xwiki.bridge.DocumentModelBridge, but not write data. Does anybody know how can I write a component that needs read/write access to the storage without using XWiki,XWikiDocument and XWikiContext classes? Thanks, Florin Ciubotaru

5 7

Re: [xwiki-devs] [xwiki-notifications] r14000 - platform/core/trunk/xwiki-localization/src/main/java/org/xwiki/localization/internal
by Vincent Massol 07 Nov '08

07 Nov '08

Sergiu, I don't understand this. You're doing a synchronization on an object that's recreated every time the method is called so it'll always have a different location in memory and there's no risk of contention. Thanks -Vincent On Nov 6, 2008, at 7:38 AM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2008-11-06 07:38:49 +0100 (Thu, 06 Nov 2008) > New Revision: 14000 > > Modified: > platform/core/trunk/xwiki-localization/src/main/java/org/xwiki/ > localization/internal/PulledDocumentsBundle.java > platform/core/trunk/xwiki-localization/src/main/java/org/xwiki/ > localization/internal/PulledFilesBundle.java > platform/core/trunk/xwiki-localization/src/main/java/org/xwiki/ > localization/internal/StaticDocumentsBundle.java > Log: > XWIKI-2811: Possible threading issues in the localization component > Fixed. > > > Modified: platform/core/trunk/xwiki-localization/src/main/java/org/ > xwiki/localization/internal/PulledDocumentsBundle.java > =================================================================== > --- platform/core/trunk/xwiki-localization/src/main/java/org/xwiki/ > localization/internal/PulledDocumentsBundle.java 2008-11-06 06:31:12 > UTC (rev 13999) > +++ platform/core/trunk/xwiki-localization/src/main/java/org/xwiki/ > localization/internal/PulledDocumentsBundle.java 2008-11-06 06:38:49 > UTC (rev 14000) > @@ -63,17 +63,19 @@ > List<String> documentNames = (List<String>) > this.execution.getContext().getProperty(PULLED_CONTEXT_KEY); > if (documentNames != null) { > Properties props; > - for (String documentName : documentNames) { > - try { > - // The document names should contain the wiki > prefix already. > - props = getDocumentBundle(documentName, > language); > - if (props.containsKey(key)) { > - translation = props.getProperty(key); > - // The first translation found is returned. > - break; > + synchronized (documentNames) { > + for (String documentName : documentNames) { > + try { > + // The document names should contain the > wiki prefix already. > + props = getDocumentBundle(documentName, > language); > + if (props.containsKey(key)) { > + translation = props.getProperty(key); > + // The first translation found is > returned. > + break; > + } > + } catch (Exception ex) { > + getLogger().warn("Cannot load document > bundle: [{0}]", documentName); > } > - } catch (Exception ex) { > - getLogger().warn("Cannot load document bundle: > [{0}]", documentName); > } > } > } > @@ -102,7 +104,9 @@ > documentNames = new ArrayList<String>(); > > this.execution.getContext().setProperty(PULLED_CONTEXT_KEY, > documentNames); > } > - documentNames.add(documentName); > + synchronized (documentNames) { > + documentNames.add(documentName); > + } > } > } > > > Modified: platform/core/trunk/xwiki-localization/src/main/java/org/ > xwiki/localization/internal/PulledFilesBundle.java > =================================================================== > --- platform/core/trunk/xwiki-localization/src/main/java/org/xwiki/ > localization/internal/PulledFilesBundle.java 2008-11-06 06:31:12 UTC > (rev 13999) > +++ platform/core/trunk/xwiki-localization/src/main/java/org/xwiki/ > localization/internal/PulledFilesBundle.java 2008-11-06 06:38:49 UTC > (rev 14000) > @@ -54,16 +54,18 @@ > List<String> fileNames = (List<String>) > this.execution.getContext().getProperty(PULLED_CONTEXT_KEY); > if (fileNames != null) { > Properties props; > - for (String fileName : fileNames) { > - try { > - props = getFileBundle(fileName, language); > - if (props.containsKey(key)) { > - translation = props.getProperty(key); > - // The first translation found is returned. > - break; > + synchronized (fileNames) { > + for (String fileName : fileNames) { > + try { > + props = getFileBundle(fileName, language); > + if (props.containsKey(key)) { > + translation = props.getProperty(key); > + // The first translation found is > returned. > + break; > + } > + } catch (Exception e) { > + getLogger().warn("Cannot load resource > bundle: [{0}]", fileName); > } > - } catch (Exception e) { > - getLogger().warn("Cannot load resource bundle: > [{0}]", fileName); > } > } > } > @@ -86,7 +88,9 @@ > fileNames = new ArrayList<String>(); > > this.execution.getContext().setProperty(PULLED_CONTEXT_KEY, > fileNames); > } > - fileNames.add(bundleLocation); > + synchronized (fileNames) { > + fileNames.add(bundleLocation); > + } > } > } > } > > Modified: platform/core/trunk/xwiki-localization/src/main/java/org/ > xwiki/localization/internal/StaticDocumentsBundle.java > =================================================================== > --- platform/core/trunk/xwiki-localization/src/main/java/org/xwiki/ > localization/internal/StaticDocumentsBundle.java 2008-11-06 06:31:12 > UTC (rev 13999) > +++ platform/core/trunk/xwiki-localization/src/main/java/org/xwiki/ > localization/internal/StaticDocumentsBundle.java 2008-11-06 06:38:49 > UTC (rev 14000) > @@ -111,7 +111,9 @@ > String oldBundleNames = > StringUtils.join(this.staticBundleNames.remove(wiki), JOIN_SEPARATOR); > String newBundleNames = > StringUtils.join(this.getStaticDocumentBundles(wiki), JOIN_SEPARATOR); > if (!StringUtils.equals(oldBundleNames, > newBundleNames)) { > - this.staticBundles.remove(wiki); > + synchronized (this.staticBundles) { > + this.staticBundles.remove(wiki); > + } > } > } > }

2 2

Re: [xwiki-devs] [xwiki-notifications] r13997 - platform/pom/trunk
by Vincent Massol 07 Nov '08

07 Nov '08

Hi Sergiu, On Nov 6, 2008, at 7:22 AM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2008-11-06 07:22:48 +0100 (Thu, 06 Nov 2008) > New Revision: 13997 > > Modified: > platform/pom/trunk/pom.xml > Log: > [misc] > Lock down another maven plugin version > Declare a default version for the shared test dependency > > > Modified: platform/pom/trunk/pom.xml > =================================================================== > --- platform/pom/trunk/pom.xml 2008-11-06 06:08:51 UTC (rev 13996) > +++ platform/pom/trunk/pom.xml 2008-11-06 06:22:48 UTC (rev 13997) > @@ -171,6 +171,7 @@ > <dependency> > <groupId>com.xpn.xwiki.platform.tools</groupId> > <artifactId>xwiki-verification-resources</artifactId> > + <version>${platform.tool.verification.version}</ > version> I don't think this is right. There should be no version specified IMO since this parent POM can be used by any module and some modules will want to use a different version. WDYT? Thanks -Vincent > </dependency> > </dependencies> > <configuration> > @@ -271,6 +272,12 @@ > </plugin> > <plugin> > <groupId>org.apache.maven.plugins</groupId> > + <artifactId>maven-plugin-plugin</artifactId> > +  > + <version>2.3</version> > + </plugin> > + <plugin> > + <groupId>org.apache.maven.plugins</groupId> > <artifactId>maven-site-plugin</artifactId> >  > <version>2.0-beta-6</version> > @@ -396,6 +403,7 @@ > <properties> >  > <xwiki.checkstyle.skip>false</xwiki.checkstyle.skip> > + <platform.tool.verification.version>1.12-SNAPSHOT</ > platform.tool.verification.version> > </properties> > <profiles> > <profile>

3 4

[xwiki-devs] XWiki usable for this + how to go on about component development
by Ion Tichy 07 Nov '08

07 Nov '08

Hi, we wish to use xwiki in a large project and find it difficult to see if the component architeture suits us. We need to hook into the login process (effectively logging users in through our own authentication process). Can this be done using a 'plugin' or 'component' for xwiki? Also: we need to intercept the page creation process and update our local indexes with certain things when a user saves a page. Can this be done throuh a plugin/component? How would one go on about setting an eclipse project up, where a component can be developed and debugged? Do I need to check out the entire Wiki into the Eclipse workspace? -- View this message in context: http://n2.nabble.com/XWiki-usable-for-this-%2B-how-to-go-on-about-component… Sent from the XWiki- Dev mailing list archive at Nabble.com.

5 8

[xwiki-devs] Jar file versions
by Paul Bernard 06 Nov '08

06 Nov '08

I don't see documentation anywhere which identifies which versions of jar files are being used (lucene, ecache, etc.). Is there a way to find this out? Also a way to know which versions are being used in a pending release? Thanks, Paul Bernard

3 2

[xwiki-devs] [Proposal] Make XHTML macro not parse wiki syntax by default
by Vincent Massol 06 Nov '08

06 Nov '08

Hi, Right now the XHTML macro parses wiki syntax by default. For example the following generates a bold: {{xhtml}} <p>**bold**</p> {{/xhtml}} I propose to change that so that wiki syntax is not parsed by default so that users will need to use the following to parse wiki syntax: {{xhtml wiki=true}} <p>**bold**</p> {{/xhtml}} Note that I'm proposing to change the current "escapeWikiSyntax" to "wiki" (another proposal is to use "allowWikiSyntax"). WDYT? Thanks -Vincent

7 6

[xwiki-devs] [VOTE] add glassfish/derby distribution and move jetty distributions in jetty subfolder
by Thomas Mortagne 06 Nov '08

06 Nov '08

Hi devs, Since the general discussion about distributions (see http://markmail.org/message/nqyvd34knm5eqkru) will need some time and I need to commit the glasshfish distribution build as soon as possible, I propose: - add a folder "glassfish" - add a "derby" subfolder containing the glassfish-derby distribution build - move all jetty related distributions in "jetty" folder et same lever than "glassfish" and change all artifact ids as xwiki-enterprise-jetty-* (xwiki-enterprise-jetty-hsqldb, xwiki-enterprise-jetty-derby, etc.) - use -Pglassfish to build glassfish and -Pjetty to build jetty (jetty being the default one to not change anything to current build except for the artifacts ids) here is my +1 WDYT ? -- Thomas Mortagne

5 7

Re: [xwiki-devs] [xwiki-notifications] r13949 - in sandbox/xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/plugin/officeimporter: filter transformer
by Sergiu Dumitriu 06 Nov '08

06 Nov '08

asiri (SVN) wrote: > Author: asiri > Date: 2008-11-04 11:31:26 +0100 (Tue, 04 Nov 2008) > New Revision: 13949 > + private void filter(Node node) > + { > + if (node.hasAttributes()) { > + try { > + node.getAttributes().removeNamedItem("style"); > + } catch (DOMException ex) { > + // Not a problem. > + } > + } I don't like this... try-catch code is costly, since creating an exception takes a lot of time and memory. Can't you check if the 'style' attribute exists instead? And a catch block in general should indicate an exceptional execution, not a normal, expected case. -- Sergiu Dumitriu http://purl.org/net/sergiu/

3 10