- xwiki-devs@xwiki.org - lists.xwiki.org

[xwiki-devs] [VOTE] Release XWiki Workspaces 1.0 RC2
by Jerome Velociter 22 Apr '08

22 Apr '08

Dear devs, I would like to release XWiki Workspaces 1.0 RC 2 on next monday, the 21th. Here are the changes planned for this release : http://jira.xwiki.org/jira/secure/IssueNavigator.jspa?reset=true&pid=10302&… And my +1 :) Regards, Jerome

4 4

Re: [xwiki-devs] [xwiki-notifications] r9225 - in xwiki-platform/xwiki-applications/trunk/wiki-manager/src/main/resources: WikiCode WikiManager WikiResources XApp
by Sergiu Dumitriu 22 Apr '08

22 Apr '08

I see there are more changes than just "Upgrade version information"... tmortagne (SVN) wrote: > Author: tmortagne > Date: 2008-04-17 19:08:18 +0200 (Thu, 17 Apr 2008) > New Revision: 9225 > Modified: xwiki-platform/xwiki-applications/trunk/wiki-manager/src/main/resources/WikiManager/CreateNewWiki > =================================================================== > --- xwiki-platform/xwiki-applications/trunk/wiki-manager/src/main/resources/WikiManager/CreateNewWiki 2008-04-17 17:06:48 UTC (rev 9224) > +++ xwiki-platform/xwiki-applications/trunk/wiki-manager/src/main/resources/WikiManager/CreateNewWiki 2008-04-17 17:08:18 UTC (rev 9225) > @@ -12,9 +12,9 @@ > <customClass></customClass> > <contentAuthor>XWiki.Admin</contentAuthor> > <creationDate>1186676964000</creationDate> > -<date>1204903048000</date> > -<contentUpdateDate>1204903048000</contentUpdateDate> > -<version>394.1</version> > +<date>1208445240000</date> > +<contentUpdateDate>1208445240000</contentUpdateDate> > +<version>23.1</version> > <title></title> > <template></template> > <defaultTemplate></defaultTemplate> > @@ -189,7 +189,9 @@ > ## > 1 $msg.get("wikimanager.createwiki") > #if ($wstepbystep) > + [$msg.get("wikimanager.action.createwiki.nonstepbystep")>CreateNewWiki#if($documentation)?doc=1#end] > #else > + [$msg.get("wikimanager.action.createwiki.stepbystep")>CreateNewWiki?stepbystep=0&#if($documentation)doc=1#end] > #end > ## > #if ($action && $action == "create") > @@ -427,9 +429,9 @@ > <dl> > <dt><label for="wikitemplate">$msg.get("wikimanager.wikitemplate")</label></dt> > <dd> > - <select name="wikitemplate" id="wikitemplate"> > + #set ($listtemplate=$WikiManager.getWikiTemplateList()) > + <select #if($listtemplate.size() == 0)disabled#end name="wikitemplate" id="wikitemplate"> > <option value="">---</option> > - #set ($listtemplate=$WikiManager.getWikiTemplateList()) > #foreach ($template in $listtemplate) > <option value="$template.wikiName">$template.wikiName</option> > #end > @@ -444,9 +446,9 @@ > <dl> > <dt><label for="wikipackage">$msg.get("wikimanager.wikipackage")</label></dt> > <dd> > - <select name="wikipackage" id="wikipackage"> > + #set ($listpackage=$doc.getAttachmentList()) > + <select #if($listpackage.size() == 0)disabled#end name="wikipackage" id="wikipackage"> > <option value="">---</option> > - #set ($listpackage=$doc.getAttachmentList()) > #foreach ($package in $listpackage) > <option value="$package.getFilename()">$package.getFilename()</option> > #end > @@ -534,6 +536,8 @@ > #end > <div id="actioncreate"> > <br /> > + #if ($request.stepbystep) <input type="hidden" name="stepbystep" value="$request.stepbystep" /> #end > + #if ($request.doc) <input type="hidden" name="doc" value="$request.doc" /> #end > <input type="submit" name="actioncreate" value="${msg.get("create")}" onclick="return validate();" /> > </div> > </fieldset> > @@ -156,6 +156,9 @@ > wikimanager.prop.wiki.homepage=Home page > wikimanager.prop.alias.server=Domain name > wikimanager.prop.alias.homepage=Home page > +XWiki.XWikiServerClass_visibility_public=Public > +XWiki.XWikiServerClass_visibility_private=Private > +XWiki.XWikiServerClass_visibility_template=Template > ## > # DOC > ## > @@ -168,7 +171,7 @@ > wikimanager.doc.createwiki.desc=Set all the properties of your wiki here. All theses properties can be changed at any time in the wiki's descriptor page. > wikimanager.doc.createwiki.desc.wikiprettyname=The display name of the wiki. > wikimanager.doc.createwiki.desc.description=A brief wiki description. > -wikimanager.doc.createwiki.desc.server=The domain name used to access the wiki. The default domain name suffix is ~~{0}~~. To change it edit this wiki page and search the $DOMAINNAME in TOOLS section.<br />You can add more domains latter in the wiki's descriptor page. > +wikimanager.doc.createwiki.desc.server=The domain name used to access the wiki. The default domain name suffix is ~~{0}~~. To change it edit this wiki page and search the \"$DOMAINNAME\" in TOOLS section.<br />You can add more domains latter in the wiki's descriptor page. > wikimanager.doc.createwiki.desc.owner=A global user who will have all the rights on this wiki. > wikimanager.doc.createwiki.datafrom=When creating a new wiki you obtain by default an empty wiki. You can use wiki template and/or XAR packages as content sources for the new wiki. > wikimanager.doc.createwiki.datafrom.template=First the wiki template content will be copied in the new wiki. To add more templates in the list set property ~~Visibility~~ of the wiki "template" in its wiki descriptor page. > -- Sergiu Dumitriu http://purl.org/net/sergiu/

2 1

Re: [xwiki-devs] [xwiki-notifications] r9278 - xwiki-products/xwiki-enterprise/trunk/wiki/src/main/resources/XWiki
by Sergiu Dumitriu 21 Apr '08

21 Apr '08

jvdrean (SVN) wrote: > +#if ($request.get("xpage") && $request.get("xpage") == "plain") The proper way is to write: #if ("$!{request.get('xpage')}" == "plain") -- Sergiu Dumitriu http://purl.org/net/sergiu/

1 0

[xwiki-devs] How to include servlets in Xwiki?
by Kamna Jain 21 Apr '08

21 Apr '08

Hello, Can somebody tell me how to include a servlet in Xwiki. I came across the following in the macros.vm file: But, I am not very sure as to where do I save the servlet and is #includeServlet("/xwiki/bin/view/Some/Document?params") this the syntax to include a servlet? I mean does this line go into the Xwiki editor? Thanks ## #includeServlet("/xwiki/bin/view/Some/Document?params") ## Invokes on the server another servlet corresponding to the passed URL, and returns the output. ## This is done using standard servlet mechanisms (javax.servlet.RequestDispatcher#include). ## #macro(includeServlet $url)  $xwiki.invokeServletAndReturnAsString($url)  #end ##

1 0

Re: [xwiki-devs] [xwiki-notifications] r9235 - xwiki-platform/core/trunk/xwiki-core/src/main/resources xwiki-platform/skins/trunk/albatross/src/main/resources/albatross xwiki-platform/skins/trunk/toucan/src/main/resources/toucan xwiki-products/xwiki-enterprise/trunk/distribution-test/selenium-tests/src/test/it/com/xpn/xwiki/it/selenium xwiki-products/xwiki-enterprise/trunk/wiki/src/main/resources/Main xwiki-products/xwiki-enterprise/trunk/wiki/src/main/resources/XWiki
by Sergiu Dumitriu 21 Apr '08

21 Apr '08

jvdrean (SVN) wrote: > Modified: xwiki-platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties > =================================================================== > --- xwiki-platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties 2008-04-18 10:34:43 UTC (rev 9234) > +++ xwiki-platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties 2008-04-18 14:14:39 UTC (rev 9235) > @@ -41,6 +41,7 @@ > save=Save > delete=Delete > preview=Preview > +copy=Copy > login=Log-in > logout=Log-out > homepage=User Profile > @@ -65,6 +66,8 @@ > author=Author > lastauthor=Last Author > filename=Filename > +rights=Rights > +actions=Actions > default=default > confirmobjectremove=Are you sure you want to remove this object? > confirmdelete=This action is not reversible. Are you sure you want to delete this document? I second Vincent. There should be no "generic" resources. Even if a piece of text appears in more than one place, each feature/page should be self-contained. In the future each feature might come in its own xar, together with its resources, and ApplicationResources should either disappear or contain core messages only, nothing related to the interface. > Modified: xwiki-platform/skins/trunk/albatross/src/main/resources/albatross/usersandgroups.css This should be renamed (split?) to something like ajaxTable.css, and the selectors should be not on specific IDs, but to all tables with a specific class (like .ajaxTable) > Added: xwiki-products/xwiki-enterprise/trunk/distribution-test/selenium-tests/src/test/it/com/xpn/xwiki/it/selenium/AllDocsTest.java > + /** > + * Validate input suggest for Page field. > + */ > + public void testTableViewSuggestForPage() > + { > + getSelenium().typeKeys("page", "Treeview"); > + // The table is updated via Ajax, we give it the time to make this call > + getSelenium().setSpeed("1000"); > + assertElementPresent("//td[@class='pagename']/a[text()='Treeview']"); > + getSelenium().setSpeed("0"); > + } This test should be done like: - typeKeys - waitForCondition(loading is displayed) - waitForCondition(loading disappears) - assertPresent(Treeview) - assertNotPresent(AllDocs) and maybe delete the filter and assert that AllDocs is there The same for the other filter tests. > + public void testTableViewSuggestForSpace() > + public void testTableViewSuggestForLastAuthor() > + public void testTableViewCopyAction() > + { > + getSelenium().typeKeys("page", "treeview"); Shouldn't this have some waiting? > + assertElementPresent("//td[@class='pagename']/a[text()='Treeview']"); > + assertElementPresent("link=Copy"); > + clickLinkWithText("Copy"); This already asserts, so the above assertElementPresent("link=Copy") is not needed. > + setFieldValue("targetdoc", "New.TreeviewCopy"); > + getSelenium().click("//input[@value='Copy']"); > + open(getUrl("Main", "AllDocs")); > + getSelenium().typeKeys("space", "New"); > + getSelenium().typeKeys("page", "treeviewcopy"); > + assertElementPresent("//td[@class='pagename']/a[text()='TreeviewCopy']"); > + } > + -- Sergiu Dumitriu http://purl.org/net/sergiu/

1 0

[xwiki-devs] Building directly to a specific database (MySQL in the case)
by Tiago Rinck Caveden 21 Apr '08

21 Apr '08

Hello! This is a beginner question, sorry if it's documented somewhere but I didn't find it. I've read the documentation available at http://dev.xwiki.org/xwiki/bin/view/Community/Building#HBuildingforaspecifi…, made the configuration as suggested (changing the .m2/settings.xml file) and executed mvn install -Pmysql, but in the end, my hibernate.cfg.xml (inside xwiki-product-enterprise/web/target/xwiki-enterprise-web-1.4-SNAPSHOT/WEB-INF/) had still the MySQL section commented. I've also noted that the mysql-connector jar is not at the lib dir after the build. Isn't there a way to build the application for mysql and have it ready to run without any intervention? (changing and adding files) If there is, what am I missing? (By the way, is this the proper list for such a question or should I have mailed this to the users list?) Thank you very much, -- Tiago Rinck Caveden http://caveden.multiply.com

4 5

Re: [xwiki-devs] [xwiki-notifications] r9229 - in xwiki-products/xwiki-enterprise/trunk/distribution-test/selenium-tests/src/test/it/com/xpn/xwiki/it/selenium: . framework
by Vincent Massol 18 Apr '08

18 Apr '08

Hi Sergiu, On Apr 18, 2008, at 1:28 AM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2008-04-18 01:28:31 +0200 (Fri, 18 Apr 2008) > New Revision: 9229 > > Modified: > xwiki-products/xwiki-enterprise/trunk/distribution-test/selenium- > tests/src/test/it/com/xpn/xwiki/it/selenium/AllTests.java > xwiki-products/xwiki-enterprise/trunk/distribution-test/selenium- > tests/src/test/it/com/xpn/xwiki/it/selenium/framework/ > XWikiTestSuite.java > Log: > [cleanup] Apply codestyle [snip] > > * { > - * XWikiTestSuite suite = new XWikiTestSuite("My Suite"); > + * XWikiTestSuite suite = new XWikiTestSuite("My > Suite"); This looks strange. I'm offline right now so can't svn up to check but it looks like the quotes were replaced with " in the java class. [snip] Thanks -Vincent

2 4

Re: [xwiki-devs] [xwiki-notifications] r9235 - xwiki-platform/core/trunk/xwiki-core/src/main/resources xwiki-platform/skins/trunk/albatross/src/main/resources/albatross xwiki-platform/skins/trunk/toucan/src/main/resources/toucan xwiki-products/xwiki-
by Jean-Vincent Drean 18 Apr '08

18 Apr '08

On Fri, Apr 18, 2008 at 7:54 PM, Vincent Massol <vincent(a)massol.net> wrote: > > I think we should also provides the French translation by default > since lots of us are French and can translate it easily... True; done. > Also it might be good to follow the naming conventions started by > Sergiu. > I thought copy/rights/actions were generic enough to be included like this. > > + public void setUp() throws Exception > > + { > > + super.setUp(); > > + loginAsAdmin(); > > + open(getUrl("Main", "AllDocs")); > > + } > > + > > + /** > > + * Validate presence of "Actions" column in table view for > > administrator. Validate absence of > > + * "Actions" column for users without administration rights. > > + */ > > + public void testTableViewActionsPresence() > > + { > > + assertElementPresent("//td[text()='Actions']"); > > + > > + // Verify that the user is logged in and log out > > + if (isAuthenticated()) { > > + logout(); > > Why is that needed since the setup always does a loginAsAdmin? I think > this can be changed to: logout(); Indeed; done. > > + /** > > + * Validate input suggest for Page field. > > + */ > > + public void testTableViewSuggestForPage() > > + { > > + getSelenium().typeKeys("page", "Treeview"); > > + // The table is updated via Ajax, we give it the time to > > make this call > > + getSelenium().setSpeed("1000"); > > + assertElementPresent("//td[@class='pagename']/ > > a[text()='Treeview']"); > > + getSelenium().setSpeed("0"); > > Is the setSpeed() required? We don't do any action after it's set so > is it used for anything? Shouldn't it be before the typeKeys? The setSpeed() affects the assert that follows (without this setSpeed the test fails). > There are way too many test methods. These are NOT unit tests and thus > 1) are costly and 2) are not supposed to be independent of each other. > > Thus most of them should be grouped in the same test method IMO, with > nice comments separating them. Maybe we don't need to have a single > test method but they should be grouped according to what they are doing. My bad, all the tests were grouped in Evelina's version, I've re-grouped them. Thanks, -- Jean-Vincent Drean

1 0

Re: [xwiki-devs] [xwiki-notifications] r9235 - xwiki-platform/core/trunk/xwiki-core/src/main/resources xwiki-platform/skins/trunk/albatross/src/main/resources/albatross xwiki-platform/skins/trunk/toucan/src/main/resources/toucan xwiki-products/xwiki-enterprise/trunk/distribution-test/selenium-tests/src/test/it/com/xpn/xwiki/it/selenium xwiki-products/xwiki-enterprise/trunk/wiki/src/main/resources/Main xwiki-products/xwiki-enterprise/trunk/wiki/src/main/resources/XWiki
by Vincent Massol 18 Apr '08

18 Apr '08

Some quick comments below. First let me say: Very cool tests! This is really cool and needed and it's good to see we're improving our tests. Well done Evelina/JV. On Apr 18, 2008, at 4:14 PM, jvdrean (SVN) wrote: > Author: jvdrean > Date: 2008-04-18 16:14:39 +0200 (Fri, 18 Apr 2008) > New Revision: 9235 > > Added: > xwiki-products/xwiki-enterprise/trunk/distribution-test/selenium- > tests/src/test/it/com/xpn/xwiki/it/selenium/AllDocsTest.java > xwiki-products/xwiki-enterprise/trunk/wiki/src/main/resources/XWiki/ > Tableresults > xwiki-products/xwiki-enterprise/trunk/wiki/src/main/resources/XWiki/ > Tableview > Modified: > xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > ApplicationResources.properties > xwiki-platform/skins/trunk/albatross/src/main/resources/albatross/ > usersandgroups.css > xwiki-platform/skins/trunk/toucan/src/main/resources/toucan/ > usersandgroups.css > xwiki-products/xwiki-enterprise/trunk/distribution-test/selenium- > tests/src/test/it/com/xpn/xwiki/it/selenium/AllTests.java > xwiki-products/xwiki-enterprise/trunk/wiki/src/main/resources/Main/ > AllDocs > Log: > XE-221 : Change the table that displays all the documents > (Main.AllDocs) to use ajax for more rapid loading > XE-224 : Write selenium test to verify the behaviour of the AllDocs > ajax table > > Applied patch from Evelina with few modifications. > > Modified: xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > ApplicationResources.properties I think we should also provides the French translation by default since lots of us are French and can translate it easily... Also it might be good to follow the naming conventions started by Sergiu. [snip] > Modified: xwiki-platform/skins/trunk/albatross/src/main/resources/ > albatross/usersandgroups.css > =================================================================== > --- xwiki-platform/skins/trunk/albatross/src/main/resources/ > albatross/usersandgroups.css 2008-04-18 10:34:43 UTC (rev 9234) > +++ xwiki-platform/skins/trunk/albatross/src/main/resources/ > albatross/usersandgroups.css 2008-04-18 14:14:39 UTC (rev 9235) > @@ -1,7 +1,6 @@ > /* USERS SCROLLING SYSTEM */ > - > div.scrollbar { > - overflow: auto; > + overflow: auto !important; Is that going to change the rights and users tables? [snip] > -#userstable, #groupstable, #usersandgroupstable { > +#userstable, #groupstable, #usersandgroupstable, #alldocstable { I think we should rename the file usersandgroups.css since it's no longer about users and groups! :) (same for Toucan) [snip] > Added: xwiki-products/xwiki-enterprise/trunk/distribution-test/ > selenium-tests/src/test/it/com/xpn/xwiki/it/selenium/AllDocsTest.java [snip] > + public void setUp() throws Exception > + { > + super.setUp(); > + loginAsAdmin(); > + open(getUrl("Main", "AllDocs")); > + } > + > + /** > + * Validate presence of "Actions" column in table view for > administrator. Validate absence of > + * "Actions" column for users without administration rights. > + */ > + public void testTableViewActionsPresence() > + { > + assertElementPresent("//td[text()='Actions']"); > + > + // Verify that the user is logged in and log out > + if (isAuthenticated()) { > + logout(); Why is that needed since the setup always does a loginAsAdmin? I think this can be changed to: logout(); > + } > + assertElementNotPresent("//td[text()='Actions']"); > + } > + > + /** > + * Validate input suggest for Page field. > + */ > + public void testTableViewSuggestForPage() > + { > + getSelenium().typeKeys("page", "Treeview"); > + // The table is updated via Ajax, we give it the time to > make this call > + getSelenium().setSpeed("1000"); > + assertElementPresent("//td[@class='pagename']/ > a[text()='Treeview']"); > + getSelenium().setSpeed("0"); Is the setSpeed() required? We don't do any action after it's set so is it used for anything? Shouldn't it be before the typeKeys? Also if it's required I think we should introduce a method in our DSL for this that does setspeed, type keys and reset speed. [snip] There are way too many test methods. These are NOT unit tests and thus 1) are costly and 2) are not supposed to be independent of each other. Thus most of them should be grouped in the same test method IMO, with nice comments separating them. Maybe we don't need to have a single test method but they should be grouped according to what they are doing. [snip] Thanks -Vincent

2 1

Re: [xwiki-devs] [xwiki-notifications] r9236 - xwiki-products/xwiki-enterprise/trunk/wiki/src/main/resources/XWiki
by Vincent Massol 18 Apr '08

18 Apr '08

This is probably nitpicking but can we rename Tableresults to TableResults? And also Tableview to TableView? Thanks -Vincent On Apr 18, 2008, at 4:53 PM, jvdrean (SVN) wrote: > Author: jvdrean > Date: 2008-04-18 16:53:55 +0200 (Fri, 18 Apr 2008) > New Revision: 9236 > > Modified: > xwiki-products/xwiki-enterprise/trunk/wiki/src/main/resources/ > XWiki/Tableresults > xwiki-products/xwiki-enterprise/trunk/wiki/src/main/resources/ > XWiki/Tableview > Log: > [cleanup] Fixed pages parents > > Modified: xwiki-products/xwiki-enterprise/trunk/wiki/src/main/ > resources/XWiki/Tableresults > =================================================================== > --- xwiki-products/xwiki-enterprise/trunk/wiki/src/main/resources/ > XWiki/Tableresults 2008-04-18 14:14:39 UTC (rev 9235) > +++ xwiki-products/xwiki-enterprise/trunk/wiki/src/main/resources/ > XWiki/Tableresults 2008-04-18 14:53:55 UTC (rev 9236) > @@ -6,7 +6,7 @@ > <language></language> > <defaultLanguage></defaultLanguage> > <translation>0</translation> > -<parent></parent> > +<parent>XWiki.Tableview</parent> > <creator>XWiki.Admin</creator> > <author>XWiki.Admin</author> > <customClass></customClass> > > Modified: xwiki-products/xwiki-enterprise/trunk/wiki/src/main/ > resources/XWiki/Tableview > =================================================================== > --- xwiki-products/xwiki-enterprise/trunk/wiki/src/main/resources/ > XWiki/Tableview 2008-04-18 14:14:39 UTC (rev 9235) > +++ xwiki-products/xwiki-enterprise/trunk/wiki/src/main/resources/ > XWiki/Tableview 2008-04-18 14:53:55 UTC (rev 9236) > @@ -6,7 +6,7 @@ > <language></language> > <defaultLanguage></defaultLanguage> > <translation>0</translation> > -<parent></parent> > +<parent>Main.AllDocs</parent> > <creator>XWiki.Admin</creator> > <author>XWiki.Admin</author> > <customClass></customClass> > > _______________________________________________ > notifications mailing list > notifications(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/notifications

1 0