- xwiki-devs@xwiki.org - lists.xwiki.org

Fwd: XWIKI-872: Adding a button to start the charting wizard in the WYSIWYG editor
by Catalin Hritcu 23 Feb '07

23 Feb '07

Is there somebody who can help me with adding a button to start the charting wizard in the WYSIWYG editor. I've never used TinyMCE before so I don't even know where to start. Do I need to create a plugin just to add a button ? http://jira.xwiki.org/jira/browse/XWIKI-872 Regards, Catalin ---------- Forwarded message ---------- From: Catalin Hritcu <catalin.hritcu(a)gmail.com> Date: Feb 16, 2007 8:28 PM Subject: XWIKI-872: Adding a button to start the charting wizard in the WYSIWYG editor To: Phung Nam <phunghainam(a)xwiki.com> Hi Nam, Could you help me with this task: http://jira.xwiki.org/jira/browse/XWIKI-872 I've never mangled with TinyMCE before so I don't even know where to start. Thanks, Catalin

2 1

[VOTE] New committer: Catalin Hritcu
by Vincent Massol 23 Feb '07

23 Feb '07

Hi, I'd like to propose to vote Catalin as a new XWiki committer. Catalin has been participating for a long time now (helped on the P2P wiki, on the charting plugin, etc). He's interested in helping us more (even though he says he doesn't have lots of time which we all understand. Nevertheless he really believes in XWiki and wants to participate on the long run). Let him apply his own patches! Here's my +1 Thanks -Vincent

9 9

Help with code review of XWikiHibernateVersioningStore
by Vincent Massol 21 Feb '07

21 Feb '07

Hi, I'd like to clean a bit the XWikiHibernateVersioningStore class but I'd like to confirm my changes as I don't want to break anything. There are several methods like this one: public void updateXWikiDocArchive(XWikiDocument doc, String text, boolean bTransaction, XWikiContext context) throws XWikiException { try { if (bTransaction) { checkHibernate(context); bTransaction = beginTransaction(false, context); } Session session = getSession(context); XWikiDocumentArchive archivedoc = getXWikiDocumentArchive (doc, context); archivedoc.updateArchive(doc.getFullName(), text); saveXWikiDocArchive(archivedoc, bTransaction, context); if (bTransaction) { endTransaction(context, true, false); } } catch (Exception e) { Object[] args = { doc.getFullName() }; throw new XWikiException ( XWikiException.MODULE_XWIKI_STORE, XWikiException.ERROR_XWIKI_STORE_HIBERNATE_SAVING_OBJECT, "Exception while updating archive {0}", e, args); } finally { try { if (bTransaction) endTransaction(context, false, false); } catch (Exception e) {} } } 1) Why is checkHibernate done only when the operation is done in a transaction? 2) Why is getSession called as the session object is not used? 3) I think the endTransaction is called twice... 4) Shouldn't we log something if the endTransaction fails? Thus I'd like to: a) move the checkHibernate outside of the if(bTransaction) b) remove getSession call c) remove the first endTransaction and leave the one in the finally clause d) add a warn log if the end transaction fail ok with everyone? Thanks -Vincent ___________________________________________________________________________ Yahoo! Mail r�invente le mail ! D�couvrez le nouveau Yahoo! Mail et son interface r�volutionnaire. http://fr.mail.yahoo.com

2 3

[JIRA] Remove all "Fix for" for issues with "won't fix", "cannot reproduce", "duplicate", etc
by Vincent Massol 21 Feb '07

21 Feb '07

Hi, Right now our policy is to set the "fix for" field for all issues. I'd like to propose to exclude issues that are not resolved (ie "won't fix", etc) so that they don't appear in the JIRA release notes. JIRA is missing the ability to exclude them from the release notes so this would be a good way of doing that. Thanks -Vincent ___________________________________________________________________________ Yahoo! Mail r�invente le mail ! D�couvrez le nouveau Yahoo! Mail et son interface r�volutionnaire. http://fr.mail.yahoo.com

1 0

Logging Aspect
by Vincent Massol 20 Feb '07

20 Feb '07

Hi, Just a heads up to let you know that I have committed a Logging Aspect in our source tree (in core/src/aspect). For more information see http://jira.xwiki.org/jira/browse/XWIKI-897 and http:// www.xwiki.org/xwiki/bin/view/Community/ Debugging#HGeneratingadebugversionofXWiki This LogAspect automatically intercepts all method calls and logs them with their parameters. For related information on this see http://blogs.codehaus.org/people/ vmassol/archives/000877_logifier.html I personally find this very cool. I hope you do too ;-) Thanks -Vincent ___________________________________________________________________________ Yahoo! Mail r�invente le mail ! D�couvrez le nouveau Yahoo! Mail et son interface r�volutionnaire. http://fr.mail.yahoo.com

1 0

Re: [xwiki-commits] r2197 - xwiki/trunk/core/src/main/java/com/xpn/xwiki/api
by Vincent Massol 19 Feb '07

19 Feb '07

Hi Sergiu, I think we need: 1) to decide if we want this in the public API (personally I'm not sure and I'm actually more against it right now, reason being that Util doesn't have a strong API). 2) we definitely need a JIRA issue for this (it's not referenced below so I guess there's no JIRA issue for it). Thanks -Vincent On Feb 19, 2007, at 2:52 PM, Sergiu Dumitriu wrote: > Author: sdumitriu > Date: 2007-02-19 14:52:55 +0100 (Mon, 19 Feb 2007) > New Revision: 2197 > > Modified: > xwiki/trunk/core/src/main/java/com/xpn/xwiki/api/Context.java > Log: > Add getUtil to the Context API > (is there a reason why this wasn't in there?) > > > Modified: xwiki/trunk/core/src/main/java/com/xpn/xwiki/api/ > Context.java > =================================================================== > --- xwiki/trunk/core/src/main/java/com/xpn/xwiki/api/Context.java > 2007-02-19 13:47:19 UTC (rev 2196) > +++ xwiki/trunk/core/src/main/java/com/xpn/xwiki/api/Context.java > 2007-02-19 13:52:55 UTC (rev 2197) > @@ -23,6 +23,7 @@ > > import com.xpn.xwiki.XWikiContext; > import com.xpn.xwiki.doc.XWikiDocument; > +import com.xpn.xwiki.util.Util; > import com.xpn.xwiki.validation.XWikiValidationStatus; > import com.xpn.xwiki.web.XWikiRequest; > import com.xpn.xwiki.web.XWikiResponse; > @@ -274,4 +275,8 @@ > { > return getXWikiContext().getDisplayedFields(); > } > + public Util getUtil() > + { > + return context.getUtil(); > + } > } > > > > -- > You receive this message as a subscriber of the xwiki- > commits(a)objectweb.org mailing list. > To unsubscribe: mailto:[email protected] > For general help: mailto:[email protected]?subject=help > ObjectWeb mailing lists service home page: http://www.objectweb.org/ > wws ___________________________________________________________________________ Yahoo! Mail r�invente le mail ! D�couvrez le nouveau Yahoo! Mail et son interface r�volutionnaire. http://fr.mail.yahoo.com

1 0

XWikiDefaultStore?
by Pablo Oliveira 19 Feb '07

19 Feb '07

Hi, What is the purpose of this abstract class? AFAIK it only mirrors XWikiStoreInterface, and it seems that it is never used or referenced... Pablo

1 0

Non ascii characters in doc names, need advices for patch
by Gilles Serasset 19 Feb '07

19 Feb '07

Hi all, I filed a jira issue concerning the management of doc names that use non ascii char (which poses problems to setup using non iso-latin-1 encoding). The bug is easy to see: setup a utf-8 xwiki and create a page using name "été" for instance. Xwiki redirects you to: http://localhost:8080/xwiki/bin/edit/Main/%C3%A9t%C3%A9? template=&parent=&title=%E9t%E9 As you can see the page name is urlEncoded using UTF-8 but the aram part is encoded using ISO-latin-1 Digging into the code, this redirect is done by create.vm: $response.sendRedirect($newdoc.getURL("edit", "template=${template} &parent=${parent}${auxparams}&title=$title")) the getURL method encodes the page name, but leaves the action string untouched. Somewhere deep in the java standard servlet API, this untouched string has to be encoded and somehow is encoded in iso (I still don't know why nor where... My question is: there are 2 ways to deal with this pb: 1. expect vm macros to explicitely call a urlEncode method when an URL is built. 2. expect the sendRedirect Method to check and encode unproperly encoded URLs. I'd vote for the first solution as the second may lead to nasty results, but I definitelly need your advice for submitting a patch for this. Regards, Gilles, -- Gilles Sérasset GETA-CLIPS-IMAG (UJF, INPG & CNRS) BP 53 - F-38041 Grenoble Cedex 9 Phone: +33 4 76 51 43 80 Fax: +33 4 76 44 66 75

2 2

xwiki as portlet available?
by Haymo Meran 16 Feb '07

16 Feb '07

Hi, is the Xwki already available as JSR-168 portlet? Best regards Haymo Meran -- __________________________________________________________________ Haymo Meran email. h.meran(a)gentics.com Chief Applications Engineer mobile. +43 699 126 775 13 Gentics Software GmbH tel. +43 1 710 99 04 0 Barmherzigengasse 17/5/2 fax. +43 1 710 99 04 4 1030 Vienna, Austria web. http://www.gentics.com Der Inhalt dieser E-Mail ist eine persönliche und vertrauliche Information und nur für den Gebrauch des oben angeführten Adressaten bestimmt. Sollten Sie nicht der vorgesehene Empfänger sein, ersuchen wir Sie höflich, sich sofort mit uns ins Einvernehmen zu setzen und die E-Mail zu vernichten. Für elektronisch übermittelte Auskünfte und Ratschläge, die nicht durch nachfolgende schriftliche Ausfertigung, welche von einem zeichnungsberechtigten Vertreter unserer Gesellschaft autorisiert wurde, bestätigt werden, wird grundsätzlich keine Haftung übernommen. Gänzliche Virenfreiheit kann niemals garantiert werden und eine Haftung findet hiefür gleichfalls nicht statt. Es gilt österreichisches Recht unter Ausschluss allfälliger Kollisions- oder Verweisungsnormen. Gerichtsstand ist Wien-Innere Stadt.

1 0

New Codesytel guidlines and some questions
by Christian Gmeiner 16 Feb '07

16 Feb '07

Hi all, at the moment I am working on xml-rpc in xwiki, I am adding documentation and fix the coding style. But I run in some trouble: 1) I have an interface "ConfluenceRpcInterface", which is documentet quite well. Now in "ConfluenceRpcHandler", which implements the "ConfluenceRpcInterface" I need to add javadoc to each method. The question now: Shall I copy and paste the javadoc from the interface, is it okay to add something like /* * (non-Javadoc) * @see com.xpn.xwiki.xmlrpc.ConfluenceRpcInterface#login(java.lang.String, java.lang.String) */ or should I not document the interface and add the documentation to the implemantion of the interface? 2) ArrayList is not allowed. What should I use instead? Thanks, austriancoder

2 1