- xwiki-devs@xwiki.org - lists.xwiki.org

xwiki build.412 Build Successful
by ludovic＠xwiki.org 15 Nov '06

15 Nov '06

View results here -> http://build.xpertnet.biz/cc/buildresults/xwiki?log=log20061115111520Lbuild…

1 0

[Code review] ZipExplorer plugin
by Vincent Massol 15 Nov '06

15 Nov '06

Hi, In order to understand better the code I have reviewed the ZipExplorer plugin. Here's my code review: * There are 2 unused fields that should be removed: capacity and log * The getFileName() method can be improved: - first parameter variable must not be modified (the path one in this case). There should always be a local variable created. - I don't think XWiki URI manipulation should be done in this class at all! I'd recommend creating a XWikiURI class in charge of performing all actions on XWiki URI: creation, getting the different part, etc. In this manner is XWiki decides to change the URI format, it'll only be done in one place. This would also remove completely the need for getFileName() from ZipExplorerPlugin. * There are no javadocs... The minimum would be to have a class javadoc explaining what the plugin is doing and putting an example of how to use it. * readFromInputStream() is a generic method to read an input stream in memory. Note that this method should be moved in some generic place as it would be useful for other portion of the code and is completely generic. Even better this method is already implemented in commons-io [http://jakarta.apache.org/commons/io/api-release/org/apache/commons/io/File Utils.html#readFileToByteArray(java.io.File)]. Also note that it's a dangerous method as it's limited by the size of the memory and the size of of a byte[] array in Java... If the zip is large it's going to fail... It would be better to implement it with streaming instead, if possible. * getFileTreeList(). By reading this method's name I don't understand what it does. I also don't understand what is the difference with getFileList() (I haven't analyzed the code). * Exception handling is very very poor :-) For example: } catch (XWikiException e) { e.printStackTrace(); } catch (IOException e) { e.printStackTrace(); } * The unit tests seem to be lacking. In any case they're hard to read. I haven't fully understood them yet... I believe they shouldn't test XWiki's core but only the plugin. Let me know what you think and I'll create some jira issues to fix it. Thanks -Vincent ___________________________________________________________________________ D�couvrez une nouvelle fa�on d'obtenir des r�ponses � toutes vos questions ! Profitez des connaissances, des opinions et des exp�riences des internautes sur Yahoo! Questions/R�ponses http://fr.answers.yahoo.com

2 6

Fwd: [xwiki-commits] r1567 - xwiki/trunk
by jeremi joslin 15 Nov '06

15 Nov '06

Hi Vincent, does it make sense to have the configuration files in the svn? Can't we generate them from maven? jeremi On 11/15/06, Vincent Massol <vmassol(a)users.forge.objectweb.org> wrote: > Author: vmassol > Date: 2006-11-15 11:00:17 +0100 (Wed, 15 Nov 2006) > New Revision: 1567 > > Modified: > xwiki/trunk/.classpath > Log: > Fixed Eclipse project's classpath. Some jars were modified in lib/ and the Eclipse project hasn't been modified. In addition the source dirs were not correct since the maven2 directory reorganization. It's now compiling fine. I haven't tested any web deployment though so it's likely that it won't work. > > Modified: xwiki/trunk/.classpath > =================================================================== > --- xwiki/trunk/.classpath 2006-11-15 09:06:57 UTC (rev 1566) > +++ xwiki/trunk/.classpath 2006-11-15 10:00:17 UTC (rev 1567) > @@ -1,8 +1,10 @@ > <?xml version="1.0" encoding="UTF-8"?> > <classpath> > - <classpathentry excluding="**/.svn|**/.svn/**|com/xpn/xwiki/test/MyFormAuthentication.java|com/xpn/xwiki/test/ServletAuthTest.java|com/xpn/xwiki/test/ServletVirtualTest.java|com/xpn/xwiki/test/Servleti18nTest.java" kind="src" path="src/main/java"/> > - <classpathentry excluding="**/.svn|**/.svn/**" kind="src" path="src/main/web"/> > <classpathentry excluding="**/.svn|**/.svn/**" kind="src" path="src/test/cactus"/> > + <classpathentry kind="src" path="web/standard/src/main/webapp"/> > + <classpathentry kind="src" path="core/src/main/java"/> > + <classpathentry kind="src" path="core/src/test/java"/> > + <classpathentry kind="src" path="core/src/main/resources"/> > <classpathentry excluding="**/.svn|**/.svn/**" kind="src" path="src/test/java"/> > <classpathentry exported="true" kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/> > <classpathentry exported="true" kind="lib" path="src/test/resources"/> > @@ -36,7 +38,6 @@ > <classpathentry exported="true" kind="lib" path="lib/commons-net-1.4.1.jar"/> > <classpathentry exported="true" kind="lib" path="lib/commons-pool-1.1.jar"/> > <classpathentry exported="true" kind="lib" path="lib/concurrent.jar"/> > - <classpathentry exported="true" kind="lib" path="lib/derby-10.1.2.1.jar"/> > <classpathentry exported="true" kind="lib" path="lib/dom4j-1.6.1.jar"/> > <classpathentry exported="true" kind="lib" path="lib/ecs-1.4.2.jar"/> > <classpathentry exported="true" kind="lib" path="lib/ehcache-1.1.jar"/> > @@ -67,8 +68,6 @@ > <classpathentry exported="true" kind="lib" path="lib/InlineJavaServer.jar"/> > <classpathentry exported="true" kind="lib" path="lib/InlineJavaUser.jar"/> > <classpathentry exported="true" kind="lib" path="lib/ipresolver-UNKNOWN.jar"/> > - <classpathentry exported="true" kind="lib" path="lib/jackrabbit-core-1.0.1.jar"/> > - <classpathentry exported="true" kind="lib" path="lib/jackrabbit-jcr-commons-1.0.1.jar"/> > <classpathentry exported="true" kind="lib" path="lib/jaxrpc-1.1.jar"/> > <classpathentry exported="true" kind="lib" path="lib/jcommon-1.0.5.jar"/> > <classpathentry exported="true" kind="lib" path="lib/jcr-1.0.jar"/> > @@ -93,7 +92,6 @@ > <classpathentry exported="true" kind="lib" path="lib/org.suigeneris.jrcs.diff-0.3.0-xwiki.jar"/> > <classpathentry exported="true" kind="lib" path="lib/org.suigeneris.jrcs.rcs-0.3.0-xwiki.jar"/> > <classpathentry exported="true" kind="lib" path="lib/oro-2.0.8.jar"/> > - <classpathentry exported="true" kind="lib" path="lib/oscache-2.3.2M.jar"/> > <classpathentry exported="true" kind="lib" path="lib/picocontainer-1.1.jar"/> > <classpathentry exported="true" kind="lib" path="lib/portlet-api-1.0.jar"/> > <classpathentry exported="true" kind="lib" path="lib/qname-1.5.2.jar"/> > @@ -121,8 +119,12 @@ > <classpathentry exported="true" kind="lib" path="lib/jgroups-2.2.9.3.jar"/> > <classpathentry exported="true" kind="lib" path="lib/ws-commons-util-1.0.1.jar"/> > <classpathentry exported="true" kind="lib" path="lib/ws-commons-java5-1.0.1.jar"/> > - <classpathentry exported="true" sourcepath="lib/xmlrpc-client-3.0-sources.jar" kind="lib" path="lib/xmlrpc-client-3.0.jar"/> > - <classpathentry exported="true" sourcepath="lib/xmlrpc-common-3.0-sources.jar" kind="lib" path="lib/xmlrpc-common-3.0.jar"/> > - <classpathentry exported="true" sourcepath="lib/xmlrpc-server-3.0-sources.jar" kind="lib" path="lib/xmlrpc-server-3.0.jar"/> > - <classpathentry kind="output" path="build/web/WEB-INF/classes"/> > + <classpathentry exported="true" kind="lib" path="lib/xmlrpc-client-3.0.jar" sourcepath="lib/xmlrpc-client-3.0-sources.jar"/> > + <classpathentry exported="true" kind="lib" path="lib/xmlrpc-common-3.0.jar" sourcepath="lib/xmlrpc-common-3.0-sources.jar"/> > + <classpathentry exported="true" kind="lib" path="lib/xmlrpc-server-3.0.jar" sourcepath="lib/xmlrpc-server-3.0-sources.jar"/> > + <classpathentry kind="lib" path="lib/derby-10.1.3.1.jar"/> > + <classpathentry kind="lib" path="lib/jackrabbit-core-1.1.jar"/> > + <classpathentry kind="lib" path="lib/oscache-2.3.2-xwiki.jar"/> > + <classpathentry kind="lib" path="lib/jcaptcha-all-1.0-RC3.jar"/> > + <classpathentry kind="output" path="build/eclipse/web/WEB-INF/classes"/> > </classpath> > > > > > > -- > You receive this message as a subscriber of the xwiki-commits(a)objectweb.org mailing list. > To unsubscribe: mailto:[email protected] > For general help: mailto:[email protected]?subject=help > ObjectWeb mailing lists service home page: http://www.objectweb.org/wws > > > -- jeremi -- jeremi

2 1

[M2] Reminder: test move
by Vincent Massol 15 Nov '06

15 Nov '06

Hi there, As a reminder, I'll start moving tests we have in trunk/src/tests in core/src/test in a few hour's time. I'll move the unit tests first (the ones with no environment dependency). I'll keep the Ant build working at all times. As usual let me know if this is going to cause an issue for you. Thanks -Vincent ___________________________________________________________________________ D�couvrez une nouvelle fa�on d'obtenir des r�ponses � toutes vos questions ! Profitez des connaissances, des opinions et des exp�riences des internautes sur Yahoo! Questions/R�ponses http://fr.answers.yahoo.com

2 1

xwiki build.411 Build Successful
by ludovic＠xwiki.org 15 Nov '06

15 Nov '06

View results here -> http://build.xpertnet.biz/cc/buildresults/xwiki?log=log20061115102005Lbuild…

1 0

xwiki build.410 Build Successful
by ludovic＠xwiki.org 15 Nov '06

15 Nov '06

View results here -> http://build.xpertnet.biz/cc/buildresults/xwiki?log=log20061115044409Lbuild…

1 0

xwiki build.409 Build Successful
by ludovic＠xwiki.org 14 Nov '06

14 Nov '06

View results here -> http://build.xpertnet.biz/cc/buildresults/xwiki?log=log20061114225815Lbuild…

1 0

xwiki build.408 Build Successful
by ludovic＠xwiki.org 14 Nov '06

14 Nov '06

View results here -> http://build.xpertnet.biz/cc/buildresults/xwiki?log=log20061114183309Lbuild…

1 0

xwiki build.407 Build Successful
by ludovic＠xwiki.org 14 Nov '06

14 Nov '06

View results here -> http://build.xpertnet.biz/cc/buildresults/xwiki?log=log20061114174807Lbuild…

1 0

xwiki build.406 Build Successful
by ludovic＠xwiki.org 14 Nov '06

14 Nov '06

View results here -> http://build.xpertnet.biz/cc/buildresults/xwiki?log=log20061114165258Lbuild…

1 0