xwiki-devs

xwiki-devs@xwiki.org

9400 discussions

by Michael Reinsch

Hello! While implementing something I came around the BaseProperty and while reading the code I found several strange things. I agree with the comment above BaseProperty that this class should be abstract, mainly because getValue() always returns null. Then PropertyClass can be made abstract as well. But then I'm stuck a bit with the stuff in XWikiHibernateStore, which creates also new instances of BaseProperty and PropertyClass. It looks to me like the code there is simply cloning those objects - but why is it not using clone() then? Well, it is doing some strange stuff there anyway. While looking at all this stuff, I also found several other things which could be cleaned up to avoid bugs, to increase performance and to make things easier understandable. But before I get really started: is this kind of work wanted? I am aware that with a code base of this size it is easy to break things... -- Michael Reinsch <mr(a)uue.org> http://mr.uue.org/ ------------------------------------------------------------------------

18 years, 9 months

New plugin: Image

by Xavier MOGHRABI

Dear Developers, I've created yesterday a new plugin to resize image to add XWiki a king of thumbnail feature. A short doc (for a small plugin) is availalble at the plugin documentation: http://www.xwiki.org/xwiki/bin/view/DevGuide/Plugins+List The plugin is already used in the ObjectWebCon '06 website to display Photo Album: http://objectwebcon06.objectweb.org/xwiki/bin/Photos/ Enjoy XWiki Ref: http://mail-archive.objectweb.org/xwiki-commits/2006-02/msg00002.html -- Xavier MOGHRABI - Consortium ObjectWeb

18 years, 9 months

Plugin integration

by Xavier MOGHRABI

Hi XWiki developers, I'm preparing a small plugin for thumbnails as explain in my previous mail. The image is resized by adding a parameter heigth at this end of a download URL (eg :xwiki/bin/download/Photos/Seychelles1999/DSC04010.JPG?height=550) To call the plugin I need to add a piece of code in DownloadAction class. Do you think : - is it better to add the dependancy to the plugin in the DownloadAction class such as : // Sending the content of the attachment - byte[] data = attachment.getContent(context); + byte[] data = null; + + // Resize if imageplugin is on + ImagePlugin imageplugin = (ImagePlugin) context.getWiki().getPlugin( + "image", context); + if ((request.getParameter("height") != null) && (imageplugin != null)) { + try { + int height = Integer.parseInt(request.getParameter("height")); + data = imageplugin.createThumbnail(attachment, height, context); + response.setContentType("image/png"); + } catch (NumberFormatException e) { + } catch (Exception e) { + e.printStackTrace(); + } + } + + if (data == null) data = attachment.getContent(context); + - or is it better to add a generic method in the plugin Interface class (XWikiPluginInterface) with a method : startDownloading(byte[] data, XWikiContext context) and to call it after in DownloadAction ? Regards -- Xavier MOGHRABI - Consortium ObjectWeb

18 years, 9 months

Problem when creating a Plugin

by Xavier MOGHRABI

Dear XWiki Dev, I try to create a plugin which should reduce the image size to have a kind of thumbnail feature. To do that I've created a plugin a part of the code is hereunder. To call the plugin I've added in xwiki.cfg the complete name of the class (and also a parameter about the cache size). The plugin uses the cache service. At runtime my plugin is set by this code : Plugin imageplugin = (ImagePlugin) context.getWiki().getPlugin("image", context); But I don't have the cache service working, the attribute imageCache is null. It seems that the init method is never called. Any idea is welcome. Regards -- Xavier MOGHRABI - Consortium ObjectWeb package com.xpn.xwiki.plugin.image; public class ImagePlugin extends XWikiDefaultPlugin implements XWikiPluginInterface { private static String name = "image"; private XWikiCache imageCache; private int capacity = 50; private static Log mLogger = LogFactory.getFactory().getInstance( ImagePlugin.class); public ImagePlugin(String name, String className, XWikiContext context) { super(name, className, context); } /** * Allow to get the plugin name * * @return plugin name */ public String getName() { return name; } public void init(XWikiContext context) { super.init(context); try { String capacityParam = context.getWiki().Param( "xwiki.plugin.image.cache.capacity"); capacity = Integer.parseInt(capacityParam); } catch (NumberFormatException e) { } imageCache = new OSCacheCache(capacity, true, "temp/imageCache"); } public void flushCache() { if (imageCache != null) imageCache.flushAll(); } ... }

18 years, 9 months

license changing and credit management

by jeremi joslin

Hi, I don't know if you remember it, but a while ago we have decided to switch from GPL to LGPL. Changes in headers have never been done. So I start to do it yesterday. Before I need your opinion on some rules: • You give you credit to XpertNet. If you give to XpertNet your credit, it's simple for XpertNet to manage licensing issues. We can't give the credit to XWiki, because it's not an entity, and I don't think ObjectWeb accept credit. • We can use the javadoc tag @author for putting your name on. Or simply a contributors.txt on the root of the svn, a page on the wiki, on the Jira's task and the SVN (because you commit it). More information about why giving your credit to Xpertnet: http://clirr.sourceforge.net/contributing.html Jérémi -- Blog: http://www.jeremi.info LinkedIn: https://www.linkedin.com/profile?viewProfile=&key=1437724 http://www.xwiki.org skype: jeremi23 -- msn et gtalk : jeremi23(a)gmail.com

18 years, 9 months

[Vote] Project head

by jeremi joslin

Hi All, It's time to elect the project head. I suggest: * Ludovic Dubost as the project Leader * Jérémi Joslin as the project Manager I know, it's not common to have a leader and a manager, but Ludovic is busy with the business, so he can't manage the project but he is the one who know the best XWiki and his skills are better then mine. I will help him to manage the project. Only committers can vote. You vote with +1, 0 or -1. * +1: Yes * 0: I don't know * -1: No and explain why. Like we don't have rules for voting now, I choose this for the first vote: The vote is over in 72h or when all committers have vote. Jérémi -- Blog: http://www.jeremi.info LinkedIn: https://www.linkedin.com/profile?viewProfile=&key=1437724 http://www.xwiki.org skype: jeremi23 -- msn et gtalk : jeremi23(a)gmail.com

18 years, 9 months

[xwiki-dev] Is XWikiAuthServiceImpl.authenticate called on every page view?

by Robin Fernandes

Hi, Assuming "Always Authenticate on Viewing" is enabled in the wiki preferences, should XWikiAuthServiceImpl.authenticate(user, password, context) actually get called on every page view? Or is some cookie used to prevent this? I ask because this behaviour seems to have changed on my local xwiki installation, and I'm not what I've done to cause the change (it used to get called on every page view, and doesn't any more). Thanks, Robin.

18 years, 9 months

[announce] XWiki Committers list

by jeremi joslin

Hi, So, I'm proud to announce the list of XWiki committers: * Matthew Conway * Stephane Laurière * Hans Gerwitz * Vincent Massol * Erwann Arzur * Ludovic Dubost * Jérémi Joslin They will help to improve XWiki and will not depend on another people to patch something. They also can vote for changes on XWiki. Not only one people take a decision, it's the committers team who take it by votes. Some rules will be written soon. Jérémi -- Blog: http://www.jeremi.info LinkedIn: https://www.linkedin.com/profile?viewProfile=&key=1437724 http://www.xwiki.org skype: jeremi23 -- msn et gtalk : jeremi23(a)gmail.com

18 years, 9 months

schema limit

by Matthew Conway

I'm running into an issue with the 200K character limit for xwikidoc.xwd_archive. Normally, a diff is generated, so this column doesn't grow too big. However, if the document is always a single long line, the diff is just that line everytime, and xwd_archive grows very quickly. Any thoughts on how I can fix this aside from just increasing the limit? Matt

18 years, 9 months

xwiki.org ergonomy

by jeremi joslin

I started to design a new ergonomy more simple, more common for the XWiki wiki. take a look at : http://www.xwiki.org/xwiki/bin/view/Dev/NewErgoXWiki I'm waiting for your feedback. Jérémi -- Blog: http://www.jeremi.info LinkedIn: https://www.linkedin.com/profile?viewProfile=&key=1437724 http://www.xwiki.org skype: jeremi23 -- msn et gtalk : jeremi23(a)gmail.com

18 years, 9 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

xwiki-devs