Re: [xwiki-devs] [VOTE] Add new xwiki-platform-git module in xwiki-platform (TAKE2)

On Feb 19, 2012, at 10:35 PM, Sergiu Dumitriu wrote: Correct, it won't be in the XE distribution. Java. Now I'd also like to propose bringing the GitHub Application I've coded over the weekend. I've documented it at http://extensions.xwiki.org/xwiki/bin/view/Extension/GitHub+Application I'm proposing: xwiki-platform-git/  |_ xwiki-platform-git-api/ <-- script service  |_ xwiki-platform-github/ <-- application The application consists in 3 pages written in Groovy: * a Repository importer * a Committer importer * a macro to list committers and their associated stats My idea is to use this macro for our Hall Of Fame page. It also lists inactive committers which is nice and what we need. <groovy vs java> I've been wondering if they should be written in Java or not. The importers are pretty basic and small and I don't think they need Java. For the Macro it's less obvious. However writing it in Java would mean three things: * bringing the notion of RepositoryClass and CommitterClass to the java code * removing the nice shortcuts I've used in Groovy for writing scripts, such as: def memberOfClause = repoNames.collect { "'${it}' member of committer.repositories" }.join(" or ") * inability to tune the stats and the macro in general ATM I'm not entirely convinced rewriting in Java is the best thing to do, since users could want to tune it a lot (it's not a domain that's rigid and where there are no variations to the results you want). I'd suggest keeping it in Groovy for some time and see how it goes. </groovy vs java> Thanks -Vincent _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs