12 Oct
2010
12 Oct
'10
9:34 a.m.
+1
Denis
On Mon, Oct 11, 2010 at 22:27, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote:
On 10/11/2010 08:56 AM, Caleb James DeLisle wrote:
--
Denis Gervalle
SOFTEC sa - CEO
eGuilde sarl - CTO
I propose that we deprecate some functions in
XWikiAttachment and
XWikiAttachmentArchive for 2.5 final.
The theoretical reason is that they are
implementation bound and we
should not expose the
implementation to the user of the API. The
practical reason is that JRCS
is very badly suited for
handling large data as it stores everything
(including all versions) in a
String. Since the content
is base64 encoded (increasing the size by 30%)
and java Strings are
UTF-16 (doubling the size) the
memory consumption from using JRCS is at least
2.6 times the size of all
revisions of the content.
I didn't find these functions used anywhere else in platform.
These are the functions I would like to deprecate:
XWikiAttachment
public void setArchive(Archive archive)
public Archive getArchive()
XWikiAttachmentArchive
public Archive getRCSArchive()
public void setRCSArchive(Archive archive)
WDYT?
+1 for the deprecation, but for 2.6M1, not for 2.5.
Note that this is not critical since it's not part of the public API, so
it's not that visible.
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs