Re: [xwiki-devs] [xwiki-notifications] r13383 - platform/core/trunk/xwiki-rendering/src/main/java/org/xwiki/rendering/parser
8 Oct
2008
8 Oct
'08
11:44 a.m.
tmortagne (SVN) wrote:
Author: tmortagne
Date: 2008-10-07 20:01:06 +0200 (Tue, 07 Oct 2008)
New Revision: 13383
Modified:
platform/core/trunk/xwiki-rendering/src/main/java/org/xwiki/rendering/parser/SyntaxType.java
Log:
XWIKI-2744: Can't add a Parser component for an unknown syntax
* add equals and hashCode methods
Since these methods do nothing but the default, why do we need to
override them? The inherited methods should be enough, no?
Anyway, I'd rather have a real implementation, since we can't be sure
that everybody will create syntaxes using the factory method.
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
8 Oct
8 Oct
1:36 p.m.
New subject: [xwiki-devs] [xwiki-notifications] r13383 - platform/core/trunk/xwiki-rendering/src/main/java/org/xwiki/rendering/parser
On Wed, Oct 8, 2008 at 11:44 AM, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote:
tmortagne (SVN) wrote:
To explicitly indicate SyntaxType can be used as Map key.
Author: tmortagne
Date: 2008-10-07 20:01:06 +0200 (Tue, 07 Oct 2008)
New Revision: 13383
Modified:
platform/core/trunk/xwiki-rendering/src/main/java/org/xwiki/rendering/parser/SyntaxType.java
Log:
XWIKI-2744: Can't add a Parser component for an unknown syntax
* add equals and hashCode methods
Since these methods do nothing but the default, why do we need to
override them? The inherited methods should be enough, no?
Anyway, I'd rather have a real implementation, since we can't be sure
that everybody will create syntaxes using the factory method.
The constructor is private so we are sure everyone will have to use
the factory to create SyntaxType.
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne
1:52 p.m.
New subject: [xwiki-devs] [xwiki-notifications] r13383 - platform/core/trunk/xwiki-rendering/src/main/java/org/xwiki/rendering/parser
Thomas Mortagne wrote:
How does this go with distributed containers, distributed shared memory,
serialized objects, RMI and other ways an object can be created without
manually calling the constructor?
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
On Wed, Oct 8, 2008 at 11:44 AM, Sergiu Dumitriu
<sergiu(a)xwiki.com> wrote:
WDYM? A map can hold anything, there's no requirement to override
equals/hashCode. If they do exactly what Object does, there's no need to
override, since the behavior is the same.
tmortagne (SVN) wrote:
To explicitly indicate SyntaxType can be used as Map key. Author: tmortagne
Date: 2008-10-07 20:01:06 +0200 (Tue, 07 Oct 2008)
New Revision: 13383
Modified:
platform/core/trunk/xwiki-rendering/src/main/java/org/xwiki/rendering/parser/SyntaxType.java
Log:
XWIKI-2744: Can't add a Parser component for an unknown syntax
* add equals and hashCode methods
Since these methods do nothing but the default, why do we need to
override them? The inherited methods should be enough, no? Anyway,
I'd rather have a real implementation, since we can't be sure
that everybody will create syntaxes using the factory method.
The constructor is private so we are sure everyone will have to use
the factory to create SyntaxType.
2:06 p.m.
New subject: [xwiki-devs] [xwiki-notifications] r13383 - platform/core/trunk/xwiki-rendering/src/main/java/org/xwiki/rendering/parser
On Wed, Oct 8, 2008 at 1:52 PM, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote:
How does this go with distributed containers, distributed shared memory,
serialized objects, RMI and other ways an object can be created without
manually calling the constructor?
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne
Thomas Mortagne wrote:
I mean for user looking at SyntaxType code not for JVM. Theses methods
are mainly here for there comments indicating to a user he can safely
use it has a Map key.
On Wed, Oct 8, 2008 at 11:44 AM, Sergiu Dumitriu
<sergiu(a)xwiki.com> wrote:
WDYM? A map can hold anything, there's no requirement to override
equals/hashCode. If they do exactly what Object does, there's no need to
override, since the behavior is the same. tmortagne (SVN) wrote:
To explicitly indicate SyntaxType can be used as Map key. Author: tmortagne
Date: 2008-10-07 20:01:06 +0200 (Tue, 07 Oct 2008)
New Revision: 13383
Modified:
platform/core/trunk/xwiki-rendering/src/main/java/org/xwiki/rendering/parser/SyntaxType.java
Log:
XWIKI-2744: Can't add a Parser component for an unknown syntax
* add equals and hashCode methods
Since these methods do nothing but the default, why do we need to
override them? The inherited methods should be enough, no? Anyway,
I'd rather have a real implementation, since we can't be sure
that everybody will create syntaxes using the factory method.
The constructor is private so we are sure everyone will have to use
the factory to create SyntaxType.
2:15 p.m.
New subject: [xwiki-devs] [xwiki-notifications] r13383 - platform/core/trunk/xwiki-rendering/src/main/java/org/xwiki/rendering/parser
On Wed, Oct 8, 2008 at 1:52 PM, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote:
Thomas Mortagne wrote:
How does this go with distributed containers, distributed shared memory,
serialized objects, RMI and other ways an object can be created without
manually calling the constructor?
If those uses cases SyntaxType is far from beying used for yes there
will be a problem... anyway if you think it's really needed you can
modify theses methods, I'm not that strongly against the idea ;)
On Wed, Oct 8, 2008 at 11:44 AM, Sergiu Dumitriu
<sergiu(a)xwiki.com> wrote:
WDYM? A map can hold anything, there's no requirement to override
equals/hashCode. If they do exactly what Object does, there's no need to
override, since the behavior is the same.
tmortagne (SVN) wrote:
To explicitly indicate SyntaxType can be used as Map key. Author: tmortagne
Date: 2008-10-07 20:01:06 +0200 (Tue, 07 Oct 2008)
New Revision: 13383
Modified:
platform/core/trunk/xwiki-rendering/src/main/java/org/xwiki/rendering/parser/SyntaxType.java
Log:
XWIKI-2744: Can't add a Parser component for an unknown syntax
* add equals and hashCode methods
Since these methods do nothing but the default, why do we need to
override them? The inherited methods should be enough, no? Anyway,
I'd rather have a real implementation, since we can't be sure
that everybody will create syntaxes using the factory method.
The constructor is private so we are sure everyone will have to use
the factory to create SyntaxType.
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne
5876
days inactive
5876
days old
4 comments
2 participants
participants (2)
-
Sergiu Dumitriu -
Thomas Mortagne