On 11/29/2010 05:05 AM, Sorin Burjan wrote: +1 +1 Not sure if current behavior was even intentional to begin with. Caleb

_______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

On 11/29/2010 12:05 PM, Sorin Burjan wrote: +1 +1 Thanks, Marius > > sburjan is now known as sburjan1 > > > > I am +1 for 1.3 and +1 for 2.1 > > Please send your feedback and even your proposals if you have one. > > WDYT ? > > Regards, > Sorin B. [14:22] sburjan is now known as sburjan1 > (~sburjan(a)this.is.areally.long.address.ro) > > Proposal 2 > We also log the user ip/host addresses when user joins. This also makes > the line much longer with information that it's not needed IMO. > This could be also a privacy concert, because your ip/host address is > exposed to anyone who uses xwiki.org . > > Version 1 : keep these addresses in log (like we have now) > > sburjan is now known as sburjan1 (~sburjan(a)this.is.areally.long.address.ro > > > > > sburjan is now known as sburjan1 > > > > I am +1 for 1.3 and +1 for 2.1 > > Please send your feedback and even your proposals if you have one. > > WDYT ? > > Regards, > Sorin B. > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

On Nov 29, 2010, at 11:05 AM, Sorin Burjan wrote: Version 2 (without the space before the ":") or Version 3 are fine with me. A small pref for version 3 since it's one char less. ok to remove information not typed by users from the logs (user coming in, going out, etc).

Thanks -Vincent _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

On 11/29/2010 11:05 AM, Sorin Burjan wrote: > Hello devs, > > I have a proposal to make about the IRCbot Application. As you know, the > bot logs the channel and saves > the content in order to make it viewable from the xwiki designated page. > > I would like to propose two things : > > Proposal 1 > In order to make archive logs more easily readable and more easy to > follow, I would like to change the > way the logs are saved. > I would like to use a standard format (also used my all major IRC > clients like Pidgin, IRC, XChat, irssi, etc). > Because date/time will have always the same length, aligning it and > putting it at the begginning of the line, makes the text more easy to > follow. > So, the proposals are : > > Version 1 (the one we have now) > > user1 - (20:07): You can comment if you have edit right > JohnDoe - (20:07): ok, thx for the answer > IreallyLoveXWiki - (20:07): I’m off for today, bye > XWikiNormalUser left at 20:07 (Quit: Leaving. > EnterpriseUser joined #xwiki at 20:38 > EnterpriseUser left at 20:38 (Client Quit > sburjan is now known as sburjan1 (~sburjan(a)this.is.areally.long.address.ro > > Note that the ")" doesn't appear on logs, so this should be fixed any way. > > > Version 2 > > [11:05] XWikiNormalUser : How can I edit a page? > [11:05] IreallyLoveXWiki : You have to be logged in order to do that > [11:05] JohnDoe : I love Open Source ! > [22:55] EnterpriseUser : joined #xwiki at 20:38 > [22:56] EnterpriseUser : left at 20:38 (Client Quit > [14:22] sburjan is now known as sburjan1 > (~sburjan(a)this.is.areally.long.address.ro)

+1 for V2, but: - no space before : - no : on system lines (join, quit, nick change...) I'd rather keep them, since it might be a reference for identifying suspicious activity. The privacy gain from not logging the IP is minimal, since that information is already available live on IRC.

Hello devs, In my effort to make IRC logging as readable as possible, nick coloring is the next step. Vincent told me that we can use pygments for coloring the IRC syntax. Pygments is also used in code macro as a highlighter for different syntaxes. The only disadvantage is that pygments needs IRC logs to be in irssi style. This means that nickname need to be wrapped around < > chars. So we have 3 options : 1. Don't use pygments and keep the following syntax (we will loose coloring)        17:59 @sburjan Syntax coloring is cool 2. Use pygments and have syntax coloring. The syntax will look like: 17:59 <@sburjan> The coloring is cool 3.Use pygments and write a custom lexer that colors IRC syntax that doesn't have the < > chars. This would look like: 17:59 @sburjan The coloring is cool I am +1 for 3, but someone with knowledge will have to make it.

Cast your vote. Regards, Sorin B. _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs

On 12/08/2010 07:05 PM, Sorin Burjan wrote: +1, < and > are not that bad. We can implement (3) later.

Thanks, Marius > > 3.Use pygments and write a custom lexer that colors IRC syntax that > doesn't have the< > chars. This would look like: > 17:59 @sburjan The coloring is cool > > I am +1 for 3, but someone with knowledge will have to make it. > > Cast your vote. > > Regards, > Sorin B. > >> Hello devs, >> >> I have a proposal to make about the IRCbot Application. As you know, the >> bot logs the channel and saves >> the content in order to make it viewable from the xwiki designated page. >> >> I would like to propose two things : >> >> Proposal 1 >> In order to make archive logs more easily readable and more easy to >> follow, I would like to change the >> way the logs are saved. >> I would like to use a standard format (also used my all major IRC >> clients like Pidgin, IRC, XChat, irssi, etc). >> Because date/time will have always the same length, aligning it and >> putting it at the begginning of the line, makes the text more easy to >> follow. >> So, the proposals are : >> >> Version 1 (the one we have now) >> >> user1 - (20:07): You can comment if you have edit right >> JohnDoe - (20:07): ok, thx for the answer >> IreallyLoveXWiki - (20:07): I’m off for today, bye >> XWikiNormalUser left at 20:07 (Quit: Leaving. >> EnterpriseUser joined #xwiki at 20:38 >> EnterpriseUser left at 20:38 (Client Quit >> sburjan is now known as sburjan1 (~sburjan(a)this.is.areally.long.address.ro >> >> Note that the ")" doesn't appear on logs, so this should be fixed any way. >> >> >> Version 2 >> >> [11:05] XWikiNormalUser : How can I edit a page? >> [11:05] IreallyLoveXWiki : You have to be logged in order to do that >> [11:05] JohnDoe : I love Open Source ! >> [22:55] EnterpriseUser : joined #xwiki at 20:38 >> [22:56] EnterpriseUser : left at 20:38 (Client Quit >> [14:22] sburjan is now known as sburjan1 >> (~sburjan(a)this.is.areally.long.address.ro) >> >> Version 3 >> >> [11:05]<XWikiNormalUser> How can I edit a page? >> [11:05]<IreallyLoveXWiki> You have to be logged in order to do that >> [11:05]<JohnDoe> I love Open Source ! >> [22:55]<EnterpriseUser> joined #xwiki at 20:38 >> [22:56]<EnterpriseUser> left at 20:38 (Client Quit) >> >> Version 1 : keep these addresses in log (like we have now) >> >> sburjan is now known as sburjan1 (~sburjan(a)this.is.areally.long.address.ro >> >> >> >> Version 2 : remove then from logging >> >> sburjan is now known as sburjan1 >> >> >> >> I am +1 for 1.3 and +1 for 2.1 >> >> Please send your feedback and even your proposals if you have one. >> >> WDYT ? >> >> Regards, >> Sorin B. [14:22] sburjan is now known as sburjan1 >> (~sburjan(a)this.is.areally.long.address.ro) >> >> Proposal 2 >> We also log the user ip/host addresses when user joins. This also makes >> the line much longer with information that it's not needed IMO. >> This could be also a privacy concert, because your ip/host address is >> exposed to anyone who uses xwiki.org . >> >> Version 1 : keep these addresses in log (like we have now) >> >> sburjan is now known as sburjan1 (~sburjan(a)this.is.areally.long.address.ro >> >> >> >> Version 2 : remove then from logging >> >> sburjan is now known as sburjan1 >> >> >> >> I am +1 for 1.3 and +1 for 2.1 >> >> Please send your feedback and even your proposals if you have one. >> >> WDYT ? >> >> Regards, >> Sorin B.