[xwiki-devs] [Proposal] XWikiDay: PR-fixing day

List overview All Threads
Download

newer

older

[xwiki-devs] GSOC Work - Deadline

[xwiki-devs] [GSoC] Extension...

Vincent Massol

19 Aug 2017 19 Aug '17

12:47 p.m.

Hi devs, We have several pages requiring PR and we’re not doing much about them. This is a major pain, for example on myxwiki.org where, every time some admin update their wikis they break features. It’s not showing XWiki in good light neither. I’ve found at least those pages requiring PR: * XWiki.AllAttachmentsResults * XWiki.DeletedDocumentsJSON * AppWithinMinutes.DynamicMessageTool * AnnotationCode.Style * XWiki.DeletedDocuments * AppWithinMinutes.LiveTableEditSheet * AppWithinMinutes.ClassEditSheet * XWiki.DeletedAttachments * Main.Activity * AnnotationCode.Script (see http://jira.xwiki.org/browse/XWIKI-10446?focusedCommentId=83579&page=co… ) And FTR we keep adding more over time. For example in 2012, AWM introduced a PR: https://github.com/xwiki/xwiki-platform/commit/ae09194f83b9fe1f75778e0a2501… I’d like to propose to do a PR-fixing day for the next non-BFD day, i.e. in 2 weeks. WDYT? Thanks -Vincent

Show replies by date

Marius Dumitru Florea

19 Aug 19 Aug

1:19 p.m.

On Sat, Aug 19, 2017 at 1:47 PM, Vincent Massol <vincent(a)massol.net> wrote:

...

* XWiki.AllAttachmentsResults

Doesn't require PR anymore.

...

* XWiki.DeletedDocumentsJSON * AppWithinMinutes.DynamicMessageTool

This is deprecated and not used. I was kept only for backwards compatibility. See https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwi… .

...

* AnnotationCode.Style * XWiki.DeletedDocuments * AppWithinMinutes.LiveTableEditSheet * AppWithinMinutes.ClassEditSheet * XWiki.DeletedAttachments * Main.Activity * AnnotationCode.Script (see http://jira.xwiki.org/browse/XWIKI-10446?focusedCommentId= 83579&page=com.atlassian.jira.plugin.system.issuetabpanels: comment-tabpanel#comment-83579 ) And FTR we keep adding more over time. For example in 2012, AWM introduced a PR: https://github.com/xwiki/xwiki-platform/commit/ ae09194f83b9fe1f75778e0a2501a6cc37c4b060 I’d like to propose to do a PR-fixing day for the next non-BFD day, i.e. in 2 weeks. WDYT? Thanks -Vincent

Vincent Massol

2 p.m.

Hi Marius,

...

On 19 Aug 2017, at 13:19, Marius Dumitru Florea <mariusdumitru.florea(a)xwiki.com> wrote: On Sat, Aug 19, 2017 at 1:47 PM, Vincent Massol <vincent(a)massol.net> wrote:

* XWiki.AllAttachmentsResults

Doesn't require PR anymore.

Ok that’s cool. When was it done? Is it on LTS? I see it’s still there on playground which is on XWiki 8.4.4.

...

* XWiki.DeletedDocumentsJSON * AppWithinMinutes.DynamicMessageTool

This is deprecated and not used. I was kept only for backwards compatibility. See https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwi…

This is not what I saw on the subwiki (started working after I resaved that page). It was still used there and the wiki is on XWiki 9.3.1. Thanks -Vincent

...

. > * AnnotationCode.Style > * XWiki.DeletedDocuments > * AppWithinMinutes.LiveTableEditSheet > * AppWithinMinutes.ClassEditSheet > * XWiki.DeletedAttachments > * Main.Activity > * AnnotationCode.Script > > (see http://jira.xwiki.org/browse/XWIKI-10446?focusedCommentId= > 83579&page=com.atlassian.jira.plugin.system.issuetabpanels: > comment-tabpanel#comment-83579 ) > > And FTR we keep adding more over time. For example in 2012, AWM introduced > a PR: https://github.com/xwiki/xwiki-platform/commit/ > ae09194f83b9fe1f75778e0a2501a6cc37c4b060 > > I’d like to propose to do a PR-fixing day for the next non-BFD day, i.e. > in 2 weeks. > > WDYT? > > Thanks > -Vincent

Marius Dumitru Florea

2:06 p.m.

On Sat, Aug 19, 2017 at 3:00 PM, Vincent Massol <vincent(a)massol.net> wrote:

...

Hi Marius,

On 19 Aug 2017, at 13:19, Marius Dumitru Florea <

mariusdumitru.florea(a)xwiki.com> wrote:

On Sat, Aug 19, 2017 at 1:47 PM, Vincent Massol <vincent(a)massol.net>

wrote:

* XWiki.AllAttachmentsResults

Doesn't require PR anymore.

...

Ok that’s cool. When was it done? Is it on LTS? I see it’s still there on playground which is on XWiki 8.4.4.

5.0M2? https://jira.xwiki.org/browse/XE-521

...

* XWiki.DeletedDocumentsJSON * AppWithinMinutes.DynamicMessageTool

This is deprecated and not used. I was kept only for backwards compatibility. See https://github.com/xwiki/xwiki-platform/blob/master/

xwiki-platform-core/xwiki-platform-appwithinminutes/xwiki-platform- appwithinminutes-ui/src/main/resources/AppWithinMinutes/ DynamicMessageTool.xml#L56

...

This is not what I saw on the subwiki (started working after I resaved that page). It was still used there and the wiki is on XWiki 9.3.1.

I think you're confusing DynamicMessageTool with ClassEditSheet.

...

Thanks -Vincent

introduced

> a PR: https://github.com/xwiki/xwiki-platform/commit/ > ae09194f83b9fe1f75778e0a2501a6cc37c4b060 > > I’d like to propose to do a PR-fixing day for the next non-BFD day, i.e. > in 2 weeks. > > WDYT? > > Thanks > -Vincent

Vincent Massol

2:49 p.m.

...

On 19 Aug 2017, at 14:06, Marius Dumitru Florea <mariusdumitru.florea(a)xwiki.com> wrote: On Sat, Aug 19, 2017 at 3:00 PM, Vincent Massol <vincent(a)massol.net> wrote:

Hi Marius,

On 19 Aug 2017, at 13:19, Marius Dumitru Florea <

mariusdumitru.florea(a)xwiki.com> wrote:

On Sat, Aug 19, 2017 at 1:47 PM, Vincent Massol <vincent(a)massol.net>

wrote:

* XWiki.AllAttachmentsResults

Doesn't require PR anymore.

Ok that’s cool. When was it done? Is it on LTS? I see it’s still there on playground which is on XWiki 8.4.4.

5.0M2? https://jira.xwiki.org/browse/XE-521

Then we need to remove the PR class: https://github.com/xwiki/xwiki-platform/blob/c77449bbfd02f1bc28d47111a20232…

...

* XWiki.DeletedDocumentsJSON * AppWithinMinutes.DynamicMessageTool

This is deprecated and not used. I was kept only for backwards compatibility. See https://github.com/xwiki/xwiki-platform/blob/master/

xwiki-platform-core/xwiki-platform-appwithinminutes/xwiki-platform- appwithinminutes-ui/src/main/resources/AppWithinMinutes/ DynamicMessageTool.xml#L56

This is not what I saw on the subwiki (started working after I resaved that page). It was still used there and the wiki is on XWiki 9.3.1.

I think you're confusing DynamicMessageTool with ClassEditSheet.

Nope I’m not confused since this is the only doc I resaved to make AWM work: http://lescastcodeurs.myxwiki.org/xwiki/bin/view/Main/AllDocs#|t=alldocs&am… So it seems it’s still used. Thanks -Vincent

...

> > Thanks > -Vincent > >> . >> >> >>> * AnnotationCode.Style >>> * XWiki.DeletedDocuments >>> * AppWithinMinutes.LiveTableEditSheet >>> * AppWithinMinutes.ClassEditSheet >>> * XWiki.DeletedAttachments >>> * Main.Activity >>> * AnnotationCode.Script >>> >>> (see http://jira.xwiki.org/browse/XWIKI-10446?focusedCommentId= >>> 83579&page=com.atlassian.jira.plugin.system.issuetabpanels: >>> comment-tabpanel#comment-83579 ) >>> >>> And FTR we keep adding more over time. For example in 2012, AWM > introduced >>> a PR: https://github.com/xwiki/xwiki-platform/commit/ >>> ae09194f83b9fe1f75778e0a2501a6cc37c4b060 >>> >>> I’d like to propose to do a PR-fixing day for the next non-BFD day, i.e. >>> in 2 weeks. >>> >>> WDYT? >>> >>> Thanks >>> -Vincent

Vincent Massol

3:16 p.m.

...

On 19 Aug 2017, at 14:49, Vincent Massol <vincent(a)massol.net> wrote:

On 19 Aug 2017, at 14:06, Marius Dumitru Florea <mariusdumitru.florea(a)xwiki.com> wrote: On Sat, Aug 19, 2017 at 3:00 PM, Vincent Massol <vincent(a)massol.net> wrote:

Hi Marius,

On 19 Aug 2017, at 13:19, Marius Dumitru Florea <

mariusdumitru.florea(a)xwiki.com> wrote:

On Sat, Aug 19, 2017 at 1:47 PM, Vincent Massol <vincent(a)massol.net>

wrote:

> Hi devs, > > We have several pages requiring PR and we’re not doing much about them. > > This is a major pain, for example on myxwiki.org where, every time some > admin update their wikis they break features. It’s not showing XWiki in > good light neither. > > I’ve found at least those pages requiring PR: > > > * XWiki.AllAttachmentsResults > Doesn't require PR anymore.

Ok that’s cool. When was it done? Is it on LTS? I see it’s still there on playground which is on XWiki 8.4.4.

5.0M2? https://jira.xwiki.org/browse/XE-521

Then we need to remove the PR class: https://github.com/xwiki/xwiki-platform/blob/c77449bbfd02f1bc28d47111a20232…

> * XWiki.DeletedDocumentsJSON > * AppWithinMinutes.DynamicMessageTool > This is deprecated and not used. I was kept only for backwards compatibility. See https://github.com/xwiki/xwiki-platform/blob/master/

xwiki-platform-core/xwiki-platform-appwithinminutes/xwiki-platform- appwithinminutes-ui/src/main/resources/AppWithinMinutes/ DynamicMessageTool.xml#L56

This is not what I saw on the subwiki (started working after I resaved that page). It was still used there and the wiki is on XWiki 9.3.1.

I think you're confusing DynamicMessageTool with ClassEditSheet.

Nope I’m not confused since this is the only doc I resaved to make AWM work: http://lescastcodeurs.myxwiki.org/xwiki/bin/view/Main/AllDocs#|t=alldocs&am…

So I was indeed confused in the end ;) I had modified only 1 doc but apparently it was still not working (was sure I had tested it though, strange) and indeed now that I resaved ClassEditSheet too, the error went away. Thanks -Vincent

...

So it seems it’s still used. Thanks -Vincent > > >> >> Thanks >> -Vincent >> >>> . >>> >>> >>>> * AnnotationCode.Style >>>> * XWiki.DeletedDocuments >>>> * AppWithinMinutes.LiveTableEditSheet >>>> * AppWithinMinutes.ClassEditSheet >>>> * XWiki.DeletedAttachments >>>> * Main.Activity >>>> * AnnotationCode.Script >>>> >>>> (see http://jira.xwiki.org/browse/XWIKI-10446?focusedCommentId= >>>> 83579&page=com.atlassian.jira.plugin.system.issuetabpanels: >>>> comment-tabpanel#comment-83579 ) >>>> >>>> And FTR we keep adding more over time. For example in 2012, AWM >> introduced >>>> a PR: https://github.com/xwiki/xwiki-platform/commit/ >>>> ae09194f83b9fe1f75778e0a2501a6cc37c4b060 >>>> >>>> I’d like to propose to do a PR-fixing day for the next non-BFD day, i.e. >>>> in 2 weeks. >>>> >>>> WDYT? >>>> >>>> Thanks >>>> -Vincent

Vincent Massol

3:24 p.m.

...

On 19 Aug 2017, at 15:16, Vincent Massol <vincent(a)massol.net> wrote:

On 19 Aug 2017, at 14:49, Vincent Massol <vincent(a)massol.net> wrote:

On 19 Aug 2017, at 14:06, Marius Dumitru Florea <mariusdumitru.florea(a)xwiki.com> wrote: On Sat, Aug 19, 2017 at 3:00 PM, Vincent Massol <vincent(a)massol.net> wrote:

Hi Marius, > On 19 Aug 2017, at 13:19, Marius Dumitru Florea < mariusdumitru.florea(a)xwiki.com> wrote: > > On Sat, Aug 19, 2017 at 1:47 PM, Vincent Massol <vincent(a)massol.net> wrote: > >> Hi devs, >> >> We have several pages requiring PR and we’re not doing much about them. >> >> This is a major pain, for example on myxwiki.org where, every time some >> admin update their wikis they break features. It’s not showing XWiki in >> good light neither. >> >> I’ve found at least those pages requiring PR: >> >> > >> * XWiki.AllAttachmentsResults >> > > Doesn't require PR anymore.

Ok that’s cool. When was it done? Is it on LTS? I see it’s still there on playground which is on XWiki 8.4.4.

5.0M2? https://jira.xwiki.org/browse/XE-521

Then we need to remove the PR class: https://github.com/xwiki/xwiki-platform/blob/c77449bbfd02f1bc28d47111a20232…

> >> * XWiki.DeletedDocumentsJSON >> * AppWithinMinutes.DynamicMessageTool >> > > This is deprecated and not used. I was kept only for backwards > compatibility. See > https://github.com/xwiki/xwiki-platform/blob/master/ xwiki-platform-core/xwiki-platform-appwithinminutes/xwiki-platform- appwithinminutes-ui/src/main/resources/AppWithinMinutes/ DynamicMessageTool.xml#L56

This is not what I saw on the subwiki (started working after I resaved that page). It was still used there and the wiki is on XWiki 9.3.1.

I think you're confusing DynamicMessageTool with ClassEditSheet.

Nope I’m not confused since this is the only doc I resaved to make AWM work: http://lescastcodeurs.myxwiki.org/xwiki/bin/view/Main/AllDocs#|t=alldocs&am…

BTW I tried creating an AWM app and on the last wizard screen after hitting the submit button I get a big stack trace on the screen (just a stack trace, nothing else): https://gist.github.com/vmassol/7266fae29b4f103a78395688186ef944 Any idea? Thanks -Vincent

...

Thanks -Vincent > > So it seems it’s still used. > > Thanks > -Vincent > >> >> >>> >>> Thanks >>> -Vincent >>> >>>> . >>>> >>>> >>>>> * AnnotationCode.Style >>>>> * XWiki.DeletedDocuments >>>>> * AppWithinMinutes.LiveTableEditSheet >>>>> * AppWithinMinutes.ClassEditSheet >>>>> * XWiki.DeletedAttachments >>>>> * Main.Activity >>>>> * AnnotationCode.Script >>>>> >>>>> (see http://jira.xwiki.org/browse/XWIKI-10446?focusedCommentId= >>>>> 83579&page=com.atlassian.jira.plugin.system.issuetabpanels: >>>>> comment-tabpanel#comment-83579 ) >>>>> >>>>> And FTR we keep adding more over time. For example in 2012, AWM >>> introduced >>>>> a PR: https://github.com/xwiki/xwiki-platform/commit/ >>>>> ae09194f83b9fe1f75778e0a2501a6cc37c4b060 >>>>> >>>>> I’d like to propose to do a PR-fixing day for the next non-BFD day, i.e. >>>>> in 2 weeks. >>>>> >>>>> WDYT? >>>>> >>>>> Thanks >>>>> -Vincent

Vincent Massol

3:24 p.m.

...

On 19 Aug 2017, at 15:24, Vincent Massol <vincent(a)massol.net> wrote:

On 19 Aug 2017, at 15:16, Vincent Massol <vincent(a)massol.net> wrote:

On 19 Aug 2017, at 14:49, Vincent Massol <vincent(a)massol.net> wrote:

On 19 Aug 2017, at 14:06, Marius Dumitru Florea <mariusdumitru.florea(a)xwiki.com> wrote: On Sat, Aug 19, 2017 at 3:00 PM, Vincent Massol <vincent(a)massol.net> wrote: > Hi Marius, > >> On 19 Aug 2017, at 13:19, Marius Dumitru Florea < > mariusdumitru.florea(a)xwiki.com> wrote: >> >> On Sat, Aug 19, 2017 at 1:47 PM, Vincent Massol <vincent(a)massol.net> > wrote: >> >>> Hi devs, >>> >>> We have several pages requiring PR and we’re not doing much about them. >>> >>> This is a major pain, for example on myxwiki.org where, every time some >>> admin update their wikis they break features. It’s not showing XWiki in >>> good light neither. >>> >>> I’ve found at least those pages requiring PR: >>> >>> >> >>> * XWiki.AllAttachmentsResults >>> >> >> Doesn't require PR anymore. > > > Ok that’s cool. When was it done? Is it on LTS? I see it’s still there on > playground which is on XWiki 8.4.4. > 5.0M2? https://jira.xwiki.org/browse/XE-521

Then we need to remove the PR class: https://github.com/xwiki/xwiki-platform/blob/c77449bbfd02f1bc28d47111a20232…

> >> >>> * XWiki.DeletedDocumentsJSON >>> * AppWithinMinutes.DynamicMessageTool >>> >> >> This is deprecated and not used. I was kept only for backwards >> compatibility. See >> https://github.com/xwiki/xwiki-platform/blob/master/ > xwiki-platform-core/xwiki-platform-appwithinminutes/xwiki-platform- > appwithinminutes-ui/src/main/resources/AppWithinMinutes/ > DynamicMessageTool.xml#L56 > > > This is not what I saw on the subwiki (started working after I resaved > that page). It was still used there and the wiki is on XWiki 9.3.1. > I think you're confusing DynamicMessageTool with ClassEditSheet.

Nope I’m not confused since this is the only doc I resaved to make AWM work: http://lescastcodeurs.myxwiki.org/xwiki/bin/view/Main/AllDocs#|t=alldocs&am…

The URL was http://lescastcodeurs.myxwiki.org/xwiki/bin/edit/Episodes/WebHome?wizard=tr… Thanks -Vincent

...

Any idea? Thanks -Vincent > > Thanks > -Vincent > >> >> So it seems it’s still used. >> >> Thanks >> -Vincent >> >>> >>> >>>> >>>> Thanks >>>> -Vincent >>>> >>>>> . >>>>> >>>>> >>>>>> * AnnotationCode.Style >>>>>> * XWiki.DeletedDocuments >>>>>> * AppWithinMinutes.LiveTableEditSheet >>>>>> * AppWithinMinutes.ClassEditSheet >>>>>> * XWiki.DeletedAttachments >>>>>> * Main.Activity >>>>>> * AnnotationCode.Script >>>>>> >>>>>> (see http://jira.xwiki.org/browse/XWIKI-10446?focusedCommentId= >>>>>> 83579&page=com.atlassian.jira.plugin.system.issuetabpanels: >>>>>> comment-tabpanel#comment-83579 ) >>>>>> >>>>>> And FTR we keep adding more over time. For example in 2012, AWM >>>> introduced >>>>>> a PR: https://github.com/xwiki/xwiki-platform/commit/ >>>>>> ae09194f83b9fe1f75778e0a2501a6cc37c4b060 >>>>>> >>>>>> I’d like to propose to do a PR-fixing day for the next non-BFD day, i.e. >>>>>> in 2 weeks. >>>>>> >>>>>> WDYT? >>>>>> >>>>>> Thanks >>>>>> -Vincent

Vincent Massol

3:34 p.m.

...

On 19 Aug 2017, at 15:24, Vincent Massol <vincent(a)massol.net> wrote:

On 19 Aug 2017, at 15:16, Vincent Massol <vincent(a)massol.net> wrote:

On 19 Aug 2017, at 14:49, Vincent Massol <vincent(a)massol.net> wrote: > > On 19 Aug 2017, at 14:06, Marius Dumitru Florea <mariusdumitru.florea(a)xwiki.com> wrote: > > On Sat, Aug 19, 2017 at 3:00 PM, Vincent Massol <vincent(a)massol.net> wrote: > >> Hi Marius, >> >>> On 19 Aug 2017, at 13:19, Marius Dumitru Florea < >> mariusdumitru.florea(a)xwiki.com> wrote: >>> >>> On Sat, Aug 19, 2017 at 1:47 PM, Vincent Massol <vincent(a)massol.net> >> wrote: >>> >>>> Hi devs, >>>> >>>> We have several pages requiring PR and we’re not doing much about them. >>>> >>>> This is a major pain, for example on myxwiki.org where, every time some >>>> admin update their wikis they break features. It’s not showing XWiki in >>>> good light neither. >>>> >>>> I’ve found at least those pages requiring PR: >>>> >>>> >>> >>>> * XWiki.AllAttachmentsResults >>>> >>> >>> Doesn't require PR anymore. >> >> > >> Ok that’s cool. When was it done? Is it on LTS? I see it’s still there on >> playground which is on XWiki 8.4.4. >> > > 5.0M2? https://jira.xwiki.org/browse/XE-521 Then we need to remove the PR class: https://github.com/xwiki/xwiki-platform/blob/c77449bbfd02f1bc28d47111a20232… > >> >>> >>>> * XWiki.DeletedDocumentsJSON >>>> * AppWithinMinutes.DynamicMessageTool >>>> >>> >>> This is deprecated and not used. I was kept only for backwards >>> compatibility. See >>> https://github.com/xwiki/xwiki-platform/blob/master/ >> xwiki-platform-core/xwiki-platform-appwithinminutes/xwiki-platform- >> appwithinminutes-ui/src/main/resources/AppWithinMinutes/ >> DynamicMessageTool.xml#L56 >> >> > >> This is not what I saw on the subwiki (started working after I resaved >> that page). It was still used there and the wiki is on XWiki 9.3.1. >> > > I think you're confusing DynamicMessageTool with ClassEditSheet. Nope I’m not confused since this is the only doc I resaved to make AWM work: http://lescastcodeurs.myxwiki.org/xwiki/bin/view/Main/AllDocs#|t=alldocs&am…

The URL was http://lescastcodeurs.myxwiki.org/xwiki/bin/edit/Episodes/WebHome?wizard=tr…

ok found the problem, there was another page that needed PR in AWM: AppWithinMinutes.LiveTableEditSheet Thanks -Vincent

...

Thanks -Vincent > > Any idea? > > Thanks > -Vincent > >> >> Thanks >> -Vincent >> >>> >>> So it seems it’s still used. >>> >>> Thanks >>> -Vincent >>> >>>> >>>> >>>>> >>>>> Thanks >>>>> -Vincent >>>>> >>>>>> . >>>>>> >>>>>> >>>>>>> * AnnotationCode.Style >>>>>>> * XWiki.DeletedDocuments >>>>>>> * AppWithinMinutes.LiveTableEditSheet >>>>>>> * AppWithinMinutes.ClassEditSheet >>>>>>> * XWiki.DeletedAttachments >>>>>>> * Main.Activity >>>>>>> * AnnotationCode.Script >>>>>>> >>>>>>> (see http://jira.xwiki.org/browse/XWIKI-10446?focusedCommentId= >>>>>>> 83579&page=com.atlassian.jira.plugin.system.issuetabpanels: >>>>>>> comment-tabpanel#comment-83579 ) >>>>>>> >>>>>>> And FTR we keep adding more over time. For example in 2012, AWM >>>>> introduced >>>>>>> a PR: https://github.com/xwiki/xwiki-platform/commit/ >>>>>>> ae09194f83b9fe1f75778e0a2501a6cc37c4b060 >>>>>>> >>>>>>> I’d like to propose to do a PR-fixing day for the next non-BFD day, i.e. >>>>>>> in 2 weeks. >>>>>>> >>>>>>> WDYT? >>>>>>> >>>>>>> Thanks >>>>>>> -Vincent

Ecaterina Moraru (Valica)

21 Aug 21 Aug

12:15 p.m.

I though we were making a day for Pull Requests :) too bad :) On Sat, Aug 19, 2017 at 4:34 PM, Vincent Massol <vincent(a)massol.net> wrote:

...

On 19 Aug 2017, at 15:24, Vincent Massol <vincent(a)massol.net> wrote: > > On 19 Aug 2017, at 15:24, Vincent Massol <vincent(a)massol.net> wrote: > >> >> On 19 Aug 2017, at 15:16, Vincent Massol <vincent(a)massol.net> wrote: >> >>> >>> On 19 Aug 2017, at 14:49, Vincent Massol <vincent(a)massol.net> wrote: >>> >>>> >>>> On 19 Aug 2017, at 14:06, Marius Dumitru Florea <

mariusdumitru.florea(a)xwiki.com> wrote:

>>>> >>>> On Sat, Aug 19, 2017 at 3:00 PM, Vincent Massol <vincent(a)massol.net>

wrote:

>>>> >>>>> Hi Marius, >>>>> >>>>>> On 19 Aug 2017, at 13:19, Marius Dumitru Florea < >>>>> mariusdumitru.florea(a)xwiki.com> wrote: >>>>>> >>>>>> On Sat, Aug 19, 2017 at 1:47 PM, Vincent Massol <

vincent(a)massol.net>

>>>>> wrote: >>>>>> >>>>>>> Hi devs, >>>>>>> >>>>>>> We have several pages requiring PR and we’re not doing much about

them.

>>>>>>> >>>>>>> This is a major pain, for example on myxwiki.org where, every

time some

>>>>>>> admin update their wikis they break features. It’s not showing

XWiki in

>>>>>>> good light neither. >>>>>>> >>>>>>> I’ve found at least those pages requiring PR: >>>>>>> >>>>>>> >>>>>> >>>>>>> * XWiki.AllAttachmentsResults >>>>>>> >>>>>> >>>>>> Doesn't require PR anymore. >>>>> >>>>> >>>> >>>>> Ok that’s cool. When was it done? Is it on LTS? I see it’s still

there on

>>>>> playground which is on XWiki 8.4.4. >>>>> >>>> >>>> 5.0M2? https://jira.xwiki.org/browse/XE-521 >>> >>> Then we need to remove the PR class: >>> https://github.com/xwiki/xwiki-platform/blob/

c77449bbfd02f1bc28d47111a202324af5355265/xwiki-platform- core/xwiki-platform-index/xwiki-platform-index-ui/src/ main/resources/XWiki/AllAttachmentsResults.xml#L179

>>> >>>> >>>>> >>>>>> >>>>>>> * XWiki.DeletedDocumentsJSON >>>>>>> * AppWithinMinutes.DynamicMessageTool >>>>>>> >>>>>> >>>>>> This is deprecated and not used. I was kept only for backwards >>>>>> compatibility. See >>>>>> https://github.com/xwiki/xwiki-platform/blob/master/ >>>>> xwiki-platform-core/xwiki-platform-appwithinminutes/xwiki-platform- >>>>> appwithinminutes-ui/src/main/resources/AppWithinMinutes/ >>>>> DynamicMessageTool.xml#L56 >>>>> >>>>> >>>> >>>>> This is not what I saw on the subwiki (started working after I

resaved

>>>>> that page). It was still used there and the wiki is on XWiki 9.3.1. >>>>> >>>> >>>> I think you're confusing DynamicMessageTool with ClassEditSheet. >>> >>> Nope I’m not confused since this is the only doc I resaved to make

AWM work:

>>> http://lescastcodeurs.myxwiki.org/xwiki/bin/view/Main/

AllDocs#|t=alldocs&p=1&l=15&s=doc.date&d=desc

>> >> So I was indeed confused in the end ;) >> >> I had modified only 1 doc but apparently it was still not working (was

sure I had tested it though, strange) and indeed now that I resaved ClassEditSheet too, the error went away.

> > BTW I tried creating an AWM app and on the last wizard screen after

hitting the submit button I get a big stack trace on the screen (just a stack trace, nothing else):

https://gist.github.com/vmassol/7266fae29b4f103a78395688186ef944

The URL was http://lescastcodeurs.myxwiki.org/xwiki/bin/edit/Episodes/

WebHome?wizard=true&template=AppWithinMinutes.LiveTableTemplate& AppWithinMinutes.LiveTableClass_0_class=Episodes.Code.EpisodesClass& title=Episodes&parent=Main.WebHome ok found the problem, there was another page that needed PR in AWM: AppWithinMinutes.LiveTableEditSheet Thanks -Vincent

day, i.e.

>>>>>>> in 2 weeks. >>>>>>> >>>>>>> WDYT? >>>>>>> >>>>>>> Thanks >>>>>>> -Vincent

Vincent Massol

29 Aug 29 Aug

12:13 p.m.

ok so WDYT about doing a ProgrammingRight-fixing-day this Thursday, i.e. the 31st of August? Thanks -Vincent

...

On 19 Aug 2017, at 12:47, Vincent Massol <vincent(a)massol.net> wrote: Hi devs, We have several pages requiring PR and we’re not doing much about them. This is a major pain, for example on myxwiki.org where, every time some admin update their wikis they break features. It’s not showing XWiki in good light neither. I’ve found at least those pages requiring PR: * XWiki.AllAttachmentsResults * XWiki.DeletedDocumentsJSON * AppWithinMinutes.DynamicMessageTool * AnnotationCode.Style * XWiki.DeletedDocuments * AppWithinMinutes.LiveTableEditSheet * AppWithinMinutes.ClassEditSheet * XWiki.DeletedAttachments * Main.Activity * AnnotationCode.Script (see http://jira.xwiki.org/browse/XWIKI-10446?focusedCommentId=83579&page=co… ) And FTR we keep adding more over time. For example in 2012, AWM introduced a PR: https://github.com/xwiki/xwiki-platform/commit/ae09194f83b9fe1f75778e0a2501… I’d like to propose to do a PR-fixing day for the next non-BFD day, i.e. in 2 weeks. WDYT? Thanks -Vincent

Thomas Mortagne

12:17 p.m.

Sure. On Tue, Aug 29, 2017 at 12:13 PM, Vincent Massol <vincent(a)massol.net> wrote:

...

ok so WDYT about doing a ProgrammingRight-fixing-day this Thursday, i.e. the 31st of August? Thanks -Vincent

-- Thomas Mortagne

2628

days inactive

2638

days old

xwiki-devs@xwiki.org

Manage subscription

11 comments

4 participants

tags (0)

participants (4)

Ecaterina Moraru (Valica)
Marius Dumitru Florea
Thomas Mortagne
Vincent Massol