6 Oct
2010
6 Oct
'10
6:11 p.m.
Hi,
This is a technical refactoring but I'm posting it here since it means changing our
rendering API quite significantly.
Basically we currently have 2 notions: Image and Link. I'd like to make them one
(called Reference) since we need/want to handle similarly and this would remove lots of
duplicated code.
Since we've already broken quite a lot of Rendering APIs in XE 2.5M1/M2 I feel
it's a good time to be brave and go the full monty... ;)
I've started the work already but wanted to keep you posted in case someone
disagrees.
For the record this is about implementing:
- http://jira.xwiki.org/jira/browse/XWIKI-5549
- http://jira.xwiki.org/jira/browse/XWIKI-5554
Thanks
-Vincent
7 Oct
7 Oct
10:22 a.m.
New subject: [xwiki-devs] [Proposal] Merge Link and Image as Reference in Rendering module
+1
On Wed, Oct 6, 2010 at 18:11, Vincent Massol <vincent(a)massol.net> wrote:
Hi,
This is a technical refactoring but I'm posting it here since it means changing our
rendering API quite significantly.
Basically we currently have 2 notions: Image and Link. I'd like to make them one
(called Reference) since we need/want to handle similarly and this would remove lots of
duplicated code.
Since we've already broken quite a lot of Rendering APIs in XE 2.5M1/M2 I feel
it's a good time to be brave and go the full monty... ;)
I've started the work already but wanted to keep you posted in case someone
disagrees.
For the record this is about implementing:
- http://jira.xwiki.org/jira/browse/XWIKI-5549
- http://jira.xwiki.org/jira/browse/XWIKI-5554
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne
noon
New subject: [xwiki-devs] [Proposal] Merge Link and Image as Reference in Rendering module
+1 for the idea of a more generic syntax.
Caleb
On 10/07/2010 04:22 AM, Thomas Mortagne wrote:
+1
On Wed, Oct 6, 2010 at 18:11, Vincent Massol <vincent(a)massol.net> wrote:
Hi,
This is a technical refactoring but I'm posting it here since it means changing our
rendering API quite significantly.
Basically we currently have 2 notions: Image and Link. I'd like to make them one
(called Reference) since we need/want to handle similarly and this would remove lots of
duplicated code.
Since we've already broken quite a lot of Rendering APIs in XE 2.5M1/M2 I feel
it's a good time to be brave and go the full monty... ;)
I've started the work already but wanted to keep you posted in case someone
disagrees.
For the record this is about implementing:
- http://jira.xwiki.org/jira/browse/XWIKI-5549
- http://jira.xwiki.org/jira/browse/XWIKI-5554
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
11:44 a.m.
New subject: [xwiki-devs] [VOTE] Re: [Proposal] Merge Link and Image as Reference in Rendering module
Actually DocumentReference already exists so it's better to find a different naming.
After long thinking I'm proposing:
- ResourceReference
- DocumentResourceReference
- InterWikiResourceReference
So from the Listener interface POV we will have:
onImage(ResourceReference reference...)
beingLink(ResourceReference reference...)
endLink((ResourceReference reference...)
Note: I've transformed this into a VOTE since it's an important API change.
+1 from me
Thanks
-Vincent
PS: I would have liked to reuse the URI class but the standard JDK URI is not good enough
for us
On Oct 6, 2010, at 6:11 PM, Vincent Massol wrote:
Hi,
This is a technical refactoring but I'm posting it here since it means changing our
rendering API quite significantly.
Basically we currently have 2 notions: Image and Link. I'd like to make them one
(called Reference) since we need/want to handle similarly and this would remove lots of
duplicated code.
Since we've already broken quite a lot of Rendering APIs in XE 2.5M1/M2 I feel
it's a good time to be brave and go the full monty... ;)
I've started the work already but wanted to keep you posted in case someone
disagrees.
For the record this is about implementing:
- http://jira.xwiki.org/jira/browse/XWIKI-5549
- http://jira.xwiki.org/jira/browse/XWIKI-5554
Thanks
-Vincent
12:19 p.m.
New subject: [xwiki-devs] [VOTE] Re: [Proposal] Merge Link and Image as Reference in Rendering module
+1
On Thu, Oct 7, 2010 at 11:44, Vincent Massol <vincent(a)massol.net> wrote:
Actually DocumentReference already exists so it's
better to find a different naming.
After long thinking I'm proposing:
- ResourceReference
- DocumentResourceReference
- InterWikiResourceReference
So from the Listener interface POV we will have:
onImage(ResourceReference reference...)
beingLink(ResourceReference reference...)
endLink((ResourceReference reference...)
Note: I've transformed this into a VOTE since it's an important API change.
+1 from me
Thanks
-Vincent
PS: I would have liked to reuse the URI class but the standard JDK URI is not good enough
for us
On Oct 6, 2010, at 6:11 PM, Vincent Massol wrote:
--
Thomas Mortagne
Hi,
This is a technical refactoring but I'm posting it here since it means changing our
rendering API quite significantly.
Basically we currently have 2 notions: Image and Link. I'd like to make them one
(called Reference) since we need/want to handle similarly and this would remove lots of
duplicated code.
Since we've already broken quite a lot of Rendering APIs in XE 2.5M1/M2 I feel
it's a good time to be brave and go the full monty... ;)
I've started the work already but wanted to keep you posted in case someone
disagrees.
For the record this is about implementing:
- http://jira.xwiki.org/jira/browse/XWIKI-5549
- http://jira.xwiki.org/jira/browse/XWIKI-5554
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
12:28 p.m.
New subject: [xwiki-devs] [VOTE] Re: [Proposal] Merge Link and Image as Reference in Rendering module
+1
Caleb
On 10/07/2010 05:44 AM, Vincent Massol wrote:
Actually DocumentReference already exists so it's
better to find a different naming.
After long thinking I'm proposing:
- ResourceReference
- DocumentResourceReference
- InterWikiResourceReference
So from the Listener interface POV we will have:
onImage(ResourceReference reference...)
beingLink(ResourceReference reference...)
endLink((ResourceReference reference...)
Note: I've transformed this into a VOTE since it's an important API change.
+1 from me
Thanks
-Vincent
PS: I would have liked to reuse the URI class but the standard JDK URI is not good enough
for us
On Oct 6, 2010, at 6:11 PM, Vincent Massol wrote:
Hi,
This is a technical refactoring but I'm posting it here since it means changing our
rendering API quite significantly.
Basically we currently have 2 notions: Image and Link. I'd like to make them one
(called Reference) since we need/want to handle similarly and this would remove lots of
duplicated code.
Since we've already broken quite a lot of Rendering APIs in XE 2.5M1/M2 I feel
it's a good time to be brave and go the full monty... ;)
I've started the work already but wanted to keep you posted in case someone
disagrees.
For the record this is about implementing:
- http://jira.xwiki.org/jira/browse/XWIKI-5549
- http://jira.xwiki.org/jira/browse/XWIKI-5554
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
12:49 p.m.
New subject: [xwiki-devs] [VOTE] Re: [Proposal] Merge Link and Image as Reference in Rendering module
+1
Thanks,
Marius
On 10/07/2010 12:44 PM, Vincent Massol wrote:
Actually DocumentReference already exists so it's
better to find a different naming.
After long thinking I'm proposing:
- ResourceReference
- DocumentResourceReference
- InterWikiResourceReference
So from the Listener interface POV we will have:
onImage(ResourceReference reference...)
beingLink(ResourceReference reference...)
endLink((ResourceReference reference...)
Note: I've transformed this into a VOTE since it's an important API change.
+1 from me
Thanks
-Vincent
PS: I would have liked to reuse the URI class but the standard JDK URI is not good enough
for us
On Oct 6, 2010, at 6:11 PM, Vincent Massol wrote:
Hi,
This is a technical refactoring but I'm posting it here since it means changing our
rendering API quite significantly.
Basically we currently have 2 notions: Image and Link. I'd like to make them one
(called Reference) since we need/want to handle similarly and this would remove lots of
duplicated code.
Since we've already broken quite a lot of Rendering APIs in XE 2.5M1/M2 I feel
it's a good time to be brave and go the full monty... ;)
I've started the work already but wanted to keep you posted in case someone
disagrees.
For the record this is about implementing:
- http://jira.xwiki.org/jira/browse/XWIKI-5549
- http://jira.xwiki.org/jira/browse/XWIKI-5554
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs 
2:19 p.m.
New subject: [xwiki-devs] [VOTE] Re: [Proposal] Merge Link and Image as Reference in Rendering module
On 10/07/2010 11:44 AM, Vincent Massol wrote:
Actually DocumentReference already exists so it's
better to find a different naming.
After long thinking I'm proposing:
- ResourceReference
- DocumentResourceReference
- InterWikiResourceReference
So from the Listener interface POV we will have:
onImage(ResourceReference reference...)
beingLink(ResourceReference reference...)
Why being, did you meant begin?
In general, +1
Thanks,
Alex
endLink((ResourceReference reference...)
Note: I've transformed this into a VOTE since it's an important API change.
+1 from me
Thanks
-Vincent
PS: I would have liked to reuse the URI class but the standard JDK URI is not good enough
for us
On Oct 6, 2010, at 6:11 PM, Vincent Massol wrote:
Hi,
This is a technical refactoring but I'm posting it here since it means changing our
rendering API quite significantly.
Basically we currently have 2 notions: Image and Link. I'd like to make them one
(called Reference) since we need/want to handle similarly and this would remove lots of
duplicated code.
Since we've already broken quite a lot of Rendering APIs in XE 2.5M1/M2 I feel
it's a good time to be brave and go the full monty... ;)
I've started the work already but wanted to keep you posted in case someone
disagrees.
For the record this is about implementing:
- http://jira.xwiki.org/jira/browse/XWIKI-5549
- http://jira.xwiki.org/jira/browse/XWIKI-5554
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
5146
days inactive
5147
days old
7 comments
5 participants
participants (5)
-
Alex Busenius -
Caleb James DeLisle -
Marius Dumitru Florea -
Thomas Mortagne -
Vincent Massol