Hi!
The current color theme editor is designed for colibri, and does not look
like flamingo does. We have several options here:
- create a new color theme editor, especially for Flamingo
- modify the current one to detect which skin is currenlty used, and change
the preview.
The application will be splited in 2 sections:
1/ a live preview where you can set some variables (what we currenlty have)
2/ a free textarea where the user can fill LESS code (for example, some
code downloaded on bootswatch).
But a lot of applications already use the color theme as it is, via the
"colorThemeInit.vm" template. So we need a retro-compatibility: a color
theme computed by LESS must be usable with old color themes.
Concretly, we will map the old color theme variables to the bootstrap ones,
example:
$theme.notificationSuccessColor = @brand-success
But because of the section 2 (the free textarea), we are not able to know
what will be the final value of a bootstrap variables without parsing the
content of the textarea!
What are the options we have:
1/ Implementing our own LESS parser/compiler in Java
2/ Trying to reuse the official LESS Parser through Rhino in a way that we
can get the computed variables
3/ Do not parse the input but the ouput: parse the CSS code to get the
final values of the variables
I'm for 3.
The idea is to create some CSS classes like this:
.colortheme-bordercolor{
color: @border-color;
}
which will be converted by LESS to:
.colortheme-bordercolor{
color: #000000;
}
so we can parse it and know the value of $theme.bordercolor. It is quick,
simple, but it pollutes the output CSS a little.
WDYT?
Thanks,
Guillaume
Hi devs,
We missed last week’s XWiki Day (I just forgot, shame on me!) but we quickly discussed on IRC what could be the content of the next XWiki Day:
- Thomas proposed a deprecation fixing day
- I proposed a Pull Request day (to review all PRs and ensure we've replied to all and merge the ones we can)
And now Danilo is proposing a Doc Day (see users list).
So, contributors and committers, what do you wish to do for the following Thursday (the 5th of June since tomorrow is a bank holiday in France and I won’t be able to organize it, if someone is interesting to lead it, please answer here!)?
Thanks
-Vincent
Hi devs.
For commit the code of Macro dynamic tree i need to have rights on
xwiki-contrib.
Github ID : bandoulyes
Thank in advance
--- Best regards - Cordialement ---
Lyes Bandou
Hi devs,
It’s been raised by a user to me that it’s strange that when they use a quote (using the “>” symbol) we don’t show visually that it’s a quote and that it seems to him that it would make sense to show some quote symbols.
Right now on XE it looks like:
https://www.evernote.com/shard/s119/sh/5eea60a0-8110-438e-a292-47d395c386bc…
On xwiki.org (junco) it looks like this:
http://www.xwiki.org/xwiki/bin/view/References/Testimonials
It’s true that the XE’s default doesn’t look very much like a quote… It can be confused with a box easily.
So WDYT about improving that in our default XE by having something either like junco (is it clear enough that it’s a quote) or adding quotes symbols?
Thanks
-Vincent
Hi devs,
I’d like to propose that we change our rule of supporting the last 2 versions of XWiki (ie the latest stable and the version in development) which is documented here: http://www.xwiki.org/xwiki/bin/view/Main/Support
The new support rule would be that we support:
* The latest release from the previous development cycle (right now that’s 5.4.5)
* The latest stable release from the current cycle (right now that’s 6.0.1)
* The latest development release from the current cycle (right now that’s 6.1M1)
The rationale is that we need to offer a super stable release (that’s the latest from the previous dev cycle) for users in production.
Here’s my +1.
Thanks
-Vincent
PS: Note that if we really wanted to support only 2 versions, then I’d propose to drop the “latest stable from the current cycle” (ie 6.0.1 right now), thus offering only 5.4.5 and 6.1M1 ATM.
Hi,
I added $doc.save() in contentview.vm to save the object added to my doc,
this save increment the revision.
is it possible to tell the save to not increment the version ?
Thanks in advance :)
Hi,
When i finish this work i want to make an extension "*Installable with the
Extension Manager*".
Main modifications i have made :
- Changes on *historyinline.vm* to add a button Approve in order to
approve a revision and make it public.
- Modification on *contentview.vm* to get the revision value passed in
parameter from historyinline.vm and set the approved revision in the object
attached to the document.
- I added a *groovy
listener*<http://extensions.xwiki.org/xwiki/bin/view/Extension/Create+an+XObject+By+d…>to
add an object to new pages
- Adding a new
*class*<http://www.rendering.xwiki.org/xwiki/bin/viewrev/FAQ/How+to+implement+%22Ap…>to
contains the value of the approved revision
It's not finished yet, i have to make a clean and tested version of this
extension and make some documentations, but i want to know if i'm on the
right way to build an extension.
An extension can override files like historyinline.vm ? if yes it won't
work for futur version if XWIKI, right ? otherwise what's the best way to
do so ?
I can't find documentation about creating an installable Extension Manager.
What about licenses? i asked my boss and he told me that we can make this
public for free but i should mention the name of our company, and make
copyright (the name of our company) in new source files, is it possible ?
Thanks in advance :)
Hi Vincent
Thank you , and no we don't need a JIRA project yet
On Mon, May 26, 2014 at 11:15 AM, vincent(a)massol.net <vincent(a)massol.net>wrote:
> Hi Lyes,
>
> Done: https://github.com/xwiki-contrib/macro-dynamic-tree
>
> Do you also need a JIRA project?
>
> Thanks
> -Vincent
>
> On 21 May 2014 at 19:07:24, Anca Luca (lucaa(a)xwiki.com(mailto:
> lucaa(a)xwiki.com)) wrote:
>
> > Hello Devs,
> >
> > As far as I know it's not a refactoring of the old macro because some
> > parameters / parameters behaviour was not kept 100%. It's missing some
> > features, basically. Adding some with the cost of removing others.
> >
> > So if we consider it a new version of the old one, installing an
> "upgrade"
> > will break the behaviour. You'd tell me we could wait to release the new
> > version it only when ready, but then people could not take advantage of
> its
> > features (which are cool).
> >
> > We could have it as a new extension until we implement all the features
> of
> > the old one, and then we mark it as implementing the same feature so that
> > the old one could be upgraded to the new one.
> >
> > Anca
> >
> >
> > On Wed, May 21, 2014 at 7:11 PM, vincent(a)massol.net wrote:
> >
> > >
> > >
> > >
> > >
> > > On 21 May 2014 at 18:08:33, Lyes Bandou (lyes.bandou(a)xwiki.com(mailto:
> > > lyes.bandou(a)xwiki.com)) wrote:
> > >
> > > > Code of the two macros is not the same,
> > >
> > > This doesn’t matter much if the new code is considered a refactoring of
> > > the old code.
> > >
> > > > The new macro has the same name and
> > > > keeps most paramettres, but the behavior is not the same it uses
> Ajax to
> > > > load the data (using JSON) and the older macro display the documents
> > > > hierarchy in a space , the new macro can uses documents list as
> documents
> > > > roots of the tree (plus another paramettres)
> > > >
> > > >
> > > > I suggest "Dynamic Tree Macro" as the new name.
> > >
> > > The real question is: do we need the 2 macros at once?
> > >
> > > I guess we need to ask the question to the author of the first macro:
> > > Anca, Paul, Mircea.
> > >
> > > Because from a user point of view, it’s a nightmare to have several
> > > extensions doing the same thing, the user never knows which one to use.
> > >
> > > Anca/Paul/Mircea, do you have an opinion?
> > >
> > > Thanks
> > > -Vincent
> > >
> > > > On Wed, May 21, 2014 at 4:40 PM, Thomas Mortagne
> > > > wrote:
> > > >
> > > > > Same question, why is a new repository needed exactly ? If it's THE
> > > > > new version then it's the same extension and it should be the same
> > > > > repository, even if you rewrite half of it in a 2.0 version.
> > > > >
> > > > > On Wed, May 21, 2014 at 5:37 PM, vincent(a)massol.net
> > > > > wrote:
> > > > > > Do you really need a new extension? Couldn’t you improve the
> existing
> > > > > one then?
> > > > > >
> > > > > > Thanks
> > > > > > -Vincent
> > > > > >
> > > > > > On 21 May 2014 at 17:35:52, Lyes Bandou (lyes.bandou(a)xwiki.com
> > > (mailto:
> > > > > lyes.bandou(a)xwiki.com)) wrote:
> > > > > >
> > > > > >> This is the new version of Hierarchy Macro (
> > > > > >>
> http://extensions.xwiki.org/xwiki/bin/view/Extension/HierarchyMacro
> > > )
> > > > > with
> > > > > >> the addition of to many parameters
> > > > > >>
> > > > > >>
> > > > > >> On Wed, May 21, 2014 at 4:26 PM, Thomas Mortagne
> > > > > >> wrote:
> > > > > >>
> > > > > >> > Are you talking about
> > > > > >> >
> > > http://extensions.xwiki.org/xwiki/bin/view/Extension/HierarchyMacro ?
> > > > > >> >
> > > > > >> > If not you might want to find another name since this one
> already
> > > have
> > > > > >> > https://github.com/xwiki-contrib/macro-hierarchy.
> > > > > >> >
> > > > > >> > On Wed, May 21, 2014 at 5:23 PM, Lyes Bandou
> > > > > >> > wrote:
> > > > > >> > > Hello devs,
> > > > > >> > >
> > > > > >> > > I would like a repository for the Hierarchy Macro on
> > > > > >> > > https://github.com/xwiki-contrib.
> > > > > >> > >
> > > > > >> > > Hierarchy Macro use jQuery and jsTree (
> http://www.jstree.com)
> > > to
> > > > > display
> > > > > >> > > dynamique tree view of wiki documents based on parent/child
> > > > > relationships
> > > > > >> > >
> > > > > >> > > Thank you in advance.
> > > > > >> > >
> > > > > >> > >
> > > > > >> > > Lyes Bandou
> > > > > >
> > > > > > _______________________________________________
> > > > > > devs mailing list
> > > > > > devs(a)xwiki.org
> > > > > > http://lists.xwiki.org/mailman/listinfo/devs
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Thomas Mortagne
> > > > > _______________________________________________
> > > > > devs mailing list
> > > > > devs(a)xwiki.org
> > > > > http://lists.xwiki.org/mailman/listinfo/devs
> > > > >
> > > > _______________________________________________
> > > > devs mailing list
> > > > devs(a)xwiki.org
> > > > http://lists.xwiki.org/mailman/listinfo/devs
> > > _______________________________________________
> > > devs mailing list
> > > devs(a)xwiki.org
> > > http://lists.xwiki.org/mailman/listinfo/devs
> > >
> > _______________________________________________
> > devs mailing list
> > devs(a)xwiki.org
> > http://lists.xwiki.org/mailman/listinfo/devs
>
> _______________________________________________
> devs mailing list
> devs(a)xwiki.org
> http://lists.xwiki.org/mailman/listinfo/devs
>
Code of the two macros is not the same, The new macro has the same name and
keeps most paramettres, but the behavior is not the same it uses Ajax to
load the data (using JSON) and the older macro display the documents
hierarchy in a space , the new macro can uses documents list as documents
roots of the tree (plus another paramettres)
I suggest "Dynamic Tree Macro" as the new name.
On Wed, May 21, 2014 at 4:40 PM, Thomas Mortagne
<thomas.mortagne(a)xwiki.com>wrote:
> Same question, why is a new repository needed exactly ? If it's THE
> new version then it's the same extension and it should be the same
> repository, even if you rewrite half of it in a 2.0 version.
>
> On Wed, May 21, 2014 at 5:37 PM, vincent(a)massol.net <vincent(a)massol.net>
> wrote:
> > Do you really need a new extension? Couldn’t you improve the existing
> one then?
> >
> > Thanks
> > -Vincent
> >
> > On 21 May 2014 at 17:35:52, Lyes Bandou (lyes.bandou(a)xwiki.com(mailto:
> lyes.bandou(a)xwiki.com)) wrote:
> >
> >> This is the new version of Hierarchy Macro (
> >> http://extensions.xwiki.org/xwiki/bin/view/Extension/HierarchyMacro)
> with
> >> the addition of to many parameters
> >>
> >>
> >> On Wed, May 21, 2014 at 4:26 PM, Thomas Mortagne
> >> wrote:
> >>
> >> > Are you talking about
> >> > http://extensions.xwiki.org/xwiki/bin/view/Extension/HierarchyMacro ?
> >> >
> >> > If not you might want to find another name since this one already have
> >> > https://github.com/xwiki-contrib/macro-hierarchy.
> >> >
> >> > On Wed, May 21, 2014 at 5:23 PM, Lyes Bandou
> >> > wrote:
> >> > > Hello devs,
> >> > >
> >> > > I would like a repository for the Hierarchy Macro on
> >> > > https://github.com/xwiki-contrib.
> >> > >
> >> > > Hierarchy Macro use jQuery and jsTree (http://www.jstree.com) to
> display
> >> > > dynamique tree view of wiki documents based on parent/child
> relationships
> >> > >
> >> > > Thank you in advance.
> >> > >
> >> > >
> >> > > Lyes Bandou
> >
> > _______________________________________________
> > devs mailing list
> > devs(a)xwiki.org
> > http://lists.xwiki.org/mailman/listinfo/devs
>
>
>
> --
> Thomas Mortagne
> _______________________________________________
> devs mailing list
> devs(a)xwiki.org
> http://lists.xwiki.org/mailman/listinfo/devs
>