xwiki-devs

xwiki-devs@xwiki.org

9400 discussions

Re: [xwiki-devs] [xwiki-notifications] r28419 - platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web

by Vincent Massol

On Apr 17, 2010, at 3:47 AM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2010-04-17 03:47:52 +0200 (Sat, 17 Apr 2010) > New Revision: 28419 > > Modified: > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/DeleteVersionsAction.java > Log: > XWIKI-5121: Weird behavior when deleting the head of the history of a renamed document > Fixed. > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/DeleteVersionsAction.java &… [View More]

14 years, 10 months

[xwiki-devs] [Proposal] Add file access module to allow secure access to the filesystem.

by Caleb James DeLisle

Currently we have 109 instantiations of the File class spread over 40 java classes. Each one of these has as much access to the filesystem as the user. My proposal is to create a new module in the core which manages access to the filesystem. I would like the module to provide roles for read-only and read/write files or directories. ReadOnlyFile and ReadWriteFile would extend java.io.File and override getParentFile() which allows the owner of a single file to walk the directory tree. Imagine … [View More]

14 years, 10 months

[xwiki-devs] Fwd: [webdriver] New release made

by Vincent Massol

fyi -Vincent Begin forwarded message: > From: Simon Stewart <simon.m.stewart(a)gmail.com> > Date: April 19, 2010 11:32:45 AM GMT+02:00 > To: webdriver <webdriver(a)googlegroups.com>, selenium-developers <selenium-developers(a)googlegroups.com> > Subject: [webdriver] New release made > Reply-To: webdriver(a)googlegroups.com > > Hi, > > I've just uploaded the JARs for a new alpha of Selenium 2: selenium > 2a3. This contains bug fixes and … [View More]

14 years, 10 months

[xwiki-devs] Implementing the XWiki.org Redesign

by Silvia Rusu

Hi XWiki devs & users, So far we've been talking a lot about redesigning XWiki.org and all feedback was greatly appreciated. Now it's time we started implementing the redesign Caty was so kind to come up with based on our suggestions. Like the proposal stage this too will be a collaborative effort and we hope you'll join in building an even better site for XWiki.org. The following is a list of things that need to be implemented in order to get us started. It would be great if you'd … [View More]volunteer for the implementation of the tasks at hand. Please add your name next to the issue you'd like to assign yourself too. Also feel free to add as many other issues you think should appear on the list and to volunteer for those issues as well. Here is the first list of tasks: * Set up the server for the new website (Alex? :) ) * Add the horizontal navigation to the new website * Implement the projects carousel for the homepage * Implement the panels for "Latest Releases", "Latest Extensions". "Latest News"(should display the latest 5 releases, extensions, news) Documentation/Projects * Implement the left navigation for documentation/projects * Implement the panel for the "Latest Documentation Updates" (should display the last 5 documents and their authors) Community page widgets and panels: * Implement the"Development Status" panel, if it's going to have dynamic content * Implement the "Top Committers" panel (show the committer's picture and number of commits) * Implement the "Latest Commits" section (should display an image of the committer, what (s)he commited, the name of the committer and the date the commit was made) * Implement the "Latest Issues" section (should have the latest Jira issues, the person who took an action with regard to the issue - e.g. create, close - and the time the action was taken) * Implement the "Latest Discussion" section (display the list, the topic discussed, the name of the person that added the latest reply and the time he added the answer) * Implement the "Latest Documentation" section (show the number of lines added/deleted, the name of the document, the author of the modification and the time (s)he made the changes) * Implement "Latest Extensions" section (display the extension name, the name of the person that added the extension, the time it was added and a short description) You may read what has already been discussed about the redesign on this page http://markmail.org/message/tfmrludhw2yh5tcn#query:+page:1+mid:h5bukrijteeu… See the latest redesign proposal here http://incubator.myxwiki.org/xwiki/bin/view/Improvements/XWikiOrgProposal2 Thanks, Silvia [View Less]

14 years, 10 months

[xwiki-devs] Contribution to the DatePicker application

by Raluca Stavro

Hello devs, I would like to contribute to the DatePicker application. Currently, the DatePicker stylesheet does not take in account the color theme. This is why I created a Jira issue (XCONTRIB-109) and I attached a patch to it. You will see some screenshots with the new styles applied on the DatePicker table. Can someone please give me the right to commit those styles? Raluca.

14 years, 10 months

[xwiki-devs] Should email invitation code be an application? How should it be put in sandbox?

by Caleb James DeLisle

I have a reasonably clean revision of the code for inviting friends to join the wiki. Should it be a separate application with it's own jira project? It's not very large but may grow. I can't imagine what other application it should be filed under. I'd like to put it in the sandbox so it can be subject to review and discussion but I don't know how that should be done. I guess that depends on whether it is going to be it's own application. Any thoughts? Caleb

14 years, 10 months

Re: [xwiki-devs] [xwiki-notifications] r26074 - in platform/core/trunk/xwiki-core/src: main/java/com/xpn/xwiki/doc test/java/com/xpn/xwiki/doc

by Caleb James DeLisle

(resending, meant to send to the dev list.) Sorry to drag up old commits but I have a couple of questions. vmassol (SVN) wrote: > Author: vmassol > Date: 2010-01-07 23:02:51 +0100 (Thu, 07 Jan 2010) > New Revision: 26074 > > Modified: > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java > platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/doc/XWikiDocumentTest.java > Log: > XWIKI-4677: Introduce new Model module > … [View More]> * Fixed infinite cycle (revert some previous change). We need to find a solution. > * Refactored existing code to prevent manual parsing > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java 2010-01-07 16:55:03 UTC (rev 26073) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java 2010-01-07 22:02:51 UTC (rev 26074) > @@ -80,6 +80,7 @@ > import org.xwiki.context.ExecutionContextManager; > import org.xwiki.model.reference.DocumentReferenceResolver; > import org.xwiki.model.reference.EntityReferenceSerializer; > +import org.xwiki.model.reference.WikiReference; > import org.xwiki.rendering.block.Block; > import org.xwiki.rendering.block.HeaderBlock; > import org.xwiki.rendering.block.LinkBlock; > @@ -359,8 +360,10 @@ > /** > * Used to create proper {@link Syntax} objects. > */ > - SyntaxFactory syntaxFactory = Utils.getComponent(SyntaxFactory.class); > + private SyntaxFactory syntaxFactory = Utils.getComponent(SyntaxFactory.class); > Why are we holding a hard reference on the Execution which was present when the document was first loaded or created? Is this not a memory leak? Cache holds Document holds Execution holds ExecutionContext holds XWikiContext holds DocumentArchive? > + private Execution execution = Utils.getComponent(Execution.class); > + > /** > * @since 2.2M1 > */ > @@ -375,7 +378,9 @@ > @Deprecated > public XWikiDocument() > { > - this(Utils.getComponent(DocumentReferenceResolver.class).resolve("")); > + // TODO: Replace this with the following when we find a way to not generate a cycle: > + // this(Utils.getComponent(DocumentReferenceResolver.class).resolve("")); > + this(new DocumentReference("xwiki", "Main", "WebHome")); > } > > /** > @@ -397,25 +402,18 @@ > * > * @param wiki The wiki this document belongs to. > * @param space The space this document belongs to. > - * @param name The name of the document. > + * @param name The name of the document (can contain either the page name or the space and page name) > * @deprecated since 2.2M1 use {@link #XWikiDocument(org.xwiki.model.reference.DocumentReference)} instead > */ > @Deprecated > public XWikiDocument(String wiki, String space, String name) > { > - String normalizedPage; > - String normalizedSpace; > - int i1 = name.indexOf("."); > - if (i1 == -1) { > - normalizedPage = name; > - normalizedSpace = space; > - } else { > - normalizedSpace = name.substring(0, i1); > - normalizedPage = name.substring(i1 + 1); > - } > - > - init(Utils.getComponent(DocumentReferenceResolver.class, "current/reference").resolve( > - new DocumentReference(wiki, normalizedSpace, normalizedPage))); > + // We allow to specify the space in the name (eg name = "space.page"). In this case the passed space is > + // ignored. > + DocumentReference reference = resolveReference(name, new DocumentReference(wiki, space, null)); > + // Replace the resolved wiki by the passed wiki > + reference.setWikiReference(new WikiReference(wiki)); > + init(reference); > } > > public XWikiStoreInterface getStore(XWikiContext context) > @@ -5846,4 +5844,21 @@ > > return syntaxId; > } > + > + private DocumentReference resolveReference(String referenceAsString, DocumentReference defaultReference) > + { > + XWikiContext xcontext = getXWikiContext(); > + XWikiDocument originalCurentDocument = xcontext.getDoc(); > + try { > + xcontext.setDoc(new XWikiDocument(defaultReference)); > + return this.currentDocumentReferenceResolver.resolve(referenceAsString); > + } finally { > + xcontext.setDoc(originalCurentDocument); > + } > + } > + How is this different from XWikiDocument#getContext() introduced in 23506? Is the only difference that the context is the one from when the document was created/loaded rather than the current context? If so this probably ought to be commented since it is a major trap for anyone who expects getXWikiContext().getUser() to yield the current user (for example). > + private XWikiContext getXWikiContext() > + { > + return (XWikiContext) this.execution.getContext().getProperty("xwikicontext"); > + } > } > > Modified: platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/doc/XWikiDocumentTest.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/doc/XWikiDocumentTest.java 2010-01-07 16:55:03 UTC (rev 26073) > +++ platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/doc/XWikiDocumentTest.java 2010-01-07 22:02:51 UTC (rev 26074) > @@ -155,6 +155,29 @@ > this.mockXWikiStoreInterface.stubs().method("search").will(returnValue(new ArrayList<XWikiDocument>())); > } > > + public void testConstructor() > + { > + XWikiDocument doc = new XWikiDocument("notused", "space.page"); > + assertEquals("space", doc.getSpaceName()); > + assertEquals("page", doc.getPageName()); > + assertEquals("xwiki", doc.getWikiName()); > + > + doc = new XWikiDocument("space", "page"); > + assertEquals("space", doc.getSpaceName()); > + assertEquals("page", doc.getPageName()); > + assertEquals("xwiki", doc.getWikiName()); > + > + doc = new XWikiDocument("wiki", "space", "page"); > + assertEquals("space", doc.getSpaceName()); > + assertEquals("page", doc.getPageName()); > + assertEquals("wiki", doc.getWikiName()); > + > + doc = new XWikiDocument("wiki", "notused", "notused:space.page"); > + assertEquals("space", doc.getSpaceName()); > + assertEquals("page", doc.getPageName()); > + assertEquals("wiki", doc.getWikiName()); > + } > + > public void testGetDisplayTitleWhenNoTitleAndNoContent() > { > this.document.setContent("Some content"); > > _______________________________________________ > notifications mailing list > notifications(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/notifications > [View Less]

14 years, 10 months

[xwiki-devs] [proposal] Fix XWIKI-4265 by changing the way the previous version of a document is found.

by Caleb James DeLisle

Currently, api.Document.getPreviousVersion() calls doc.XWikiDocument.getPreviousVersion() which calls doc.XWikiDocument.getDocumentArchive() which will return null if the document archive is not currently loaded. doc.XWikiDocument.getPreviousVersion() is inherently dangerous and should be deprecated then removed. doc.XWikiDocument.getDocumentArchive() sometimes returns null and should be deprecated then made private. everywhere doc.XWikiDocument.getDocumentArchive() is used it should be … [View More]

14 years, 10 months

[xwiki-devs] [ANN] XWiki Enterprise and XWiki Enterprise Manager 2.2.5 Released

by Thomas Mortagne

The XWiki development team is pleased to announce the release of XWiki Enterprise and XWiki Enterprise Manager 2.2.5. This is a bug fix release for the 2.2 branches. Improvement * [XSCOLIBRI-206] - Use isInPortletMode and isInServletMode velocity variables instead of querying context mode * [XWIKI-5095] - Introduce isInPortletMode and isInServletMode velocity variables and use them instead of querying context mode * [XWIKI-5096] - Prevent ActionFilter from being called … [View More]

14 years, 10 months

[xwiki-devs] [Proposal] Computed title depth configuration option

by Vincent Massol

Hi, We've had a user request (Ludovic as a user ;)) to have a config option to decide the header level to consider for a title. Right now we consider only levels 1 and 2 when computing a title from the doc content. Thus I'm going to add a config option named xwiki.title.headerdepth and with a default value of 2 (to have the same behavior as now) and use it in XWikiDocument.getRenderedContentTitle(). Note that this is only for the 2.0 syntax (since it's too hard to do for syntax 1.0 and we'… [View More]

14 years, 10 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

xwiki-devs