October 2008 - xwiki-devs@xwiki.org

Re: [xwiki-devs] [xwiki-notifications] r13381 - platform/core/trunk/xwiki-rendering/src/main/java/org/xwiki/rendering/renderer
by Sergiu Dumitriu 08 Oct '08

08 Oct '08

tmortagne (SVN) wrote: > Author: tmortagne > Date: 2008-10-07 19:24:57 +0200 (Tue, 07 Oct 2008) > New Revision: 13381 > > Added: > platform/core/trunk/xwiki-rendering/src/main/java/org/xwiki/rendering/renderer/XHTMLWikiPrinter.java > Removed: > platform/core/trunk/xwiki-rendering/src/main/java/org/xwiki/rendering/renderer/AbstractXMLRenderer.java > Modified: > platform/core/trunk/xwiki-rendering/src/main/java/org/xwiki/rendering/renderer/XHTMLRenderer.java > Log: > * makes AbstractXMLRenderer a XHTMLWikiPrinter tool > I don't quite agree with this... The class is about XML printing, yet it is named XHTML. The methods are all about pure XML: printXMLStartElement, printXMLEndElement, createAttributes... And I'd like to keep it that way, if we don't need something HTML specific in it, just in case we'll need a different renderer (DocBook? the dead WML?). -- Sergiu Dumitriu http://purl.org/net/sergiu/

2 1

[xwiki-devs] [Proposal] Rendering Link Syntax Take 2
by Vincent Massol 07 Oct '08

07 Oct '08

Hi devs, Sorry for the numerous mails on this topic. I've been struggling a bit in choosing the best solution with the caveats brought by wikimodel. So here's my latest proposal that replaces all previous ones on the link topic: 1) General link syntax: [[label>>reference]] or [[label||reference]] Note1: I've removed the need for parameters, see below. Note2: I'm suggesting double character separators since if we allow wiki syntax in link labels we need to easily differentiate the separator from a character typed in the label. Same reason why we doubled [[ ]], **, //, etc. characters. We could still use single characters (open question, I'm not sure about double chars) since people are not meant to write tons of text in link labels. OTOH it's consistent with our usage of double chars everywhere else (but it breaks current habits of the single char for links). 2) Links with parameters: (% param1=value1 paramN=valueN %)[[label>>reference]] 3) Links with wiki syntax for the label: [[**bold** link>>reference]] [[{{velocity}}...{{/velocity}}>>reference]] [[{{image:...}}>>reference]] <-- image link <OT> Note: For the image link we'll still need to decide if we want a macro for inserting an image or use wiki syntax but that's a topic that is now dissociated from the link topic: [[{{image:my.png}}>>reference]] or [[image:my.png>>reference </OT> Last for those wondering, I've found a solution to make this work with wikimodel and I've discovered Doxia supported wiki syntax in link labels, hence why I'm resurrecting the idea of having wiki syntax in links which is a way superior solution. Thanks -Vincent

8 10

Re: [xwiki-devs] Things change
by Anca Paula Luca 06 Oct '08

06 Oct '08

Evelina Slatineanu wrote: > Hello all, > > > > This time I will "bother" you with a different type of mail, not the usual > bugs and fixes issues that come on dev mailing lists. > > > > First, let me say that so far it was nice to be part of the XWiki Team. And > many thanks to those who worked with me and helped me when I couldn't do it > by myself. Here, first in the list goes Sergiu Dumitriu, who was helped me > more than anyone else throughout the time. Also, thanks to Marta, Jerome, > JV, Laurent and the whole Iasi Team. I hope I'm not forgetting anyone. > > It has been a nice opportunity to work with you guys. > It's the same here, even if it might not have always felt like this. > > > However, time has come to say goodbye to all of you and continue my journey > with the next step in my professional life. I am going to pursue the goal of > becoming a good java programmer and even if XWiki could provide me with an > environment for doing this, I feel I need something more than that. There > are already plenty of intelligent and motivated people who do this very well > in XWiki and I would always be in their shadow. I feel I need to do this by > myself. > Since I think I know what it means and I'm enjoying it most of the seconds of everyday, I hope this decision is a step towards you finding the thing you like to do and which will make you happy (professionally speaking). I won't hide how disturbing it is to see people who have been here (in Iasi) from the very beginning leave. > > > So, I can only wish everyone good luck and success in whatever is that > everyone is doing. I am sure that only a bright and successful future awaits > XWiki. I can only wish it the best. > > > > Thank you very much for working with me. > +1 > > > Evelina Vrabie > > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs

1 0

[xwiki-devs] [Rendering] XHTML placeholder for links
by Vincent Massol 06 Oct '08

06 Oct '08

Hi, Since recognizing links to be xwiki links is hard (not even always possible) we need to add some extra information when we render wiki syntax content into XHTML (for the WYSIWYG editor for ex) so that we can convert it back to wiki syntax. We have 2 solutions I can think of: 1) Using a span with a class value: <! [CDATA[Space.ExistingPage]]><a href="/xwiki/bin/view/Space/ ExistingPage">Space.ExistingPage</a> 2) Using a comment: <a href="/ xwiki/bin/view/Space/ExistingPage">Space.ExistingPage</a> Pros and cons: * 2) allows not generating visible content in XHTML so that if someone copy/paste our generated XHTML he won't have to add some CSS rule to prevent it from being visible. BTW I'm not even sure we can find a CSS rule to do that in solution 1) so we might need to have 2 spans as in: <![CDATA[Space.ExistingPage]]><a href="/xwiki/bin/view/Space/ ExistingPage">Space.ExistingPage</a> * 1) is harder to code since it requires using a SAX2 LexicalHandler, which btw is not supported by all XML parsers: "This is an optional extension handler for SAX2 to provide lexical information about an XML document, such as comments and CDATA section boundaries. XML readers are not required to recognize this handler, and it is not part of core-only SAX2 distributions." It also requires that I make some modifications to wikimodel since wikimodel currently ignores comments. Solution 2) seems slightly better to me but as it's quite more complex to implement I'd like to be sure that it's the best solution. WDYT? Thanks -Vincent

3 8

[xwiki-devs] Things change
by Evelina Slatineanu 06 Oct '08

06 Oct '08

Hello all, This time I will "bother" you with a different type of mail, not the usual bugs and fixes issues that come on dev mailing lists. First, let me say that so far it was nice to be part of the XWiki Team. And many thanks to those who worked with me and helped me when I couldn't do it by myself. Here, first in the list goes Sergiu Dumitriu, who was helped me more than anyone else throughout the time. Also, thanks to Marta, Jerome, JV, Laurent and the whole Iasi Team. I hope I'm not forgetting anyone. It has been a nice opportunity to work with you guys. However, time has come to say goodbye to all of you and continue my journey with the next step in my professional life. I am going to pursue the goal of becoming a good java programmer and even if XWiki could provide me with an environment for doing this, I feel I need something more than that. There are already plenty of intelligent and motivated people who do this very well in XWiki and I would always be in their shadow. I feel I need to do this by myself. So, I can only wish everyone good luck and success in whatever is that everyone is doing. I am sure that only a bright and successful future awaits XWiki. I can only wish it the best. Thank you very much for working with me. Evelina Vrabie

1 0

[xwiki-devs] [VOTE] New link syntax
by Vincent Massol 06 Oct '08

06 Oct '08

Hi, Following up on my previous email we have several pbs in our current syntax: * we need to forbid "=" in doc names * we need to forbid "|" and ">" in doc names Hence Sergiu and I have brainstormed and we propose the following: label>ref>>param1=value1 ... paramN=valueN and label|ref||param1=value1 ... paramN=valueN Here's my +1 Thanks -Vincent

6 6

Re: [xwiki-devs] Fwd: [xwiki-notifications] r13338 - in sandbox/xwiki-webdav: references src/main/java/com/xpn/xwiki/plugin/webdav src/main/java/com/xpn/xwiki/plugin/webdav/mock src/main/java/com/xpn/xwiki/plugin/webdav/resources src/main/java/com/xp
by Asiri Rathnayake 06 Oct '08

06 Oct '08

On Mon, Oct 6, 2008 at 3:23 PM, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote: > Asiri Rathnayake wrote: > > On Mon, Oct 6, 2008 at 12:38 PM, SVN asiri > > <sandbox-notifications(a)xwiki.org>wrote: > > > >> Author: asiri > >> Date: 2008-10-06 09:08:11 +0200 (Mon, 06 Oct 2008) > >> New Revision: 13338 > >> > >> Added: > >> sandbox/xwiki-webdav/references/OldXWikiDavResource.java.Reference > >> > >> > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/AbstractXWikiDavResource.java > >> > >> > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/domain/AbstractXWikiDavFile.java > >> > >> > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/views/AbstractXWikiDavView.java > >> > >> > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/utils/XWikiDavUtils.java > >> Removed: > >> > >> > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/mock/MockXWikiServletContext.java > >> > >> > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/XWikiDavResource.java > >> > >> > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/domain/XWikiDavFile.java > >> > >> > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/old/ > >> > >> > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/views/XWikiDavView.java > >> > >> > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/utils/XWikiDavUtils.java > > > > > > Does this mean `svn mv` is not used ? I thought subclipse will take care > of > > it when i do refactorings :( > > No, this is how it appears in the file list. If you look in the detailed > diff, you can see: > > Copied: > sandbox/xwiki-webdav/references/OldXWikiDavResource.java.Reference (from > rev 13209, > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/old/OldXWikiDavResource.java) > > So it did a copy + delete = move > Yes, Thomas also mentioned this. Thanks. - Asiri > > -- > Sergiu Dumitriu > http://purl.org/net/sergiu/ > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs >

1 0

[xwiki-devs] Fwd: [xwiki-notifications] r13338 - in sandbox/xwiki-webdav: references src/main/java/com/xpn/xwiki/plugin/webdav src/main/java/com/xpn/xwiki/plugin/webdav/mock src/main/java/com/xpn/xwiki/plugin/webdav/resources src/main/java/com/xpn/xwiki/plugin/we
by Asiri Rathnayake 06 Oct '08

06 Oct '08

---------- Forwarded message ---------- From: Asiri Rathnayake <asiri.rathnayake(a)gmail.com> Date: Mon, Oct 6, 2008 at 12:46 PM Subject: Re: [xwiki-notifications] r13338 - in sandbox/xwiki-webdav: references src/main/java/com/xpn/xwiki/plugin/webdav src/main/java/com/xpn/xwiki/plugin/webdav/mock src/main/java/com/xpn/xwiki/plugin/webdav/resources src/main/java/com/xpn/xwiki/plugin/web To: XWiki Developers <devs(a)xwiki.org> On Mon, Oct 6, 2008 at 12:38 PM, SVN asiri <sandbox-notifications(a)xwiki.org>wrote: > Author: asiri > Date: 2008-10-06 09:08:11 +0200 (Mon, 06 Oct 2008) > New Revision: 13338 > > Added: > sandbox/xwiki-webdav/references/OldXWikiDavResource.java.Reference > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/AbstractXWikiDavResource.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/domain/AbstractXWikiDavFile.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/views/AbstractXWikiDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/utils/XWikiDavUtils.java > Removed: > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/mock/MockXWikiServletContext.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/XWikiDavResource.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/domain/XWikiDavFile.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/old/ > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/views/XWikiDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/utils/XWikiDavUtils.java Does this mean `svn mv` is not used ? I thought subclipse will take care of it when i do refactorings :(

3 2

Re: [xwiki-devs] [xwiki-notifications] r13338 - in sandbox/xwiki-webdav: references src/main/java/com/xpn/xwiki/plugin/webdav src/main/java/com/xpn/xwiki/plugin/webdav/mock src/main/java/com/xpn/xwiki/plugin/webdav/resources src/main/java/com/xpn/xwi
by Asiri Rathnayake 06 Oct '08

06 Oct '08

On Mon, Oct 6, 2008 at 1:25 PM, Vincent Massol <vincent(a)massol.net> wrote: > Hi Asiri, > > There was no comment in the commit. We always need a comment to know > why you did this commit. > Sorry, this was a mistake. My first commit failed (out of date source) and then i forgot to include the comment on the second try. > > Re XWikiDavITest could you follow our naming conventions: > * set up method is protected and called setUp() > * test methods start with "test" and not 'try" Ok, but since junit 4.0 has no restrictions on these names i was using what made the most sense. Anyway, i'll change them :) Thanks. - Asiri > > > Note: Haven't checked the rest. > > Thanks > -Vincent > > On Oct 6, 2008, at 9:08 AM, asiri (SVN) wrote: > > > Author: asiri > > Date: 2008-10-06 09:08:11 +0200 (Mon, 06 Oct 2008) > > New Revision: 13338 > > > > Added: > > sandbox/xwiki-webdav/references/OldXWikiDavResource.java.Reference > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/AbstractXWikiDavResource.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/domain/AbstractXWikiDavFile.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/views/AbstractXWikiDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > utils/XWikiDavUtils.java > > Removed: > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > mock/MockXWikiServletContext.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/XWikiDavResource.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/domain/XWikiDavFile.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/old/ > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/views/XWikiDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > utils/XWikiDavUtils.java > > Modified: > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > XWikiDavFilter.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > XWikiDavServlet.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > XWikiWebdavResponseImpl.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > mock/XWikiXMLRPCResponse.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/domain/XWikiDavAttachment.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/domain/XWikiDavPage.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/domain/XWikiDavTempFile.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/domain/XWikiDavWikiFile.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/views/XWikiHomeDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/views/XWikiOrphansDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/views/XWikiRootDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/views/XWikiWhatsnewDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/views/attachments/XWikiAttachmentsByFirstLettersDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/views/attachments/XWikiAttachmentsBySpaceNameDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/views/attachments/XWikiAttachmentsDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/views/spaces/XWikiPagesByFirstLettersDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/views/spaces/XWikiPagesBySpaceNameDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/views/spaces/XWikiPagesDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > utils/XWikiDavParams.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > utils/XWikiDavSession.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > utils/XWikiDavSessionProvider.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > utils/XWikiExportContext.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > utils/XWikiPropertyHandler.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > utils/XWikiResourceConfig.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > utils/XWikiResourceFactory.java > > sandbox/xwiki-webdav/src/test/java/com/xpn/xwiki/plugin/webdav/ > > tests/XWikiDavITest.java > > Log: > > > > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs >

2 1

[xwiki-devs] [Rendering] Link target in syntax 2.0 + wiki syntax in links
by Vincent Massol 06 Oct '08

06 Oct '08

Hi, In v1.0 we were using: [label>ref>_top] for a link with a target (rel). We need to decide how that translates in v2.0. A first approach would be to use: [[label>ref>>target=_top]] However there's a problem since we already have a way to define parameters: (% ... %) So this should probably be written instead as: (% rel=_top %)[[label>ref]] Since the (% %) notation allows passing any parameter I'm wondering why we need the parameters in the link syntax. I'll ask Mikhail from wikimodel why we need it but I don't see a valid reason. Note that (% %) parameters are currently not supported on inline blocks for now but the plan is to add it in wikimodel. Last I'm pretty convinced now that we should support wiki syntax in the label portion of a link, even if this is currently not supported in wikimodel and that means we won't be able to use wikimodel renderers (note that there's only 1 for now: the LaTex one but Doxia also has a LaTex renderer that we can use). Thanks -Vincent

1 0