June 2010 - xwiki-devs@xwiki.org

[xwiki-devs] [proposal] Remove registeruser.vm and RegisterAction.java, and fold register-inline.vm into register.vm
by Caleb James DeLisle 28 Jun '10

28 Jun '10

I would like to remove registeruser.vm because it was once used by the administration app and is now unused. I would also like to merge register-inline.vm into register.vm and remove c.x.x.web.RegisterAction and move it's functionality into register.vm so that everything will continue to work without XWiki.Registration. This will remove 60 lines in one class from xwiki-core and remove/merge away 2 templates making the code easier to understand for people who don't know the history of it. WDYT? Caleb

2 2

[xwiki-devs] Gadgets & Dashboard roadmap
by Anca Luca 25 Jun '10

25 Jun '10

Hi all, I am now restarting the work on the gadgets & dashboard project, documented here http://dev.xwiki.org/xwiki/bin/view/Design/GadgetIntegration (however documentation needs to be slightly revised). What is done already can be summarized as: * gadgets are implemented as macros and there is a script to import google gadgets as xwiki macros, * also, right now, gadgets are implemented as xwiki macros and can be used anywhere just like a regular wiki macro, and any wiki macro can be seen/used as a gadget so **there is no difference between macros and gadgets** . WDYT about this? should we keep it like that? (A) * there is a dashboard macro responsible with layouting a gadgets dashboard, which also provides specific editing features in inline mode (gadgets can be dragged around, toolboxes for gadgets in the top right) * there is a minimal macros directory, where one can see all the existing macros, descriptions, details about the parameters. * there is an PanelMacro macro, that displays an xwiki panel inside a document, which can be used to display xwiki panels as gadgets in a dashboard. The big picture of the roadmap is that we should: 1/ have a fully working dashboard, that is implement add gadget and edit gadget settings 2/ implement the main dashboard (Main.Dashboard) as a dashboard and fill it with the appropriate gadgets by default, and also to add a user specific dashboard ("My dashboard") where each user can configure his/her dashboard, and is available to a user from his / her profile or the user menu 3/ have a nice macros directory where a user can navigate through existing gadgets and add one to a dashboard 4/ have a "dashboard template", integrated with the document templates system to easily allow a user to create a dashboard 5/ also, since the xwiki panels can be seen as gadgets / macros, and can be implemented as such, somewhere in the future a refactoring should be made to integrate the 2 notions 6/ be able to publish the gadgets in the wiki such that other apps can integrate this in their content WDYT about the order above? (B) with the mention that points 5 and 6 could eventually be infinitely postponed. Also, after points 1 and 2 are implemented, the feature could be available with xwiki platform and integrated in XE by default. WDYT? (C) my +1 for (A), (B) and (C). Happy hacking, Anca

5 11

[xwiki-devs] [Proposal] Front End Architecture
by Vincent Massol 25 Jun '10

25 Jun '10

Hi, I've started thinking with Thomas about the new front end architecture and here's our current idea (without details) for the future: http://dev.xwiki.org/xwiki/bin/view/Design/FrontEndArchitecture If you have ideas about this please send them. This message is there so that we can share a common vision for the future. Thanks -Vincent

3 5

[xwiki-devs] [Proposal] Selective Export UI
by Ecaterina Valica 25 Jun '10

25 Jun '10

Hi, Please provide feedback for the Selective Export UI: http://incubator.myxwiki.org/xwiki/bin/view/Improvements/MultiExportProposal PS. The HTML+CSS is not final and it's tested only in Firefox. It will be improved if it gets positive feedback. If it doesn't display correctly, please use the IMG to visualize. Thanks, Caty

8 26

Re: [xwiki-devs] [xwiki-notifications] r29713 - platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/LDAP
by Vincent Massol 24 Jun '10

24 Jun '10

On Jun 24, 2010, at 5:47 PM, tmortagne (SVN) wrote: > Author: tmortagne > Date: 2010-06-24 17:47:52 +0200 (Thu, 24 Jun 2010) > New Revision: 29713 > > Modified: > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/LDAP/XWikiLDAPAuthServiceImpl.java > Log: > [misc] More useful debug log > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/LDAP/XWikiLDAPAuthServiceImpl.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/LDAP/XWikiLDAPAuthServiceImpl.java 2010-06-24 15:47:15 UTC (rev 29712) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/LDAP/XWikiLDAPAuthServiceImpl.java 2010-06-24 15:47:52 UTC (rev 29713) > @@ -417,7 +417,7 @@ > String passwordField = config.getLDAPParam("ldap_password_field", "userPassword", context); > if (!connector.checkPassword(ldapDn, password, passwordField)) { > LOG.debug("Password comparision failed, are you really sure you need validate_password ?" + > - " If you don't enable it it does not mean use credentiel are not validated." + > + " If you don't enable it it does not mean user credentiels are not validated." + typo: credentials :) -Vincent > " The goal of this property is to bypass standard LDAP bind."); > > throw new XWikiException(XWikiException.MODULE_XWIKI_USER, XWikiException.ERROR_XWIKI_USER_INIT, > >

2 1

Re: [xwiki-devs] [xwiki-notifications] r29712 - platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/LDAP
by Vincent Massol 24 Jun '10

24 Jun '10

On Jun 24, 2010, at 5:47 PM, tmortagne (SVN) wrote: > Author: tmortagne > Date: 2010-06-24 17:47:15 +0200 (Thu, 24 Jun 2010) > New Revision: 29712 > > Modified: > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/LDAP/XWikiLDAPAuthServiceImpl.java > Log: > [misc] More useful debug log > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/LDAP/XWikiLDAPAuthServiceImpl.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/LDAP/XWikiLDAPAuthServiceImpl.java 2010-06-24 15:43:19 UTC (rev 29711) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/LDAP/XWikiLDAPAuthServiceImpl.java 2010-06-24 15:47:15 UTC (rev 29712) > @@ -416,6 +416,10 @@ > if ("1".equals(config.getLDAPParam("ldap_validate_password", "0", context))) { > String passwordField = config.getLDAPParam("ldap_password_field", "userPassword", context); > if (!connector.checkPassword(ldapDn, password, passwordField)) { > + LOG.debug("Password comparision failed, are you really sure you need validate_password ?" + typo: comparison. -Vincent > + " If you don't enable it it does not mean use credentiel are not validated." + > + " The goal of this property is to bypass standard LDAP bind."); > + > throw new XWikiException(XWikiException.MODULE_XWIKI_USER, XWikiException.ERROR_XWIKI_USER_INIT, > "LDAP authentication failed:" + " could not validate the password: wrong password for " + ldapDn); > }

1 0

[xwiki-devs] [VOTE] [wysiwyg] Displaying the macro id and searching for it in the wysiwyg insert macro wizard
by Anca Luca 24 Jun '10

24 Jun '10

Hi all, I wanted to insert a macro in a page using the wysiwyg and I noticed that the macros filter (search box on top right) is not searching in the macro ids. For example, if I try to write "toc" I get no results. If I write "table" I get the "Table of contents" macro as result, since its name matches. I found this a bit annoying in my case, since i know the macroid (if I were to write it in the wiki syntax) and I cannot find the macro (still, I'm using the wysiwyg because I can never remember macro params). Also, I use the search function because it's far easier to filter it out then scroll for it in the list. WDYT about searching in the macro ids as well? (1) Also, the macro id is not displayed. This is good for simple users for which it has no meaning, but there can be a situation when 2 macros have the same name and same description (e.g. void description) and users would want to be able to differentiate one from the other in the macros list, even the simple users, I would say (for example because they always want to use one macro of the 2 and they can never tell one from the other only by name). WDYT about displaying the macro is as well? (2) of course pretty small and greyed out, like some advanced metadata. Marius said it's no big deal to implement neither, as long as we agree. My +1 for both (1) and (2). Thanks, Anca

9 9

[xwiki-devs] Invitation application icon
by Caleb James DeLisle 23 Jun '10

23 Jun '10

Hello, Since the invitation application is in XE, I was wondering if anyone wanted to try putting together an icon for the invitation section in the administration interface. Sorry about the short notice, if you're all busy that's fine, I can slap something together but it won't be nearly as good as some of the stuff I've seen (search icon). Any takers? Thanks, Caleb

8 16

Re: [xwiki-devs] [xwiki-notifications] r29668 - in enterprise/trunk/distribution-test/wysiwyg-tests/src/test/it/com/xpn/xwiki/it/selenium: . framework
by Vincent Massol 23 Jun '10

23 Jun '10

On Jun 23, 2010, at 12:40 PM, mflorea (SVN) wrote: > Author: mflorea > Date: 2010-06-23 12:40:12 +0200 (Wed, 23 Jun 2010) > New Revision: 29668 > > Modified: > enterprise/trunk/distribution-test/wysiwyg-tests/src/test/it/com/xpn/xwiki/it/selenium/EditInlineTest.java > enterprise/trunk/distribution-test/wysiwyg-tests/src/test/it/com/xpn/xwiki/it/selenium/framework/AbstractWysiwygTestCase.java > enterprise/trunk/distribution-test/wysiwyg-tests/src/test/it/com/xpn/xwiki/it/selenium/framework/WysiwygTestSetup.java > Log: > Fixed WYSIWYG Selenium tests due to changes in the class editor. [snip] > + > + /** > + * Clicks the add property button in the class editor. > + */ > + public void clickEditAddProperty() > + { > + getSelenium().click("//input[@value = 'Add']"); > + waitForCondition("(window.document.getElementsByClassName('xnotification-done')[0] != null " > + + "&& window.document.getElementsByClassName('xnotification-done')[0].innerHTML == 'Property added')"); > + } Shouldn't this go in the general framework in selenium-tests? Is there anything specific to the wysiwyg? Thanks -Vincent [snip]

2 1

[xwiki-devs] [Proposal] Package organization for ui-tests
by Vincent Massol 23 Jun '10

23 Jun '10

Hi devs, I'm proposing to have org.xwiki.it.ui.elements.<application name> where <application name> is the name of the application containing the page. WDYT? Thanks -Vincent

5 15