- xwiki-devs@xwiki.org - lists.xwiki.org

Re: [xwiki-devs] [xwiki-notifications] r13414 - in sandbox/xwiki-webdav/src/main: java/com/xpn/xwiki/plugin/webdav/resources java/com/xpn/xwiki/plugin/webdav/resources/views java/com/xpn/xwiki/plugin/webdav/utils resources resources/META-INF resource

by Asiri Rathnayake

Hi Sergiu, On Fri, Oct 10, 2008 at 6:20 AM, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote: > asiri (SVN) wrote: > > Modified: > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/XWikiDavResource.java > > =================================================================== > > --- > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/XWikiDavResource.java > 2008-10-08 11:28:58 UTC (rev 13413) > > +++ > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/XWikiDavResource.java > 2008-10-08 12:12:14 UTC (rev 13414) > > @@ -9,6 +9,8 @@ > > import org.apache.jackrabbit.webdav.DavResourceLocator; > > import org.apache.jackrabbit.webdav.DavSession; > > import org.apache.jackrabbit.webdav.lock.LockManager; > > +import org.xwiki.component.manager.ComponentManager; > > +import org.xwiki.component.phase.Composable; > > > > import com.xpn.xwiki.XWikiContext; > > > > @@ -18,9 +20,14 @@ > > * > > * @version $Id$ > > */ > > -public interface XWikiDavResource extends DavResource > > +public interface XWikiDavResource extends DavResource, Composable > > { > > /** > > + * This component's role, used when code needs to look it up. > > + */ > > + String ROLE = XWikiDavResource.class.getName(); > > + > > + /** > > * Initializes this resource with common attributes inherited from > the parent. > > * > > * @param parent Parent resource. > > @@ -72,6 +79,11 @@ > > XWikiContext getXwikiContext(); > > > > /** > > + * @return The {@link ComponentManager} used to lookup components. > > + */ > > + ComponentManager getComponentManager(); > > + > > + /** > > * @return The {@link LockManager} associated with this request > (global). > > */ > > LockManager getLockManager(); > > I don't like this... a component interface should not expose the > component manager, which is supposed to be used in implementations. Please: > - remove the Composable from the interface > - add it to AbstractXWikiDavResource, if needed > - move the getComponentManager there, too, if you must > > I'm not sure you need the component manager inside all DAV resources. As > I see in the code, you only need it in the Root view, so you should only > declare that XWikiRootDavView implements Composable. > > > FYI, the XWiki helper interfaces (Composable, LogEnabled, Initializable) > are supposed to be used by implementations, not by other interfaces. Working on it. Thanks. - Asiri > > -- > Sergiu Dumitriu > http://purl.org/net/sergiu/ > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs >

16 years, 11 months

1
0
0 0

[xwiki-devs] [xwiki-notifications] r13428 - in sandbox/xwiki-webdav/src: main/java/com/xpn/xwiki/plugin/webdav/resources/views main/java/com/xpn/xwiki/plugin/webdav/resources/views/pages test/java/com/xpn/xwiki/plugin/webdav/tests

by Asiri Rathnayake

---------- Forwarded message ---------- From: Asiri Rathnayake <asiri.rathnayake(a)gmail.com> Date: Thu, Oct 9, 2008 at 2:09 PM Subject: Re: [xwiki-notifications] r13428 - in sandbox/xwiki-webdav/src: main/java/com/xpn/xwiki/plugin/webdav/resources/views main/java/com/xpn/xwiki/plugin/webdav/resources/views/pages test/java/com/xpn/xwiki/plugin/webdav/tests To: XWiki Notifications <notifications(a)xwiki.org> Hi Vincent, Sergiu and all, I will try to explain the need to componetize xwiki-webdav. May be we shouldn't componetize xwiki-webdav after all ;) Following is the way we lookup for a base-view (a particular view of an xwiki-repository). Basically, when a request comes for a particular url, we take the corresponding segment of the url (nextToken here), append "-baseview" and lookup for a component with that ROLE_HINT. If found, we'll handover the job to that component. > + XWikiDavResource resource = null; > + try { > + resource = > + (XWikiDavResource) getComponentManager() > + .lookup(ROLE, nextToken + "-baseview"); > + resource.init(this, nextToken, "/" + nextToken); > + stack.push(resource); > + resource.decode(stack, tokens, next + 1); > + } catch (ComponentLookupException e) { > + throw new > DavException(DavServletResponse.SC_INTERNAL_SERVER_ERROR, e); > Bellow is where we list the set of possible views. for this i need to filter out only those views which has the "-baseview" id appended to their role hint. This is why i added the getRoleHint() method into the component interface. The use of this approach is, if someone need to add a new view, he simply have to extend the XWikiDavResource interface and have the ROLE_HINT ending like "-baseview", nothing else. The other approach is to manually load each base view using lookup("role", "role-hint") but in this case, the developer of the new view will have to change the RootView's code to load his view along with the rest of base views. > > + List<XWikiDavResource> viewsList = > getComponentManager().lookupList(ROLE); > + for (XWikiDavResource view : viewsList) { > + String componentHint = view.getRoleHint(); > + int dash = componentHint.lastIndexOf('-'); > + if (componentHint.endsWith("-baseview")) { > + String name = componentHint.substring(0, dash); > + view.init(this, name, "/" + name); > + children.add(view); > + } > + } > + } catch (ComponentLookupException e) { > + LOG.error("Unexpected Error : ", e); > May be this is a wrong approach. And yes, XWikiDavResource is not a business interface. But I think this increases the extensibility / flexibility of xwiki-webdav. To add a new view, (as i said before) extend XWikiDavResourve and end your ROLE_HINT with "-baseview". To remove an existing view, simply remove the "-baseview" part from your components.xml configuration file, that's it. I would like to know your thoughts. And i can revert these changes if necessary. Thanks. - Asiri

16 years, 11 months

2
2
0 0

[xwiki-devs] XWiki as ACEGI provider?

by Paul Libbrecht

Has anyone worked on XWiki serving the role of an ACEGI provider? (identity managed by XWiki but shared to other, in VMs, web-apps) thanks in advance paul

16 years, 11 months

1
0
0 0

Re: [xwiki-devs] [xwiki-notifications] r13414 - in sandbox/xwiki-webdav/src/main: java/com/xpn/xwiki/plugin/webdav/resources java/com/xpn/xwiki/plugin/webdav/resources/views java/com/xpn/xwiki/plugin/webdav/utils resources resources/META-INF resources/META-INF/plexus

by Sergiu Dumitriu

asiri (SVN) wrote: > Modified: sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/XWikiDavResource.java > =================================================================== > --- sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/XWikiDavResource.java 2008-10-08 11:28:58 UTC (rev 13413) > +++ sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/XWikiDavResource.java 2008-10-08 12:12:14 UTC (rev 13414) > @@ -9,6 +9,8 @@ > import org.apache.jackrabbit.webdav.DavResourceLocator; > import org.apache.jackrabbit.webdav.DavSession; > import org.apache.jackrabbit.webdav.lock.LockManager; > +import org.xwiki.component.manager.ComponentManager; > +import org.xwiki.component.phase.Composable; > > import com.xpn.xwiki.XWikiContext; > > @@ -18,9 +20,14 @@ > * > * @version $Id$ > */ > -public interface XWikiDavResource extends DavResource > +public interface XWikiDavResource extends DavResource, Composable > { > /** > + * This component's role, used when code needs to look it up. > + */ > + String ROLE = XWikiDavResource.class.getName(); > + > + /** > * Initializes this resource with common attributes inherited from the parent. > * > * @param parent Parent resource. > @@ -72,6 +79,11 @@ > XWikiContext getXwikiContext(); > > /** > + * @return The {@link ComponentManager} used to lookup components. > + */ > + ComponentManager getComponentManager(); > + > + /** > * @return The {@link LockManager} associated with this request (global). > */ > LockManager getLockManager(); I don't like this... a component interface should not expose the component manager, which is supposed to be used in implementations. Please: - remove the Composable from the interface - add it to AbstractXWikiDavResource, if needed - move the getComponentManager there, too, if you must I'm not sure you need the component manager inside all DAV resources. As I see in the code, you only need it in the Root view, so you should only declare that XWikiRootDavView implements Composable. FYI, the XWiki helper interfaces (Composable, LogEnabled, Initializable) are supposed to be used by implementations, not by other interfaces. -- Sergiu Dumitriu http://purl.org/net/sergiu/

16 years, 11 months

1
0
0 0

[xwiki-devs] [Idea] Providing a production level packaging solution with Jetty+Derby

by Vincent Massol

Hi, I was wondering today if we could provide a production quality XE packaging. Here's what would be my combo: * Jetty 6 or 7 * Latest Derby (aka JavaDB - which is included in JDK 1.6 BTW) in embedded mode See http://developers.sun.com/learning/javaoneonline/j1sessn.jsp?sessn=TS-45170… for performance stats * Java Service Wrapper See http://wrapper.tanukisoftware.org/doc/english/integrate.html The nice thing with the wrapper is that it can also monitor the JVM and restart it if hung or not responding, in addition to restarting the service when the machine is rebooted of course. I'm confident that we could offer a base packaging that would work well for relatively large usages of XE and that is still small and all- preconfigured. Basically I think we could replace our current combo of Jetty 5.x + HSQLDB with this new combo and still get the best of both worlds: * simple packaging * production level quality Whereas our current standalone packaging is not production ready and is just for getting started with XWiki. WDYT? Thanks -Vincent

16 years, 11 months

6
10
0 0

Re: [xwiki-devs] [xwiki-users] Loginsubmit

by Jean-Vincent Drean

On Wed, Sep 24, 2008 at 4:44 PM, Spinring <bi2607(a)fh-weihenstephan.de> wrote: > > Hello, > > I am trying to change the registration page, so that it redirects to the > pevious page after you have registered (like after you have logged in) > > I know, that login.vm and registerinline.vm are called in global.vm. My > first try was to add xredirect=$xwiki.getURLEncoded($logredir) to the > $regurl, but it did work. The register action takes into account the xredirect and do it immediatly. [1] Anyway you could add redirect=$xwiki.getURLEncoded($logredir) to the $regurl (global.vm) And apply this to registerinline.vm #elseif($reg) + #if($request.redirect) + $response.sendRedirect($request.redirect) + #end #set($xwname = "XWiki.${request.xwikiname}") #info("$msg.get('core.register.successful', [$xwiki.getUserName($xwname), $request.xwikiname])") #end Anyway I'm not sure that you'll get the expected behavior since the user will be correctly redirected .. without being logged in. To log the user automatically after sign up (+ redirection) you can apply the following patch to registerinline.vm (replace the one above) : #elseif($reg) + #if($request.redirect) + #set ($xredirect = $xwiki.getURL("XWiki.XWikiLogin", "loginsubmit", "j_username=$!request.xwikiname&j_password=$!request.register_password&xredirect=$!request.redirect")) + $response.sendRedirect($xredirect) + #end #set($xwname = "XWiki.${request.xwikiname}") #info("$msg.get('core.register.successful', [$xwiki.getUserName($xwname), $request.xwikiname])") #end 1) While we are at it, WWYT about adding this in XE 1.7, xwiki devs ? Is it bad to have the password sent over the network once again ? 2) In this case is there a reason to keep the sendRedirect call in RegisterAction (see [1]) ? Thanks, JV.

16 years, 11 months

2
1
0 0

Re: [xwiki-devs] [xwiki-notifications] r13383 - platform/core/trunk/xwiki-rendering/src/main/java/org/xwiki/rendering/parser

by Sergiu Dumitriu

tmortagne (SVN) wrote: > Author: tmortagne > Date: 2008-10-07 20:01:06 +0200 (Tue, 07 Oct 2008) > New Revision: 13383 > > Modified: > platform/core/trunk/xwiki-rendering/src/main/java/org/xwiki/rendering/parser/SyntaxType.java > Log: > XWIKI-2744: Can't add a Parser component for an unknown syntax > * add equals and hashCode methods > Since these methods do nothing but the default, why do we need to override them? The inherited methods should be enough, no? Anyway, I'd rather have a real implementation, since we can't be sure that everybody will create syntaxes using the factory method. -- Sergiu Dumitriu http://purl.org/net/sergiu/

16 years, 11 months

2
4
0 0

Re: [xwiki-devs] [xwiki-notifications] r13381 - platform/core/trunk/xwiki-rendering/src/main/java/org/xwiki/rendering/renderer

by Sergiu Dumitriu

tmortagne (SVN) wrote: > Author: tmortagne > Date: 2008-10-07 19:24:57 +0200 (Tue, 07 Oct 2008) > New Revision: 13381 > > Added: > platform/core/trunk/xwiki-rendering/src/main/java/org/xwiki/rendering/renderer/XHTMLWikiPrinter.java > Removed: > platform/core/trunk/xwiki-rendering/src/main/java/org/xwiki/rendering/renderer/AbstractXMLRenderer.java > Modified: > platform/core/trunk/xwiki-rendering/src/main/java/org/xwiki/rendering/renderer/XHTMLRenderer.java > Log: > * makes AbstractXMLRenderer a XHTMLWikiPrinter tool > I don't quite agree with this... The class is about XML printing, yet it is named XHTML. The methods are all about pure XML: printXMLStartElement, printXMLEndElement, createAttributes... And I'd like to keep it that way, if we don't need something HTML specific in it, just in case we'll need a different renderer (DocBook? the dead WML?). -- Sergiu Dumitriu http://purl.org/net/sergiu/

16 years, 11 months

2
1
0 0

[xwiki-devs] [Proposal] Rendering Link Syntax Take 2

by Vincent Massol

Hi devs, Sorry for the numerous mails on this topic. I've been struggling a bit in choosing the best solution with the caveats brought by wikimodel. So here's my latest proposal that replaces all previous ones on the link topic: 1) General link syntax: [[label>>reference]] or [[label||reference]] Note1: I've removed the need for parameters, see below. Note2: I'm suggesting double character separators since if we allow wiki syntax in link labels we need to easily differentiate the separator from a character typed in the label. Same reason why we doubled [[ ]], **, //, etc. characters. We could still use single characters (open question, I'm not sure about double chars) since people are not meant to write tons of text in link labels. OTOH it's consistent with our usage of double chars everywhere else (but it breaks current habits of the single char for links). 2) Links with parameters: (% param1=value1 paramN=valueN %)[[label>>reference]] 3) Links with wiki syntax for the label: [[**bold** link>>reference]] [[{{velocity}}...{{/velocity}}>>reference]] [[{{image:...}}>>reference]] <-- image link <OT> Note: For the image link we'll still need to decide if we want a macro for inserting an image or use wiki syntax but that's a topic that is now dissociated from the link topic: [[{{image:my.png}}>>reference]] or [[image:my.png>>reference </OT> Last for those wondering, I've found a solution to make this work with wikimodel and I've discovered Doxia supported wiki syntax in link labels, hence why I'm resurrecting the idea of having wiki syntax in links which is a way superior solution. Thanks -Vincent

16 years, 11 months

8
10
0 0

Re: [xwiki-devs] Things change

by Anca Paula Luca

Evelina Slatineanu wrote: > Hello all, > > > > This time I will "bother" you with a different type of mail, not the usual > bugs and fixes issues that come on dev mailing lists. > > > > First, let me say that so far it was nice to be part of the XWiki Team. And > many thanks to those who worked with me and helped me when I couldn't do it > by myself. Here, first in the list goes Sergiu Dumitriu, who was helped me > more than anyone else throughout the time. Also, thanks to Marta, Jerome, > JV, Laurent and the whole Iasi Team. I hope I'm not forgetting anyone. > > It has been a nice opportunity to work with you guys. > It's the same here, even if it might not have always felt like this. > > > However, time has come to say goodbye to all of you and continue my journey > with the next step in my professional life. I am going to pursue the goal of > becoming a good java programmer and even if XWiki could provide me with an > environment for doing this, I feel I need something more than that. There > are already plenty of intelligent and motivated people who do this very well > in XWiki and I would always be in their shadow. I feel I need to do this by > myself. > Since I think I know what it means and I'm enjoying it most of the seconds of everyday, I hope this decision is a step towards you finding the thing you like to do and which will make you happy (professionally speaking). I won't hide how disturbing it is to see people who have been here (in Iasi) from the very beginning leave. > > > So, I can only wish everyone good luck and success in whatever is that > everyone is doing. I am sure that only a bright and successful future awaits > XWiki. I can only wish it the best. > > > > Thank you very much for working with me. > +1 > > > Evelina Vrabie > > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs

16 years, 11 months

1
0
0 0

[xwiki-devs] [Rendering] XHTML placeholder for links

by Vincent Massol

Hi, Since recognizing links to be xwiki links is hard (not even always possible) we need to add some extra information when we render wiki syntax content into XHTML (for the WYSIWYG editor for ex) so that we can convert it back to wiki syntax. We have 2 solutions I can think of: 1) Using a span with a class value: <! [CDATA[Space.ExistingPage]]><a href="/xwiki/bin/view/Space/ ExistingPage">Space.ExistingPage</a> 2) Using a comment: <a href="/ xwiki/bin/view/Space/ExistingPage">Space.ExistingPage</a> Pros and cons: * 2) allows not generating visible content in XHTML so that if someone copy/paste our generated XHTML he won't have to add some CSS rule to prevent it from being visible. BTW I'm not even sure we can find a CSS rule to do that in solution 1) so we might need to have 2 spans as in: <![CDATA[Space.ExistingPage]]><a href="/xwiki/bin/view/Space/ ExistingPage">Space.ExistingPage</a> * 1) is harder to code since it requires using a SAX2 LexicalHandler, which btw is not supported by all XML parsers: "This is an optional extension handler for SAX2 to provide lexical information about an XML document, such as comments and CDATA section boundaries. XML readers are not required to recognize this handler, and it is not part of core-only SAX2 distributions." It also requires that I make some modifications to wikimodel since wikimodel currently ignores comments. Solution 2) seems slightly better to me but as it's quite more complex to implement I'd like to be sure that it's the best solution. WDYT? Thanks -Vincent

16 years, 11 months

3
8
0 0

[xwiki-devs] Things change

by Evelina Slatineanu

Hello all, This time I will "bother" you with a different type of mail, not the usual bugs and fixes issues that come on dev mailing lists. First, let me say that so far it was nice to be part of the XWiki Team. And many thanks to those who worked with me and helped me when I couldn't do it by myself. Here, first in the list goes Sergiu Dumitriu, who was helped me more than anyone else throughout the time. Also, thanks to Marta, Jerome, JV, Laurent and the whole Iasi Team. I hope I'm not forgetting anyone. It has been a nice opportunity to work with you guys. However, time has come to say goodbye to all of you and continue my journey with the next step in my professional life. I am going to pursue the goal of becoming a good java programmer and even if XWiki could provide me with an environment for doing this, I feel I need something more than that. There are already plenty of intelligent and motivated people who do this very well in XWiki and I would always be in their shadow. I feel I need to do this by myself. So, I can only wish everyone good luck and success in whatever is that everyone is doing. I am sure that only a bright and successful future awaits XWiki. I can only wish it the best. Thank you very much for working with me. Evelina Vrabie

16 years, 11 months

1
0
0 0

[xwiki-devs] [VOTE] New link syntax

by Vincent Massol

Hi, Following up on my previous email we have several pbs in our current syntax: * we need to forbid "=" in doc names * we need to forbid "|" and ">" in doc names Hence Sergiu and I have brainstormed and we propose the following: label>ref>>param1=value1 ... paramN=valueN and label|ref||param1=value1 ... paramN=valueN Here's my +1 Thanks -Vincent

16 years, 11 months

6
6
0 0

Re: [xwiki-devs] Fwd: [xwiki-notifications] r13338 - in sandbox/xwiki-webdav: references src/main/java/com/xpn/xwiki/plugin/webdav src/main/java/com/xpn/xwiki/plugin/webdav/mock src/main/java/com/xpn/xwiki/plugin/webdav/resources src/main/java/com/xp

by Asiri Rathnayake

On Mon, Oct 6, 2008 at 3:23 PM, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote: > Asiri Rathnayake wrote: > > On Mon, Oct 6, 2008 at 12:38 PM, SVN asiri > > <sandbox-notifications(a)xwiki.org>wrote: > > > >> Author: asiri > >> Date: 2008-10-06 09:08:11 +0200 (Mon, 06 Oct 2008) > >> New Revision: 13338 > >> > >> Added: > >> sandbox/xwiki-webdav/references/OldXWikiDavResource.java.Reference > >> > >> > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/AbstractXWikiDavResource.java > >> > >> > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/domain/AbstractXWikiDavFile.java > >> > >> > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/views/AbstractXWikiDavView.java > >> > >> > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/utils/XWikiDavUtils.java > >> Removed: > >> > >> > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/mock/MockXWikiServletContext.java > >> > >> > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/XWikiDavResource.java > >> > >> > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/domain/XWikiDavFile.java > >> > >> > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/old/ > >> > >> > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/views/XWikiDavView.java > >> > >> > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/utils/XWikiDavUtils.java > > > > > > Does this mean `svn mv` is not used ? I thought subclipse will take care > of > > it when i do refactorings :( > > No, this is how it appears in the file list. If you look in the detailed > diff, you can see: > > Copied: > sandbox/xwiki-webdav/references/OldXWikiDavResource.java.Reference (from > rev 13209, > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/old/OldXWikiDavResource.java) > > So it did a copy + delete = move > Yes, Thomas also mentioned this. Thanks. - Asiri > > -- > Sergiu Dumitriu > http://purl.org/net/sergiu/ > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs >

16 years, 11 months

1
0
0 0

[xwiki-devs] Fwd: [xwiki-notifications] r13338 - in sandbox/xwiki-webdav: references src/main/java/com/xpn/xwiki/plugin/webdav src/main/java/com/xpn/xwiki/plugin/webdav/mock src/main/java/com/xpn/xwiki/plugin/webdav/resources src/main/java/com/xpn/xwiki/plugin/we

by Asiri Rathnayake

---------- Forwarded message ---------- From: Asiri Rathnayake <asiri.rathnayake(a)gmail.com> Date: Mon, Oct 6, 2008 at 12:46 PM Subject: Re: [xwiki-notifications] r13338 - in sandbox/xwiki-webdav: references src/main/java/com/xpn/xwiki/plugin/webdav src/main/java/com/xpn/xwiki/plugin/webdav/mock src/main/java/com/xpn/xwiki/plugin/webdav/resources src/main/java/com/xpn/xwiki/plugin/web To: XWiki Developers <devs(a)xwiki.org> On Mon, Oct 6, 2008 at 12:38 PM, SVN asiri <sandbox-notifications(a)xwiki.org>wrote: > Author: asiri > Date: 2008-10-06 09:08:11 +0200 (Mon, 06 Oct 2008) > New Revision: 13338 > > Added: > sandbox/xwiki-webdav/references/OldXWikiDavResource.java.Reference > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/AbstractXWikiDavResource.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/domain/AbstractXWikiDavFile.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/views/AbstractXWikiDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/utils/XWikiDavUtils.java > Removed: > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/mock/MockXWikiServletContext.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/XWikiDavResource.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/domain/XWikiDavFile.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/old/ > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/resources/views/XWikiDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/utils/XWikiDavUtils.java Does this mean `svn mv` is not used ? I thought subclipse will take care of it when i do refactorings :(

16 years, 11 months

3
2
0 0

Re: [xwiki-devs] [xwiki-notifications] r13338 - in sandbox/xwiki-webdav: references src/main/java/com/xpn/xwiki/plugin/webdav src/main/java/com/xpn/xwiki/plugin/webdav/mock src/main/java/com/xpn/xwiki/plugin/webdav/resources src/main/java/com/xpn/xwi

by Asiri Rathnayake

On Mon, Oct 6, 2008 at 1:25 PM, Vincent Massol <vincent(a)massol.net> wrote: > Hi Asiri, > > There was no comment in the commit. We always need a comment to know > why you did this commit. > Sorry, this was a mistake. My first commit failed (out of date source) and then i forgot to include the comment on the second try. > > Re XWikiDavITest could you follow our naming conventions: > * set up method is protected and called setUp() > * test methods start with "test" and not 'try" Ok, but since junit 4.0 has no restrictions on these names i was using what made the most sense. Anyway, i'll change them :) Thanks. - Asiri > > > Note: Haven't checked the rest. > > Thanks > -Vincent > > On Oct 6, 2008, at 9:08 AM, asiri (SVN) wrote: > > > Author: asiri > > Date: 2008-10-06 09:08:11 +0200 (Mon, 06 Oct 2008) > > New Revision: 13338 > > > > Added: > > sandbox/xwiki-webdav/references/OldXWikiDavResource.java.Reference > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/AbstractXWikiDavResource.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/domain/AbstractXWikiDavFile.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/views/AbstractXWikiDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > utils/XWikiDavUtils.java > > Removed: > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > mock/MockXWikiServletContext.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/XWikiDavResource.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/domain/XWikiDavFile.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/old/ > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/views/XWikiDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > utils/XWikiDavUtils.java > > Modified: > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > XWikiDavFilter.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > XWikiDavServlet.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > XWikiWebdavResponseImpl.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > mock/XWikiXMLRPCResponse.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/domain/XWikiDavAttachment.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/domain/XWikiDavPage.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/domain/XWikiDavTempFile.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/domain/XWikiDavWikiFile.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/views/XWikiHomeDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/views/XWikiOrphansDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/views/XWikiRootDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/views/XWikiWhatsnewDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/views/attachments/XWikiAttachmentsByFirstLettersDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/views/attachments/XWikiAttachmentsBySpaceNameDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/views/attachments/XWikiAttachmentsDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/views/spaces/XWikiPagesByFirstLettersDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/views/spaces/XWikiPagesBySpaceNameDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > resources/views/spaces/XWikiPagesDavView.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > utils/XWikiDavParams.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > utils/XWikiDavSession.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > utils/XWikiDavSessionProvider.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > utils/XWikiExportContext.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > utils/XWikiPropertyHandler.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > utils/XWikiResourceConfig.java > > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > > utils/XWikiResourceFactory.java > > sandbox/xwiki-webdav/src/test/java/com/xpn/xwiki/plugin/webdav/ > > tests/XWikiDavITest.java > > Log: > > > > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs >

16 years, 11 months

2
1
0 0

[xwiki-devs] [Rendering] Link target in syntax 2.0 + wiki syntax in links

by Vincent Massol

Hi, In v1.0 we were using: [label>ref>_top] for a link with a target (rel). We need to decide how that translates in v2.0. A first approach would be to use: [[label>ref>>target=_top]] However there's a problem since we already have a way to define parameters: (% ... %) So this should probably be written instead as: (% rel=_top %)[[label>ref]] Since the (% %) notation allows passing any parameter I'm wondering why we need the parameters in the link syntax. I'll ask Mikhail from wikimodel why we need it but I don't see a valid reason. Note that (% %) parameters are currently not supported on inline blocks for now but the plan is to add it in wikimodel. Last I'm pretty convinced now that we should support wiki syntax in the label portion of a link, even if this is currently not supported in wikimodel and that means we won't be able to use wikimodel renderers (note that there's only 1 for now: the LaTex one but Doxia also has a LaTex renderer that we can use). Thanks -Vincent

16 years, 11 months

1
0
0 0

by Vincent Massol

Hi Asiri, There was no comment in the commit. We always need a comment to know why you did this commit. Re XWikiDavITest could you follow our naming conventions: * set up method is protected and called setUp() * test methods start with "test" and not 'try" Note: Haven't checked the rest. Thanks -Vincent On Oct 6, 2008, at 9:08 AM, asiri (SVN) wrote: > Author: asiri > Date: 2008-10-06 09:08:11 +0200 (Mon, 06 Oct 2008) > New Revision: 13338 > > Added: > sandbox/xwiki-webdav/references/OldXWikiDavResource.java.Reference > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > resources/AbstractXWikiDavResource.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > resources/domain/AbstractXWikiDavFile.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > resources/views/AbstractXWikiDavView.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > utils/XWikiDavUtils.java > Removed: > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > mock/MockXWikiServletContext.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > resources/XWikiDavResource.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > resources/domain/XWikiDavFile.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > resources/old/ > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > resources/views/XWikiDavView.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > utils/XWikiDavUtils.java > Modified: > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > XWikiDavFilter.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > XWikiDavServlet.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > XWikiWebdavResponseImpl.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > mock/XWikiXMLRPCResponse.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > resources/domain/XWikiDavAttachment.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > resources/domain/XWikiDavPage.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > resources/domain/XWikiDavTempFile.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > resources/domain/XWikiDavWikiFile.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > resources/views/XWikiHomeDavView.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > resources/views/XWikiOrphansDavView.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > resources/views/XWikiRootDavView.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > resources/views/XWikiWhatsnewDavView.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > resources/views/attachments/XWikiAttachmentsByFirstLettersDavView.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > resources/views/attachments/XWikiAttachmentsBySpaceNameDavView.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > resources/views/attachments/XWikiAttachmentsDavView.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > resources/views/spaces/XWikiPagesByFirstLettersDavView.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > resources/views/spaces/XWikiPagesBySpaceNameDavView.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > resources/views/spaces/XWikiPagesDavView.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > utils/XWikiDavParams.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > utils/XWikiDavSession.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > utils/XWikiDavSessionProvider.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > utils/XWikiExportContext.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > utils/XWikiPropertyHandler.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > utils/XWikiResourceConfig.java > sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ > utils/XWikiResourceFactory.java > sandbox/xwiki-webdav/src/test/java/com/xpn/xwiki/plugin/webdav/ > tests/XWikiDavITest.java > Log: >

16 years, 11 months

1
0
0 0

[xwiki-devs] [Rendering] Issue implementing new link format

by Vincent Massol

Hi devs, I'm working on implementing the new link format we've decided, i.e.: label>reference>param1=value1 ... paramN=valueN Note that there's a potential ambiguity with the following link: text>param=value Since this can be considered as either: * label = text, reference = "param=value" * reference = text, parameters = "param=value" Thus we have to decide that it's fordbidden to use "=" in document names or we need to find a different link format. I think forbidding "=" is fine. WDYT? Thanks -Vincent

16 years, 11 months

2
1
0 0

Re: [xwiki-devs] [xwiki-notifications] r13258 - platform/xwiki-applications/trunk

by Artem Melentyev

jvdrean (SVN) wrote: > Author: jvdrean > Date: 2008-10-03 15:13:00 +0200 (Fri, 03 Oct 2008) > New Revision: 13258 > > Modified: > platform/xwiki-applications/trunk/pom.xml > Log: > [release] Prepare XE 1.6 release. > > Modified: platform/xwiki-applications/trunk/pom.xml > =================================================================== > --- platform/xwiki-applications/trunk/pom.xml 2008-10-03 13:08:44 UTC (rev 13257) > +++ platform/xwiki-applications/trunk/pom.xml 2008-10-03 13:13:00 UTC (rev 13258) > @@ -27,7 +27,7 @@ > <parent> > <groupId>com.xpn.xwiki.platform</groupId> > <artifactId>xwiki</artifactId> > - <version>19-SNAPSHOT</version> > + <version>8</version> It should be 18, not 8. So released xwiki-application-15 is wrong. > <relativePath>../pom</relativePath> > </parent> > <groupId>com.xpn.xwiki.platform.applications</groupId> > @@ -46,14 +46,14 @@ > <extension> > <groupId>com.xpn.xwiki.platform.tools</groupId> > <artifactId>xwiki-xar-handlers</artifactId> > - <version>1.9-SNAPSHOT</version> > + <version>1.8</version> > </extension> > </extensions> > <plugins> > <plugin> > <groupId>com.xpn.xwiki.platform.tools</groupId> > <artifactId>xwiki-xar-plugin</artifactId> > - <version>1.12-SNAPSHOT</version> > + <version>1.11</version> > </plugin> > </plugins> > </build> > -- Artem Melentyev

16 years, 11 months

1
0
0 0

[xwiki-devs] [ANN] XWiki Enterprise 1.6 Released

by Jean-Vincent Drean

The XWiki development team is pleased to announce the release of XWiki Enterprise 1.6 final. Go grab it at http://www.xwiki.org/xwiki/bin/view/Main/Download This release spanned a bit more than 2 months starting on the 23rd of July 2008 and ending on the 3rd of October 2008. During that period we have implemented issues, fixed bugs and added new features such as: * New experimental support for other syntaxes (Confluence, JSPWiki, Creole, MediaWiki, TWiki and XHTML), including a new XWiki Syntax v2.0. * New experimental WYSIWYG editor (Work In Progress). * Improved page footer displaying : comments, attachments, history, various information * New "Password Renewal and Forgot Username" feature * Default account validation & confirmation emails provided in the wiki preferences * Rights Management interface now support adding groups into groups * Improvement of Query Manager which was introduced in 1.6M1. * New experimental XWiki Query Language called XWQL. * Added .xml extensions to all exported wiki pages (XAR) * The name of the main database in virtual wiki mode is not hardcoded to 'xwiki' anymore, and in virtual mode all database names can be prefixed with a configurable value New or improved translations: * german * french * czech * norwegian * ukrainian For more information see the Release notes at: http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXWikiEnterprise16 Thanks -The XWiki dev team

16 years, 11 months

1
0
0 0

[xwiki-devs] Review of XWS 1.1 Roadmap vs. what has been done

by Jerome Velociter

Hello Devs, Below is a review of what has been done in XWS 1.1 vs. what was initially planned in the Roadmap : * Improving usability : Adding tooltips, advices, etc. for a smoother user experience -> Not really done, but we re-worked all the french and english messages. * UI Refactorings : especially global administration, dashboard, and All my spaces UIs. -> Not done (partly done in 1.2 M1) * Quality insurance : keep adding more unit tests and integration tests. (Yes, I will try to definitely fix the two tests that fails on our continuum server ;)) -> Done, for the Integration Tests part. Tests has been fixed, and many tests were added. * Invitation management (see http://jira.xwiki.org/jira/browse/XWS-79) -> Done * Improvement of users and groups management (see http://jira.xwiki.org/jira/browse/XWS-7) -> Done * RSS on space and dashboard stories -> Not done * More options exposed in the global administration -> Done Conclusion ---------- We did about half what we initially planned, and we did not respect initially dates (the final release has been delayed by more than 1 month and a half). This due to both a lack of resources (I have been taken by other projects), and a too greedy roadmap. We will take this into account when proposing the future roadmaps. Regards, Jerome.

16 years, 11 months

1
0
0 0

[xwiki-devs] strange behaviour when modifying an DBStringList prop in an object from a velocity script

by Pascal Voitot

hello guys, I do the following: - I have a class with a DBStringList property "mylist" - In a velocity script, I do: #set($obj = $doc.getObject("MyClass", $mynb) #set($mylist = $obj.get("mylist")) #set($mylist = "${mylist}|${mynewlistitem}") #set($ret = $obj.set("mylist", $mylist)) #set($ret = $doc.save()) - I run this script and I can see in the DB that "mynewlistitem" was added as listitem to "mylist" but the item doesn't appear in the object editor for property "mylist" in my document. - Moreover, I get some rendering exception in contentview.vm when I try to access this object in other velocity scripts. - When I create the link using the Object editor, then everything works well but I don't see anything different in the DB from the previous state. - I have tried the same with: #set($obj = $doc.getObject("MyClass", $mynb) #set($mylist = $obj.getProperty("mylist").getValue()) #set($ret = $mylist.add("${mynewlistitem}")) #set($ret = $doc.save()) same result... It seems the Object property is saved but it is not taken into account by the object in the document. Do you any clue for me? regards Pascal

16 years, 11 months

3
8
0 0

[xwiki-devs] question about programming rights and SQL extraction...

by Pascal Voitot

hello, I would like to write some scripts which do some more complex SQL extraction requests using for example $xwiki.search(sql)... no modif of the DB, just extraction for presentation... I would prefer not to be forced to code a new Java module just for this... But this function is protected by programming rights... So I must give programming rights to allow people to view this page... I find a bit disturbing because programming rights have a "sensitive" meaning in my head... What's your point of view about this? What's the lightest, cleverest and fairest way to allow this? Any advice? :) regards Pascal

16 years, 11 months

6
7
0 0

[xwiki-devs] Postponing creation of 1.6 branch till Thursday?

by Vincent Massol

Hi devs, Since we're in a rush for the final 1.6 release I'm proposing to postpone creating the 1.6 branch to this Thursday. This means that trunks stays 1.6 final and thus only bug fixes should be done. Thus this means postponing any 1.7 change to after Thursday. Is that ok with everyone? Thanks -Vincent

16 years, 11 months

7
8
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

xwiki-devs