Re: [xwiki-devs] [proposal] IRCbot log formatting improvement

On 11/29/2010 11:05 AM, Sorin Burjan wrote: > Hello devs, > > I have a proposal to make about the IRCbot Application. As you know, the > bot logs the channel and saves > the content in order to make it viewable from the xwiki designated page. > > I would like to propose two things : > > Proposal 1 > In order to make archive logs more easily readable and more easy to > follow, I would like to change the > way the logs are saved. > I would like to use a standard format (also used my all major IRC > clients like Pidgin, IRC, XChat, irssi, etc). > Because date/time will have always the same length, aligning it and > putting it at the begginning of the line, makes the text more easy to > follow. > So, the proposals are : > > Version 1 (the one we have now) > > user1 - (20:07): You can comment if you have edit right > JohnDoe - (20:07): ok, thx for the answer > IreallyLoveXWiki - (20:07): I’m off for today, bye > XWikiNormalUser left at 20:07 (Quit: Leaving. > EnterpriseUser joined #xwiki at 20:38 > EnterpriseUser left at 20:38 (Client Quit > sburjan is now known as sburjan1 (~sburjan(a)this.is.areally.long.address.ro > > Note that the ")" doesn't appear on logs, so this should be fixed any way. > > > Version 2 > > [11:05] XWikiNormalUser : How can I edit a page? > [11:05] IreallyLoveXWiki : You have to be logged in order to do that > [11:05] JohnDoe : I love Open Source ! > [22:55] EnterpriseUser : joined #xwiki at 20:38 > [22:56] EnterpriseUser : left at 20:38 (Client Quit > [14:22] sburjan is now known as sburjan1 > (~sburjan(a)this.is.areally.long.address.ro)

+1 for V2, but: - no space before : - no : on system lines (join, quit, nick change...) I'd rather keep them, since it might be a reference for identifying suspicious activity. The privacy gain from not logging the IP is minimal, since that information is already available live on IRC.