- xwiki-devs@xwiki.org - lists.xwiki.org

[xwiki-devs] [proposal] Deprecate the practice of using $xcontext.blah to call $xcontext.getBlah() in the templates.

by Caleb James DeLisle

When I was looking for places where hasProgrammingRights is called, I found calls to c.x.x.api.Context.get() in the templates. I discovered that there is code in the templates which implicitly calls $xcontext.get('something') by calling $xcontext.something where there is no function Context.getSomething(). Since this is so easy and there is no way to know that anything is wrong since Context.get() returns null if you don't have PR, I am proposing that we do away with the practice of implicitly referring to functions in $context entirely. I used the following command to find implicit context references and I have filled in the mappings which I determined manually user@debo8:~/wrk/xwiki.clone/xwiki/platform/web/trunk/standard/src/main/webapp/templates$ find ./ -name '*.vm' -exec grep '$xcontext\.[a-zA-Z0-9]*[^a-zA-Z0-9$]' {} \; | sed -n -e 's/\($xcontext\.[a-zA-Z0-9]*[^a-zA-Z0-9(]$/\n\1\n/p' | grep '^$xcontext' | sort $xcontext.action= $xcontext.action= $xcontext.action= $xcontext.action $xcontext.action $xcontext.action $xcontext.action $xcontext.action $xcontext.action $xcontext.action $xcontext.action, $xcontext.action, $xcontext.action, $xcontext.action, $xcontext.action, $xcontext.action, $xcontext.action, $xcontext.action, $xcontext.action, $xcontext.action, $xcontext.action, $xcontext.action, $xcontext.action. $xcontext.action) ^-- maps to Context.getAction() $xcontext.database $xcontext.database) $xcontext.database) $xcontext.database) $xcontext.database) $xcontext.database) $xcontext.database) ^-- maps to Context.getDatabase() $xcontext.language" $xcontext.language" $xcontext.language" ^-- maps to Context.getLanguage() $xcontext.tocData ^-- this line is broken entirely, it maps to context.get('tocData') but the line is: #set ($xcontext.tocData = $tocData) which is simply invalid and I can't even figure out what it would do. $xcontext.user $xcontext.user $xcontext.user $xcontext.user $xcontext.user $xcontext.user $xcontext.user $xcontext.user $xcontext.user $xcontext.user $xcontext.user $xcontext.user, $xcontext.user, $xcontext.user, $xcontext.user, $xcontext.user, $xcontext.user, $xcontext.user, $xcontext.user, $xcontext.user, $xcontext.user, $xcontext.user, $xcontext.user, $xcontext.user, $xcontext.user. $xcontext.user. $xcontext.user. $xcontext.user" $xcontext.user" $xcontext.user) $xcontext.user) $xcontext.user) $xcontext.user) $xcontext.user) ^-- Maps to $xcontext.getUser() $xcontext.wiki, $xcontext.wiki, $xcontext.wiki, ^-- Maps to $xcontext.get('wiki') I think this is the source of most of the messages and since it appears to be relatively new code, it convinces me that the $context.blah pattern is simply unsafe and should be abandoned at least for the xcontext object. I would like to fix these now and establish a best practice of avoiding the use of these in the future for $xcontext. I myself avoid this pattern entirely but I do not have a compelling reason to propose it as a best practice except for $context. WDYT? Caleb

14 years, 7 months

3
3
0 0

[xwiki-devs] build failing on rendering module

by Vincent Massol

Hi Thomas, FYI the build is failing on the xwiki10 parser syntax tests (links3.test): junit.framework.ComparisonFailure: null Expected :[[http:~~/~~/reference>>reference]] [[*not bold*>>reference]] Actual :[[http:~~/~~/reference>>reference]] [[**not bold**>>reference]] at org.xwiki.rendering.scaffolding.RenderingTestCase.runTestInternal(RenderingTestCase.java:159) at org.xwiki.rendering.scaffolding.RenderingTestCase.runTest(RenderingTestCase.java:106) at org.jmock.core.VerifyingTestCase.runBare(VerifyingTestCase.java:39) at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24) Seems like non bold is transformed into bold now. Any ide? Thanks -Vincent

14 years, 7 months

2
9
0 0

[xwiki-devs] [UX][Proposal] Add a list with keyboard shortcuts

by Ecaterina Moraru (Valica)

Hi, I've made a proposal on how to integrate keyboard shortcuts into UI http://incubator.myxwiki.org/xwiki/bin/view/Improvements/KeyboardShortcuts Thanks, Caty

14 years, 7 months

6
7
0 0

by Vincent Massol

Hi Sergiu, On Feb 26, 2011, at 12:00 AM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2011-02-26 00:00:44 +0100 (Sat, 26 Feb 2011) > New Revision: 34960 > > Added: > platform/core/trunk/xwiki-eventstream/ > platform/core/trunk/xwiki-eventstream/pom.xml > platform/core/trunk/xwiki-eventstream/src/ > platform/core/trunk/xwiki-eventstream/src/main/ > platform/core/trunk/xwiki-eventstream/src/main/java/ > platform/core/trunk/xwiki-eventstream/src/main/java/org/ > platform/core/trunk/xwiki-eventstream/src/main/java/org/xwiki/ > platform/core/trunk/xwiki-eventstream/src/main/java/org/xwiki/eventstream/ > platform/core/trunk/xwiki-eventstream/src/main/java/org/xwiki/eventstream/Event.java > platform/core/trunk/xwiki-eventstream/src/main/java/org/xwiki/eventstream/EventFactory.java > platform/core/trunk/xwiki-eventstream/src/main/java/org/xwiki/eventstream/EventGroup.java > platform/core/trunk/xwiki-eventstream/src/main/java/org/xwiki/eventstream/EventStream.java > platform/core/trunk/xwiki-eventstream/src/main/java/org/xwiki/eventstream/internal/ > platform/core/trunk/xwiki-eventstream/src/main/java/org/xwiki/eventstream/internal/DefaultEvent.java > platform/core/trunk/xwiki-eventstream/src/main/java/org/xwiki/eventstream/internal/DefaultEventFactory.java > platform/core/trunk/xwiki-eventstream/src/main/resources/ > platform/core/trunk/xwiki-eventstream/src/main/resources/META-INF/ > platform/core/trunk/xwiki-eventstream/src/main/resources/META-INF/components.txt > platform/core/trunk/xwiki-eventstream/src/test/ > platform/core/trunk/xwiki-eventstream/src/test/java/ > platform/core/trunk/xwiki-eventstream/src/test/java/org/ > platform/core/trunk/xwiki-eventstream/src/test/java/org/xwiki/ > platform/core/trunk/xwiki-eventstream/src/test/java/org/xwiki/eventstream/ > platform/core/trunk/xwiki-eventstream/src/test/java/org/xwiki/eventstream/EventAndFactoryTest.java > platform/core/trunk/xwiki-eventstream/src/test/java/org/xwiki/eventstream/EventGroupTest.java > Modified: > platform/core/trunk/pom.xml > Log: > XWIKI-6047: New EventStream component That was new to me. Was this discussed (it's possible I missed a mail on the list)? From the jira it seems this module is meant to be a replacement of the ActivityStream plugin, right? If so what's the strategy to replace it (timing, backward compat, etc)? There seems to be a notion of Event similar to that of the Observation module. Maybe Event is not the right term here seems the javadoc says "A recorded event that happened at some point in the wiki". Maybe something like ArchiveEvent, PastEvent, SavedEvent, etc And maybe these events should extend the Observation Event and add new fields (date, etc)? Or maybe it's better to not extend but have a field that is the original Observation Event object? Or maybe not and it's better to have no relationship to the Observation module to be independent? In any case this should probably be discussed/explained. Maybe the Obervation module should be split in one more submodule called xwiki-observation-store or xwiki-observation-history? It seems to me this could be about historizing the events sent by the Observation managed. To be honest, I haven't really thought about it enough (would need to load the code in my IDE). I find that this commit happens quite late in the release cycle (3 days before end of milestone) and would have warranted some earlier discussion. It's ok, I'm not asking to rollback, just saying that something this important from an architecture point of view should rather be done earlier and discussed. Thanks -Vincent

14 years, 7 months

2
3
0 0

[xwiki-devs] XWiki Enterprise and XWiki Enterprise Manager 2.5.2, 2.6.2 and 2.7.1 Released

by Raluca Stavro

The XWiki development team is pleased to announce the release of XWiki Enterprise and XWiki Enterprise Manager 2.5.2, 2.6.2 and 2.7.1. These are the last releases on the 2.5 and 2.6 branches, but the 2.7 branch will continue to be maintained. Go grab 2.7.1 at http://www.xwiki.org/xwiki/bin/view/Main/Download , or browse http://forge.ow2.org/project/showfiles.php?group_id=170 for the other releases. The highlights of these releases are: * Cannot login with Safari 5 without selecting "remember me" * Better support for custom display of object properties * Fixed several PDF export and WYSIWYG issues * Support for Forgot Username & Password in private wikis * Fixed some bugs with XAR Import * New {{cache}} macro For more information, see the full release notes: XWiki Enterprise: * http://www.xwiki.org/xwiki/bin/view/ReleaseNotes/ReleaseNotesXWikiEnterpris… * http://www.xwiki.org/xwiki/bin/view/ReleaseNotes/ReleaseNotesXWikiEnterpris… * http://www.xwiki.org/xwiki/bin/view/ReleaseNotes/ReleaseNotesXWikiEnterpris… XWiki Enterprise Manager: * http://www.xwiki.org/xwiki/bin/view/ReleaseNotes/ReleaseNotesXEM252 * http://www.xwiki.org/xwiki/bin/view/ReleaseNotes/ReleaseNotesXEM262 * http://www.xwiki.org/xwiki/bin/view/ReleaseNotes/ReleaseNotesXEM271 Thanks -The XWiki dev team

14 years, 7 months

1
0
0 0

Re: [xwiki-devs] [xwiki-notifications] r34925 - in platform: core/trunk/xwiki-core/src/main/resources web/trunk/standard/src/main/webapp/resources/uicomponents/search web/trunk/standard/src/main/webapp/templates xwiki-applications/trunk/search/src/main/resources/

by Jerome Velociter

On Fri, Feb 25, 2011 at 4:27 AM, jvelociter <platform-notifications(a)xwiki.org> wrote: > Author: jvelociter > Date: 2011-02-25 04:27:58 +0100 (Fri, 25 Feb 2011) > New Revision: 34925 > > Added: > platform/web/trunk/standard/src/main/webapp/resources/uicomponents/search/searchSuggest.js > platform/xwiki-applications/trunk/search/src/main/resources/XWiki/SearchSuggestConfig.xml > platform/xwiki-applications/trunk/search/src/main/resources/XWiki/SearchSuggestConfigSheet.xml > platform/xwiki-applications/trunk/search/src/main/resources/XWiki/SearchSuggestLuceneService.xml > platform/xwiki-applications/trunk/search/src/main/resources/XWiki/SearchSuggestSourceClass.xml > Modified: > platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties > platform/web/trunk/standard/src/main/webapp/templates/javascript.vm > Log: > XASEARCH-22 Support for multi-sources live suggestions when typing in the search box > XWIKI-6044 Resources for the search suggest feature of search application > > First iteration on the "search suggest" feature. > > It's not completely finished, though it's functional. It's not activated by default yet, you can go and activate it in the administration in order to test. > > Remains to do : > > * Fully internationalize > * Improve suggestion display (show both document title AND document full name) > * Shortcut to open suggestions pages in edit mode (replace jump to page functionnality) > * Other tuning * Search on both name and title for the document name source * Fix the attachment name source that does not seem to work * Filter on blacklisted spaces for non-advanced users Jerome. > > Feedback very welcome. > > > > Modified: platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties 2011-02-25 02:31:38 UTC (rev 34924) > +++ platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties 2011-02-25 03:27:58 UTC (rev 34925) > @@ -2980,6 +2980,7 @@ > dashboard.actions.add.failed=Failed to add gadget: > > # Search application resources > +admin.searchsuggest=Search Suggest > admin.search=Search > admin.search.description=Choose the default search engine or configure the Lucene index. > search.admin.title=Search > > Added: platform/web/trunk/standard/src/main/webapp/resources/uicomponents/search/searchSuggest.js > =================================================================== > --- platform/web/trunk/standard/src/main/webapp/resources/uicomponents/search/searchSuggest.js (rev 0) > +++ platform/web/trunk/standard/src/main/webapp/resources/uicomponents/search/searchSuggest.js 2011-02-25 03:27:58 UTC (rev 34925) > @@ -0,0 +1,213 @@ > +var XWiki = (function (XWiki) { > + > + /** > + * The search suggest hooks itself on the search input and provide live results as the user types. > + * Search form validation is not affected (user can still type enter and get to the regular search result page) > + */ > + XWiki.SearchSuggest = Class.create({ > + > + /** > + * Constructor. Prepares a light modal container on the same model as the modalPopup > + * and registers event listerners. > + */ > + initialize: function(searchInput, sources){ > + > + this.sources = sources; > + > + this.realSearchInput = $(searchInput); > + > + this.modalContainer = new Element('div', {'class': 'xdialog-modal-container'}).hide(); > + var screen = new Element('div', {'class': 'xdialog-screen'}).setStyle({ > + opacity : 0.35, > + backgroundColor : "#000000" > + }); > + this.modalContainer.insert(screen); > + this.modalContainer.insert(new Element('div', {'id' : 'searchSuggest'})); > + document.body.appendChild(this.modalContainer); > + > + document.observe("xwiki:suggest:clearSuggestions", this.onClearSuggestions.bindAsEventListener(this)); > + document.observe("xwiki:suggest:containerCreated", this.onSuggestContainerCreated.bindAsEventListener(this)); > + document.observe("xwiki:suggest:containerPrepared", this.onSuggestContainerPrepared.bindAsEventListener(this)); > + document.observe("xwiki:suggest:selected", this.onSuggestionSelected.bindAsEventListener(this)); > + > + this.createSuggest(); > + }, > + > + /** > + * Callback triggered when the original suggest clears its suggestions. > + */ > + onClearSuggestions: function(event){ > + if (event.memo.suggest == this.suggest) { > + this.modalContainer.hide(); > + this.devirtualizeSearchInput(); > + } > + }, > + > + /** > + * Callback triggered when the original suggest has prepared its results container. > + */ > + onSuggestContainerPrepared: function(event){ > + if (event.memo.suggest == this.suggest && event.memo.suggest == this.suggest) { > + this.modalContainer.show(); > + this.virtualizeSearchInput(); > + } > + }, > + > + /** > + * Callback triggered when a suggestion is selected. > + * Submits the form or go to a selected page according to selection. > + */ > + onSuggestionSelected: function(event) { > + if (event.memo.suggest = this.suggest) { > + event.stop(); > + this.onClearSuggestions(event); > + this.virtualSearchInput.value = event.memo.value; > + if (!event.memo.id) { > + // Submit form > + this.realSearchInput.up('form').submit(); > + } > + else { > + // Go to page > + window.location = event.memo.id;; > + } > + } > + }, > + > + /** > + * Creates the underlaying suggest widget. > + */ > + createSuggest: function() { > + // Create dummy suggestion node to hold the "Show all results" option > + var valueNode = new Element('div') > + .insert(new Element('span', {'class':'suggestId'})) > + .insert(new Element('span', {'class':'suggestValue'})) > + .insert(new Element('span', {'class':'suggestInfo'})) > + var allResultsNode = new XWiki.widgets.XList([ > + new XWiki.widgets.XListItem( "Show all results...", { > + 'containerClasses': 'suggestItem', > + 'classes': 'showAllResuts', > + 'eventCallbackScope' : this, > + 'noHighlight' : true, > + 'value' : valueNode > + } ), > + ], > + { > + 'classes' : 'suggestList', > + 'eventListeners' : { > + 'click': function(event){ > + this.devirtualizeSearchInput(); > + this.realSearchInput.up('form').submit(); > + }, > + 'mouseover':function(event){ > + this.suggest.clearHighlight(); > + this.suggest.iHighlighted = event.element(); > + event.element().addClassName('xhighlight'); > + } > + } > + }); > + this.suggest = new XWiki.widgets.Suggest( this.realSearchInput, { > + parentContainer: $('searchSuggest'), > + className: 'ajaxsuggest searchSuggest', > + fadeOnClear:false, > + align: "right", > + minchars: 3, > + sources : this.sources, > + insertBeforeSuggestions : new Element("div", {'class' : 'results'}).update(allResultsNode.getElement()) > + }); > + }, > + > + /** > + * Add a "virtual" search input on top of the original one, so that it appears on top of the modal container. > + */ > + virtualizeSearchInput: function(){ > + if (!this.isVirtual) { > + this.isVirtual = true; > + this.virtualSearchInput.value = this.realSearchInput.value; > + this.virtualSearchInput.show(); > + this.virtualSearchInput.focus(); > + this.suggest.setInputField(this.virtualSearchInput); > + } > + }, > + > + /** > + * Hides the virtual search input > + */ > + devirtualizeSearchInput: function(){ > + this.realSearchInput.value = this.virtualSearchInput.value; > + this.realSearchInput.focus(); > + this.suggest.setInputField(this.realSearchInput); > + this.isVirtual = false; > + }, > + > + /** > + * Callback triggered when the original suggest has created its results container. > + */ > + onSuggestContainerCreated: function(event){ > + if (event.memo.suggest == this.suggest) { > + var container = event.memo.container; > + this.modalContainer.show(); > + this.virtualSearchInput = this.realSearchInput.clone(); > + this.virtualSearchInput.id = this.realSearchInput.id + '-virtual'; > + this.virtualSearchInput.clonePosition(container, { setWidth : false }); > + $('searchSuggest').insert(this.virtualSearchInput); > + this.virtualSearchInput.setStyle({position : 'absolute'}); > + this.virtualSearchInput.setStyle({ > + top : (this.virtualSearchInput.cumulativeOffset().top - this.realSearchInput.getHeight()) + 'px', > + position:'absolute' > + }); > + > + if (Prototype.Browser.IE || Prototype.Browser.WebKit) { > + this.virtualSearchInput.observe("keydown", this.onKeyPress.bindAsEventListener(this)); > + } else { > + this.virtualSearchInput.observe("keypress", this.onKeyPress.bindAsEventListener(this)); > + } > + } > + }, > + > + /** > + * Callback triggered when a key has been typed on the virtual input. > + */ > + onKeyPress: function(event){ > + var key = event.keyCode; > + switch(key) { > + // Ignore special keys, which are treated in onKeyPress > + case Event.KEY_RETURN: > + if (!this.suggest.hasActiveSelection()) { > + this.devirtualizeSearchInput(); > + event.stop(); > + this.realSearchInput.up('form').submit(); > + } > + default: > + } > + } > + > + }); > + > + return XWiki; > + > +})(XWiki); > + > +document.observe("dom:loaded", function(){ > + > + var sources = [ > + ## Iterate over the sources defined in the configuration document, and create a source array to be passed to the > + ## search suggest contructor. > + #set($sourceDocument = $xwiki.getDocument("XWiki.SearchSuggestConfig")) > + #foreach($source in $sourceDocument.getObjects('XWiki.SearchSuggestSourceClass')) > + #if($source.getProperty('activated').value == 1) > + { > + name : "$escapetool.javascript($source.display('name','view'))", > + varname : 'input', > + script : "#evaluate($source.getProperty('url').value)&query=$source.getProperty('query').value&nb=$source.getProperty('resultsNumber').value&", > + icon : "#evaluate($source.getProperty('icon').value)", > + highlight: #if($source.getProperty('highlight').value == 1) true #else false #end > + }, > + #end > + #end > + null // Don't handle last coma. This is going to be compated anyway. > + ].compact() > + > + new XWiki.SearchSuggest($('headerglobalsearchinput'), sources); > + > +}); > + > > Modified: platform/web/trunk/standard/src/main/webapp/templates/javascript.vm > =================================================================== > --- platform/web/trunk/standard/src/main/webapp/templates/javascript.vm 2011-02-25 02:31:38 UTC (rev 34924) > +++ platform/web/trunk/standard/src/main/webapp/templates/javascript.vm 2011-02-25 03:27:58 UTC (rev 34925) > @@ -21,6 +21,27 @@ > $xwiki.ssfx.use('uicomponents/widgets/notification.css', true) > $xwiki.jsfx.use('uicomponents/widgets/list/xlist.js') > $xwiki.jsfx.use('uicomponents/suggest/suggest.js') > +#if($xwiki.exists('XWiki.SearchSuggestConfig')) > + ## Hook to request the search suggest script if search suggest configuration is present. > + ## We can't just have it as a always-use SSX yet since we compute a hash to be sure to refresh > + ## the file when the configuration changes. > + ## Ideally, this code should be located in a interface extension, in the search application. > + #set($searchSuggestConfigDocument = $xwiki.getDocument('XWiki.SearchSuggestConfig')) > + #set($searchSuggestConfigObject = $searchSuggestConfigDocument.getObject('XWiki.SearchSuggestConfig')) > + #if($searchSuggestConfigObject.getProperty('activated').value == 1) > + #set($searchSuggestConfigHash = '') > + #foreach($source in $searchSuggestConfigDocument.getObjects('XWiki.SearchSuggestSourceClass')) > + #if($source.getProperty('activated').value == 1) > + #set($sourceId = "${source.get('name')}:${source.get('url')}:${source.get('highlight')}:${source.get('icon')}}") > + #set($searchSuggestConfigHash = "${searchSuggestConfigHash}|${sourceId}") > + #end > + #end > + $xwiki.jsfx.use('uicomponents/search/searchSuggest.js', { > + 'forceSkinAction' : true, > + 'h' : $searchSuggestConfigHash.hashCode() > + }) > + #end > +#end > <script type="text/javascript" src="$xwiki.getSkinFile("js/prototype/prototype.js")"></script> > <script type="text/javascript" src="$xwiki.getSkinFile("js/xwiki/xwiki.js", true)"></script> > <script type="text/javascript"> > > Added: platform/xwiki-applications/trunk/search/src/main/resources/XWiki/SearchSuggestConfig.xml > =================================================================== > --- platform/xwiki-applications/trunk/search/src/main/resources/XWiki/SearchSuggestConfig.xml (rev 0) > +++ platform/xwiki-applications/trunk/search/src/main/resources/XWiki/SearchSuggestConfig.xml 2011-02-25 03:27:58 UTC (rev 34925) > @@ -0,0 +1,960 @@ > +<?xml version="1.0" encoding="UTF-8"?> > +<xwikidoc> > +<web>XWiki</web> > +<name>SearchSuggestConfig</name> > +<language></language> > +<defaultLanguage>en</defaultLanguage> > +<translation>0</translation> > +<parent>XWiki.SearchCode</parent> > +<creator>XWiki.Admin</creator> > +<author>XWiki.Admin</author> > +<customClass></customClass> > +<contentAuthor>XWiki.Admin</contentAuthor> > +<creationDate>1280310893000</creationDate> > +<date>1298601876000</date> > +<contentUpdateDate>1298601876000</contentUpdateDate> > +<version>1.1</version> > +<title>Search Suggest Configuration</title> > +<template></template> > +<defaultTemplate></defaultTemplate> > +<validationScript></validationScript> > +<comment></comment> > +<minorEdit>false</minorEdit> > +<syntaxId>xwiki/2.0</syntaxId> > +<hidden>false</hidden> > +<class> > +<name>XWiki.SearchSuggestConfig</name> > +<customClass></customClass> > +<customMapping></customMapping> > +<defaultViewSheet></defaultViewSheet> > +<defaultEditSheet></defaultEditSheet> > +<defaultWeb></defaultWeb> > +<nameField></nameField> > +<validationScript></validationScript> > +<activated> > +<disabled>0</disabled> > +<displayFormType>select</displayFormType> > +<name>activated</name> > +<number>1</number> > +<prettyName>activated</prettyName> > +<unmodifiable>0</unmodifiable> > +<classType>com.xpn.xwiki.objects.classes.BooleanClass</classType> > +</activated> > +</class> > +<object> > +<class> > +<name>XWiki.ConfigurableClass</name> > +<customClass></customClass> > +<customMapping></customMapping> > +<defaultViewSheet></defaultViewSheet> > +<defaultEditSheet></defaultEditSheet> > +<defaultWeb></defaultWeb> > +<nameField></nameField> > +<validationScript></validationScript> > +<codeToExecute> > +<disabled>0</disabled> > +<editor>---</editor> > +<name>codeToExecute</name> > +<number>7</number> > +<picker>0</picker> > +<prettyName>codeToExecute</prettyName> > +<rows>5</rows> > +<size>40</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.TextAreaClass</classType> > +</codeToExecute> > +<configurationClass> > +<disabled>0</disabled> > +<name>configurationClass</name> > +<number>3</number> > +<picker>0</picker> > +<prettyName>configurationClass</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</configurationClass> > +<configureGlobally> > +<defaultValue></defaultValue> > +<disabled>0</disabled> > +<displayFormType>checkbox</displayFormType> > +<displayType></displayType> > +<name>configureGlobally</name> > +<number>4</number> > +<prettyName>configureGlobally</prettyName> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.BooleanClass</classType> > +</configureGlobally> > +<displayInSection> > +<disabled>0</disabled> > +<name>displayInSection</name> > +<number>1</number> > +<picker>0</picker> > +<prettyName>displayInSection</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</displayInSection> > +<heading> > +<disabled>0</disabled> > +<name>heading</name> > +<number>2</number> > +<picker>0</picker> > +<prettyName>heading</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</heading> > +<iconAttachment> > +<disabled>0</disabled> > +<name>iconAttachment</name> > +<number>8</number> > +<picker>0</picker> > +<prettyName>iconAttachment</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</iconAttachment> > +<linkPrefix> > +<disabled>0</disabled> > +<name>linkPrefix</name> > +<number>5</number> > +<picker>0</picker> > +<prettyName>linkPrefix</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</linkPrefix> > +<propertiesToShow> > +<cache>0</cache> > +<disabled>0</disabled> > +<displayType>input</displayType> > +<multiSelect>1</multiSelect> > +<name>propertiesToShow</name> > +<number>6</number> > +<picker>0</picker> > +<prettyName>propertiesToShow</prettyName> > +<relationalStorage>1</relationalStorage> > +<separator> </separator> > +<separators> ,|</separators> > +<size>20</size> > +<sort>none</sort> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<values></values> > +<classType>com.xpn.xwiki.objects.classes.StaticListClass</classType> > +</propertiesToShow> > +</class> > +<name>XWiki.SearchSuggestConfig</name> > +<number>0</number> > +<className>XWiki.ConfigurableClass</className> > +<guid>322238f5-c742-43ed-81e0-ba169fc05653</guid> > +<property> > +<codeToExecute>[[Configure the suggest sources>>XWiki.SearchSuggestConfig]]</codeToExecute> > +</property> > +<property> > +<configurationClass>XWiki.SearchSuggestConfig</configurationClass> > +</property> > +<property> > +<configureGlobally>1</configureGlobally> > +</property> > +<property> > +<displayInSection>searchSuggest</displayInSection> > +</property> > +<property> > +<heading>Search Suggest</heading> > +</property> > +<property> > +<iconAttachment></iconAttachment> > +</property> > +<property> > +<linkPrefix></linkPrefix> > +</property> > +<property> > +<propertiesToShow> > +<value>activated</value> > +</propertiesToShow> > +</property> > +</object> > +<object> > +<class> > +<name>XWiki.SearchSuggestConfig</name> > +<customClass></customClass> > +<customMapping></customMapping> > +<defaultViewSheet></defaultViewSheet> > +<defaultEditSheet></defaultEditSheet> > +<defaultWeb></defaultWeb> > +<nameField></nameField> > +<validationScript></validationScript> > +<activated> > +<disabled>0</disabled> > +<displayFormType>select</displayFormType> > +<name>activated</name> > +<number>1</number> > +<prettyName>activated</prettyName> > +<unmodifiable>0</unmodifiable> > +<classType>com.xpn.xwiki.objects.classes.BooleanClass</classType> > +</activated> > +</class> > +<name>XWiki.SearchSuggestConfig</name> > +<number>0</number> > +<className>XWiki.SearchSuggestConfig</className> > +<guid>5faef1df-77ac-4bb3-9dda-8d38447b94e1</guid> > +<property> > +<activated>0</activated> > +</property> > +</object> > +<object> > +<class> > +<name>XWiki.SearchSuggestSourceClass</name> > +<customClass></customClass> > +<customMapping></customMapping> > +<defaultViewSheet></defaultViewSheet> > +<defaultEditSheet></defaultEditSheet> > +<defaultWeb></defaultWeb> > +<nameField></nameField> > +<validationScript></validationScript> > +<activated> > +<defaultValue></defaultValue> > +<disabled>0</disabled> > +<displayFormType>checkbox</displayFormType> > +<displayType></displayType> > +<name>activated</name> > +<number>7</number> > +<prettyName>activated</prettyName> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.BooleanClass</classType> > +</activated> > +<highlight> > +<defaultValue></defaultValue> > +<disabled>0</disabled> > +<displayFormType>checkbox</displayFormType> > +<displayType></displayType> > +<name>highlight</name> > +<number>6</number> > +<prettyName>highlight</prettyName> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.BooleanClass</classType> > +</highlight> > +<icon> > +<disabled>0</disabled> > +<name>icon</name> > +<number>5</number> > +<picker>0</picker> > +<prettyName>icon</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</icon> > +<name> > +<disabled>0</disabled> > +<name>name</name> > +<number>1</number> > +<picker>0</picker> > +<prettyName>name</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</name> > +<query> > +<disabled>0</disabled> > +<name>query</name> > +<number>3</number> > +<picker>0</picker> > +<prettyName>query</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</query> > +<resultsNumber> > +<disabled>0</disabled> > +<name>resultsNumber</name> > +<number>4</number> > +<picker>0</picker> > +<prettyName>resultsNumber</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</resultsNumber> > +<url> > +<disabled>0</disabled> > +<name>url</name> > +<number>2</number> > +<picker>0</picker> > +<prettyName>url</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</url> > +</class> > +<name>XWiki.SearchSuggestConfig</name> > +<number>0</number> > +<className>XWiki.SearchSuggestSourceClass</className> > +<guid>291d9c6d-b9b1-41b2-8aab-5f1cedba5ded</guid> > +<property> > +<activated>1</activated> > +</property> > +<property> > +<highlight>1</highlight> > +</property> > +<property> > +<icon>$xwiki.getSkinFile('icons/silk/page_white_text.gif')</icon> > +</property> > +<property> > +<name>Document name</name> > +</property> > +<property> > +<query>name:__INPUT__*</query> > +</property> > +<property> > +<resultsNumber>3</resultsNumber> > +</property> > +<property> > +<url>$xwiki.getURL('XWiki.SearchSuggestLuceneService', 'get', 'outputSyntax=plain')</url> > +</property> > +</object> > +<object> > +<class> > +<name>XWiki.SearchSuggestSourceClass</name> > +<customClass></customClass> > +<customMapping></customMapping> > +<defaultViewSheet></defaultViewSheet> > +<defaultEditSheet></defaultEditSheet> > +<defaultWeb></defaultWeb> > +<nameField></nameField> > +<validationScript></validationScript> > +<activated> > +<defaultValue></defaultValue> > +<disabled>0</disabled> > +<displayFormType>checkbox</displayFormType> > +<displayType></displayType> > +<name>activated</name> > +<number>7</number> > +<prettyName>activated</prettyName> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.BooleanClass</classType> > +</activated> > +<highlight> > +<defaultValue></defaultValue> > +<disabled>0</disabled> > +<displayFormType>checkbox</displayFormType> > +<displayType></displayType> > +<name>highlight</name> > +<number>6</number> > +<prettyName>highlight</prettyName> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.BooleanClass</classType> > +</highlight> > +<icon> > +<disabled>0</disabled> > +<name>icon</name> > +<number>5</number> > +<picker>0</picker> > +<prettyName>icon</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</icon> > +<name> > +<disabled>0</disabled> > +<name>name</name> > +<number>1</number> > +<picker>0</picker> > +<prettyName>name</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</name> > +<query> > +<disabled>0</disabled> > +<name>query</name> > +<number>3</number> > +<picker>0</picker> > +<prettyName>query</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</query> > +<resultsNumber> > +<disabled>0</disabled> > +<name>resultsNumber</name> > +<number>4</number> > +<picker>0</picker> > +<prettyName>resultsNumber</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</resultsNumber> > +<url> > +<disabled>0</disabled> > +<name>url</name> > +<number>2</number> > +<picker>0</picker> > +<prettyName>url</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</url> > +</class> > +<name>XWiki.SearchSuggestConfig</name> > +<number>1</number> > +<className>XWiki.SearchSuggestSourceClass</className> > +<guid>9c2ba119-f8b2-4652-b5ff-9d446cbdb9aa</guid> > +<property> > +<activated>1</activated> > +</property> > +<property> > +<highlight>0</highlight> > +</property> > +<property> > +<icon>$xwiki.getSkinFile('icons/silk/page_white_text.gif')</icon> > +</property> > +<property> > +<name>Document content</name> > +</property> > +<property> > +<query>__INPUT__*</query> > +</property> > +<property> > +<resultsNumber>3</resultsNumber> > +</property> > +<property> > +<url>$xwiki.getURL('XWiki.SearchSuggestLuceneService', 'get', 'outputSyntax=plain')</url> > +</property> > +</object> > +<object> > +<class> > +<name>XWiki.SearchSuggestSourceClass</name> > +<customClass></customClass> > +<customMapping></customMapping> > +<defaultViewSheet></defaultViewSheet> > +<defaultEditSheet></defaultEditSheet> > +<defaultWeb></defaultWeb> > +<nameField></nameField> > +<validationScript></validationScript> > +<activated> > +<defaultValue></defaultValue> > +<disabled>0</disabled> > +<displayFormType>checkbox</displayFormType> > +<displayType></displayType> > +<name>activated</name> > +<number>7</number> > +<prettyName>activated</prettyName> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.BooleanClass</classType> > +</activated> > +<highlight> > +<defaultValue></defaultValue> > +<disabled>0</disabled> > +<displayFormType>checkbox</displayFormType> > +<displayType></displayType> > +<name>highlight</name> > +<number>6</number> > +<prettyName>highlight</prettyName> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.BooleanClass</classType> > +</highlight> > +<icon> > +<disabled>0</disabled> > +<name>icon</name> > +<number>5</number> > +<picker>0</picker> > +<prettyName>icon</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</icon> > +<name> > +<disabled>0</disabled> > +<name>name</name> > +<number>1</number> > +<picker>0</picker> > +<prettyName>name</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</name> > +<query> > +<disabled>0</disabled> > +<name>query</name> > +<number>3</number> > +<picker>0</picker> > +<prettyName>query</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</query> > +<resultsNumber> > +<disabled>0</disabled> > +<name>resultsNumber</name> > +<number>4</number> > +<picker>0</picker> > +<prettyName>resultsNumber</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</resultsNumber> > +<url> > +<disabled>0</disabled> > +<name>url</name> > +<number>2</number> > +<picker>0</picker> > +<prettyName>url</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</url> > +</class> > +<name>XWiki.SearchSuggestConfig</name> > +<number>2</number> > +<className>XWiki.SearchSuggestSourceClass</className> > +<guid>40387571-e03f-4ffd-abda-61cf2a2b2b55</guid> > +<property> > +<activated>1</activated> > +</property> > +<property> > +<highlight>1</highlight> > +</property> > +<property> > +<icon>$xwiki.getSkinFile('icons/silk/attach.gif')</icon> > +</property> > +<property> > +<name>Attachment name</name> > +</property> > +<property> > +<query>name:__INPUT__* AND type:attachment</query> > +</property> > +<property> > +<resultsNumber>3</resultsNumber> > +</property> > +<property> > +<url>$xwiki.getURL('XWiki.SearchSuggestLuceneService', 'get', 'outputSyntax=plain')</url> > +</property> > +</object> > +<object> > +<class> > +<name>XWiki.SearchSuggestSourceClass</name> > +<customClass></customClass> > +<customMapping></customMapping> > +<defaultViewSheet></defaultViewSheet> > +<defaultEditSheet></defaultEditSheet> > +<defaultWeb></defaultWeb> > +<nameField></nameField> > +<validationScript></validationScript> > +<activated> > +<defaultValue></defaultValue> > +<disabled>0</disabled> > +<displayFormType>checkbox</displayFormType> > +<displayType></displayType> > +<name>activated</name> > +<number>7</number> > +<prettyName>activated</prettyName> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.BooleanClass</classType> > +</activated> > +<highlight> > +<defaultValue></defaultValue> > +<disabled>0</disabled> > +<displayFormType>checkbox</displayFormType> > +<displayType></displayType> > +<name>highlight</name> > +<number>6</number> > +<prettyName>highlight</prettyName> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.BooleanClass</classType> > +</highlight> > +<icon> > +<disabled>0</disabled> > +<name>icon</name> > +<number>5</number> > +<picker>0</picker> > +<prettyName>icon</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</icon> > +<name> > +<disabled>0</disabled> > +<name>name</name> > +<number>1</number> > +<picker>0</picker> > +<prettyName>name</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</name> > +<query> > +<disabled>0</disabled> > +<name>query</name> > +<number>3</number> > +<picker>0</picker> > +<prettyName>query</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</query> > +<resultsNumber> > +<disabled>0</disabled> > +<name>resultsNumber</name> > +<number>4</number> > +<picker>0</picker> > +<prettyName>resultsNumber</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</resultsNumber> > +<url> > +<disabled>0</disabled> > +<name>url</name> > +<number>2</number> > +<picker>0</picker> > +<prettyName>url</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</url> > +</class> > +<name>XWiki.SearchSuggestConfig</name> > +<number>3</number> > +<className>XWiki.SearchSuggestSourceClass</className> > +<guid>dbc05205-6333-4889-8613-83686f9288f6</guid> > +<property> > +<activated>1</activated> > +</property> > +<property> > +<highlight>0</highlight> > +</property> > +<property> > +<icon>$xwiki.getSkinFile('icons/silk/attach.gif')</icon> > +</property> > +<property> > +<name>Attachment content</name> > +</property> > +<property> > +<query>__INPUT__*AND type:attachment</query> > +</property> > +<property> > +<resultsNumber>3</resultsNumber> > +</property> > +<property> > +<url>$xwiki.getURL('XWiki.SearchSuggestLuceneService', 'get', 'outputSyntax=plain')</url> > +</property> > +</object> > +<object> > +<class> > +<name>XWiki.SearchSuggestSourceClass</name> > +<customClass></customClass> > +<customMapping></customMapping> > +<defaultViewSheet></defaultViewSheet> > +<defaultEditSheet></defaultEditSheet> > +<defaultWeb></defaultWeb> > +<nameField></nameField> > +<validationScript></validationScript> > +<activated> > +<defaultValue></defaultValue> > +<disabled>0</disabled> > +<displayFormType>checkbox</displayFormType> > +<displayType></displayType> > +<name>activated</name> > +<number>7</number> > +<prettyName>activated</prettyName> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.BooleanClass</classType> > +</activated> > +<highlight> > +<defaultValue></defaultValue> > +<disabled>0</disabled> > +<displayFormType>checkbox</displayFormType> > +<displayType></displayType> > +<name>highlight</name> > +<number>6</number> > +<prettyName>highlight</prettyName> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.BooleanClass</classType> > +</highlight> > +<icon> > +<disabled>0</disabled> > +<name>icon</name> > +<number>5</number> > +<picker>0</picker> > +<prettyName>icon</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</icon> > +<name> > +<disabled>0</disabled> > +<name>name</name> > +<number>1</number> > +<picker>0</picker> > +<prettyName>name</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</name> > +<query> > +<disabled>0</disabled> > +<name>query</name> > +<number>3</number> > +<picker>0</picker> > +<prettyName>query</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</query> > +<resultsNumber> > +<disabled>0</disabled> > +<name>resultsNumber</name> > +<number>4</number> > +<picker>0</picker> > +<prettyName>resultsNumber</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</resultsNumber> > +<url> > +<disabled>0</disabled> > +<name>url</name> > +<number>2</number> > +<picker>0</picker> > +<prettyName>url</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</url> > +</class> > +<name>XWiki.SearchSuggestConfig</name> > +<number>4</number> > +<className>XWiki.SearchSuggestSourceClass</className> > +<guid>1e881b2d-031c-42ba-bd2d-867fa72c7dab</guid> > +<property> > +<activated>0</activated> > +</property> > +<property> > +<highlight>0</highlight> > +</property> > +<property> > +<icon>$xwiki.getSkinFile('icons/silk/page_white_picture.gif')</icon> > +</property> > +<property> > +<name>Blog Posts</name> > +</property> > +<property> > +<query>__INPUT__* AND object:Blog.BlogPostClass</query> > +</property> > +<property> > +<resultsNumber>3</resultsNumber> > +</property> > +<property> > +<url>$xwiki.getURL('XWiki.SearchSuggestLuceneService', 'get', 'outputSyntax=plain')</url> > +</property> > +</object> > +<object> > +<class> > +<name>XWiki.SearchSuggestSourceClass</name> > +<customClass></customClass> > +<customMapping></customMapping> > +<defaultViewSheet></defaultViewSheet> > +<defaultEditSheet></defaultEditSheet> > +<defaultWeb></defaultWeb> > +<nameField></nameField> > +<validationScript></validationScript> > +<activated> > +<defaultValue></defaultValue> > +<disabled>0</disabled> > +<displayFormType>checkbox</displayFormType> > +<displayType></displayType> > +<name>activated</name> > +<number>7</number> > +<prettyName>activated</prettyName> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.BooleanClass</classType> > +</activated> > +<highlight> > +<defaultValue></defaultValue> > +<disabled>0</disabled> > +<displayFormType>checkbox</displayFormType> > +<displayType></displayType> > +<name>highlight</name> > +<number>6</number> > +<prettyName>highlight</prettyName> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.BooleanClass</classType> > +</highlight> > +<icon> > +<disabled>0</disabled> > +<name>icon</name> > +<number>5</number> > +<picker>0</picker> > +<prettyName>icon</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</icon> > +<name> > +<disabled>0</disabled> > +<name>name</name> > +<number>1</number> > +<picker>0</picker> > +<prettyName>name</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</name> > +<query> > +<disabled>0</disabled> > +<name>query</name> > +<number>3</number> > +<picker>0</picker> > +<prettyName>query</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</query> > +<resultsNumber> > +<disabled>0</disabled> > +<name>resultsNumber</name> > +<number>4</number> > +<picker>0</picker> > +<prettyName>resultsNumber</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</resultsNumber> > +<url> > +<disabled>0</disabled> > +<name>url</name> > +<number>2</number> > +<picker>0</picker> > +<prettyName>url</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</url> > +</class> > +<name>XWiki.SearchSuggestConfig</name> > +<number>5</number> > +<className>XWiki.SearchSuggestSourceClass</className> > +<guid>8cc7466d-c6be-4118-bb06-8f287a3bad92</guid> > +<property> > +<activated>1</activated> > +</property> > +<property> > +<highlight>0</highlight> > +</property> > +<property> > +<icon>$xwiki.getSkinFile('icons/silk/user.gif')</icon> > +</property> > +<property> > +<name>Users</name> > +</property> > +<property> > +<query>__INPUT__* AND object:XWiki.XWikiUsers</query> > +</property> > +<property> > +<resultsNumber>3</resultsNumber> > +</property> > +<property> > +<url>$xwiki.getURL('XWiki.SearchSuggestLuceneService', 'get', 'outputSyntax=plain')</url> > +</property> > +</object> > +<content>{{include document="XWiki.SearchSuggestConfigSheet" /}} > +</content></xwikidoc> > > Added: platform/xwiki-applications/trunk/search/src/main/resources/XWiki/SearchSuggestConfigSheet.xml > =================================================================== > --- platform/xwiki-applications/trunk/search/src/main/resources/XWiki/SearchSuggestConfigSheet.xml (rev 0) > +++ platform/xwiki-applications/trunk/search/src/main/resources/XWiki/SearchSuggestConfigSheet.xml 2011-02-25 03:27:58 UTC (rev 34925) > @@ -0,0 +1,73 @@ > +<?xml version="1.0" encoding="UTF-8"?> > +<xwikidoc> > +<web>XWiki</web> > +<name>SearchSuggestConfigSheet</name> > +<language></language> > +<defaultLanguage>en</defaultLanguage> > +<translation>0</translation> > +<parent>XWiki.SearchSuggestConfig</parent> > +<creator>XWiki.Admin</creator> > +<author>XWiki.Admin</author> > +<customClass></customClass> > +<contentAuthor>XWiki.Admin</contentAuthor> > +<creationDate>1280310959000</creationDate> > +<date>1297439261000</date> > +<contentUpdateDate>1297439261000</contentUpdateDate> > +<version>1.1</version> > +<title></title> > +<template></template> > +<defaultTemplate></defaultTemplate> > +<validationScript></validationScript> > +<comment></comment> > +<minorEdit>false</minorEdit> > +<syntaxId>xwiki/2.0</syntaxId> > +<hidden>false</hidden> > +<object> > +<class> > +<name>XWiki.SheetClass</name> > +<customClass></customClass> > +<customMapping></customMapping> > +<defaultViewSheet></defaultViewSheet> > +<defaultEditSheet></defaultEditSheet> > +<defaultWeb></defaultWeb> > +<nameField></nameField> > +<validationScript></validationScript> > +<defaultEditMode> > +<disabled>0</disabled> > +<name>defaultEditMode</name> > +<number>1</number> > +<prettyName>Default Edit Mode</prettyName> > +<size>15</size> > +<unmodifiable>0</unmodifiable> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</defaultEditMode> > +</class> > +<name>XWiki.SearchSuggestConfigSheet</name> > +<number>0</number> > +<className>XWiki.SheetClass</className> > +<guid>933b2bea-9566-4352-83ed-0cd9b4fba530</guid> > +<property> > +<defaultEditMode>inline</defaultEditMode> > +</property> > +</object> > +<content>{{velocity}} > +=Search Suggest= > + > +#set($searchSuggestConfigClass = $xwiki.getDocument("XWiki.SearchSuggestConfig").xWikiClass) > +#set($searchSuggestSourceClassname = "XWiki.SearchSuggestSourceClass") > +#set($configObj = $doc.getObject($doc.fullName)) > +**$searchSuggestConfigClass.get("activated").prettyName**: $doc.display("activated") > + > +== Sources == > + > +A suggest source is a URL that takes 3 parameters: query, input and nb. The query parameter must contain a ~_~_INPUT~_~_ placeholder. This URL must process the query with the given user input and return the result in the XML format expected by the suggest component. > + > +|= Name |= URL |= Query |= Results Number |= Icon |= Highlight matches |= Activated > +#foreach($srcObj in $doc.getObjects($searchSuggestSourceClassname))| $doc.display('name', $srcObj) | $doc.display('url', $srcObj) | #if($context.action == 'view') {{{ #end $doc.display('query', $srcObj) #if($context.action == 'view') }}} #end | $doc.display('resultsNumber', $srcObj) | $doc.display('icon', $srcObj) | $doc.display('highlight', $srcObj) | $doc.display('activated', $srcObj) > +#end > + > + > +#if($context.display == 'edit') > +[[Add a new source>>$doc.getExternalURL('objectadd', "classname=${searchSuggestSourceClassname}&xredirect=${doc.getURL('inline')}")]] > +#end > +{{/velocity}}</content></xwikidoc> > > Added: platform/xwiki-applications/trunk/search/src/main/resources/XWiki/SearchSuggestLuceneService.xml > =================================================================== > --- platform/xwiki-applications/trunk/search/src/main/resources/XWiki/SearchSuggestLuceneService.xml (rev 0) > +++ platform/xwiki-applications/trunk/search/src/main/resources/XWiki/SearchSuggestLuceneService.xml 2011-02-25 03:27:58 UTC (rev 34925) > @@ -0,0 +1,62 @@ > +<?xml version="1.0" encoding="UTF-8"?> > +<xwikidoc> > +<web>XWiki</web> > +<name>SearchSuggestLuceneService</name> > +<language></language> > +<defaultLanguage>en</defaultLanguage> > +<translation>0</translation> > +<parent>XWiki.SearchSuggestConfig</parent> > +<creator>XWiki.Admin</creator> > +<author>XWiki.Admin</author> > +<customClass></customClass> > +<contentAuthor>XWiki.Admin</contentAuthor> > +<creationDate>1280310630000</creationDate> > +<date>1280318001000</date> > +<contentUpdateDate>1280318001000</contentUpdateDate> > +<version>1.1</version> > +<title></title> > +<template></template> > +<defaultTemplate></defaultTemplate> > +<validationScript></validationScript> > +<comment></comment> > +<minorEdit>false</minorEdit> > +<syntaxId>xwiki/2.0</syntaxId> > +<hidden>false</hidden> > +<content>{{velocity}} > +#set($query = "$!request.query") > +#set($input = "$!request.input") > +#set($nb = "$!request.nb") > +#if($nb != '') > + #set($nb = $util.parseInt($nb) + 1) > +#else > + #set($nb = 6) > +#end > +#if($query != '' && $input != '') > + #set($query = $query.replaceAll('__INPUT__', $input)) > + #set($discard = $response.setContentType("text/xml")) > + <?xml version="1.0" encoding="UTF-8"?> > + #set($rawresults = $xwiki.lucene.getSearchResults($query, $util.null)) > + #set($results = $rawresults.getResults("0", "$nb")) > + <results> > + #foreach($item in $results) > + #set($itemfullname = "${item.wiki}:${item.space}.${item.name}") > + #set($itemdoc = $xwiki.getDocument($itemfullname)) > + #if($item.type == "attachment") > + #set($name = $item.filename) > + #set($url = $itemdoc.getAttachmentURL($name)) > + #else > + #set($name = $itemdoc.getDisplayTitle()) > + #set($url = $itemdoc.getURL()) > + #end > + <rs id="$url" info="$name">$name</rs> > + #end > + </results> > +#else > +{{info}} > +This service allows to retrieve search results for the suggest UI component. > +Examples: > +* [[$doc.getExternalURL('get', 'outputSyntax=plain&query=__INPUT__*&input=test')]] > +{{/info}} > +#end > +{{/velocity}} > +</content></xwikidoc> > > Added: platform/xwiki-applications/trunk/search/src/main/resources/XWiki/SearchSuggestSourceClass.xml > =================================================================== > --- platform/xwiki-applications/trunk/search/src/main/resources/XWiki/SearchSuggestSourceClass.xml (rev 0) > +++ platform/xwiki-applications/trunk/search/src/main/resources/XWiki/SearchSuggestSourceClass.xml 2011-02-25 03:27:58 UTC (rev 34925) > @@ -0,0 +1,122 @@ > +<?xml version="1.0" encoding="UTF-8"?> > +<xwikidoc> > +<web>XWiki</web> > +<name>SearchSuggestSourceClass</name> > +<language></language> > +<defaultLanguage></defaultLanguage> > +<translation>0</translation> > +<parent>XWiki.SearchSuggestConfig</parent> > +<creator>XWiki.Admin</creator> > +<author>XWiki.Admin</author> > +<customClass></customClass> > +<contentAuthor>XWiki.Admin</contentAuthor> > +<creationDate>1280310752000</creationDate> > +<date>1280318001000</date> > +<contentUpdateDate>1280318001000</contentUpdateDate> > +<version>1.1</version> > +<title></title> > +<template></template> > +<defaultTemplate></defaultTemplate> > +<validationScript></validationScript> > +<comment></comment> > +<minorEdit>false</minorEdit> > +<syntaxId>xwiki/2.0</syntaxId> > +<hidden>false</hidden> > +<class> > +<name>XWiki.SearchSuggestSourceClass</name> > +<customClass></customClass> > +<customMapping></customMapping> > +<defaultViewSheet></defaultViewSheet> > +<defaultEditSheet></defaultEditSheet> > +<defaultWeb></defaultWeb> > +<nameField></nameField> > +<validationScript></validationScript> > +<activated> > +<defaultValue></defaultValue> > +<disabled>0</disabled> > +<displayFormType>checkbox</displayFormType> > +<displayType></displayType> > +<name>activated</name> > +<number>7</number> > +<prettyName>activated</prettyName> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.BooleanClass</classType> > +</activated> > +<highlight> > +<defaultValue></defaultValue> > +<disabled>0</disabled> > +<displayFormType>checkbox</displayFormType> > +<displayType></displayType> > +<name>highlight</name> > +<number>6</number> > +<prettyName>highlight</prettyName> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.BooleanClass</classType> > +</highlight> > +<icon> > +<disabled>0</disabled> > +<name>icon</name> > +<number>5</number> > +<picker>0</picker> > +<prettyName>icon</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</icon> > +<name> > +<disabled>0</disabled> > +<name>name</name> > +<number>1</number> > +<picker>0</picker> > +<prettyName>name</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</name> > +<query> > +<disabled>0</disabled> > +<name>query</name> > +<number>3</number> > +<picker>0</picker> > +<prettyName>query</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</query> > +<resultsNumber> > +<disabled>0</disabled> > +<name>resultsNumber</name> > +<number>4</number> > +<picker>0</picker> > +<prettyName>resultsNumber</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</resultsNumber> > +<url> > +<disabled>0</disabled> > +<name>url</name> > +<number>2</number> > +<picker>0</picker> > +<prettyName>url</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<validationMessage></validationMessage> > +<validationRegExp></validationRegExp> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</url> > +</class> > +<content>{{include document="XWiki.ClassSheet"/}} > +</content></xwikidoc> > > _______________________________________________ > notifications mailing list > notifications(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/notifications >

14 years, 7 months

1
0
0 0

[xwiki-devs] [VOTE] Make XWiki Rendering a top level project

by Vincent Massol

Hi devs, I'd like to make the XWiki Rendering module a top level project. Rationale ======== * Make it more visible in order to get more outside visibility/contributions (it'll have its own wiki and can be advertised separately from the rest, see below) * Ensure that we keep the rendering module independent from xwiki's core model * Prepare it for a potential (no plans yet) future step which would be to either merge it with some other projects (such as Eclipse's WikiText) or move it to a forge with more visibility should we want that * Allow releasing it separately from the rest of XWiki with minimal dependencies which means it would be possible to use an oldish version of XE with the latest rendering module, allowing to provide features on an older platform. * Allows better controlling backward compatibility * Allows better and cleaner documentation (since it would be on a wiki of its own) * This module has grown large and has a life of its own now that warrants being a top level project The only cons I can see is that it means one more module to release separately and thus a little bit more time during the release process but I don't think that's a good enough reason to not do it (compared to the listed advantages above). Implementation details ================== * Name: XWiki Rendering (I hesitated giving it a code name such a XWiki Babel but in the end I think using a descriptive name is more inline with other names we have and clearer for the end users - it also allows us to not change existing package names this not breaking backward compatibility) * SVN: http://svn.xwiki.org/svnroot/xwiki/rendering * JIRA: http://jira.xwiki.org/jira/browse/XRENDERING * Wiki: http://rendering.xwiki.org * Package: org.xwiki.rendering * Versioning strategy: Start at 3.0-SNAPSHOT and release XWiki Rendering 3.0 final just before we release XE 3.0 final. Then let it have its own life: 3.1, 3.2, etc, independently of platform/XE (although in practice it can be released at the same time as we release platform) * Directory structure: http://svn.xwiki.org/svnroot/xwiki/rendering/ |_ tags |_ branches |_ trunk |_ xwiki-rendering-api |_ xwiki-rendering-macros |_ (move here all macros that don't depend on XWiki's model - it's ok to depend on XWiki's WikiModel's interface though) |_ xwiki-rendering-standalone |_ xwiki-rendering-syntaxes |_ (all syntaxes submodules moved here) |_ xwiki-rendering-tests |_ xwiki-rendering-transformations |_ (all transformation submodules) * We leave in platform/xwiki-rendering/* the macros that depend on XWiki's model + the xwiki-rendering-xwiki module. * In the future, the idea will be to separate xwiki-rendering-api into several parts (rendering-block, rendering-renderers, etc) but that's a second step. I'm on holidays right now (for a week) but that's something I'd be keep on implementing on and off during this week should we agree on it. Here's my +1 Thanks -Vincent

14 years, 7 months

6
11
0 0

[xwiki-devs] LDAP support

by Peter McLarty

Hi Having a discussion in our company about wiki's and LDAP support We had some issues getting LDAP working and a person made a comment that LDAP was not really a key focus and that some of the issues we encountered are in other classes that are used and therefore the problems are not in Xwiki Is there plans to improve Xwiki LDAP support and and will configuration come into the front end? Will its configuration be simplified? Cheers Peter

14 years, 7 months

3
2
0 0

Re: [xwiki-devs] [xwiki-notifications] r34922 - platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/suggest

by Sergiu Dumitriu

On 02/25/2011 02:07 AM, jvelociter (SVN) wrote: > Author: jvelociter > Date: 2011-02-25 02:07:18 +0100 (Fri, 25 Feb 2011) > New Revision: 34922 > > Modified: > platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/suggest/ajaxSuggest.js > Log: > XWIKI-6042 Allow to insert a node before the suggestion list(s) in the suggest widget > > + API to know wheter a suggestion is highlighted > > > Modified: platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/suggest/ajaxSuggest.js > =================================================================== > --- platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/suggest/ajaxSuggest.js 2011-02-24 23:33:57 UTC (rev 34921) > +++ platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/suggest/ajaxSuggest.js 2011-02-25 01:07:18 UTC (rev 34922) > @@ -168,9 +169,6 @@ > > switch(key) { > case Event.KEY_RETURN: Why did you remove this? > - if(this.aSuggestions.length == 1) { > - this.highlightFirst(); > - } > this.setHighlightedValue(); > Event.stop(event); > break; -- Sergiu Dumitriu http://purl.org/net/sergiu/

14 years, 7 months

2
1
0 0

Re: [xwiki-devs] [xwiki-notifications] r34917 - in contrib/sandbox/xwiki-extension-handler-xar/src: main/java/org/xwiki/extension/xar/internal/handler/packager/xml test/java/org/xwiki/extension/xar test/resources/repository/local

by Jerome Velociter

\o/ On Thu, Feb 24, 2011 at 5:08 PM, tmortagne <contrib-notifications(a)xwiki.org> wrote: > Author: tmortagne > Date: 2011-02-24 17:08:47 +0100 (Thu, 24 Feb 2011) > New Revision: 34917 > > Added: > contrib/sandbox/xwiki-extension-handler-xar/src/test/resources/repository/local/page.xml > Removed: > contrib/sandbox/xwiki-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/handler/packager/xml/ClassHandler.java > contrib/sandbox/xwiki-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/handler/packager/xml/ObjectHandler.java > Modified: > contrib/sandbox/xwiki-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/handler/packager/xml/DocumentImporterHandler.java > contrib/sandbox/xwiki-extension-handler-xar/src/test/java/org/xwiki/extension/xar/XarExtensionHandlerTest.java > contrib/sandbox/xwiki-extension-handler-xar/src/test/resources/repository/local/test-1.0.xar > contrib/sandbox/xwiki-extension-handler-xar/src/test/resources/repository/local/test-2.0.xar > Log: > XWIKI-5557: Add extension manager xar handler > Yea ! first fully implemented version with install/commit/upgrade support (ok "upgrade" is maybe a lot to say ;)) > > Deleted: contrib/sandbox/xwiki-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/handler/packager/xml/ClassHandler.java > =================================================================== > --- contrib/sandbox/xwiki-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/handler/packager/xml/ClassHandler.java 2011-02-24 15:58:04 UTC (rev 34916) > +++ contrib/sandbox/xwiki-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/handler/packager/xml/ClassHandler.java 2011-02-24 16:08:47 UTC (rev 34917) > @@ -1,37 +0,0 @@ > -/* > - * See the NOTICE file distributed with this work for additional > - * information regarding copyright ownership. > - * > - * This is free software; you can redistribute it and/or modify it > - * under the terms of the GNU Lesser General Public License as > - * published by the Free Software Foundation; either version 2.1 of > - * the License, or (at your option) any later version. > - * > - * This software is distributed in the hope that it will be useful, > - * but WITHOUT ANY WARRANTY; without even the implied warranty of > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > - * Lesser General Public License for more details. > - * > - * You should have received a copy of the GNU Lesser General Public > - * License along with this software; if not, write to the Free > - * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA > - * 02110-1301 USA, or see the FSF site: http://www.fsf.org. > - */ > -package org.xwiki.extension.xar.internal.handler.packager.xml; > - > -import org.xwiki.component.manager.ComponentManager; > - > -import com.xpn.xwiki.objects.classes.BaseClass; > - > -public class ClassHandler extends AbstractHandler > -{ > - public ClassHandler(ComponentManager componentManager, BaseClass xclass) > - { > - super(componentManager, xclass); > - } > - > - public BaseClass getObject() > - { > - return (BaseClass) getCurrentBean(); > - } > -} > > Modified: contrib/sandbox/xwiki-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/handler/packager/xml/DocumentImporterHandler.java > =================================================================== > --- contrib/sandbox/xwiki-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/handler/packager/xml/DocumentImporterHandler.java 2011-02-24 15:58:04 UTC (rev 34916) > +++ contrib/sandbox/xwiki-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/handler/packager/xml/DocumentImporterHandler.java 2011-02-24 16:08:47 UTC (rev 34917) > @@ -19,6 +19,7 @@ > */ > package org.xwiki.extension.xar.internal.handler.packager.xml; > > +import org.dom4j.io.SAXContentHandler; > import org.xml.sax.Attributes; > import org.xml.sax.SAXException; > import org.xwiki.component.manager.ComponentLookupException; > @@ -26,7 +27,9 @@ > import org.xwiki.model.reference.DocumentReference; > > import com.xpn.xwiki.XWikiContext; > +import com.xpn.xwiki.XWikiException; > import com.xpn.xwiki.doc.XWikiDocument; > +import com.xpn.xwiki.objects.BaseObject; > > public class DocumentImporterHandler extends AbstractHandler > { > @@ -34,6 +37,11 @@ > > private boolean needSave = true; > > + /** > + * Avoid create a new SAXContentHandler for each object/class when the same can be used for all. > + */ > + public SAXContentHandler domBuilder = new SAXContentHandler(); > + > public DocumentImporterHandler(ComponentManager componentManager) > { > super(componentManager); > @@ -43,6 +51,7 @@ > } catch (ComponentLookupException e) { > setCurrentBean(new XWikiDocument()); > } > + > // skip useless known elements > this.skippedElements.add("version"); > this.skippedElements.add("minorEdit"); > @@ -99,10 +108,9 @@ > { > if (qName.equals("attachment")) { > setCurrentHandler(new AttachmentHandler(getComponentManager())); > - } else if (qName.equals("object")) { > - setCurrentHandler(new ObjectHandler(getComponentManager())); > - } else if (qName.equals("class")) { > - setCurrentHandler(new ClassHandler(getComponentManager(), getDocument().getXClass())); > + } else if (qName.equals("class") || qName.equals("object")) { > + this.domBuilder.startDocument(); > + setCurrentHandler(this.domBuilder); > } else { > super.startElementInternal(uri, localName, qName, attributes); > } > @@ -120,14 +128,25 @@ > > getDocument().getAttachmentList().add(handler.getAttachment()); > > - // TODO: add attachment to documentxwikidoc > + // TODO: add attachment to document > saveDocument("Import: add attachment"); > } else if (qName.equals("object")) { > - ObjectHandler handler = (ObjectHandler) getCurrentHandler(); > - getDocument().addXObject(handler.getObject()); > + try { > + BaseObject baseObject = new BaseObject(); > + baseObject.fromXML(this.domBuilder.getDocument().getRootElement()); > + getDocument().setXObject(baseObject.getNumber(), baseObject); > + } catch (XWikiException e) { > + throw new SAXException("Failed to parse object", e); > + } > > this.needSave = true; > } else if (qName.equals("class")) { > + try { > + getDocument().getXClass().fromXML(this.domBuilder.getDocument().getRootElement()); > + } catch (XWikiException e) { > + throw new SAXException("Failed to parse object", e); > + } > + > this.needSave = true; > } else { > super.endElementInternal(uri, localName, qName); > > Deleted: contrib/sandbox/xwiki-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/handler/packager/xml/ObjectHandler.java > =================================================================== > --- contrib/sandbox/xwiki-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/handler/packager/xml/ObjectHandler.java 2011-02-24 15:58:04 UTC (rev 34916) > +++ contrib/sandbox/xwiki-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/handler/packager/xml/ObjectHandler.java 2011-02-24 16:08:47 UTC (rev 34917) > @@ -1,37 +0,0 @@ > -/* > - * See the NOTICE file distributed with this work for additional > - * information regarding copyright ownership. > - * > - * This is free software; you can redistribute it and/or modify it > - * under the terms of the GNU Lesser General Public License as > - * published by the Free Software Foundation; either version 2.1 of > - * the License, or (at your option) any later version. > - * > - * This software is distributed in the hope that it will be useful, > - * but WITHOUT ANY WARRANTY; without even the implied warranty of > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > - * Lesser General Public License for more details. > - * > - * You should have received a copy of the GNU Lesser General Public > - * License along with this software; if not, write to the Free > - * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA > - * 02110-1301 USA, or see the FSF site: http://www.fsf.org. > - */ > -package org.xwiki.extension.xar.internal.handler.packager.xml; > - > -import org.xwiki.component.manager.ComponentManager; > - > -import com.xpn.xwiki.objects.BaseObject; > - > -public class ObjectHandler extends AbstractHandler > -{ > - public ObjectHandler(ComponentManager componentManager) > - { > - super(componentManager, new BaseObject()); > - } > - > - public BaseObject getObject() > - { > - return (BaseObject) getCurrentBean(); > - } > -} > > Modified: contrib/sandbox/xwiki-extension-handler-xar/src/test/java/org/xwiki/extension/xar/XarExtensionHandlerTest.java > =================================================================== > --- contrib/sandbox/xwiki-extension-handler-xar/src/test/java/org/xwiki/extension/xar/XarExtensionHandlerTest.java 2011-02-24 15:58:04 UTC (rev 34916) > +++ contrib/sandbox/xwiki-extension-handler-xar/src/test/java/org/xwiki/extension/xar/XarExtensionHandlerTest.java 2011-02-24 16:08:47 UTC (rev 34917) > @@ -40,6 +40,9 @@ > import com.xpn.xwiki.XWiki; > import com.xpn.xwiki.XWikiContext; > import com.xpn.xwiki.doc.XWikiDocument; > +import com.xpn.xwiki.objects.BaseObject; > +import com.xpn.xwiki.objects.classes.BaseClass; > +import com.xpn.xwiki.objects.classes.NumberClass; > import com.xpn.xwiki.test.AbstractBridgedComponentTestCase; > > public class XarExtensionHandlerTest extends AbstractBridgedComponentTestCase > @@ -147,6 +150,11 @@ > Assert.assertEquals("Wrong content", "content", document.getContent()); > Assert.assertEquals("Wrong author", "XWiki.author", document.getAuthor()); > Assert.assertEquals("Wrong versions", "1.1", document.getVersion()); > + > + BaseClass baseClass = document.getXClass(); > + Assert.assertNotNull(baseClass.getField("property")); > + Assert.assertEquals("property", baseClass.getField("property").getName()); > + Assert.assertSame(NumberClass.class, baseClass.getField("property").getClass()); > } > > @Test > @@ -173,6 +181,11 @@ > Assert.assertEquals("Wrong content", "content 2", document.getContent()); > Assert.assertEquals("Wrong author", "XWiki.author", document.getAuthor()); > Assert.assertEquals("Wrong versions", "2.1", document.getVersion()); > + > + BaseClass baseClass = document.getXClass(); > + Assert.assertNotNull(baseClass.getField("property")); > + Assert.assertEquals("property", baseClass.getField("property").getName()); > + Assert.assertSame(NumberClass.class, baseClass.getField("property").getClass()); > } > > @Test > > Added: contrib/sandbox/xwiki-extension-handler-xar/src/test/resources/repository/local/page.xml > =================================================================== > --- contrib/sandbox/xwiki-extension-handler-xar/src/test/resources/repository/local/page.xml (rev 0) > +++ contrib/sandbox/xwiki-extension-handler-xar/src/test/resources/repository/local/page.xml 2011-02-24 16:08:47 UTC (rev 34917) > @@ -0,0 +1,166 @@ > +<?xml version="1.0" encoding="UTF-8"?> > +<xwikidoc> > +<web>space</web> > +<name>page</name> > +<language></language> > +<defaultLanguage>en</defaultLanguage> > +<translation>0</translation> > +<parent></parent> > +<creator>XWiki.creator</creator> > +<author>XWiki.author</author> > +<customClass></customClass> > +<contentAuthor>XWiki.contentAuthor</contentAuthor> > +<creationDate>1297952360000</creationDate> > +<date>1297952371000</date> > +<contentUpdateDate>1297952371000</contentUpdateDate> > +<version>1.1</version> > +<title></title> > +<template></template> > +<defaultTemplate></defaultTemplate> > +<validationScript></validationScript> > +<comment></comment> > +<minorEdit>false</minorEdit> > +<syntaxId>xwiki/2.0</syntaxId> > +<hidden>false</hidden> > +<class> > +<name>space.page</name> > +<customClass></customClass> > +<customMapping></customMapping> > +<defaultViewSheet></defaultViewSheet> > +<defaultEditSheet></defaultEditSheet> > +<defaultWeb></defaultWeb> > +<nameField></nameField> > +<validationScript></validationScript> > +<property> > +<disabled>0</disabled> > +<name>property</name> > +<number>1</number> > +<numberType>long</numberType> > +<prettyName>property</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<classType>com.xpn.xwiki.objects.classes.NumberClass</classType> > +</property> > +</class> > +<object> > +<class> > +<name>XWiki.StyleSheetExtension</name> > +<customClass></customClass> > +<customMapping></customMapping> > +<defaultViewSheet></defaultViewSheet> > +<defaultEditSheet></defaultEditSheet> > +<defaultWeb></defaultWeb> > +<nameField></nameField> > +<validationScript></validationScript> > +<cache> > +<cache>0</cache> > +<disabled>0</disabled> > +<displayType>select</displayType> > +<multiSelect>0</multiSelect> > +<name>cache</name> > +<number>5</number> > +<prettyName>Caching policy</prettyName> > +<relationalStorage>0</relationalStorage> > +<separator> </separator> > +<separators> ,|</separators> > +<size>1</size> > +<unmodifiable>0</unmodifiable> > +<values>long|short|default|forbid</values> > +<classType>com.xpn.xwiki.objects.classes.StaticListClass</classType> > +</cache> > +<code> > +<disabled>0</disabled> > +<name>code</name> > +<number>2</number> > +<prettyName>Code</prettyName> > +<rows>20</rows> > +<size>50</size> > +<unmodifiable>0</unmodifiable> > +<classType>com.xpn.xwiki.objects.classes.TextAreaClass</classType> > +</code> > +<name> > +<disabled>0</disabled> > +<name>name</name> > +<number>1</number> > +<prettyName>Name</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<classType>com.xpn.xwiki.objects.classes.StringClass</classType> > +</name> > +<parse> > +<disabled>0</disabled> > +<displayFormType>select</displayFormType> > +<displayType>yesno</displayType> > +<name>parse</name> > +<number>4</number> > +<prettyName>Parse content</prettyName> > +<unmodifiable>0</unmodifiable> > +<classType>com.xpn.xwiki.objects.classes.BooleanClass</classType> > +</parse> > +<use> > +<cache>0</cache> > +<disabled>0</disabled> > +<displayType>select</displayType> > +<multiSelect>0</multiSelect> > +<name>use</name> > +<number>3</number> > +<prettyName>Use this extension</prettyName> > +<relationalStorage>0</relationalStorage> > +<separator> </separator> > +<separators> ,|</separators> > +<size>1</size> > +<unmodifiable>0</unmodifiable> > +<values>onDemand=On demand|always=Always</values> > +<classType>com.xpn.xwiki.objects.classes.StaticListClass</classType> > +</use> > +</class> > +<name>space.page</name> > +<number>0</number> > +<className>XWiki.StyleSheetExtension</className> > +<guid>8eaeac52-e2f2-47b2-87e1-bc6909597b39</guid> > +<property> > +<cache>long</cache> > +</property> > +<property> > +<code>some code</code> > +</property> > +<property> > +<name>name</name> > +</property> > +<property> > +<parse></parse> > +</property> > +<property> > +<use>onDemand</use> > +</property> > +</object> > +<object> > +<class> > +<name>space.page</name> > +<customClass></customClass> > +<customMapping></customMapping> > +<defaultViewSheet></defaultViewSheet> > +<defaultEditSheet></defaultEditSheet> > +<defaultWeb></defaultWeb> > +<nameField></nameField> > +<validationScript></validationScript> > +<property> > +<disabled>0</disabled> > +<name>property</name> > +<number>1</number> > +<numberType>long</numberType> > +<prettyName>property</prettyName> > +<size>30</size> > +<unmodifiable>0</unmodifiable> > +<classType>com.xpn.xwiki.objects.classes.NumberClass</classType> > +</property> > +</class> > +<name>space.page</name> > +<number>0</number> > +<className>space.page</className> > +<guid>e2167721-2a64-430c-9520-bac1c0ee68cb</guid> > +<property> > +<property>12</property> > +</property> > +</object> > +<content>content</content></xwikidoc> > > > Property changes on: contrib/sandbox/xwiki-extension-handler-xar/src/test/resources/repository/local/page.xml > ___________________________________________________________________ > Added: svn:mime-type > + text/plain > Added: svn:eol-style > + native > > Modified: contrib/sandbox/xwiki-extension-handler-xar/src/test/resources/repository/local/test-1.0.xar > =================================================================== > (Binary files differ) > > Modified: contrib/sandbox/xwiki-extension-handler-xar/src/test/resources/repository/local/test-2.0.xar > =================================================================== > (Binary files differ) > > _______________________________________________ > notifications mailing list > notifications(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/notifications >

14 years, 7 months

1
0
0 0

[xwiki-devs] Dynamically set rights over document

by Lukapt

Hi, I'm trying to set rights over a document automatically. In my wiki i have the "Publication" concept. Each Publication has one or more authors. Each author is an "Researcher" that is directly related to an XWikiUser. What I want to do is to set editing rights only for the authors of that publication. If I add (or remove) an author he should be able (not able) to edit the document. What i thought first was to check and add user rights every time the document was loaded. However this didn't worked because, initially, users don't have rights to add new rights (lol). That doesn't seemed a good practice anyway. What is the best way to do this? Maybe after every change in editing mode, system may apply the rights? How can I do that? Btw, I'm using this snippet to add the user rights: http://extensions.xwiki.org/xwiki/bin/view/Extension/Setting+Rights Thanks in advance, Luís Braga -- View this message in context: http://xwiki.475771.n2.nabble.com/Dynamically-set-rights-over-document-tp60… Sent from the XWiki- Dev mailing list archive at Nabble.com.

14 years, 7 months

2
2
0 0

[xwiki-devs] How to use xpage

by Lukapt

Hi, This is probably a newbie question but I didn't find any clear answer for me. Could someone explain to me how to use "xpage"? For example, when trying to modify user avatar this code is used: $doc.getURL('edit', 'xpage=changemyavatar') I really don't know how this works or where I can find the piece of code related to this action. Thanks, Luís Braga -- View this message in context: http://xwiki.475771.n2.nabble.com/How-to-use-xpage-tp6056768p6056768.html Sent from the XWiki- Dev mailing list archive at Nabble.com.

14 years, 7 months

2
2
0 0

[xwiki-devs] [Release] 2.7.1 Build : check artifacts

by Raluca Stavro

Hello devs, 2.7.1 has been built, please check that the artifacts are OK. The resources can be found at: XWiki Core: http://maven.xwiki.org/releases/org/xwiki/platform/ XWiki Application Administration: http://maven.xwiki.org/releases/org/xwiki/platform/applications/xwiki-appli… XWiki Enterprise: http://maven.xwiki.org/releases/org/xwiki/enterprise/ XWiki Enterprise Manager: http://maven.xwiki.org/releases/org/xwiki/manager/ Thank you, Raluca.

14 years, 7 months

2
1
0 0

[xwiki-devs] [UX][Proposal] XWikiSyntax Page

by Ecaterina Moraru (Valica)

Hi, This is a proposal for compacting the way we show XWiki Syntaxes http://incubator.myxwiki.org/xwiki/bin/view/Improvements/SyntaxExperiments Feedback is welcomed. Thanks, Caty

14 years, 7 months

13
32
0 0

[xwiki-devs] [rendering] Replace BlockFilter with BlockMatcher?

by Vincent Massol

Hi Thomas, I think it could be a good idea to remove (deprecate?) the current BlockFilter interface/implementations and instead use the newly introduced BlockMatcher. WDYT? Thanks -Vincent

14 years, 7 months

2
6
0 0

Re: [xwiki-devs] [xwiki-notifications] r34808 - in platform/core/trunk/xwiki-rendering: xwiki-rendering-api/src/main/java/org/xwiki/rendering/block/match xwiki-rendering-macros/xwiki-rendering-macro-include/src/main/java/org/xwiki/rendering/internal/macro/include

by Thomas Mortagne

On Sat, Feb 19, 2011 at 10:38, vmassol <platform-notifications(a)xwiki.org> wrote: > Author: vmassol > Date: 2011-02-19 10:38:37 +0100 (Sat, 19 Feb 2011) > New Revision: 34808 > > Added: > platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/block/match/CompositeBlockMatcher.java > Modified: > platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-include/src/main/java/org/xwiki/rendering/internal/macro/include/IncludeMacro.java > Log: > XWIKI-1776: Support Include of Section Content > > * Added javadoc > * Introduced CompositeBlockMatcher > > Added: platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/block/match/CompositeBlockMatcher.java > =================================================================== > --- platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/block/match/CompositeBlockMatcher.java (rev 0) > +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/block/match/CompositeBlockMatcher.java 2011-02-19 09:38:37 UTC (rev 34808) > @@ -0,0 +1,72 @@ > +/* > + * See the NOTICE file distributed with this work for additional > + * information regarding copyright ownership. > + * > + * This is free software; you can redistribute it and/or modify it > + * under the terms of the GNU Lesser General Public License as > + * published by the Free Software Foundation; either version 2.1 of > + * the License, or (at your option) any later version. > + * > + * This software is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this software; if not, write to the Free > + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA > + * 02110-1301 USA, or see the FSF site: http://www.fsf.org. > + */ > +package org.xwiki.rendering.block.match; > + > +import java.util.ArrayList; > +import java.util.List; > + > +import org.xwiki.rendering.block.Block; > + > +/** > + * Implementation of {@link BlockMatcher} which matches blocks using passed matchers in series. > + * > + * @version $Id$ > + * @since 3.0M3 > + */ > +public class CompositeBlockMatcher implements BlockMatcher > +{ > + /** > + * The matchers to match in series. > + */ > + private List<BlockMatcher> matchers = new ArrayList<BlockMatcher>(); > + > + /** > + * @param matchers list of matchers to add > + */ > + public CompositeBlockMatcher(List<BlockMatcher> matchers) > + { > + this.matchers.addAll(matchers); > + } > + > + /** > + * @param matchers vararg list of matchers to add > + */ > + public CompositeBlockMatcher(BlockMatcher... matchers) > + { > + for (BlockMatcher matcher : matchers) { > + this.matchers.add(matcher); > + } > + } > + > + /** > + * {@inheritDoc} > + * > + * @see org.xwiki.rendering.block.match.BlockMatcher#match(org.xwiki.rendering.block.Block) > + */ > + public boolean match(Block block) > + { > + for (BlockMatcher matcher : this.matchers) { > + if (!matcher.match(block)) { > + return false; > + } > + } > + return true; > + } > +} > > Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-include/src/main/java/org/xwiki/rendering/internal/macro/include/IncludeMacro.java > =================================================================== > --- platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-include/src/main/java/org/xwiki/rendering/internal/macro/include/IncludeMacro.java 2011-02-18 22:26:41 UTC (rev 34807) > +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-include/src/main/java/org/xwiki/rendering/internal/macro/include/IncludeMacro.java 2011-02-19 09:38:37 UTC (rev 34808) > @@ -41,6 +41,8 @@ > import org.xwiki.rendering.block.MetaDataBlock; > import org.xwiki.rendering.block.XDOM; > import org.xwiki.rendering.block.match.BlockMatcher; > +import org.xwiki.rendering.block.match.ClassBlockMatcher; > +import org.xwiki.rendering.block.match.CompositeBlockMatcher; > import org.xwiki.rendering.internal.macro.MacroContentParser; > import org.xwiki.rendering.listener.MetaData; > import org.xwiki.rendering.macro.AbstractMacro; > @@ -207,24 +209,33 @@ > return result; > } > > + /** > + * Get the content to include (either full target document or a specific section's content). > + * > + * @param document the reference to the document from which to get the content > + * @param section the id of the section from which to get the content in that document or null to take the whole > + * content > + * @param includedReference the resolved absolute reference of the included document > + * @return the content as an XDOM tree > + * @throws MacroExecutionException if no section of the passed if exists in the included document > + */ > private XDOM getContent(DocumentModelBridge document, final String section, DocumentReference includedReference) > throws MacroExecutionException > { > XDOM includedContent = document.getXDOM(); > > if (section != null) { > - HeaderBlock headerBlock = (HeaderBlock) includedContent.getFirstBlock(new BlockMatcher() { > - public boolean match(Block block) > - { > - if (block instanceof HeaderBlock) { > + HeaderBlock headerBlock = (HeaderBlock) includedContent.getFirstBlock( > + new CompositeBlockMatcher(new ClassBlockMatcher(HeaderBlock.class), new BlockMatcher() { > + public boolean match(Block block) > + { > HeaderBlock headerBlock = (HeaderBlock) block; > if (headerBlock.getId().equals(section)) { > return true; > } > + return false; What about return headerBlock.getId().equals(section); ? > } > - return false; > - } > - }, Block.Axes.DESCENDANT); > + }),Block.Axes.DESCENDANT); > if (headerBlock == null) { > throw new MacroExecutionException("Cannot find section [" + section > + "] in document [" + this.defaultEntityReferenceSerializer.serialize(includedReference) + "]"); > @@ -291,19 +302,26 @@ > { > DocumentReference result; > > - String sourceMetadata = null; > - MetaDataBlock metadataBlock = block.getPreviousBlockByType(MetaDataBlock.class, true); > - while (sourceMetadata == null && metadataBlock != null) { > - sourceMetadata = (String) metadataBlock.getMetaData().getMetaData(MetaData.SOURCE); > - metadataBlock = metadataBlock.getPreviousBlockByType(MetaDataBlock.class, true); > - } > + MetaDataBlock metaDataBlock = (MetaDataBlock) block.getFirstBlock( > + new CompositeBlockMatcher(new ClassBlockMatcher(MetaDataBlock.class), new BlockMatcher() { > + public boolean match(Block block) > + { > + MetaDataBlock metaDataBlock = (MetaDataBlock) block; > + String sourceMetaData = (String) metaDataBlock.getMetaData().getMetaData(MetaData.SOURCE); > + if (sourceMetaData != null) { > + return true; > + } > + return false; Maybe we should add something like MetaDataBlock#contains(String key) method. > + } > + }), Block.Axes.ANCESTOR); > > // If no Source MetaData was found resolve against the current document as a failsafe solution. > - if (sourceMetadata == null) { > + if (metaDataBlock == null) { > result = this.currentDocumentReferenceResolver.resolve(documentName); > } else { > + String sourceMetaData = (String) metaDataBlock.getMetaData().getMetaData(MetaData.SOURCE); > result = this.currentDocumentReferenceResolver.resolve(documentName, > - this.currentDocumentReferenceResolver.resolve(sourceMetadata)); > + this.currentDocumentReferenceResolver.resolve(sourceMetaData)); > } > > return result; > > _______________________________________________ > notifications mailing list > notifications(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/notifications > -- Thomas Mortagne

14 years, 7 months

1
0
0 0

[xwiki-devs] Remove old branches from SVN

by Vincent Massol

Hi, Just a notice that I'll remove the following branches from jira since we (open source xwiki developers) only support 2 branches (trunk + latest stable): • xwiki-core-1.5-curriki/ • xwiki-core-1.8/ • xwiki-core-1.9/ • xwiki-core-2.1/ • xwiki-core-2.2/ • xwiki-core-2.3/ • xwiki-core-2.4/ Please shout quickly if you have a good reason to keep one of these (also note that they'll always be in the svn history). Thanks -Vincent

14 years, 7 months

3
7
0 0

[xwiki-devs] [VOTE] Release XE/XEM 2.5.2, 2.6.2 and 2.7.1

by Sergiu Dumitriu

Hi devs, I'd like to tag new releases on the 2.5, 2.6 and 2.7 branches, since there have been several bugfixes and a few performance improvements on each of them. See the fixed issues here: 2.7.1 http://jira.xwiki.org/jira/secure/IssueNavigator.jspa?reset=true&jqlQuery=p… 2.6.2 http://jira.xwiki.org/jira/secure/IssueNavigator.jspa?reset=true&jqlQuery=p… 2.5.2 http://jira.xwiki.org/jira/secure/IssueNavigator.jspa?reset=true&jqlQuery=p… After that, I'd like to drop the 2.5 and 2.6 branches. -- Sergiu Dumitriu http://purl.org/net/sergiu/

14 years, 7 months

8
9
0 0

[xwiki-devs] [Community] We need a wiki and volunteers for implementing the new XWiki.org

by Ecaterina Moraru (Valica)

Hi, Would be very nice to have a development wiki in order to get things going on the new XWiki.org proposal: http://incubator.myxwiki.org/xwiki/bin/view/Improvements/XWikiOrgProposal2 Maybe Vincent can help with this? :) Since the redesign is quite big and lots of spaces|panels|styles need to be changed, morphing the current xwiki.org on the go would be quite difficult. So, having the development wiki would be much easier to work decentralized on different parts of it when people have time. There are lot of areas of the proposal that are not covered and would be really great to receive proposals and help from other members of the community. Also the implementation needs volunteers :) so any help is appreciated. We will also use the new xwiki.org logo proposed by the community, so having all this ideas come together and be put into action is very exciting. Thanks for the support, Caty Resources: - Original Proposal mail: http://markmail.org/message/4erqdhwuzvmtts6p - Logo Challenge mail: http://markmail.org/thread/bze35tdm4iojnafa

14 years, 7 months

4
4
0 0

[xwiki-devs] Notion of Active committers

by Vincent Massol

Hi guys, I've taken the liberty to refine the notion of active committer on http://dev.xwiki.org/xwiki/bin/view/Community/Committership Basically the idea is that active means having at least 1 commit in a period of 1 year (rolling period). We had discussed this and it was hinted in the text I rewrote. Just wanted to make sure we all agree about it. This notion can be useful on: * the hall of fame page * the new download page where companies can list their number of active committers Thanks -Vincent

14 years, 7 months

3
8
0 0

[xwiki-devs] Visual way to display a document reference?

by Vincent Massol

Hi, We have several places where we need to display a document reference; for ex: - rename page - copy page etc One solution is to not display the reference and break it into discrete parts, for ex: Source wiki: <wiki name> Source space: <space name> Source page: <page name> However there are drawbacks: 1) it takes space 2) when we introduced nested spaces it's going to be even more complex to do so... I was wondering if instead we couldn't go another way which is to have a visual way to display a reference. Two ideas: http://tinycoke.com/_6rGYY9JXqpvD6/screen_shot_2011-02-10_at_12.29.24_pm.png WDYT? Any more ideas? Thanks -Vincent

14 years, 7 months

7
14
0 0

[xwiki-devs] [Proposal] New module: xwiki-resources

by Vincent Massol

Hi devs, While designing the xwiki-action and xwiki-url modules I've realized that we need a general way to represent an xwiki resource and an action on that resource. This will allow every resource in XWiki to be addressable and offer a generic action mechanism. What is an xwiki resource? ===================== Examples: * an Entity (Document, XObject, XProperty, Attachment, etc) * A Page (i.e. an Entity rendered with a skin) * a resource file on the filesystem (image, css, js, icon, etc) * something on which a REST call will operate (which may or may not be an Entity) Note that a resource has a type, a reference and optional generic parameters. It's very much similar to a URI in the JDK but represented differently. What is an action done on a resource? ===================== Examples: * For an Entity: view it in XHTML (or in any other syntax) * For an Entity: view it with the skin applied, in XHTML (or in any other syntax) * Generate a URL for it * Create a link to it * For an Entity: Create it, modify it, delete it Where would it be used: ===================== Examples: * To transform any XWiki URL into a resource object. Any XWiki URL would be transformed internally into a resource. Note: The current XWikiURL class located in the xwiki-url module would disappear * In the Rendering to represent the reference of a link or an image. Ex: [[label>>reference]]. We currently have a ResourceReference class that would be removed and replaced by the new generic resource class. * More generically Resource and Resource Actions will be used at entry points of XWiki and internally XWiki will only manipulate Resources. String representation: ===================== <resource type>:<action>:<resource reference> Examples: ===================== * view a document with skin applied page:view:wiki:space1.space2.page <==> ViewAction * view a document entity:view:wiki:space1.space2.page params: context=new <==> No equiv or {{include document="wiki:space1.space2.page" context="new"/}} ex: link to attachment entity:link:wiki:space.page@my.png <==> [[attach:wiki:space.page@my.png]] ex: link to a document entity:link:wiki:space1.space2.page <==> [[doc:wiki:space1.space2.page]] ex: view icon icon:view:accept <==> image:icon:accept ex: view image stored in document entity:view:wiki:space.page@my.png <==> image:doc:wiki:space.page@my.png ex: view image located at external URL url:view:http://server/my.png <==> image:url:http://server/my.png API === * ResourceReference * ResourceAction (extends ResourceReference by adding an action field) * ResourceReferenceSerializer * ResourceReferenceResolver * ResourceExecutor(ResourceReference). Hint = <executor type>/<resource type>/<resource action> Example: View "entity:view:wiki:space.page@my.png" in XHTML Algorithm: - lookup ResourceExecutor (hint = "xhtml/entity/view") - cast ref = ResourceReference.getReference() to EntityReference - if ref.type == ATTACHMENT - get attachment URL => <img src="..../my.png"/> Example: Generate URL for "entity:view:wiki:space.page@my.png" Algorithm: - lookup ResourceExecutor (hint = "url/entity/view") - cast ref = ResourceReference.getReference() to EntityReference => http://wiki/xwiki/bin/view/space/page/my.png OR simply: ResourceExecutor(ResourceAction). Hint = <executor type> ex: "xhtml", "url", etc. And it's up to the executor to have sub components for the various actions, resource types.... Conclusion =========== The API is not completely finished and I'd need to explore it (ie start implementing it) to refine it. Right now I'd just like to discuss whether you see the idea as interesting and whether I should start spending some time working on it. I'll post refinements as I progress. Thanks -Vincent

14 years, 7 months

2
5
0 0

[xwiki-devs] [Discussion] Dashboard default behaviour

by Anca Luca

Hi devs, I committed XWIKI-5938 but I think we should discuss the default source of the dashboard macro, namely where does it pick the gadget objects to display on the dashboard, e.g. in the case of a dashboard macro call in an included document. It is very easy to add a "source" parameter to the dashboard macro, which would tell the dashboard where should it read the objects from (and render in the context of the current document), but now the question is what should {{dashboard /}} without parameters do? 1/ read the objects from the current document, which means, in the case of an include, it will depend on the context of the include. Note that, if an include is done in a new context, then all the gadgets on that dashboard will be also relative to the included document (e.g. if they use $doc, the $doc will be the included document, not the including doc). 2/ read the objects from the closest MetaData.SOURCE, which means the document from which the content that contains the {{dashboard /}} call comes from. E.g. in the case of an include, the included document. WDYT? There are a lot of possible situations to discuss, I will just present a few usecases below, to be taken into account when analyzing: A. The current Main.Dashboard is included in all the WebHomes by default, but its gadgets refer to the current document (the _including_ document) B. Users want to be able to easily customize their WebHomes, without affecting other people (not change the wiki general dashboard, but only their space dashboard) C. There is a dashboard somewhere on the wiki, Main.CoolDashboard, and users want to be able to include that dashboard as a copy, without having to re-create the dashboard objects on their including page D. User dashboards: at one point we will want each user to have their own dashboard on their profile page, which is rendered by a sheet. Ideally we should have the same user sheet for all users. E. Also, the user dashboard should be include-able on the Main.WebHome of a logged in user (a "Home"). F. Since the include doesn't make too much sense for a dashboard document (since the dashboard document is only a call to a {{dashboard /}} macro), users will replace its usage with {{dashboard /}} macro calls, with a source parameter to pick gadget objects from another document ('reuse' a dashboard definition). If you can think of more cases that could involve include issues, please fill them in. Thanks, Anca

14 years, 7 months

3
9
0 0

Re: [xwiki-devs] [xwiki-notifications] r34718 - platform/core/branches/xwiki-core-2.7/xwiki-core/src/main/java/com/xpn/xwiki/store

by Sergiu Dumitriu

On 02/16/2011 10:09 AM, tmortagne (SVN) wrote: > Author: tmortagne > Date: 2011-02-16 10:09:31 +0100 (Wed, 16 Feb 2011) > New Revision: 34718 > > Modified: > platform/core/branches/xwiki-core-2.7/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateBaseStore.java > platform/core/branches/xwiki-core-2.7/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateStore.java > Log: > XWIKI-5976: Cannot create subwiki named "lines" > Better (but a lot less elegant...) fix > > Modified: platform/core/branches/xwiki-core-2.7/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateBaseStore.java > =================================================================== > --- platform/core/branches/xwiki-core-2.7/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateBaseStore.java 2011-02-16 09:09:21 UTC (rev 34717) > +++ platform/core/branches/xwiki-core-2.7/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateBaseStore.java 2011-02-16 09:09:31 UTC (rev 34718) > @@ -504,7 +504,6 @@ > } > } catch (Exception e) { > } > - ; > try { > if (bTransaction) { > endTransaction(context, true); > @@ -600,13 +599,14 @@ > > if (context.getDatabase() != null) { > String schemaName = getSchemaFromWikiName(context); > + String escapedSchemaName = escapeSchema(schemaName, context); > > DatabaseProduct databaseProduct = getDatabaseProductName(context); > if (DatabaseProduct.ORACLE == databaseProduct) { > Statement stmt = null; > try { > stmt = session.connection().createStatement(); > - stmt.execute("alter session set current_schema = " + schemaName); > + stmt.execute("alter session set current_schema = " + escapedSchemaName); > } finally { > try { > if (stmt != null) { > @@ -620,7 +620,7 @@ > Statement stmt = null; > try { > stmt = session.connection().createStatement(); > - stmt.execute("SET SCHEMA " + schemaName); > + stmt.execute("SET SCHEMA " + escapedSchemaName); > } finally { > try { > if (stmt != null) { > @@ -648,6 +648,29 @@ > } > > /** > + * Escape schema name depending of the database engine. > + * > + * @param schema the schema name to escape > + * @param context the XWiki context to get database engine identifier > + * @return the escaped version > + */ > + protected String escapeSchema(String schema, XWikiContext context) > + { > + DatabaseProduct databaseProduct = getDatabaseProductName(context); > + > + String escapedSchema; You should use this instead: escapedSchema = dialect.openQuote() + schema + dialect.closeQuote(); I think nobody wants to use ` or " in the wiki name, so there shouldn't be a need for doubling them. BTW, SQLServer uses [ ] for quoting. > + if (DatabaseProduct.MYSQL == databaseProduct) { > + // MySQL does not use SQL92 escaping syntax by default > + escapedSchema = "`" + schema.replace("`", "``") + "`"; > + } else { > + // Use SQL92 escape syntax > + escapedSchema = "\"" + schema.replace("\"", "\"\"") + "\""; > + } > + > + return escapedSchema; > + } > + > + /** > * Begins a transaction > * > * @param context -- Sergiu Dumitriu http://purl.org/net/sergiu/

14 years, 7 months

2
6
0 0

Re: [xwiki-devs] [xwiki-notifications] r34727 - in platform/web/trunk/standard/src/main/webapp/resources/uicomponents/widgets: . gallery

by Jerome Velociter

On Wed, Feb 16, 2011 at 12:12 PM, mflorea <platform-notifications(a)xwiki.org>wrote: > Author: mflorea > Date: 2011-02-16 12:12:34 +0100 (Wed, 16 Feb 2011) > New Revision: 34727 > > Added: > > platform/web/trunk/standard/src/main/webapp/resources/uicomponents/widgets/gallery/ > > platform/web/trunk/standard/src/main/webapp/resources/uicomponents/widgets/gallery/gallery.css > > platform/web/trunk/standard/src/main/webapp/resources/uicomponents/widgets/gallery/gallery.js > > platform/web/trunk/standard/src/main/webapp/resources/uicomponents/widgets/gallery/loading.gif > > platform/web/trunk/standard/src/main/webapp/resources/uicomponents/widgets/gallery/maximize.gif > > platform/web/trunk/standard/src/main/webapp/resources/uicomponents/widgets/gallery/minimize.gif > Log: > XWIKI-6010: Add a gallery macro to display images using a slide-show view > * Add resources to uicomponents/widgets/gallery > > > Added: > platform/web/trunk/standard/src/main/webapp/resources/uicomponents/widgets/gallery/gallery.css > =================================================================== > --- > platform/web/trunk/standard/src/main/webapp/resources/uicomponents/widgets/gallery/gallery.css > (rev 0) > +++ > platform/web/trunk/standard/src/main/webapp/resources/uicomponents/widgets/gallery/gallery.css > 2011-02-16 11:12:34 UTC (rev 34727) > @@ -0,0 +1,146 @@ > +#macro(ieOpacity $selector $value) > +/* start IE opacity setting */ > +$selector { > + /* We need to quote the property value because the equal sign is not > valid inside a CSS property value. */ > + -ms-filter: "progid:DXImageTransform.Microsoft.Alpha(Opacity=$value)"; > +} > + > +#foreach($item in $selector.split('\s*,\s*')) > +*+html $item, ## > +#end { > + /* This is for IE7, which doesn't accept the quoted value but > fortunately understands the escape syntax. */ > + filter: alpha(opacity\=$value); > + /* Unicode escape works too. */ > + /*filter: alpha(opacity\003d $value);*/ > +} > + > +#foreach($item in $selector.split('\s*,\s*')) > +* html $item, ## > +#end { > + /* This is for IE6, which doesn't understand the escaped equal sign (not > even the unicode escape) but fortunately accepts the quoted value. */ > + filter: "progid:DXImageTransform.Microsoft.Alpha(Opacity=$value)"; > +} > +/* end IE opacity setting */ > +#end > + > +#set($imageMaxWidth = 492) > +#set($imageMaxHeight = 369) > + > +.xGallery { > + background-color: black; > + padding: 10px; > + position: relative; > + width: ${mathtool.add($imageMaxWidth, 128)}px; > +} > + > +.xGallery.maximized { > + left: 0; > + position: absolute; > + top: 0; > + z-index: 1001; > +} > + > +.xGallery .currentImageWrapper { > + height: ${imageMaxHeight}px; > + line-height: ${imageMaxHeight}px; > + text-align: center; > + width: 100%; > +} > + > +.xGallery .currentImage { > + max-height: ${imageMaxHeight}px; > + max-width: ${imageMaxWidth}px; > + vertical-align: middle; > +} > + > +.xGallery .navigation { > + left: 0; > + margin-top: -64px; > + position: absolute; > + top: 50%; > + width: 100%; > +} > + > +.xGallery .previous, .xGallery .next { > + color: #A0A0A0; > + cursor: pointer; > + font-family: courier,monospace; > + font-size: 32px; > + font-weight: 100; > + height: 124px; > + line-height: 124px; > + text-align: center; > + width: 32px; > +} > + > +.xGallery .previous:hover, .xGallery .next:hover { > + color: white; > +} > + > +.xGallery .previous { > + float: left; > +} > + > +.xGallery .next { > + float: right; > +} > + > +.xGallery .index { > + bottom: 10px; > + color: #C0C0C0; > + font-family: sans-serif; > + font-size: smaller; > + left: 10px; > + position: absolute; > +} > + > +.xGallery .loading { > + background-image: url('loading.gif') !important; > +} > + > +.xGallery .focusCatcher { > + background-color: black; > + border: 0 none; > + color: black; > + height: 1px; > + left: 0; > + overflow: hidden; > + position: absolute; > + top: 0; > + width: 1px; > + z-index: -1; > +} > + > +.xGallery .maximize, .xGallery .minimize { > + cursor: pointer; > + height: 16px; > + opacity: .5; > + position: absolute; > + right: 10px; > + top: 10px; > + width: 16px; > +} > + > +.xGallery .maximize:hover, .xGallery .minimize:hover { > + opacity: 1; > +} > + > +#ieOpacity('.xGallery .maximize, .xGallery .minimize' 50) > + > +#ieOpacity('.xGallery .maximize:hover, .xGallery .minimize:hover' 100) > + > +.xGallery .maximize { > + background: transparent url('maximize.gif') no-repeat scroll center; > +} > + > +.xGallery .minimize { > + background: transparent url('minimize.gif') no-repeat scroll center; > +} > + > +html.maximized, html.maximized body { > + height: 100% !important; > + margin: 0 !important; > + overflow: hidden !important; > + padding: 0 !important; > + width: 100% !important; > +} > > > Property changes on: > platform/web/trunk/standard/src/main/webapp/resources/uicomponents/widgets/gallery/gallery.css > ___________________________________________________________________ > Added: svn:keywords > + Author Id Revision HeadURL > Added: svn:eol-style > + native > > Added: > platform/web/trunk/standard/src/main/webapp/resources/uicomponents/widgets/gallery/gallery.js > =================================================================== > --- > platform/web/trunk/standard/src/main/webapp/resources/uicomponents/widgets/gallery/gallery.js > (rev 0) > +++ > platform/web/trunk/standard/src/main/webapp/resources/uicomponents/widgets/gallery/gallery.js > 2011-02-16 11:12:34 UTC (rev 34727) > @@ -0,0 +1,139 @@ > +var XWiki = (function (XWiki) { > +// Start XWiki augmentation. > +XWiki.Gallery = Class.create({ > + initialize : function(container) { > + this.images = this._collectImages(container); > + > + this.container = container.update('<input type="text" tabindex="-1" > class="focusCatcher"/><div class="currentImageWrapper"><img > class="currentImage" alt="Current image"/></div><div class="navigation"><div > class="previous" title="Show previous image"><</div><div class="next" > title="Show next image">></div><div style="clear:both"></div></div><div > class="index">0 / 0</div><div class="maximize" title="Maximize"></div>'); > Titles will not be localized here + this.container.addClassName('xGallery'); > + > + this.focusCatcher = this.container.down('.focusCatcher'); > + this.focusCatcher.observe('keydown', > this._onKeyDown.bindAsEventListener(this)); > + this.container.observe('click', function() { > + this.focusCatcher.focus(); > + }.bind(this)); > + > + this.container.down('.previous').observe('click', > this._onPreviousImage.bind(this)); > + this.container.down('.next').observe('click', > this._onNextImage.bind(this)); > + > + this.currentImage = this.container.down('.currentImage'); > + this.currentImage.observe('load', this._onLoadImage.bind(this)); > + this.currentImage.observe('error', this._onErrorImage.bind(this)); > + this.currentImage.observe('abort', this._onAbortImage.bind(this)); > + > + this.indexDisplay = this.container.down('.index'); > + > + this.maximizeToggle = this.container.down('.maximize'); > + this.maximizeToggle.observe('click', > this._onToggleMaximize.bind(this)); > + > + this.show(0); > + }, > + _collectImages : function(container) { > + var images = []; > + var imageElements = container.getElementsByTagName('img'); > Why not use container.select('img') ? > + for(var i = 0; i < imageElements.length; i++) { > + var imageElement = imageElements[i]; > + images.push({url: imageElement.getAttribute('src'), title: > imageElement.title}); > + imageElement.removeAttribute('src'); > + } > + return images; > + }, > + _onPreviousImage : function() { > + this.show(this.index > 0 ? this.index - 1 : this.images.length - 1); > + }, > + _onNextImage : function() { > + this.show(this.index < this.images.length - 1 ? this.index + 1 : 0); > + }, > + _onLoadImage : function() { > + Element.removeClassName(this.currentImage.parentNode, 'loading'); > + this.currentImage.style.visibility = 'visible'; > + }, > + _onErrorImage: function() { > + }, > + _onAbortImage: function() { > + }, > + _onKeyDown : function(event) { > + var stop = true; > + switch(event.keyCode) { > + case Event.KEY_LEFT: > + this._onPreviousImage(); > + break; > + case Event.KEY_RIGHT: > + this._onNextImage(); > + break; > + case Event.KEY_HOME: > + this.show(0); > + break; > + case Event.KEY_END: > + this.show(this.images.length - 1); > + break; > + case Event.KEY_ESC: > + if (this.container.hasClassName('maximized')) { > + this._onToggleMaximize(); > + } > + break; > + case 70: /* F */ > + this._onToggleMaximize(); > + break; > + defualt: > + stop = false; > + break; > + } > + if (stop) { > + Event.stop(event); > + } > + }, > + _onToggleMaximize : function() { > + this.maximizeToggle.toggleClassName('maximize'); > + this.maximizeToggle.toggleClassName('minimize'); > + this.maximizeToggle.title = > this.maximizeToggle.hasClassName('maximize') ? 'Maximize' : 'Minimize'; > + this.container.toggleClassName('maximized'); > + $(document.documentElement).toggleClassName('maximized'); > + if (this.container.hasClassName('maximized')) { > + this._updateSize(); > + } else { > + this._resetSize(); > + } > + }, > + _updateSize : function() { > + var dimensions = document.viewport.getDimensions(); > + // Remove container padding; > + var width = dimensions.width - 20; > + var height = dimensions.height - 20; > + this.container.style.width = width + 'px'; > + this.container.style.height = height + 'px'; > + this.currentImage.parentNode.style.height = height + 'px'; > + this.currentImage.parentNode.style.lineHeight = height + 'px'; > I think as a best practice we should prefer prototype.js accessors versus. a mix of prototype helpers and native DOM properties. It's more consistent and more bug-proof in my opinion. I tend to always assume elements have been extended by prototype, but when the code mixes prototype.js and native accessors, you have greater chances to introduce non-extended elements as variables / members of your class that another developer will maybe miss. Here you would do this.currentImage.up().setStyle({ lineHeight: height + 'px' }) > + this.currentImage.style.maxHeight = height + 'px'; > + // Remove width reserved for the navigation arrows. > + this.currentImage.style.maxWidth = (width - 128) + 'px'; > + }, > + _resetSize : function() { > + this.container.style.cssText = ''; > + this.container.removeAttribute('style'); > + this.currentImage.parentNode.style.cssText = ''; > + this.currentImage.parentNode.removeAttribute('style'); > + this.currentImage.style.cssText = ''; > + this.currentImage.removeAttribute('style'); > + }, > + show : function(index) { > + if (index < 0 || index >= this.images.length || index == this.index) { > + return; > + } > + this.currentImage.style.visibility = 'hidden'; > + Element.addClassName(this.currentImage.parentNode, 'loading'); > + this.currentImage.title = this.images[index].title; > + this.currentImage.src = this.images[index].url; > + this.index = index; > + this.indexDisplay.firstChild.nodeValue = (index + 1) + ' / ' + > this.images.length; > Same for firstChild.nodeValue, I would prefer .down().update() > + } > +}); > +// End XWiki augmentation. > +return XWiki; > +}(XWiki || {})); > + > +Element.observe(document, "dom:loaded", function() { > + $$('.gallery').each(function(gallery) { > Same remark as for the dashboard macro, IMO this is too greedy and $mainContentArea.select('.gallery') would perform better. The problem is not really each such selector taken individually, but if we continue adding more and more, it will make the loading after DOM is loaded clumsy. Jerome. > + new XWiki.Gallery(gallery); > + }); > +}); > > > Property changes on: > platform/web/trunk/standard/src/main/webapp/resources/uicomponents/widgets/gallery/gallery.js > ___________________________________________________________________ > Added: svn:keywords > + Author Id Revision HeadURL > Added: svn:eol-style > + native > > Added: > platform/web/trunk/standard/src/main/webapp/resources/uicomponents/widgets/gallery/loading.gif > =================================================================== > (Binary files differ) > > > Property changes on: > platform/web/trunk/standard/src/main/webapp/resources/uicomponents/widgets/gallery/loading.gif > ___________________________________________________________________ > Added: svn:mime-type > + image/gif > > Added: > platform/web/trunk/standard/src/main/webapp/resources/uicomponents/widgets/gallery/maximize.gif > =================================================================== > (Binary files differ) > > > Property changes on: > platform/web/trunk/standard/src/main/webapp/resources/uicomponents/widgets/gallery/maximize.gif > ___________________________________________________________________ > Added: svn:mime-type > + image/gif > > Added: > platform/web/trunk/standard/src/main/webapp/resources/uicomponents/widgets/gallery/minimize.gif > =================================================================== > (Binary files differ) > > > Property changes on: > platform/web/trunk/standard/src/main/webapp/resources/uicomponents/widgets/gallery/minimize.gif > ___________________________________________________________________ > Added: svn:mime-type > + image/gif > > _______________________________________________ > notifications mailing list > notifications(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/notifications >

14 years, 7 months

3
7
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

xwiki-devs