- xwiki-devs@xwiki.org - lists.xwiki.org

[xwiki-devs] WYSIWYG editor loading time

by Marius Dumitru Florea

Hi devs, I noticed today that the time spent by Hudson to run all the WYSIWYG selenium tests (274) has increased from 19 to 22 minutes although the number of tests didn't change much from XE 2.4 and neither the tests' code. I wanted to know if this was caused by an increased WYSIWYG editor loading time so I did a quick profiling using Firefox 3.6.10 and Firebug 1.5.4. The WYSIWYG editor loading time (alone, excluding other artifacts on the host page) has three components: (T1) time to interpret the WYSIWYG editor JavaScript code (~530KB) (T2) time to load the edited document in the in-line frame (T3) time to load the editor plugins and to initialize the UI (menu, tool bar) It seems that (T3) is: * XE 2.4 -> 219.128ms, 26753 calls * XE 2.5 -> 242.968ms, 28282 calls Next I checked with Firebug's Net tab the page loading time. In order to test the editor alone I created a simple velocity template (wysiwyg.vm) that includes only the editor (plus the JavaScript and stylesheets needed by the editor). XE 2.4 ------ 4.35s -> WYSIWYG edit mode with SmartClient 2.47s -> WYSIWYG edit mode without SmartClient 3.4s -> xpage=wysiwyg with SmartClient 1.7s -> xpage=wysiwyg without SmartClient XE 2.5 ------ 3.9s -> WYSIWYG edit mode with SmartClient 2s -> WYSIWYG edit mode without SmartClient 3.2s -> xpage=wysiwyg with SmartClient 1.3s -> xpage=wysiwyg without SmartClient So the overall page loading time in edit mode has decreased. Also note that SmartClient adds a lot of time and it is used only for the XWiki Explorer tree.. This means the increased time spent on WYSIWYG selenium tests is caused by something else. Thanks, Marius

14 years, 11 months

2
1
0 0

[xwiki-devs] [VOTE] Stop supporting the Albatross skin

by Sergiu Dumitriu

Hi devs, I'd like to propose that we don't maintain the Albatross skin anymore, since it's time consuming to port all the UI improvements and fixes to it. The skin will not be removed from the distribution yet, since it's still the base skin on which Toucan and Colibri are built, although we should try to fix this dependency in the near future. -- Sergiu Dumitriu http://purl.org/net/sergiu/

14 years, 11 months

11
15
0 0

[xwiki-devs] Create a trunks for enterprise/ in SVN

by Vincent Massol

Hi devs, I'd like to create svn externals for enterprise in enterprise/trunks that would build both platform and enterprise. I would put a pom.xml in trunks for doing that. The need is to have a single maven multi module project to run Clover on (otherwise it's more complex for setting up Clover). WDYT? Thanks -Vincent

14 years, 11 months

4
9
0 0

Re: [xwiki-devs] [xwiki-notifications] r31913 - platform/xwiki-applications/trunk/administration

by Vincent Massol

Hi Sergiu, On Oct 17, 2010, at 3:33 AM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2010-10-17 03:33:22 +0200 (Sun, 17 Oct 2010) > New Revision: 31913 > > Modified: > platform/xwiki-applications/trunk/administration/pom.xml > Log: > [misc] New version number > > Modified: platform/xwiki-applications/trunk/administration/pom.xml > =================================================================== > --- platform/xwiki-applications/trunk/administration/pom.xml 2010-10-17 01:10:40 UTC (rev 31912) > +++ platform/xwiki-applications/trunk/administration/pom.xml 2010-10-17 01:33:22 UTC (rev 31913) > @@ -31,7 +31,7 @@ > </parent> > <artifactId>xwiki-application-administration</artifactId> > <name>XWiki Platform - Applications - Administration</name> > - <version>1.42-SNAPSHOT</version> > + <version>2.0-SNAPSHOT</version> Why are we doing this? Did we agree about a strategy? I'm worried about aligning versions for all apps in case we decided something. Thanks -Vincent > <packaging>xar</packaging> > <description>Application for administrating wiki features like users, groups, rights etc.</description> > <!-- We must configure SCM in each module. For more information see:

14 years, 11 months

2
1
0 0

[xwiki-devs] Remove com.xpn.xwiki.test.smtp package

by Vincent Massol

Hi, I'd like to remove this package which doesn't seem to be used and is something used for testing and thus has nothing to do in src/main/java. In addition for tests we now use Greenmail. Please let me know if you think this is used somewhere and I've missed it. Thanks -Vincent

14 years, 11 months

4
3
0 0

[xwiki-devs] [Proposal][UX] Administration with vertical tabs

by Ecaterina Valica

This is a proposal for a new Administration UI having vertical tabs for grouping instead of the current select input. Proposal: http://incubator.myxwiki.org/xwiki/bin/view/Improvements/Administration Category: http://incubator.myxwiki.org/xwiki/bin/download/Improvements/Administration… Section: http://incubator.myxwiki.org/xwiki/bin/download/Improvements/Administration… The vertical tab could be also integrated into the User Profile: http://incubator.myxwiki.org/xwiki/bin/view/Improvements/Administration#pro… This proposal is made using CSS3 rules. The degradation of the tabs: http://incubator.myxwiki.org/xwiki/bin/download/Improvements/Administration… Thanks, Caty

14 years, 11 months

9
16
0 0

[xwiki-devs] [Announcement] XWiki Enterprise 2.5 Release Candidate 1 Released

by Sergiu Dumitriu

The XWiki development team is pleased to announce the release of XWiki Enterprise 2.5 Release Candidate 1. Go grab it at http://www.xwiki.org/xwiki/bin/view/Main/Download Main changes since XWiki Enterprise 2.5 Milestone 2: * New macros for the Space List and Tag Cloud * Display user avatars in annotations * A few improvements to the Extension Manager * A few improvements to the User Directory * WYSIWYG and Rendering improvements * A few security and performance improvements For more information see the Release notes at http://www.xwiki.org/xwiki/bin/Main/ReleaseNotesXWikiEnterprise25RC1 Thanks -The XWiki dev team

14 years, 11 months

1
0
0 0

[xwiki-devs] [proposal] Add public void setContent(InputStream is) throws IOException to c.x.x.doc.XWikiAttachment.

by Caleb James DeLisle

This is just a small API change proposal. Since my implementation changes for XWikiAttachment store the attachment content in a temp file rather than a byte array, there is no need to require the user to provide the length of the provided stream and in many cases (upload for instance) this number is very difficult to determine in advance. I propose we add: public void setContent(InputStream is) throws IOException In addition to the existing: public void setContent(InputStream is, int length) throws IOException WDYT? Caleb

14 years, 11 months

4
5
0 0

[xwiki-devs] [discussion] The future of attachments and attachment versioning.

by Caleb James DeLisle

Hi, I have some changes to the attachment system which will allow XWiki to handle much larger attachments without memory exhaustion. I have found that there are some places where I cannot make any changes because the code is not in XWiki but rather in JRCS. XWiki versions attachments by creating a JRCS node for the XML version of each version of each attachment. This means that memory consumption improvements hit a hard wall at 2 * 2 * 1.3 * the size of the attachment. base-64 encoding for XML increases the size by 1.3 times, storage as a String (array of 16 bit chars) doubles the size and the need to copy the String doubles the size again. The second issue is that the database and JDBC do not handle multiple hundreds of megabytes in a single query well. If I try to attach a 500MB attachment with attachment versioning disabled, my changes allow the attachment to be streamed to the database but postgresql is not able to save it. I am able to attach a 256MB attachment but with 512MB of heap space, the attachment cannot be loaded from the database because JDBC lacks the necessary streaming functionality. An option which I am now considering is adding a binary table to the database schema. The table would contain a composite id made of the id of the data and the part number of that entry, and a data column slightly smaller than 1MB (default max_allowed_packet in mysql). All interaction with this table would go through a storage engine which would require InputStreams and OutputStreams and the streams would be written and read by the storage mechanism which would ID tag them and break them up into parts to be sent to the database individually. WDYT? Caleb

14 years, 11 months

2
2
0 0

[xwiki-devs] [VOTE] Better release strategy

by Sergiu Dumitriu

Hi devs, I don't think that Monday is a good day for releases, since voting over the weekend is not a good thing. Thus, I propose to move the general release day to the Thursday of the week. The current release process doesn't really follow the VOTE rules, since the way it's done is: send vote mail at 10AM, wait a few hours, start the release around 1PM. The rule for VOTE emails is to wait for three days. Thus: - Send release VOTE on Monday - Prepare the release during the following three days (release plan, release notes) - Perform the maven release on Thursday, request tests for publishing the release (testing of the build) - Finalize the release on Friday (download, announcements, version update) -- Sergiu Dumitriu http://purl.org/net/sergiu/

14 years, 11 months

10
9
0 0

[xwiki-devs] CSS content placeholder when customizing a skin

by Bogdan Flueras

Hello Xwiki devs, I want to customize the COLIBRI skin.. for the very beginning just the colibry.css file. Basically I've just added a few lines to the original file. I don't want to paste into the 'style' text area ( http://localhost:8080/xwiki/bin/edit/XWiki/RtSkin?editor=object) the whole content of the css file because like I said it has minor additions not modifications. Furthermore when a modification is done to the default colibry.css file, mine's will be deprecated! So do you happen to know if there is a placeholder for the default colibry.css file? To make myself clear, I've painted a pictogram : Style________________________________ | %{placeholder for original Colibry.css}% | | AND here are my additions | |____________________________________| -- ing. Flueras Bogdan

14 years, 11 months

4
4
0 0

Re: [xwiki-devs] [xwiki-notifications] r31772 - platform/pom/trunk

by Vincent Massol

oops that was committed by error.... -Vincent On Oct 14, 2010, at 10:53 AM, vmassol (SVN) wrote: > Author: vmassol > Date: 2010-10-14 10:53:33 +0200 (Thu, 14 Oct 2010) > New Revision: 31772 > > Modified: > platform/pom/trunk/pom.xml > Log: > Fixed parent dependency version > > > Modified: platform/pom/trunk/pom.xml > =================================================================== > --- platform/pom/trunk/pom.xml 2010-10-14 08:34:58 UTC (rev 31771) > +++ platform/pom/trunk/pom.xml 2010-10-14 08:53:33 UTC (rev 31772) > @@ -537,6 +537,10 @@ > PrmNWuONRNMnMoPnQRMWWNQPqnnrqRmMrqTuWtUVwStROo > PrnmqmUUnounqquummmmmUUnounqquummmmmUUONfhfUUn > mmmm]]></license> > +  > + <includesTestSourceRoots>false</includesTestSourceRoots> > + <cloverDatabase>${user.home}/.xwiki/clover/clover.db</cloverDatabase> > </configuration> > </plugin> > <plugin> > @@ -718,7 +722,10 @@ > </plugins> > </build> > </profile> > -  > +  > +  > <profile> > <id>clover</id> > <properties> > @@ -727,41 +734,6 @@ >  > <xwiki.clirr.skip>true</xwiki.clirr.skip> > </properties> > - <reporting> > - <plugins> > - <plugin> > - <groupId>com.atlassian.maven.plugins</groupId> > - <artifactId>maven-clover2-plugin</artifactId> > - </plugin> > - </plugins> > - </reporting> > - <build> > - <plugins> > -  > - <plugin> > - <groupId>com.atlassian.maven.plugins</groupId> > - <artifactId>maven-clover2-plugin</artifactId> > - <executions> > - <execution> > - <id>main</id> > - <phase>verify</phase> > - <goals> > - <goal>instrument</goal> > - <goal>aggregate</goal> > - </goals> > - </execution> > - <execution> > - <id>site</id> > - <phase>pre-site</phase> > - <goals> > - <goal>instrument</goal> > - <goal>aggregate</goal> > - </goals> > - </execution> > - </executions> > - </plugin> > - </plugins> > - </build> > </profile> > <profile> > <!-- We run Cobertura in a profile since Cobertura interferes with Clirr and thus we run

14 years, 11 months

1
0
0 0

Re: [xwiki-devs] [xwiki-notifications] r31742 - platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/usersandgroups

by Ecaterina Valica

How about <th width="50px"> in the HTML (like on http://l10n.xwiki.org/xwiki/bin/view/L10N/ ) so that it works also for IE6? Caty On Tue, Oct 12, 2010 at 22:37, sdumitriu <platform-notifications(a)xwiki.org>wrote: > Author: sdumitriu > Date: 2010-10-12 21:37:35 +0200 (Tue, 12 Oct 2010) > New Revision: 31742 > > Modified: > > platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/usersandgroups/usersandgroups.css > Log: > XWIKI-5572: Make the avatar column in the User Directory smaller > Done. > > Modified: > platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/usersandgroups/usersandgroups.css > =================================================================== > --- > platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/usersandgroups/usersandgroups.css > 2010-10-12 18:53:36 UTC (rev 31741) > +++ > platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/usersandgroups/usersandgroups.css > 2010-10-12 19:37:35 UTC (rev 31742) > @@ -78,4 +78,9 @@ > > tr.userorgroups-header { > background-color:#DDDDDD; > -} > \ No newline at end of file > +} > + > +/* Make the avatar column smaller */ > +table#groupusers th.xwiki-livetable-display-header-text:first-child { > + width: 50px; > +} > > _______________________________________________ > notifications mailing list > notifications(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/notifications >

14 years, 11 months

2
1
0 0

[xwiki-devs] Fwd: [hibernate-dev] Hibernate Core is now using Git

by Caleb James DeLisle

Moving to github is an interesting solution, also it looks like they only gitified branches and tags on an "as needed" basis. Caleb -------- Original Message -------- Subject: [hibernate-dev] Hibernate Core is now using Git Date: Thu, 7 Oct 2010 11:30:11 +0200 From: Emmanuel Bernard <emmanuel(a)hibernate.org> To: hibernate-dev(a)lists.jboss.org Hibernate Core now uses Git as the version control system. You can access it at http://github.com/hibernate/hibernate-core Core on Git We have imported the SVN history (at least what GIT could extract) and pushed the SVN trunk, branch 3.5 and branch 3.3. If you need more of the legacy branches or tags, let me know, that can be arranged. If you want to contribute a fix or new feature, either use the pure Git approach, or use the GitHub fork capability (see http://help.github.com/forking/ and http://help.github.com/pull-requests/ ) The benefit of the GitHub approach is that we can comment on the pull request and code though I am far from an expert so far and their flow could easily be improved (slightly confusing). If you still want to do it the old way a provide a patch file, that's ok too. Tips on Git Here are some tips on Git: o read Pro Git http://progit.org/book/ awesome book and very practical. It has a free html and epub version (buying the tree version is recommended to repay the author). o prefer the git protocol when cloning over http (so say the experts). At the very least that will be much faster. cloning the repo from GitHub took me less than 3 minutes #for people with read/write access git clone git@github.com:hibernate/hibernate-core.git #for people with read-only access git clone git://github.com/hibernate/hibernate-core.git It will create a "remote" link named origin. I usually tend to rename it to reflect what it is really. git remote rename origin core-on-github o always work on a topic branch and merge your work when you are done git checkout master git checkout -b HHH-XXX hack commit hack commit Likewise if you want to share a work with somebody from the Hibernate team, push or define the pull request of your topic branch (though make sure your topic branch is above master). o prefer small commits, they will be more readable and will very unlikely fail on merge o write good comments (short one line including the issue at stack followed by a blank line and a more detailed explanation if needed) `HHH-XXX Fix NPE on persist Fix stupid bug by Gavin that lead to a NPE when persisting objects with components` o prefer rebase over merge Rebase put changes from the branch you forked below the new commits you have done and thus keep the history linear. got checkout HHH-XXX git rebase master DO NOT rebase a branch that you have shared publicly (unless you know people won't use it or you wish them harm). o while you are at rebasing, you can rewrite your commit history to clean comments or merge some commits together (named squashing) git rebase -i HEAD~6 (go back 6 commits in time) o once you're fed up with typing longish command lines, use aliases (see below) o I've put a copy of my ~/.gitconfig file in case people want to copy some things including aliases (see below) o if you use Mac OS X, GitX is a fantastic tool, in particular to do interactive staging and commit only some parts of a file o you can read this blog entry that was some more info http://blog.emmanuelbernard.com/2010/05/git-how-my-life-has-improved-since-… o feel free to add your tips to this email thread, I'll likely compile them in a blog entry. ~/.gitconfig [user] name = Redacted email = redacted(a)redacted.com signingkey = id_key.pub [core] editor = open -nW -a Smultron [merge] tool = opendiff [color] ui = auto [color "branch"] current = yellow reverse local = yellow remote = green [color "diff"] meta = yellow bold frag = magenta bold old = red bold new = green bold [color "status"] added = yellow changed = green untracked = cyan [github] user = redacted token = redacted [alias] co = checkout undo = reset --hard cb = checkout -b br = branch cp = cherry-pick _______________________________________________ hibernate-dev mailing list hibernate-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

14 years, 11 months

1
0
0 0

Re: [xwiki-devs] [xwiki-notifications] r31733 - in platform/core/trunk/xwiki-rendering: xwiki-rendering-api/src/main/java/org/xwiki/rendering/macro/parameter xwiki-rendering-macros/xwiki-rendering-macro-toc xwiki-rendering-macros/xwiki-rendering-macr

by Thomas Mortagne

On Tue, Oct 12, 2010 at 15:45, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote: > On 10/12/2010 02:03 PM, tmortagne (SVN) wrote: >> Author: tmortagne >> Date: 2010-10-12 14:03:53 +0200 (Tue, 12 Oct 2010) >> New Revision: 31733 >> >> Added: >> platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/test/resources/macrotoc11.test >> Modified: >> platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/macro/parameter/ParameterValueTooHighException.java >> platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/macro/parameter/ParameterValueTooLowException.java >> platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/pom.xml >> platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/main/java/org/xwiki/rendering/macro/toc/TocMacroParameters.java >> platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/test/java/org/xwiki/rendering/RenderingTests.java >> Log: >> XWIKI-5571: Toc macro parameters bean should use standard Java bean validator >> Also deprecated two exceptions that are useless since xwiki-properties is executing Java bean validation >> >> Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/macro/parameter/ParameterValueTooHighException.java >> =================================================================== >> --- platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/macro/parameter/ParameterValueTooHighException.java 2010-10-12 11:18:57 UTC (rev 31732) >> +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/macro/parameter/ParameterValueTooHighException.java 2010-10-12 12:03:53 UTC (rev 31733) >> @@ -23,7 +23,9 @@ >> * Exception used when the macro parameter is two high. >> * >> * @version $Id$ >> + * @deprecated use {@link javax.validation.constraints.Max} instead >> */ >> +@Deprecated >> public class ParameterValueTooHighException extends MacroParameterException >> { >> /** >> >> Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/macro/parameter/ParameterValueTooLowException.java >> =================================================================== >> --- platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/macro/parameter/ParameterValueTooLowException.java 2010-10-12 11:18:57 UTC (rev 31732) >> +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/macro/parameter/ParameterValueTooLowException.java 2010-10-12 12:03:53 UTC (rev 31733) >> @@ -23,7 +23,9 @@ >> * Exception used when the macro parameter is two low. >> * >> * @version $Id$ >> + * @deprecated use {@link javax.validation.constraints.Min} instead >> */ >> +@Deprecated >> public class ParameterValueTooLowException extends MacroParameterException >> { >> /** >> >> Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/pom.xml >> =================================================================== >> --- platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/pom.xml 2010-10-12 11:18:57 UTC (rev 31732) >> +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/pom.xml 2010-10-12 12:03:53 UTC (rev 31733) >> @@ -32,4 +32,12 @@ >> <artifactId>xwiki-core-rendering-macro-toc</artifactId> >> <name>XWiki Platform - Core - Rendering - Macro - Toc</name> >> <description>XWiki Platform - Core - Rendering - Macro - Toc</description> >> +<dependencies> >> +<dependency> >> +<groupId>org.hibernate</groupId> >> +<artifactId>hibernate-validator</artifactId> >> +<version>4.0.2.GA</version> >> +<scope>test</scope> >> +</dependency> >> +</dependencies> >> </project> >> >> Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/main/java/org/xwiki/rendering/macro/toc/TocMacroParameters.java >> =================================================================== >> --- platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/main/java/org/xwiki/rendering/macro/toc/TocMacroParameters.java 2010-10-12 11:18:57 UTC (rev 31732) >> +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/main/java/org/xwiki/rendering/macro/toc/TocMacroParameters.java 2010-10-12 12:03:53 UTC (rev 31733) >> @@ -19,8 +19,9 @@ >> */ >> package org.xwiki.rendering.macro.toc; >> >> +import javax.validation.constraints.Min; >> + >> import org.xwiki.properties.annotation.PropertyDescription; >> -import org.xwiki.rendering.macro.parameter.ParameterValueTooLowException; >> >> /** >> * Parameters for the {@link org.xwiki.rendering.internal.macro.toc.TocMacro} Macro. >> @@ -49,6 +50,7 @@ >> /** >> * The minimum section level. For example if 2 then level 1 sections will not be listed. >> */ >> + @Min(1) >> private int start = 1; >> >> /** >> @@ -59,6 +61,7 @@ >> /** >> * The maximum section level. For example if 3 then all section levels from 4 will not be listed. >> */ >> + @Min(1) >> private int depth = 6; >> >> /** >> @@ -74,15 +77,10 @@ >> >> /** >> * @param start the minimum section level. For example if 2 then level 1 sections will not be listed. >> - * @throws ParameterValueTooLowException the provided value is too low, it needs to be>= 1. >> */ >> @PropertyDescription("the minimum section level. For example if 2 then level 1 sections will not be listed") >> - public void setStart(int start) throws ParameterValueTooLowException >> + public void setStart(int start) >> { >> - if (start< 1) { >> - throw new ParameterValueTooLowException(1); >> - } >> - >> this.start = start; >> this.customStart = true; >> } >> @@ -105,16 +103,11 @@ >> >> /** >> * @param depth the maximum section level. For example if 3 then all section levels from 4 will not be listed. >> - * @throws ParameterValueTooLowException the provided value is too low, it needs to be>= 1. >> */ >> @PropertyDescription("the maximum section level. " >> + "For example if 3 then all section levels from 4 will not be listed") >> - public void setDepth(int depth) throws ParameterValueTooLowException >> + public void setDepth(int depth) >> { >> - if (depth< 1) { >> - throw new ParameterValueTooLowException(1); >> - } >> - >> this.depth = depth; >> } >> >> >> Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/test/java/org/xwiki/rendering/RenderingTests.java >> =================================================================== >> --- platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/test/java/org/xwiki/rendering/RenderingTests.java 2010-10-12 11:18:57 UTC (rev 31732) >> +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/test/java/org/xwiki/rendering/RenderingTests.java 2010-10-12 12:03:53 UTC (rev 31733) >> @@ -35,7 +35,7 @@ >> { >> public static Test suite() throws Exception >> { >> - RenderingTestSuite suite = new RenderingTestSuite("Test Toc Macro"); >> + RenderingTestSuite suite = new RenderingTestSuite("Test Toc Macro", "", "macrotoc11.test"); >> return new ComponentManagerTestSetup(suite); >> } >> } >> >> Added: platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/test/resources/macrotoc11.test >> =================================================================== >> --- platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/test/resources/macrotoc11.test (rev 0) >> +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/test/resources/macrotoc11.test 2010-10-12 12:03:53 UTC (rev 31733) >> @@ -0,0 +1,81 @@ >> +.runTransformations >> +.#----------------------------------------------------- >> +.input|xwiki/2.0 >> +.# Verify the TOC produce error when "start" or "depth" parameters are too low >> +.#----------------------------------------------------- >> +{{toc start="0"/}} >> + >> +{{toc depth="0"/}} >> +.#----------------------------------------------------- >> +.expect|event/1.0 >> +.#----------------------------------------------------- >> +beginDocument >> +beginMacroMarkerStandalone [toc] [start=0] >> +beginGroup [[class]=[xwikirenderingerror]] >> +onWord [Invalid macro parameters used for the "toc" macro] >> +endGroup [[class]=[xwikirenderingerror]] >> +beginGroup [[class]=[xwikirenderingerrordescription hidden]] > > This stacktrace looks really fragile, any changes in the source files > will prompt redoing the test file. Yes i already changed that to do "traditional" unit tests instead. > >> +onVerbatim [org.xwiki.properties.PropertyException: Failed to validate bean: [must be greater than or equal to 1] >> + at org.xwiki.properties.internal.DefaultBeanManager.validateBean(DefaultBeanManager.java:178) >> + at org.xwiki.properties.internal.DefaultBeanManager.populate(DefaultBeanManager.java:113) >> + at org.xwiki.rendering.internal.transformation.MacroTransformation.transformOnce(MacroTransformation.java:158) >> + at org.xwiki.rendering.internal.transformation.MacroTransformation.transform(MacroTransformation.java:117) >> + at org.xwiki.rendering.internal.transformation.DefaultTransformationManager.performTransformations(DefaultTransformationManager.java:85) >> + at org.xwiki.rendering.scaffolding.RenderingTestCase.runTestInternal(RenderingTestCase.java:126) >> + at org.xwiki.rendering.scaffolding.RenderingTestCase.runTest(RenderingTestCase.java:99) >> + at org.jmock.core.VerifyingTestCase.runBare(VerifyingTestCase.java:39) >> + at junit.framework.TestResult$1.protect(TestResult.java:110) >> + at junit.framework.TestResult.runProtected(TestResult.java:128) >> + at junit.framework.TestResult.run(TestResult.java:113) >> + at junit.framework.TestCase.run(TestCase.java:124) >> + at junit.framework.TestSuite.runTest(TestSuite.java:232) >> + at junit.framework.TestSuite.run(TestSuite.java:227) >> + at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24) >> + at junit.extensions.TestSetup$1.protect(TestSetup.java:23) >> + at junit.framework.TestResult.runProtected(TestResult.java:128) >> + at junit.extensions.TestSetup.run(TestSetup.java:27) >> + at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:79) >> + at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:49) >> + at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38) >> + at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467) >> + at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683) >> + at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390) >> + at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197) >> +] [false] >> +endGroup [[class]=[xwikirenderingerrordescription hidden]] >> +endMacroMarkerStandalone [toc] [start=0] >> +beginMacroMarkerStandalone [toc] [depth=0] >> +beginGroup [[class]=[xwikirenderingerror]] >> +onWord [Invalid macro parameters used for the "toc" macro] >> +endGroup [[class]=[xwikirenderingerror]] >> +beginGroup [[class]=[xwikirenderingerrordescription hidden]] >> +onVerbatim [org.xwiki.properties.PropertyException: Failed to validate bean: [must be greater than or equal to 1] >> + at org.xwiki.properties.internal.DefaultBeanManager.validateBean(DefaultBeanManager.java:178) >> + at org.xwiki.properties.internal.DefaultBeanManager.populate(DefaultBeanManager.java:113) >> + at org.xwiki.rendering.internal.transformation.MacroTransformation.transformOnce(MacroTransformation.java:158) >> + at org.xwiki.rendering.internal.transformation.MacroTransformation.transform(MacroTransformation.java:117) >> + at org.xwiki.rendering.internal.transformation.DefaultTransformationManager.performTransformations(DefaultTransformationManager.java:85) >> + at org.xwiki.rendering.scaffolding.RenderingTestCase.runTestInternal(RenderingTestCase.java:126) >> + at org.xwiki.rendering.scaffolding.RenderingTestCase.runTest(RenderingTestCase.java:99) >> + at org.jmock.core.VerifyingTestCase.runBare(VerifyingTestCase.java:39) >> + at junit.framework.TestResult$1.protect(TestResult.java:110) >> + at junit.framework.TestResult.runProtected(TestResult.java:128) >> + at junit.framework.TestResult.run(TestResult.java:113) >> + at junit.framework.TestCase.run(TestCase.java:124) >> + at junit.framework.TestSuite.runTest(TestSuite.java:232) >> + at junit.framework.TestSuite.run(TestSuite.java:227) >> + at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24) >> + at junit.extensions.TestSetup$1.protect(TestSetup.java:23) >> + at junit.framework.TestResult.runProtected(TestResult.java:128) >> + at junit.extensions.TestSetup.run(TestSetup.java:27) >> + at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:79) >> + at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:49) >> + at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38) >> + at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467) >> + at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683) >> + at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390) >> + at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197) >> +] [false] >> +endGroup [[class]=[xwikirenderingerrordescription hidden]] >> +endMacroMarkerStandalone [toc] [depth=0] >> +endDocument >> \ No newline at end of file > > > -- > Sergiu Dumitriu > http://purl.org/net/sergiu/ > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs > -- Thomas Mortagne

14 years, 11 months

1
0
0 0

Re: [xwiki-devs] [xwiki-notifications] r31733 - in platform/core/trunk/xwiki-rendering: xwiki-rendering-api/src/main/java/org/xwiki/rendering/macro/parameter xwiki-rendering-macros/xwiki-rendering-macro-toc xwiki-rendering-macros/xwiki-rendering-macro-toc/src/main/java/org/xwiki/rendering/macro/toc xwiki-rendering-macros/xwiki-rendering-macro-toc/src/test/java/org/xwiki/rendering xwiki-rendering-macros/xwiki-rendering-macro-toc/src/test/resources

by Sergiu Dumitriu

On 10/12/2010 02:03 PM, tmortagne (SVN) wrote: > Author: tmortagne > Date: 2010-10-12 14:03:53 +0200 (Tue, 12 Oct 2010) > New Revision: 31733 > > Added: > platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/test/resources/macrotoc11.test > Modified: > platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/macro/parameter/ParameterValueTooHighException.java > platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/macro/parameter/ParameterValueTooLowException.java > platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/pom.xml > platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/main/java/org/xwiki/rendering/macro/toc/TocMacroParameters.java > platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/test/java/org/xwiki/rendering/RenderingTests.java > Log: > XWIKI-5571: Toc macro parameters bean should use standard Java bean validator > Also deprecated two exceptions that are useless since xwiki-properties is executing Java bean validation > > Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/macro/parameter/ParameterValueTooHighException.java > =================================================================== > --- platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/macro/parameter/ParameterValueTooHighException.java 2010-10-12 11:18:57 UTC (rev 31732) > +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/macro/parameter/ParameterValueTooHighException.java 2010-10-12 12:03:53 UTC (rev 31733) > @@ -23,7 +23,9 @@ > * Exception used when the macro parameter is two high. > * > * @version $Id$ > + * @deprecated use {@link javax.validation.constraints.Max} instead > */ > +@Deprecated > public class ParameterValueTooHighException extends MacroParameterException > { > /** > > Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/macro/parameter/ParameterValueTooLowException.java > =================================================================== > --- platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/macro/parameter/ParameterValueTooLowException.java 2010-10-12 11:18:57 UTC (rev 31732) > +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/macro/parameter/ParameterValueTooLowException.java 2010-10-12 12:03:53 UTC (rev 31733) > @@ -23,7 +23,9 @@ > * Exception used when the macro parameter is two low. > * > * @version $Id$ > + * @deprecated use {@link javax.validation.constraints.Min} instead > */ > +@Deprecated > public class ParameterValueTooLowException extends MacroParameterException > { > /** > > Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/pom.xml > =================================================================== > --- platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/pom.xml 2010-10-12 11:18:57 UTC (rev 31732) > +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/pom.xml 2010-10-12 12:03:53 UTC (rev 31733) > @@ -32,4 +32,12 @@ > <artifactId>xwiki-core-rendering-macro-toc</artifactId> > <name>XWiki Platform - Core - Rendering - Macro - Toc</name> > <description>XWiki Platform - Core - Rendering - Macro - Toc</description> > +<dependencies> > +<dependency> > +<groupId>org.hibernate</groupId> > +<artifactId>hibernate-validator</artifactId> > +<version>4.0.2.GA</version> > +<scope>test</scope> > +</dependency> > +</dependencies> > </project> > > Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/main/java/org/xwiki/rendering/macro/toc/TocMacroParameters.java > =================================================================== > --- platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/main/java/org/xwiki/rendering/macro/toc/TocMacroParameters.java 2010-10-12 11:18:57 UTC (rev 31732) > +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/main/java/org/xwiki/rendering/macro/toc/TocMacroParameters.java 2010-10-12 12:03:53 UTC (rev 31733) > @@ -19,8 +19,9 @@ > */ > package org.xwiki.rendering.macro.toc; > > +import javax.validation.constraints.Min; > + > import org.xwiki.properties.annotation.PropertyDescription; > -import org.xwiki.rendering.macro.parameter.ParameterValueTooLowException; > > /** > * Parameters for the {@link org.xwiki.rendering.internal.macro.toc.TocMacro} Macro. > @@ -49,6 +50,7 @@ > /** > * The minimum section level. For example if 2 then level 1 sections will not be listed. > */ > + @Min(1) > private int start = 1; > > /** > @@ -59,6 +61,7 @@ > /** > * The maximum section level. For example if 3 then all section levels from 4 will not be listed. > */ > + @Min(1) > private int depth = 6; > > /** > @@ -74,15 +77,10 @@ > > /** > * @param start the minimum section level. For example if 2 then level 1 sections will not be listed. > - * @throws ParameterValueTooLowException the provided value is too low, it needs to be>= 1. > */ > @PropertyDescription("the minimum section level. For example if 2 then level 1 sections will not be listed") > - public void setStart(int start) throws ParameterValueTooLowException > + public void setStart(int start) > { > - if (start< 1) { > - throw new ParameterValueTooLowException(1); > - } > - > this.start = start; > this.customStart = true; > } > @@ -105,16 +103,11 @@ > > /** > * @param depth the maximum section level. For example if 3 then all section levels from 4 will not be listed. > - * @throws ParameterValueTooLowException the provided value is too low, it needs to be>= 1. > */ > @PropertyDescription("the maximum section level. " > + "For example if 3 then all section levels from 4 will not be listed") > - public void setDepth(int depth) throws ParameterValueTooLowException > + public void setDepth(int depth) > { > - if (depth< 1) { > - throw new ParameterValueTooLowException(1); > - } > - > this.depth = depth; > } > > > Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/test/java/org/xwiki/rendering/RenderingTests.java > =================================================================== > --- platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/test/java/org/xwiki/rendering/RenderingTests.java 2010-10-12 11:18:57 UTC (rev 31732) > +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/test/java/org/xwiki/rendering/RenderingTests.java 2010-10-12 12:03:53 UTC (rev 31733) > @@ -35,7 +35,7 @@ > { > public static Test suite() throws Exception > { > - RenderingTestSuite suite = new RenderingTestSuite("Test Toc Macro"); > + RenderingTestSuite suite = new RenderingTestSuite("Test Toc Macro", "", "macrotoc11.test"); > return new ComponentManagerTestSetup(suite); > } > } > > Added: platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/test/resources/macrotoc11.test > =================================================================== > --- platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/test/resources/macrotoc11.test (rev 0) > +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/test/resources/macrotoc11.test 2010-10-12 12:03:53 UTC (rev 31733) > @@ -0,0 +1,81 @@ > +.runTransformations > +.#----------------------------------------------------- > +.input|xwiki/2.0 > +.# Verify the TOC produce error when "start" or "depth" parameters are too low > +.#----------------------------------------------------- > +{{toc start="0"/}} > + > +{{toc depth="0"/}} > +.#----------------------------------------------------- > +.expect|event/1.0 > +.#----------------------------------------------------- > +beginDocument > +beginMacroMarkerStandalone [toc] [start=0] > +beginGroup [[class]=[xwikirenderingerror]] > +onWord [Invalid macro parameters used for the "toc" macro] > +endGroup [[class]=[xwikirenderingerror]] > +beginGroup [[class]=[xwikirenderingerrordescription hidden]] This stacktrace looks really fragile, any changes in the source files will prompt redoing the test file. > +onVerbatim [org.xwiki.properties.PropertyException: Failed to validate bean: [must be greater than or equal to 1] > + at org.xwiki.properties.internal.DefaultBeanManager.validateBean(DefaultBeanManager.java:178) > + at org.xwiki.properties.internal.DefaultBeanManager.populate(DefaultBeanManager.java:113) > + at org.xwiki.rendering.internal.transformation.MacroTransformation.transformOnce(MacroTransformation.java:158) > + at org.xwiki.rendering.internal.transformation.MacroTransformation.transform(MacroTransformation.java:117) > + at org.xwiki.rendering.internal.transformation.DefaultTransformationManager.performTransformations(DefaultTransformationManager.java:85) > + at org.xwiki.rendering.scaffolding.RenderingTestCase.runTestInternal(RenderingTestCase.java:126) > + at org.xwiki.rendering.scaffolding.RenderingTestCase.runTest(RenderingTestCase.java:99) > + at org.jmock.core.VerifyingTestCase.runBare(VerifyingTestCase.java:39) > + at junit.framework.TestResult$1.protect(TestResult.java:110) > + at junit.framework.TestResult.runProtected(TestResult.java:128) > + at junit.framework.TestResult.run(TestResult.java:113) > + at junit.framework.TestCase.run(TestCase.java:124) > + at junit.framework.TestSuite.runTest(TestSuite.java:232) > + at junit.framework.TestSuite.run(TestSuite.java:227) > + at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24) > + at junit.extensions.TestSetup$1.protect(TestSetup.java:23) > + at junit.framework.TestResult.runProtected(TestResult.java:128) > + at junit.extensions.TestSetup.run(TestSetup.java:27) > + at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:79) > + at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:49) > + at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38) > + at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467) > + at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683) > + at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390) > + at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197) > +] [false] > +endGroup [[class]=[xwikirenderingerrordescription hidden]] > +endMacroMarkerStandalone [toc] [start=0] > +beginMacroMarkerStandalone [toc] [depth=0] > +beginGroup [[class]=[xwikirenderingerror]] > +onWord [Invalid macro parameters used for the "toc" macro] > +endGroup [[class]=[xwikirenderingerror]] > +beginGroup [[class]=[xwikirenderingerrordescription hidden]] > +onVerbatim [org.xwiki.properties.PropertyException: Failed to validate bean: [must be greater than or equal to 1] > + at org.xwiki.properties.internal.DefaultBeanManager.validateBean(DefaultBeanManager.java:178) > + at org.xwiki.properties.internal.DefaultBeanManager.populate(DefaultBeanManager.java:113) > + at org.xwiki.rendering.internal.transformation.MacroTransformation.transformOnce(MacroTransformation.java:158) > + at org.xwiki.rendering.internal.transformation.MacroTransformation.transform(MacroTransformation.java:117) > + at org.xwiki.rendering.internal.transformation.DefaultTransformationManager.performTransformations(DefaultTransformationManager.java:85) > + at org.xwiki.rendering.scaffolding.RenderingTestCase.runTestInternal(RenderingTestCase.java:126) > + at org.xwiki.rendering.scaffolding.RenderingTestCase.runTest(RenderingTestCase.java:99) > + at org.jmock.core.VerifyingTestCase.runBare(VerifyingTestCase.java:39) > + at junit.framework.TestResult$1.protect(TestResult.java:110) > + at junit.framework.TestResult.runProtected(TestResult.java:128) > + at junit.framework.TestResult.run(TestResult.java:113) > + at junit.framework.TestCase.run(TestCase.java:124) > + at junit.framework.TestSuite.runTest(TestSuite.java:232) > + at junit.framework.TestSuite.run(TestSuite.java:227) > + at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24) > + at junit.extensions.TestSetup$1.protect(TestSetup.java:23) > + at junit.framework.TestResult.runProtected(TestResult.java:128) > + at junit.extensions.TestSetup.run(TestSetup.java:27) > + at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:79) > + at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:49) > + at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38) > + at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467) > + at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683) > + at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390) > + at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197) > +] [false] > +endGroup [[class]=[xwikirenderingerrordescription hidden]] > +endMacroMarkerStandalone [toc] [depth=0] > +endDocument > \ No newline at end of file -- Sergiu Dumitriu http://purl.org/net/sergiu/

14 years, 11 months

1
0
0 0

[xwiki-devs] CSRF tests taking long

by Vincent Massol

Hi (Alex), Is it normal that CSRF tests take so long to execute on hudson (> 5mn for 7 unit tests): http://hudson.xwiki.org/job/xwiki-platform-core/org.xwiki.platform$xwiki-co… On my local machine they took 26 seconds. Thanks -Vincent

14 years, 11 months

3
2
0 0

[xwiki-devs] outofmemory errors

by Iola Hagen [ioh]

Hi we are having problems with outofmemory permgen errors, we make heavy use of the attachment feature in our xwiki installation and as the site has become more popular the memory errors have increased. I found the email below as a response to a similar question does anyone know if this has now been resolved. We are running XWiki Enterprise 2.1.1.25889, on Windows Server 2008 Tomcat 6.0 with Java 1.6.0_18, the database is SQL server 2008. Thanks for any help. Cheers Iola Subject: Re: [xwiki-users] Out of memory error<http://markmail.org/message/dctm6ag7j2ci6j42> [cid:image001.gif@01CB69F1.481DD2E0]<http://markmail.org/message/dctm6ag7j2ci6j42> From: Vincent Massol (vinc...(a)massol.net) Date: Jul 16, 2009 4:19:39 am List: org.xwiki.users Hi there, Unfortunately XWiki is still memory intensive when it comes to attachment manipulation. Thus the memory required depends on the size of the attachment you're uploading. Seen the OOM error you're getting you'd need to increase the memory to make it work. We really need to look into this and see how we can reduce the memory needs. Thanks -Vincent

14 years, 11 months

2
1
0 0

[xwiki-devs] [proposal] Deprecate functions in XWikiAttachment and XWikiAttachmentArchive which are bound to JRCS based implementation.

by Caleb James DeLisle

I propose that we deprecate some functions in XWikiAttachment and XWikiAttachmentArchive for 2.5 final. The theoretical reason is that they are implementation bound and we should not expose the implementation to the user of the API. The practical reason is that JRCS is very badly suited for handling large data as it stores everything (including all versions) in a String. Since the content is base64 encoded (increasing the size by 30%) and java Strings are UTF-16 (doubling the size) the memory consumption from using JRCS is at least 2.6 times the size of all revisions of the content. I didn't find these functions used anywhere else in platform. These are the functions I would like to deprecate: XWikiAttachment public void setArchive(Archive archive) public Archive getArchive() XWikiAttachmentArchive public Archive getRCSArchive() public void setRCSArchive(Archive archive) WDYT? Caleb

14 years, 11 months

6
5
0 0

[xwiki-devs] [VOTE] Release XE 2.5RC1, create branches for 2.5, move trunks to 2.6

by Sergiu Dumitriu

Hi devs, The XWiki 2.5 RC1 was scheduled today. Given that M2 was released a couple of days later, and that we still need to wait for the vote results, I propose to release XE 2.5 RC1 tomorrow. Since 2.5 is entering the RC phase, I also propose to move 2.5 to a branch (core, web, enterprise, manager). -- Sergiu Dumitriu http://purl.org/net/sergiu/

14 years, 11 months

4
3
0 0

[xwiki-devs] [Proposal][Standard][UX] Forms

by Ecaterina Valica

I've made some additions to our Forms Standard page: http://incubator.myxwiki.org/xwiki/bin/view/Standards/Forms The standard is very similar to what we have for the WYSIWYG editor: - vertical alignment - display of labels (we have uppercase text for Colibri style consistency) - display of hints/error messages - primary/secondary buttons I made a proposal to integrate this standards inside the platform: http://incubator.myxwiki.org/xwiki/bin/view/Standards/FormsProposal - administration - object editor - user profile - Create Space/Page - Copy/Rename Page Any feedback is welcomed, Caty

14 years, 11 months

8
12
0 0

[xwiki-devs] Fwd: [ANN] Maven Release Plugin 2.1 Released

by Vincent Massol

fyi -Vincent Begin forwarded message: > From: Brett Porter <brett(a)apache.org> > Date: October 8, 2010 7:03:48 PM GMT+02:00 > To: announce(a)maven.apache.org, Maven Users List <users(a)maven.apache.org> > Cc: Maven Developers List <dev(a)maven.apache.org> > Subject: [ANN] Maven Release Plugin 2.1 Released > Reply-To: users(a)maven.apache.org > > The Maven team is pleased to announce the release of the Maven Release Plugin, version 2.1 > > This plugin is used to release a project with Maven, saving a lot of repetitive, manual work. Releasing a project is made in two steps: prepare and perform. > > http://maven.apache.org/plugins/maven-release-plugin/ > > You should specify the version in your project's plugin configuration: > > <plugin> > <groupId>org.apache.maven.plugins</groupId> > <artifactId>maven-release-plugin</artifactId> > <version>2.1</version> > </plugin> > > Release Notes - Maven Release Plugin - Version 2.1 > > ** Bug > * [MRELEASE-128] - SCM properties being replaced during release:perform > * [MRELEASE-317] - release:prepare should fail if any pom depends on SNAPSHOT parent > * [MRELEASE-318] - Release plugin throws NullPointerException when using version range for dependency > * [MRELEASE-350] - Option '0' for "specify the selection number ( 0:All 1:Project Dependencies 2:Plugins 3:Reports 4:Extensions ):" is broken > * [MRELEASE-370] - release:prepare is not updating inter-modules dependencies to the next version snapshot identifier correctly (-DdryRun=true). > * [MRELEASE-458] - Branch Does Not Honor updateWorkingCopyVersions Setting > * [MRELEASE-524] - command line versions don't seem to work on release:branch for specific format > * [MRELEASE-536] - CommonBasedir Calculation fails on windows > * [MRELEASE-546] - regression introduced in MRELEASE-261 > * [MRELEASE-551] - Unable to release with maven 3 when having no $HOME/.m2/settings.xml > * [MRELEASE-563] - help strings need help, they are not helpful out of context > * [MRELEASE-586] - release:perform - The temporary file "pom.xml.branch" should be ignored as "pom.xml.next" and "pom.xml.tag" are ignored > * [MRELEASE-589] - Resolved dependencies overwritten when multiple subprojects with SNAPSHOT dependencies are released > > ** Improvement > * [MRELEASE-497] - Don't overwrite SVN auth cache > * [MRELEASE-530] - Git provider does 'git push' during 'mvn release:prepare' which causes unwanted problems (scm 1.4 upgrade) > * [MRELEASE-554] - Allow custom files to be modified before doing a prepare or branch... > * [MRELEASE-583] - Better Snapshot Dependency Handling > > Enjoy, > -The Maven team > > -- > Brett Porter > brett(a)apache.org > http://brettporter.wordpress.com/ > > > >

14 years, 11 months

1
0
0 0

[xwiki-devs] [discussion] Synchronizing version numbers of applications, plugins, and core.

by Caleb James DeLisle

I have been observing problems with the versioning scheme which we are using. Because applications are not branched along with core, when a bugfix version of a stable branch is released, new versions of applications are typically pulled in. This means that `experimental' code is being introduced into a `stable' branch in a bugfix version. This is not the path I would choose but more importantly we can't honestly say that our code goes through a milestone/release candidate verification process if some of the code is allowed to bypass it. This situation has caused me to make a mistake which I was able to correct during the release without major issue, I think the same issue is behind the release of 2 bogus versions (2.4.1 and 2.4.2) There is another issue, users who want to mix and match applications to build their own wiki are faced with a set of version numbers and no way to know what is compatible with what. A user who I spoke with last night had this very problem. We could publish a compatibility matrix but if we were to show all the versions a given application is compatible with, that would require testing each application version against each core version and I think we need to concentrate on testing what gets released in XE. Both of these problems would be fixed if version numbers were synchronized and everything was branched for a release. Relevant questions which come to mind are "do we need the capability to release applications at separate times?" and "is there no way to do that with synchronized version numbers?" Am I missing any other reasons? Should this not become a proposal? Caleb

14 years, 11 months

8
37
0 0

[xwiki-devs] UniqueIdentificationNumber component

by Stefan abageru

Hello Devs ! I built a component to handle unique generation of document names. The documents must be instantiations of a specified class and the generation is done taking into consideration the currently existing documents and all the values used before. It retrieves the maximum value currently used, increments It is configurable in xwiki.properties. More info cand be found here http://code.xwiki.org/xwiki/bin/view/Plugins/UniqueIdentificationNumberPlug… . Thanks, Stefan Abageru !

14 years, 11 months

1
0
0 0

[xwiki-devs] [proposal] Deprecate com.xpn.xwiki.api.Context#getUtil()

by Caleb James DeLisle

Hi, I would like to hard deprecate com.xpn.xwiki.api.Context#getUtil(). It exposes functions to the user which are not optimized for scripting and some of which are security vulnerabilities. This class is not in the api package and it appears that it was never intended to be exposed to the user. +1 @Deprecated. Caleb

14 years, 11 months

5
5
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

xwiki-devs