- xwiki-devs@xwiki.org - lists.xwiki.org

[xwiki-devs] [Proposal] Stop using $msg.get()

by Vincent Massol

Hi, We now used $msg.get() eveywhere in the default XAR. IMO this is bad for the following reasons: * Our search no longer returns hits since it searches on the page content in the database (web search). BTW this is why some REST tests were failing since the content no longer existed for it (it does a hibernate search). * Users get to see $msg.get() everywhere in document titles when they edit XE pages, which is ugly and not understandable for simple users (for ex check Main.WebHome). * It's not a good way to translate apps since we bundle app translations keys in the core jar! Apps should be self-standing What should we do instead? Proposal: * Use the xwiki page translation feature... * Provide a XAR with all languages (and possibly a XAR per language). If the user configures his wiki for one language he'll see only that language (make sure all translations are imported even when in mono language) * Refactor existing pages to separate content from code. Move code to separate pages included from content pages. Never put content in code pages, have it passed to velocity macros for example. On the technical side we need to verify it can work but this is way better and would address the shortcomings listed above. Thanks -Vincent

16 years

4
6
0 0

[xwiki-devs] [VOTE] Title compat flag on for now for 2.0 final

by Vincent Massol

Hi, I'd like to set the compat flag on for now since we haven't converted all page titles yet and this is going to take some time. We should move it back to off when it's all converted. +1 Thanks -Vincent

16 years

4
4
0 0

[xwiki-devs] interesting comparison of scriping languages for Java from JavaOne

by Niels Mayer

Too bad Groovy isn't in here: "Alternative Languages on a JVM" http://www.azulsystems.com/events/javaone_2009/session/2009_J1_JVMLang.pdf ... > Deeper Dive > Clojure - “almost close” ● Good: no obvious subroutine calls in inner loop ● Bad: Massive “ephemeral” object allocation - requires good GC ● But needs Escape Analysis to go really fast ● Ugly: fix-num overflow checks everywhere ● Turn off fix-nums: same speed as Java ● Weird “holes” - ● Not-optimized reflection calls here & there ● Can get reports on generated reflection calls 10 Deeper Dive > Jython - “almost close” ● Also has fix-num issue; massive allocation ● Some extra locks thrown in > JavaScript/Rhino - “almost close” ● All things are Doubles – not 'double' ● Same fix-num allocation issues as Clojure, Jython ● Otherwise looks pretty good (no fix-num checks) > JRuby – Missed The Metal ● Assuming CachingCallSite::call inlines ● Using -XX:+PrintInlining to determine ● But flag is lying: claims method inlined, but it's not 11 Common Issue – Fix-Nums > Huge allocation rate of “fix-nums” ● Allocation is not free ● Setting final fields cost a memory fence ● GC does NOT cost here ● i.e., object pooling would be a big loser > Could do much better with JIT ● Need “ultra-stupid” Escape Analysis ● Need some (easy) JIT tweaking ● e.g. Getting around Integer.valueOf(i) caching 12 JRuby – Missed The Metal > Each minor action dispatches via “call” > Assuming CachingCallSite::call inlines ● (and allows further inlining) > Using -XX:+PrintInlining to determine > But flag is lying: claims inlined, but it's not ● BimorphicInlining is 'guessing' wrong target > Confirmed w/GDB on X86 Java6 > Confirmed w/Azul profiler ● My 1st impression: can't be inlined ever Niels http://nielsmayer.com

16 years

2
1
0 0

[xwiki-devs] Skin TODOs for the 2.0 RC1 release

by Vincent Massol

Hi, Here are skin problems I can see that need to be fixed before the RC1 release: 1) ColorTheme space is not excluded for simple users 2) On admin page the large header is not correctly positioned 3) Colibri is not set to be the skin by default 4) Colibri is not using the voted default colors 5) The colorTheme property is not set in XWikiPreferences 6) There's no theme editor/chooser available from the admin presentation page 7) Ugly (too large) create button on the blog home page 8) Blog title is no longer using the Blog object title value 9) When going to a blog post page there are 2 dup titles that really don't look nice 10) Use profile page has dup titles. XWiki.User does not start directly with the title, but wraps it inside a vcard microformat. 11) Main.WebSearch is not a plain title, but also contains an icon link to the RSS results. The document should be updated. 12) Main.Tags does not have a heading, but a div styled to look like a heading. Also, it is not a simple title, it also incorporates tools for the selected tag. Anything else that is a blocker for the RC1 and 2.0 final release? Can we spread the work amongst ourselves? Please volunteer to take some items. Note1: This means that we're late yet again since today is supposed to be the release day for RC1... This means we need to finish all the items above today at latest. Note2: I haven't looked at existing colibri skin issues already in jira. Please someone have a look and add to the list above if they are blocker for RC1. Let's crack this all together today! Thanks -Vincent

16 years

4
12
0 0

[xwiki-devs] [Proposal] Title compatibility flag

by Vincent Massol

Hi, Following our discussion on the new title behavior we need to define the title compat flag value. I'm proposing: #-# Defines whether title handling should be using the compatyiblity mode or not. When the compatibility #-# mode is active, if the document's content first header (level 1 or level 2) matches the document's title #-# the first header is stripped. xwiki.title.compatibility=0 + we need a way to access this property from contentview.vm so I'm proposing to also add a method to api.XWiki: isTitleInCompatibilityMode() WDYT? Thanks -Vincent

16 years

6
7
0 0

[xwiki-devs] enterprise pom.xml : hibernate.cfg.xml empty ?

by Hervé Agnoux

Hi, For some reasons, I build XWiki Enterprise with netbeans and maven. I checkout http://svn.xwiki.org/svnroot/xwiki/enterprise/trunk, I choose project "XWiki Products - Enterprise - Web (war)", I run, and I see in my navigator : Etat HTTP 500 - javax.servlet.ServletException: com.xpn.xwiki.XWikiException: Error number 3 in 0: Could not initialize main XWiki context Wrapped Exception: Error number 3001 in 3: Cannot load class com.xpn.xwiki.store.migration.hibernate.XWikiHibernateMigrationManager from param xwiki.store.migration.manager.class Wrapped Exception: Error number 0 in 3: Exception while hibernate execute Wrapped Exception: Hibernate Dialect must be explicitly set I read in googled world there is a hibernate.cfg.xml. In my checkouted directory, there is a checkout/trunk/web/src/main/webapp/WEB- INF/hibernate.cfg.xml, but this file is empty ? Is it this file ? I read some parts on http://platform.xwiki.org/xwiki/bin/view/AdminGuide/InstallationHSQL but I can't see a complete model hibernate.cfg.xml Thanks for your help.

16 years

3
9
0 0

[xwiki-devs] [VOTE] Change the default author of documents created programmatically or provided in XARs

by Jean-Vincent Drean

Hi devs, I'm currently working on documents we create from core/plugins or those we bundle in XARs (xwiki/2.0 conversion, filling title field, etc). I'd like to take advantage of this to discuss about the author we use in those documents. We currently have 2 different behaviors: - classes created from the core usually have their author set to "" - classes created from plugins (skinx, scheduler, etc) or bundled in our XARs usually have their author set to "XWiki.Admin" It lacks consistency and it can lead to security issues. If for some reason the administrator of a wiki decide to delete the XWiki.Admin account some can re-create it and gain the authorship -- thus the right to delete -- plenty of XE documents. We can decide to: 1) Only tackle the consistency problem and use "XWiki.Admin" everywhere 2) Solve the 2 problems by extending core policy to all our documents, ie. use "" everywhere 3) Solve the 2 problems by using a special username everywhere, like "System". Here's my +1 for 3), rationale: - 1) is only a quick fix and core shouldn't be aware of a user that comes with XE, - 2) is fine except that not having an author seems unnatural from a user POV. - In the future we could decide to have special handler for the "System" user, like pointing to a page explaining that it is a pseudo-user when we use $xwiki.getLocalUserName("System"). JV.

16 years

5
7
0 0

[xwiki-devs] Good News for the XWiki Open Source Project: French State Research funding

by Ludovic Dubost

Hi XWiki Community, I'm happy to share some good news for the XWiki Platform and Community that we got today. We (XWiki SAS) had responded to a French Government Call for Web 2.0 Projects in early July and we got the good news today that our project was selected with 43 other projects (among 340 proposals) to receive state funding. In this project, where the research entity INRIA/ECOO and Open Source company Mandriva are also participating, we have proposed to enhance XWiki's social features and integrate Real-Time capabilities in XWiki (both for editing information and viewing information in real-time). We already worked with INRIA/ECOO on XWiki Concerto (offline and mobile XWiki) which is the specialist in France and probably Europe of Operational Transformation Technology (which is used in Google Wave for real-time capabilities). We'll talk more about the features this will bring to XWiki when we formally launch the project. We don't know yet how fast it will go to formalize the public funding and start the project (it usually takes at least a few month). It's great to be able to continue to work on innovative technologies in the Wiki space, which is not that easy as we have already so much work to package and polish all the great ideas and features that are already in the XWiki platform. It's also great to see the progress the XWiki software has made in the last year, from XWiki 1.8 to XWiki 2.0 coming out soon. The new rendering, new Wysiwyg editor, the Office Importer and now the new skin are making XWiki do a lightyear of progress in just one year ! Ludovic -- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost

16 years

3
2
0 0

[xwiki-devs] Orphaned WikiMacroClass & WikiMacroParameterClass

by Vincent Massol

Hi Asiri, They are still orphaned in the 2.0 branch (just rebuilt a few minutes ago) Thanks -Vincent

16 years

4
4
0 0

[xwiki-devs] [VOTE] New RegexTool velocity tool

by Vincent Massol

Hi, I'm working on http://jira.xwiki.org/jira/browse/XWIKI-4345 and in order to implement the logic in contenview.vm I need to perform some regex find() from velocity. I'd like to propose introducing a new velocity tool for this: #-# velocity.tools = regextool = org.xwiki.velocity.tools.RegexTool Right now RegexTool has one method: /** * @param content the content to parse * @param regex the regex to look for in the passed content * @return empty list if the passed regex doesn't match the content or several {@link RegexResult} objects * containing the matched position and matched content for all capturing groups, the first group * representing the whole . The first object is represents the entier pattern */ public List<RegexResult> find(String content, String regex) { List<RegexResult> result = new ArrayList<RegexResult>(); Matcher matcher = Pattern.compile(regex, Pattern.MULTILINE).matcher(content); if (matcher.find()) { for (int i = 0; i < matcher.groupCount() + 1; i++) { result.add(new RegexResult(matcher.start(i), matcher.end(i), matcher.group(i))); } } return result; } WDYT? FYI here's what I currently have in contenview.vm: ## ---------------------------------------------------------------------------- ## Remove the first rendered H1 or H2 if the following conditions are met: ## - the document's title is set ## - the title compatibility flag is on ## - the title extracted from the rendered content is the same as the set title ## We need to do this since we've changed how titles are used and we need to ## ensure we don't break existing documents that have not yet migrated to the ## new way. ## ----------------------------------------------------------------------------- #set ($titleToDisplay = $tdoc.displayTitle) #if ($cdoc.title && $cdoc.title.length() > 0) ## Look for first H1 or H2 either in lowercase or uppercase #set ($regexResult = $regextool.find($renderedContent, "<[hH][12].*? ><span>(.*)</span></[hH][12]>")) #if (!$regexResult.isEmpty() && $regexResult.get(1).group.equals($titleToDisplay)) #if ($regexResult.get(0).end < $mathtool.sub($renderedContent.length(), 1)) #set ($renderedContent = "${renderedContent.substring(0, $regexResult.get(0).start)}$ {renderedContent.substring($regexResult.get(0).end)}") #else #set ($renderedContent = $renderedContent.substring(0, $regexResult.get(0).start)) #end #end #end Note that the other option is to introduce yet another API in Document for this but it doesn't look right to me. Here's my +1 Thanks -Vincent

16 years

3
2
0 0

[xwiki-devs] Proposal to manage columns using simple tables in the Wysiwyg editor

by Ludovic Dubost

Hi, In multiple cases, we have heard the requirements to manage simple 2 or 3 column layouts in the Wysiwyg. This has come up with some users and is a need in the Socracy project (http://www.socracy.org). I've thought a bit more about this need and realized we could handle it quite simply using our already available Table feature in the Wysiwyg. For this the only thing we actually need would be to be able to edit the "class" being assigned to a table. I've made some CSS to show the results that we could have using such a class: http://incubator.myxwiki.org/xwiki/bin/view/Test/TestColumns The only special thing that these tables have in the wiki syntax is a class assigned: (% class="columns2" %) or (% class="columns3" %) The rest is CSS magic put in the skin. The way I see it would be to have the possibility to choose between different classes when creating or editing table properties. The list of available classes could be a preference set in the Wiki, this way we could extend the styles available for tables. Not only we could handle columns this way but we could also have additional styles for table (home page tables or table to show numbers, etc..). This is not too much work in the Wysiwyg and can provide quite some benefits to make nice presentations in XWiki. WDYT ? Ludovic -- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost

16 years

4
3
0 0

[xwiki-devs] Pb with new Dashboard content & wysiwyg

by Vincent Massol

Hi, Try editing http://localhost:8080/xwiki/bin/edit/Main/Dashboard You'll get "Document in space null" and "Recent Changes for space null" And you won't see any changes, etc. There seems to be a context problem somewhere. Thanks -Vincent

16 years

1
0
0 0

Re: [xwiki-devs] [xwiki-notifications] r23516 - platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/feed

by Vincent Massol

Hi, On Sep 14, 2009, at 6:13 PM, jvdrean (SVN) wrote: > Author: jvdrean > Date: 2009-09-14 18:13:16 +0200 (Mon, 14 Sep 2009) > New Revision: 23516 > > Modified: > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/ > feed/FeedPlugin.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/ > feed/FeedPluginApi.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/ > feed/SyndEntryDocumentSource.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/ > feed/SyndEntrySource.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/ > feed/SyndEntrySourceApi.java > Log: > [misc] Introduce generics [snip] > /** > @@ -470,7 +481,8 @@ > */ > public SyndFeed getWebFeed(String query, int count, int start) > { > - return getWebFeed(query, count, start, > Collections.EMPTY_MAP); > + Map<String, Object> metadata = new HashMap<String, Object>(); > + return getWebFeed(query, count, start, metadata); > } Shouldn't this use Collections.emptyMap()? Thanks -Vincent

16 years

2
2
0 0

Re: [xwiki-devs] [xwiki-notifications] r23517 - in platform/core/branches/xwiki-core-2.0/xwiki-rendering: xwiki-rendering-api/src/main/java/org/xwiki/rendering/internal/renderer/xwiki xwiki-rendering-tests/src/test/java/org/xwiki/rendering xwiki-rend

by Thomas Mortagne

On Mon, Sep 14, 2009 at 21:11, Vincent Massol <vincent(a)massol.net> wrote: > > On Sep 14, 2009, at 6:22 PM, tmortagne (SVN) wrote: > >> Author: tmortagne >> Date: 2009-09-14 18:22:10 +0200 (Mon, 14 Sep 2009) >> New Revision: 23517 >> >> Added: >> platform/core/branches/xwiki-core-2.0/xwiki-rendering/xwiki- >> rendering-tests/src/test/resources/escape/escape20.test >> Modified: >> platform/core/branches/xwiki-core-2.0/xwiki-rendering/xwiki- >> rendering-api/src/main/java/org/xwiki/rendering/internal/renderer/ >> xwiki/XWikiSyntaxEscapeHandler.java >> platform/core/branches/xwiki-core-2.0/xwiki-rendering/xwiki- >> rendering-tests/src/test/java/org/xwiki/rendering/ >> SimpleRenderingTests.java >> Log: >> XWIKI-4341: Quote syntax is not escaped when HTML is parsed >> >> Modified: platform/core/branches/xwiki-core-2.0/xwiki-rendering/ >> xwiki-rendering-api/src/main/java/org/xwiki/rendering/internal/ >> renderer/xwiki/XWikiSyntaxEscapeHandler.java >> =================================================================== >> --- platform/core/branches/xwiki-core-2.0/xwiki-rendering/xwiki- >> rendering-api/src/main/java/org/xwiki/rendering/internal/renderer/ >> xwiki/XWikiSyntaxEscapeHandler.java 2009-09-14 16:13:16 UTC (rev >> 23516) >> +++ platform/core/branches/xwiki-core-2.0/xwiki-rendering/xwiki- >> rendering-api/src/main/java/org/xwiki/rendering/internal/renderer/ >> xwiki/XWikiSyntaxEscapeHandler.java 2009-09-14 16:22:10 UTC (rev >> 23517) >> @@ -43,6 +43,8 @@ >> private static final Pattern LIST_PATTERN = >> Pattern.compile("\\p{Blank}*((\\*+[:;]*)|([1*]+\\.[:;]*)| >> ([:;]+))\\p{Blank}+"); >> >> + private static final Pattern QUOTE_PATTERN = Pattern.compile("(\ >> \>+)"); >> + >> private static final Pattern HEADER_PATTERN = Pattern.compile("\ >> \p{Blank}*(=+)"); >> >> private static final Pattern TABLE_PATTERN = Pattern.compile("\ >> \p{Blank}*(\\||!!)"); >> @@ -77,6 +79,9 @@ >> >> // Look for table character patterns at beginning of >> line and escape the first character only (it's enough) >> escapeFirstMatchedCharacter(TABLE_PATTERN, >> accumulatedBuffer); >> + >> + // Look for quote pattern at beginning of line and >> escape the first character only (it's enough) >> + escapeFirstMatchedCharacter(QUOTE_PATTERN, >> accumulatedBuffer); >> } >> >> // Escape table characters >> @@ -136,7 +141,7 @@ >> >> // Escape begin link >> replaceAll(accumulatedBuffer, "[[", ESCAPE_CHAR + "[" + >> ESCAPE_CHAR + "["); >> - >> + >> // Escape link label >> int linkLevel = getLinkLevel(listenerChain); >> >> >> Modified: platform/core/branches/xwiki-core-2.0/xwiki-rendering/ >> xwiki-rendering-tests/src/test/java/org/xwiki/rendering/ >> SimpleRenderingTests.java >> =================================================================== >> --- platform/core/branches/xwiki-core-2.0/xwiki-rendering/xwiki- >> rendering-tests/src/test/java/org/xwiki/rendering/ >> SimpleRenderingTests.java 2009-09-14 16:13:16 UTC (rev 23516) >> +++ platform/core/branches/xwiki-core-2.0/xwiki-rendering/xwiki- >> rendering-tests/src/test/java/org/xwiki/rendering/ >> SimpleRenderingTests.java 2009-09-14 16:22:10 UTC (rev 23517) >> @@ -184,6 +184,7 @@ >> suite.addTestsFromResource("escape/escape17", false); >> suite.addTestsFromResource("escape/escape18", false); >> suite.addTestsFromResource("escape/escape19", false); >> + suite.addTestsFromResource("escape/escape20", false); >> >> // Other >> suite.addTestsFromResource("horizontalline/horizontalline1", >> false); >> >> Added: platform/core/branches/xwiki-core-2.0/xwiki-rendering/xwiki- >> rendering-tests/src/test/resources/escape/escape20.test >> =================================================================== >> --- platform/core/branches/xwiki-core-2.0/xwiki-rendering/xwiki- >> rendering-tests/src/test/resources/escape/ >> escape20.test (rev 0) >> +++ platform/core/branches/xwiki-core-2.0/xwiki-rendering/xwiki- >> rendering-tests/src/test/resources/escape/escape20.test 2009-09-14 >> 16:22:10 UTC (rev 23517) >> @@ -0,0 +1,19 @@ >> + >> .#--------------------------------------------------------------------------------------------------------- >> +.input|xwiki/2.0 >> +.# Verify that ) is escaped if last character of a group > > The comment talks about ")" but the test below is about ">". > > copy paste? Yes as usual, always do the same mistake, fixing it. Thanks for the report. > > Thanks > -Vincent > >> + >> .#--------------------------------------------------------------------------------------------------------- >> +~> text >> +.#----------------------------------------------------- >> +.expect|event/1.0 >> +.#----------------------------------------------------- >> +beginDocument >> +beginParagraph >> +onSpecialSymbol [>] >> +onSpace >> +onWord [text] >> +endParagraph >> +endDocument >> +.#----------------------------------------------------- >> +.expect|xwiki/2.0 >> +.#----------------------------------------------------- >> +~> text >> \ No newline at end of file > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs > -- Thomas Mortagne

16 years

1
0
0 0

[xwiki-devs] [VOTE] Upgrade the 2.0 branch to GWT 1.7

by Marius Dumitru Florea

Hi devs, I upgraded the 2.1 branch to GWT 1.7 and I'm waiting for Hudson to run the selenium tests. If everything goes well I'd like to upgrade the 2.0 branch too. The main reason for doing this is to improve the support for IE8 (XWIKI3446 and XWIKI3448 for instance). Note that I ran the unit tests in IE8 and I got the same results as in IE6/7. Here's my +1 Thanks, Marius

16 years

7
7
0 0

Re: [xwiki-devs] [xwiki-notifications] r23517 - in platform/core/branches/xwiki-core-2.0/xwiki-rendering: xwiki-rendering-api/src/main/java/org/xwiki/rendering/internal/renderer/xwiki xwiki-rendering-tests/src/test/java/org/xwiki/rendering xwiki-rendering-tests/src/test/resources/escape

by Vincent Massol

On Sep 14, 2009, at 6:22 PM, tmortagne (SVN) wrote: > Author: tmortagne > Date: 2009-09-14 18:22:10 +0200 (Mon, 14 Sep 2009) > New Revision: 23517 > > Added: > platform/core/branches/xwiki-core-2.0/xwiki-rendering/xwiki- > rendering-tests/src/test/resources/escape/escape20.test > Modified: > platform/core/branches/xwiki-core-2.0/xwiki-rendering/xwiki- > rendering-api/src/main/java/org/xwiki/rendering/internal/renderer/ > xwiki/XWikiSyntaxEscapeHandler.java > platform/core/branches/xwiki-core-2.0/xwiki-rendering/xwiki- > rendering-tests/src/test/java/org/xwiki/rendering/ > SimpleRenderingTests.java > Log: > XWIKI-4341: Quote syntax is not escaped when HTML is parsed > > Modified: platform/core/branches/xwiki-core-2.0/xwiki-rendering/ > xwiki-rendering-api/src/main/java/org/xwiki/rendering/internal/ > renderer/xwiki/XWikiSyntaxEscapeHandler.java > =================================================================== > --- platform/core/branches/xwiki-core-2.0/xwiki-rendering/xwiki- > rendering-api/src/main/java/org/xwiki/rendering/internal/renderer/ > xwiki/XWikiSyntaxEscapeHandler.java 2009-09-14 16:13:16 UTC (rev > 23516) > +++ platform/core/branches/xwiki-core-2.0/xwiki-rendering/xwiki- > rendering-api/src/main/java/org/xwiki/rendering/internal/renderer/ > xwiki/XWikiSyntaxEscapeHandler.java 2009-09-14 16:22:10 UTC (rev > 23517) > @@ -43,6 +43,8 @@ > private static final Pattern LIST_PATTERN = > Pattern.compile("\\p{Blank}*((\\*+[:;]*)|([1*]+\\.[:;]*)| > ([:;]+))\\p{Blank}+"); > > + private static final Pattern QUOTE_PATTERN = Pattern.compile("(\ > \>+)"); > + > private static final Pattern HEADER_PATTERN = Pattern.compile("\ > \p{Blank}*(=+)"); > > private static final Pattern TABLE_PATTERN = Pattern.compile("\ > \p{Blank}*(\\||!!)"); > @@ -77,6 +79,9 @@ > > // Look for table character patterns at beginning of > line and escape the first character only (it's enough) > escapeFirstMatchedCharacter(TABLE_PATTERN, > accumulatedBuffer); > + > + // Look for quote pattern at beginning of line and > escape the first character only (it's enough) > + escapeFirstMatchedCharacter(QUOTE_PATTERN, > accumulatedBuffer); > } > > // Escape table characters > @@ -136,7 +141,7 @@ > > // Escape begin link > replaceAll(accumulatedBuffer, "[[", ESCAPE_CHAR + "[" + > ESCAPE_CHAR + "["); > - > + > // Escape link label > int linkLevel = getLinkLevel(listenerChain); > > > Modified: platform/core/branches/xwiki-core-2.0/xwiki-rendering/ > xwiki-rendering-tests/src/test/java/org/xwiki/rendering/ > SimpleRenderingTests.java > =================================================================== > --- platform/core/branches/xwiki-core-2.0/xwiki-rendering/xwiki- > rendering-tests/src/test/java/org/xwiki/rendering/ > SimpleRenderingTests.java 2009-09-14 16:13:16 UTC (rev 23516) > +++ platform/core/branches/xwiki-core-2.0/xwiki-rendering/xwiki- > rendering-tests/src/test/java/org/xwiki/rendering/ > SimpleRenderingTests.java 2009-09-14 16:22:10 UTC (rev 23517) > @@ -184,6 +184,7 @@ > suite.addTestsFromResource("escape/escape17", false); > suite.addTestsFromResource("escape/escape18", false); > suite.addTestsFromResource("escape/escape19", false); > + suite.addTestsFromResource("escape/escape20", false); > > // Other > suite.addTestsFromResource("horizontalline/horizontalline1", > false); > > Added: platform/core/branches/xwiki-core-2.0/xwiki-rendering/xwiki- > rendering-tests/src/test/resources/escape/escape20.test > =================================================================== > --- platform/core/branches/xwiki-core-2.0/xwiki-rendering/xwiki- > rendering-tests/src/test/resources/escape/ > escape20.test (rev 0) > +++ platform/core/branches/xwiki-core-2.0/xwiki-rendering/xwiki- > rendering-tests/src/test/resources/escape/escape20.test 2009-09-14 > 16:22:10 UTC (rev 23517) > @@ -0,0 +1,19 @@ > + > .#--------------------------------------------------------------------------------------------------------- > +.input|xwiki/2.0 > +.# Verify that ) is escaped if last character of a group The comment talks about ")" but the test below is about ">". copy paste? Thanks -Vincent > + > .#--------------------------------------------------------------------------------------------------------- > +~> text > +.#----------------------------------------------------- > +.expect|event/1.0 > +.#----------------------------------------------------- > +beginDocument > +beginParagraph > +onSpecialSymbol [>] > +onSpace > +onWord [text] > +endParagraph > +endDocument > +.#----------------------------------------------------- > +.expect|xwiki/2.0 > +.#----------------------------------------------------- > +~> text > \ No newline at end of file

16 years

1
0
0 0

[xwiki-devs] [UX] Edit Buttons Order

by Ecaterina Valica

Hi, Because we want to make a standard from vertical-aligned form, this means the buttons should be left-ordered with the most important action first. This should be changed also in Toucan and Albatross skin, not only just in Colibri. Right now the Edit Actions are "Cancel", "Preview", "Save&Continue", "Save&View". What do you think is the right order for them when they are left-aligned? (A) Save&View, Save&Continue, Preview, Cancel (as it is - just in reverse) (B) Save&View, Preview, Save&Continue, Cancel (C) Preview, Save&Continue, Save&View, Cancel (D) other variation Remarks: - "Cancel" should be *last* because it's a terminal (takes you out of the editor), no-saving action. This is the least important. - "Save & View" is also a terminal action (takes you out of the editor) - having it* first* you have the 2 terminal actions at extremities. - "Preview" is the least damaging action in case of accidental submit (Silvia + Marta) - should be *first*? - Some people use ("Preview" + "Save&Continue") {many times} + "Save&View" {final} - Other people just use "Save&Continue" + "Save & View" {final}, never "Preview", etc - What is the necessity for the "Preview" button in a WYSIYWG editor? On the other hand "Preview" is very important if you edit in "Wiki" mode. - Should "Preview" separate the two other SAVING actions? (Marta) - Should "Save&Continue" separate the two other VIEW actions? Thanks, Caty

16 years

8
18
0 0

[xwiki-devs] about the playground

by [Ricardo Rodriguez] Your EPEC Network ICT Team

Hi! I've being lately using the XWiki playground to test access to some sample pages with wget and simple authentication. It worked fine. No, when I login I've no access the the site contents. Here what I am seeing.... http://xen.net/images/xwikiPlayground.png I know that the functioning of the playground is not guarantee but do you expect to recover a "normal" operation soon? Thanks! All the best, Ricardo -- Ricardo Rodríguez Your EPEC Network ICT Team

16 years

2
2
0 0

[xwiki-devs] XWiki.XWikiPreferences_* properties not used anywhere?

by Vincent Massol

Hi, It seems that the XWiki.XWikiPreferences_* properties are not used anywhere. For example: # XWiki.XWikiPreferences (core) XWiki.XWikiPreferences_skin=Skin XWiki.XWikiPreferences_colorTheme=Color theme XWiki.XWikiPreferences_webbgcolor=Space Background Color XWiki.XWikiPreferences_authenticate_view=Authenticated View XWiki.XWikiPreferences_webcopyright=Space Copyright XWiki.XWikiPreferences_plugins=Plugins XWiki.XWikiPreferences_authenticate_edit=Authenticate On Edit XWiki.XWikiPreferences_menu=Menu XWiki.XWikiPreferences_meta=HTTP Meta Info XWiki.XWikiPreferences_title=Title XWiki.XWikiPreferences_version=Version XWiki.XWikiPreferences_smtp_server=Server XWiki.XWikiPreferences_smtp_port=Port XWiki.XWikiPreferences_smtp_server_username=Server username (optional) XWiki.XWikiPreferences_smtp_server_password=Server password (optional) XWiki.XWikiPreferences_javamail_extra_props=Additional JavaMail properties XWiki.XWikiPreferences_admin_email=Admin email XWiki.XWikiPreferences_validation_email_content=Validation email Content XWiki.XWikiPreferences_confirmation_email_content=Confirmation email Content XWiki.XWikiPreferences_stylesheet=Stylesheet XWiki.XWikiPreferences_stylesheets=Stylesheets XWiki.XWikiPreferences_multilingual=Multilingual XWiki.XWikiPreferences_default_language=Default Language XWiki.XWikiPreferences_editor=Default Editor XWiki.XWikiPreferences_core.defaultDocumentSyntax=Default document syntax XWiki.XWikiPreferences_editbox_width=Editbox Width XWiki.XWikiPreferences_use_email_verification=Use email Verification XWiki.XWikiPreferences_editbox_height=Editbox Height XWiki.XWikiPreferences_ad_clientid=Advertisement Client ID XWiki.XWikiPreferences_backlinks=Backlinks XWiki.XWikiPreferences_macros_languages=Macros Languages XWiki.XWikiPreferences_macros_velocity=Macros for Velocity XWiki.XWikiPreferences_macros_groovy=Macros for Groovy XWiki.XWikiPreferences_macros_wiki2=Macros for new wiki Parser XWiki.XWikiPreferences_macros_mapping=Macros Mapping XWiki.XWikiPreferences_auth_active_check=Authentication Active Check XWiki.XWikiPreferences_macros_wiki=Macros for the wiki Parser XWiki.XWikiPreferences_notification_pages=Notification Pages XWiki.XWikiPreferences_invitation_email_content=Invitation email content XWiki.XWikiPreferences_registration_anonymous=Anonymous XWiki.XWikiPreferences_registration_registered=Registered XWiki.XWikiPreferences_edit_anonymous=Anonymous XWiki.XWikiPreferences_edit_registered=Registered XWiki.XWikiPreferences_comment_anonymous=Anonymous XWiki.XWikiPreferences_comment_registered=Registered XWiki.XWikiPreferences_renderXWikiVelocityRenderer=Render velocity code XWiki.XWikiPreferences_renderXWikiGroovyRenderer=Render Groovy code XWiki.XWikiPreferences_renderXWikiRadeoxRenderer=Render Wiki syntax XWiki.XWikiPreferences_leftPanels=Panels displayed on the left XWiki.XWikiPreferences_rightPanels=Panels displayed on the right XWiki.XWikiPreferences_showLeftPanels=Display the left panel column XWiki.XWikiPreferences_showRightPanels=Display the right panel column XWiki.XWikiPreferences_pageWidth=Preferred page width XWiki.XWikiPreferences_languages=Supported languages XWiki.XWikiPreferences_convertmail=convert email type XWiki.XWikiPreferences_tags=Activate the tagging XWiki.XWikiPreferences_parent=Parent space XWiki.XWikiPreferences_documentBundles=Internationalization Document Bundles XWiki.XWikiPreferences_upload_maxsize=Maximum Upload Size Is that so? I've searched for XWiki.XWikiPreferences_editor=Default Editor and couldn't find it anywhere and XWiki.XWikiPreferences_core.defaultDocumentSyntax isn't used in the General admin page (this is why this text is not translated in French for ex). Any idea? Thanks -Vincent

16 years

2
2
0 0

[xwiki-devs] [ANN] XWiki Enterprise 2.0 RC 1 released

by Thomas Mortagne

The XWiki development team is pleased to announce the release of XWiki Enterprise 2.0 RC 1. Go grab it at http://www.xwiki.org/xwiki/bin/view/Main/Download This is the first release candidate for the XWiki enterprise 2.0 version. It will be followed by a second RC. 133 Jira issues has been closed for this release. Changes from 2.0 Milestone 4: * Many improvements and bug fixes in the new Colibri skin * Many general UI improvements * Many WYSIWYG improvements * Many Rendering 2.0 improvements ** Script macro improvements ** Introduce Python macro * Many Watchlist improvements * Activity stream improvements * Blog categories UI improvement * Update translations: fr, de, ro, sv As usual we need the community to heavily test this release before the final release to catch all the remaining issues. You can look at http://platform.xwiki.org/xwiki/bin/view/AdminGuide/DistributedEventCluster… to test the new event based clustering support. For more information see the Release notes at: http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXWikiEnterprise20RC1 Thanks -The XWiki dev team

16 years

3
2
0 0

[xwiki-devs] Could you recommend some good books or material which could help me overcome the learning curve of developing Xwiki?

by Leon Wang

Hi everyone, Could you recommend some books or material which could help me overcome the learning curve of developing Xwiki? I have read the book Maven Definitive Guide. Thank you all! Everyone have a wonderful weekend! Leon

16 years

2
1
0 0

[xwiki-devs] 2.0 RC1 not working with jar installer or exe installer?

by Vincent Massol

Hi, Someone just reported http://jira.xwiki.org/jira/browse/XE-492 Could it be caused by the jar installer or the exe one? I thought we had fixed this. It may be something else but it looks very close to the issue reported before. WDYT? Thanks -Vincent

16 years

1
0
0 0

[xwiki-devs] [NOTICE] Publishing gwt-incubator-july-14-2009.jar to our maven repo

by Marius Dumitru Florea

Hi devs, The WYSIWYG editor uses the GlassPanel widget from GWT incubator. The version currently used doesn't work with GWT 1.7 ( http://tinyurl.com/nwr4bm ) so we have to upgrade. Unfortunately the latest version is not yet published to the maven central repo ( http://tinyurl.com/ksuh7h ) so we have to publish it in our repo. Let me know if you have something against it. Thanks, Marius

16 years

2
1
0 0

Re: [xwiki-devs] [xwiki-notifications] r23469 - platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/internal

by Vincent Massol

Hi Asiri, I see you're setting the content author to "System". This hasn't been agreed yet. Could you please send a vote email on the list since it's an important decision? Thanks -Vincent On Sep 11, 2009, at 12:53 PM, asiri (SVN) wrote: > Author: asiri > Date: 2009-09-11 12:53:31 +0200 (Fri, 11 Sep 2009) > New Revision: 23469 > > Modified: > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > internal/DefaultWikiMacroInitializer.java > Log: > XWIKI-4320: XWiki.WikiMacroClass and XWiki.WikiMacroParameterClass > are orphaned > > * Fixed. > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > internal/DefaultWikiMacroInitializer.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > internal/DefaultWikiMacroInitializer.java 2009-09-11 10:44:24 UTC > (rev 23468) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > internal/DefaultWikiMacroInitializer.java 2009-09-11 10:53:31 UTC > (rev 23469) > @@ -28,10 +28,10 @@ > import org.xwiki.component.annotation.Requirement; > import org.xwiki.component.logging.AbstractLogEnabled; > import org.xwiki.context.Execution; > -import org.xwiki.rendering.macro.wikibridge.WikiMacroInitializer; > import org.xwiki.rendering.macro.wikibridge.WikiMacro; > +import org.xwiki.rendering.macro.wikibridge.WikiMacroException; > import org.xwiki.rendering.macro.wikibridge.WikiMacroFactory; > -import org.xwiki.rendering.macro.wikibridge.WikiMacroException; > +import org.xwiki.rendering.macro.wikibridge.WikiMacroInitializer; > import org.xwiki.rendering.macro.wikibridge.WikiMacroManager; > > import com.xpn.xwiki.XWikiContext; > @@ -153,29 +153,50 @@ > needsUpdate |= > bclass.addTextAreaField(MACRO_DESCRIPTION_PROPERTY, "Macro > description", 40, 5); > needsUpdate |= > bclass.addTextField(MACRO_DEFAULT_CATEGORY_PROPERTY, "Default > category", 30); > needsUpdate |= bclass.addBooleanField(MACRO_INLINE_PROPERTY, > "Supports inline mode", "select"); > - needsUpdate |= > bclass.addStaticListField(MACRO_CONTENT_TYPE_PROPERTY, "Macro > content type", 1, false, > - "Mandatory|Optional|No content", "select", "|"); > - needsUpdate |= > bclass.addTextAreaField(MACRO_CONTENT_DESCRIPTION_PROPERTY, > - "Content description (Not applicable for \"No content\" > type)", 40, 5); > + needsUpdate |= > + bclass.addStaticListField(MACRO_CONTENT_TYPE_PROPERTY, > "Macro content type", 1, false, > + "Mandatory|Optional|No content", "select", "|"); > + needsUpdate |= > + > bclass.addTextAreaField(MACRO_CONTENT_DESCRIPTION_PROPERTY, > + "Content description (Not applicable for \"No > content\" type)", 40, 5); > needsUpdate |= bclass.addTextAreaField(MACRO_CODE_PROPERTY, > "Macro code", 40, 5); > - > + > if (needsUpdate) { > - xcontext.getWiki().saveDocument(doc, xcontext); > + update(doc); > } > - > + > // Install or Upgrade XWiki.WikiMacroParameterClass > doc = > xcontext.getWiki().getDocument(WIKI_MACRO_PARAMETER_CLASS, xcontext); > bclass = doc.getxWikiClass(); > bclass.setName(WIKI_MACRO_PARAMETER_CLASS); > - > + > needsUpdate = false; > - > + > needsUpdate |= bclass.addTextField(PARAMETER_NAME_PROPERTY, > "Parameter name", 30); > needsUpdate |= > bclass.addTextAreaField(PARAMETER_DESCRIPTION_PROPERTY, "Parameter > description", 40, 5); > needsUpdate |= > bclass.addBooleanField(PARAMETER_MANDATORY_PROPERTY, "Parameter > mandatory", "select"); > - > + > if (needsUpdate) { > - xcontext.getWiki().saveDocument(doc, xcontext); > + update(doc); > } > } > + > + /** > + * Utility method for updating a wiki macro class definition > document. > + * > + * @param doc xwiki document containing the wiki macro class. > + * @throws XWikiException if an error occurs while saving the > document. > + */ > + private void update(XWikiDocument doc) throws XWikiException > + { > + XWikiContext xcontext = getContext(); > + > + if (doc.isNew()) { > + doc.setCreator("System"); > + doc.setParent("XWiki.WebHome"); > + } > + > + doc.setAuthor("System"); > + xcontext.getWiki().saveDocument(doc, xcontext); > + } > } > > _______________________________________________ > notifications mailing list > notifications(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/notifications

16 years

1
0
0 0

[xwiki-devs] A better UI for annotation module

by Lucien Pereira

Hi all, Annotation module success depends strongly of being able to provide a great user exprerience. So I think current annotation module UI should be improved, for now it has only been tested in firefox. Since I really do not have skills concerning interface ergonomy, I would propose that a designer handle it. annotation feature installation and usage instructions can be found here http://dev.xwiki.org/xwiki/bin/view/Drafts/AnnotationModule WDYT ? Lucien

16 years

6
20
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

xwiki-devs